- 27 Oct, 2020 40 commits
-
-
Oriol Brufau authored
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568 that inherited properties that apply to text can be set on ::marker and should affect the marker text. And in https://github.com/w3c/csswg-drafts/issues/5303 it resolved that 'line-height' applies to text (as it already does in Chromium). Therefore, this patch allows 'line-height' in ::marker. Note it was already possibly to set it to the list item and the ::marker would inherit it. Just letting authors set it directly to the ::marker. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-line-height.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html marker-line-height.html fails in legacy because ::markers with 'content: normal' are not implemented with actual text. Change-Id: If63095d046150a2b5f76c40fce93fce1c0e7741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438413 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821293}
-
Stefan Zager authored
BUG=1142877 TBR=poromov@chromium.org NOTRY=TRUE Change-Id: Ib657fd85f7bbe1daf8fd7368c856dda60db018b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502783Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#821292}
-
Joshua Peraza authored
5368dc638901 handle potentially throwing functions in no_cfi_icall cdb1e7f52bdc fix flake in LogOutputStreamTest 640b13f3cb80 linux: Don't load section headers of test module Change-Id: I4e7f5d3983e499a20988fd1a3f6ca184ec4d1cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500319 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821291}
-
Andrew Grieve authored
Java targets should never depend in non-java targets unless they are generating inputs for them. Change-Id: I537d96183976476abec3a5fb3de87d122620a409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499418 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821290}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests. Change-Id: I244899c638df91c27f34ee3e5888077d61248c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497903 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#821289}
-
Matt Menke authored
The last browser tests using the built-in SpawnedTestServer have finally been migrated the EmbeddedTestServer, so nothing is using it. This also helps reduce visibility of the SpawnedTestServer, so makes accidental use of it harder. This CL also fixes a bunch of IWYU issues that the removal unearthed. Bug: 492672 Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#821288}
-
Sylvain Defresne authored
Applications build for the macOS "catalyst" environment do not support the extensions or widgets that ships with Chrome on iOS. Fix the build when the variables used to enabled them are set to false. Add assertion to ensure that the BUILD.gn defining the extensions and widgets are not included when the variables are set to false, in order to prevent from accidental inclusion. Add a gn variable to control whether screen_time is enabled or not. It will allow disabling it when environment is macOS "catalyst". Bug: 1138425 Change-Id: If2cf9734c0595098cb2f60247702f73cf5da7d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498593 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#821287}
-
Peng Huang authored
The crash is because fd ownership is passed to vulkan, however the fd is still hold in base::ScopedFD. It confuses android fdsan, and then fdsan reports an ownership problem and crashes. Bug: 1140950 Change-Id: I0cc22992cedb22a649c61e84020317261255e04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503008Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821286}
-
Elly Fong-Jones authored
This will make using AnyWidgetWaiter a lot more convenient for tests that cover code which does not subclass View for the widget delegate's contents view (which is current best practice). Bug: 1075649 Change-Id: Ie1c8d2917f525176d1b17bcbeddd7b6f93b19644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492891 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821285}
-
Antonio Sartori authored
According to the specification, executing a javascript: URL in a document does not commit a new document. Indeed, following https://html.spec.whatwg.org/multipage/browsing-the-web.html#javascript-protocol executing a javascript: URL request gives a response whose status is 204, and processing a response with status 204 does not commit a new document: https://html.spec.whatwg.org/multipage/browsing-the-web.html#process-a-navigate-response In particular, executing a javascript: URL does not change the document's URL. So if we create a new (empty) iframe and execute right away some javascript: URL in it, the URL of the iframe document will be "about:blank". On the other side, a document with URL "about:blank" will usually not send any Referer header, since the algorithm for determining the outgoing referrer goes through the stripping section https://w3c.github.io/webappsec-referrer-policy/#strip-url which returns `no-referrer` for a local scheme. As a consequence, we should always expect the Referer header of an outgoing fetch request from an `<iframe src="javascript:...">` without custom referrer to be empty. This CL adjusts the referrer policy inheritance WP test to that. Still, we want to test that the referrer policy is inherited correctly for javascript: URLs. For doing that, we add a custom referrer to the outgoing fetch request, and we check that the content of the received Referer header corresponds to the custom referrer modulo the inherited referrer policy. Change-Id: Ib3fe0808d3f8a1790e3f565cf2b1648fd2ea6c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464930 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#821284}
-
Rune Lillesveen authored
The css-pseudo specification lists which properties applies to which pseudo elements. For ::marker and ::first-letter we were already using the CascadeFilter. This CL uses the filter for highlight pseudo elements like ::selection and ::target-text, which share the same set of properties which apply. This means we stop retrieving resources for CSS properties which don't apply to these pseudo elements. Additionally, block all resource fetching for the ::target-text element since resource fetching can be used by an external stylesheet in combination with a text fragment url to detect text content on a page. Bug: 1136817 Change-Id: I8b19db8535882e6b20f6319cd2a9f5219e7c9538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489657 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#821283}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I797c98ff77d57ab47dfb95eecfe6d70000f3409d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500561 Auto-Submit: Caroline Rising <corising@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#821282}
-
Chris Hamilton authored
This adds OnGraphCreated test seams to the browser harness, as well as a utility function for running a lambda synchronously in the graph (a common operation in tests). Change-Id: I4c10dbba34bc8c1d81722ac3780491079a8cadf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493687Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#821281}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6d17cf58. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I166d60117fcd1e0292503f434a2594759419ba5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502848Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821280}
-
Russell Davis authored
Bug: 1142027 Change-Id: Ie2fb4d4631f3d8507b404d6641f89170e35d98e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496290 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821279}
-
Stefan Zager authored
This reverts commit c756c75c. Reason for revert: Suspected cause of crbug.com/1142873 Original change's description: > [iOS] Fix tab strip views when using FullscreenProvider > > When the FullscreenProvider is used, the layout of the browser views is > slightly different. Instead of having the web content views start from > the bottom of the toolbar, the web content extends all the way to the > top of the BrowserContainerViewController, behind the tab strip. > > This means that the prior approach of making all the top background > views clear does not work when using FullscreenProvider. Instead, this > CL uses the following approach: set these background views to have > the same background color as the tab grid. As soon as the panning > gesture starts, make them clear so the tab grid shows through and the > animations appear correctly. At the same time, move the web content > views down so they don't obstruct the animations either. > > Bug: 1094335 > Change-Id: Ieea7d268e781da5e1ccd4c2c0ad3c0925407d133 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489898 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Cr-Commit-Position: refs/heads/master@{#821200} TBR=marq@chromium.org,rkgibson@google.com,mouraroberto@google.com Change-Id: I2b026d35000d34b29de9235ed2752273f6f7dd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502574Reviewed-by:
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: I0275f2ee7515dd907c13f3fdfb0e9ca2da23e3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497391 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: Ibd93c72f8a5eb46a9d346d6ef381bcb3a8cbb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497389 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Wei Li authored
Change Button, ImageButton, LabelButton, and ColorTrackingVectorImageButton to always focusable on non-Mac platform and accessible only for Mac. This will remove the need to override these buttons' focus behavior for normal use cases. This CL explicitly set some button's focus behavior when they don't want to platform default focus behavior. This CL also removes the DCHECKs added earlier to show the changed behavior. Bug: 1001103 Change-Id: I97ebea9c477e6155e40b09007254a51be9ee5125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499166Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
Kyle Milka authored
Move a few of the editor screenshot files into c/b/share/. This eliminates the DEPS on those files. Bug: 1022172 Change-Id: Ibe12b1d4aadae983d74e348ea5279af4230610eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481928Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821274}
-
David Roger authored
This reverts commit f89b2b5b. Reason for revert: test is timing out on windows. See https://crbug.com/1142869 Original change's description: > Enable ChromeSitePerProcessTest.LaunchExternalProtocolFromSubframe on windows. > > Enabling test to see if it is still flaky on Windows. > > Bug: 980446 > Change-Id: I6f1b0dce68cce9bd359ebe315ee8782b26888c66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498957 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Auto-Submit: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821188} TBR=acolwell@chromium.org,wjmaclean@chromium.org Change-Id: Ie7f5c8d58bc12698c2f22b17a327b2f6f39bcffe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 980446, 1142869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502691Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#821273}
-
Tanmoy Mollik authored
In https://crrev.com/c/2498946 the following test was disabled because it was flaky on emulator: - GoogleServicesSettingsTest#showSignOutDialogBeforeSigningUserOut They are re-enabled on other builders. This issue seems to be problem with espresso being used in emulators similar to this bug: https://crrev.com/c/1108459 Bug: 1142481 Change-Id: I28fff49d24244af7935729e895fc2f78659ef716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499541Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821272}
-
Victor Costan authored
This will avoid including this file in a large CL that turns QuotaClient into a mojo interface. Bug: 1016065 Change-Id: If029b5362fcc77b7acf8e55206b7143900ff6369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501062 Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821271}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=jwd@chromium.org Bug: 1142671 Change-Id: I9501b09c902d0741f7bbd92d1ada0ff06bfa5136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500609 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#821270}
-
Stephen McGruer authored
Despite efforts to address it, this test continues to be flaky on Mac, so squash the flaky-failures. Bug: 1137228 Change-Id: I48e4745d4f21977b59cfeba99e73d39126932ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502312 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#821269}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4ffe4940bba5cf5f6789dc5979669c54afd11337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821268}
-
Evan Stade authored
Bug: 1142600 Change-Id: Iebabca71d53c9cdc08cd0bfa50927b4bd4513d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500547Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#821267}
-
Rune Lillesveen authored
When ::target-text was introduced, we did not add an extra bit in pseudo_bits. Add static_asserts to make sure we actually test first and last public pseudo. Had to add another 8 bits to ComputedStyle. Bug: 1136817 Change-Id: If8593b5a7022b93f18f4ee7b216e6753b6747076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502629Reviewed-by:
-
Victor Hugo Vianna Silva authored
This test seems to have been disabled mostly due to the TextInputServerCreate Windows error [1], which doesn't manifest anymore (crbug.com/1123944). Let's try to re-enable it. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8883515428383041104/+/steps/sync_integration_tests__with_patch__on_Windows-10-15063/0/logs/Flaky_failure:_All__x2f_TwoClientExtensionAppsSyncTest.StartWithDifferentApps__x2f_WebApps__status_CRASH_SUCCESS_/0 Bug: 1069843 Change-Id: I9bce6dd03effd2128f9691e887ab68962c898ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498485 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#821265}
-
Evan Shrubsole authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/6866adbec5af..19d71f6b351f $ git log 6866adbec..19d71f6b3 --date=short --no-merges --format='%ad %ae %s' 2020-10-24 libyuv-ci-autoroll-builder Roll chromium_revision e812106b..df9aecfc (817907:820568) 2020-10-16 libyuv-ci-autoroll-builder Roll chromium_revision 48924233..e812106b (815587:817907) 2020-10-13 fbarchard UVScale down use AVX2 and Neon for aarch32 2020-10-13 fbarchard UVScale down by 4 use SSSE3/NEON 2020-10-12 fbarchard 2x down sample for UV planes ported to SSSE3 / NEON 2020-10-09 libyuv-ci-autoroll-builder Roll chromium_revision ccec2ad0..48924233 (811963:815587) 2020-10-02 fbarchard I420ToARGB prototype added to convert_from.h 2020-10-01 fbarchard scale neon adjust PRFM instruction to co-issue with math Created with: roll-dep src/third_party/libyuv Bug: None Change-Id: I3b0edcc78471ee3dc5701f40b07acf6b97560664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502469 Commit-Queue: Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821264}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=corising@chromium.org Bug: 1142671 Change-Id: I63425a4accecedcffa4da3e746a0ccf449296336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500611 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#821263}
-
Martin Kreichgauer authored
CL:2410419 added support for the WebAuthn credProps extension. I meant to guard it with the WebAuthenticationResidentKeyRequirement, but accidentally commented out the relevant line. Thanks to Shane Weeden for spotting this issue. Bug: 1117630 Change-Id: I96f6bac63cd3093f333891ba7a54c0c471d304ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500956 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#821262}
-
Mounir Lamouri authored
They were not used anymore. Bug: 1142522 Fixed: 1142522 Change-Id: I01bf92f378ce85fedb6f972782267d0fbcd57f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498650Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#821261}
-
Matt Menke authored
This one of only two tests using BrowserTestBase::spawned_test_server(). We want to reduce the use of the test server for a variety of reasons, and removing access from BrowserTestBase is a good way to decrease visibility of the spawned test server. Also remove the download-known-size handler from the SpawnedTestServer's Python code, as this was the only remaining test using that method. Bug: 492672 Change-Id: Ib4836b9db3beb6a3f1f8598dea63fb262bf24dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498644 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821260}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da4b0932..47c8f45b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie48d69f1766a11d6609734f9e6caf949c64a42fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502668Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821259}
-
Samuel Huang authored
crrev.com/c/2051870 added DOM retargeting usage to AXLayoutObject::AccessibilityHitTest() so that accessibility hit test targets an <input> Element instead of its internals. However, the fix was too aggressive, and caused hit tests to miss Elements inside all shadow DOM, including those in custom elements (disregarding whether mode is "open" and "closed", and ignoring non-Element Nodes). This CL removes DOM retarget usage for accessibility hit test. Instead, when a Node in a shadow DOM is targeted, if the Node is in a user-agent shadow tree then the target is changed to the shadow root's host. Bug: 1111800 Change-Id: I8bcfaea0a113166464efe82f14f986c1bfa0c2c7 Fixed: 1111800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495660Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821258}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fc7525b95bfe..64543505bd67 2020-10-27 alcastano@google.com Typecheck elements/ElementsTreeElementHighlighter.js with TypeScript 2020-10-27 wolfi@chromium.org Fix 'learn more' link descriptions for CSP issues 2020-10-27 jacktfranklin@chromium.org Fix bridges presubmit error not failing presubmit 2020-10-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-27 alexrudenko@chromium.org Add icons for global CSS keywords 2020-10-27 mulherje@gmail.com Remove unnecessay "edit expression" option from right click drop down 2020-10-27 sigurds@chromium.org Refactor console.table messages to their own class 2020-10-27 jacktfranklin@chromium.org Fix component bridges and use of legacy interfaces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1072335,chromium:1139945,chromium:1140516 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id5533679466f06d9ee4ce17fd7ccb4b5cef0c8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502828Reviewed-by:
-
Toby Huang authored
This CL adds a new metrics provider for differentiating between types of Family Link users. Previously, these supervised user types were indistinguishable in ChromeOS. This metrics provider will enable filtering UMA metrics by supervision type as well. This slicing mechanism is for metrics purposes only, and not for any other features. Bug: 1136304 Change-Id: Ida750eb188772db29158dce8cf750648ce580805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466338Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821256}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 1142671 Change-Id: I32ce49b4eb448c0a18a44ae7a4b570124260466c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500213 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#821255}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7737a5bd2510..6f87de7c272d 2020-10-27 ethannicholas@google.com Made IRNode smaller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I102b4414bdc886e4c288ec7a36cae148184ef2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502493Reviewed-by:
-
