- 09 Nov, 2018 14 commits
-
-
rajendrant authored
PreviewsState is used in DataReductionProxyURLLoaderThrottle to set some chrome-proxy specific headers to serve previews. Bug: 893728 Change-Id: Ie54f174bb1ba2ff4d77f725c0e64450f8d2aad0c Reviewed-on: https://chromium-review.googlesource.com/c/1327568Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#606661}
-
chrome://ukmNikunj Bhagat authored
BUG=843181 Change-Id: I8b43a72535dd09a175df731a94dc8e216374e7ff Reviewed-on: https://chromium-review.googlesource.com/c/1306660 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606660}
-
Yves Arrouye authored
BUG=chromium:890636 TEST=Enroll using attestation and check UMA Change-Id: Ifdfa408a62cf7af43e7436b4a64b2a43afe7bf18 Reviewed-on: https://chromium-review.googlesource.com/c/1304613 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#606659}
-
Brian Sheedy authored
This reverts commit e19fa28d. Reason for revert: Cause of https://crbug.com/903402 Original change's description: > Marks the document object as busy while it is still loading > > Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. > The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. > > R=dmazzoni@chromium.org, aleventhal@chromium.org > > Bug: 897177 > Change-Id: I5d734ff9d32c53b7ba12a6d5d4eeb74b26ba0a02 > Reviewed-on: https://chromium-review.googlesource.com/c/1295769 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606147} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897177 Change-Id: Ib13f772ecf7fe300afbb48e16952f65bf0d0728a Reviewed-on: https://chromium-review.googlesource.com/c/1327721Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606658}
-
Eric Roman authored
(Previously it would just print -1 if the request failed due to a network error) Change-Id: I5f61bc4461f109c733f56983ac0420b0e5083c27 Reviewed-on: https://chromium-review.googlesource.com/c/1327575Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606657}
-
Varun Khaneja authored
Bug: 889972 Change-Id: I5b0ab0869a526061f0125d5d23beb8f38f81b7ed Reviewed-on: https://chromium-review.googlesource.com/c/1326845Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606656}
-
danakj authored
Importantly, non-visible RenderWidgets include swapped out RenderWidgets which are zombies, without a frame, and which should not be used. This can happen if the RenderWidget swap out races with the posted task from the compositor to make a LayerTreeFrameSink. When swapping out, the compositor would be marked as not-visible, which would stop it from making such requests, but one could already be in flight. In the other case, honoring the request for a non-visible compositor is more benign, but we can delay it until the compositor is actually visible again. This means if a context is lost, backgrounded tabs would not all attempt to reconnect to the Gpu process at once. This is a better followup for the hacky https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which was meant only for merge to a release branch. It reverts that change as part of this one. R=piman@chromium.org Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7 Bug: 896836, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1292714 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606655}
-
Peter Boström authored
Removing TabIcon from a layer used to happen after SetData marks a tab as no longer loading. With the new tab-icon animation we extend the animation period for 200ms past that. This is a speculative fix for the referenced bug that I've been unable to reproduce locally. Bug: chromium:901277 Change-Id: I81c5e5af56fddc90ca210b027a681cd2309d2742 Reviewed-on: https://chromium-review.googlesource.com/c/1327231Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#606654}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b8b52b46f8db..760b1c16f676 git log b8b52b46f8db..760b1c16f676 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 thestig@chromium.org Remove CPDF_DocRenderData::Clear(). Created with: gclient setdep -r src/third_party/pdfium@760b1c16f676 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9b6d7c3304b4db3c9210144d864650e61735def3 Reviewed-on: https://chromium-review.googlesource.com/c/1327350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606653}
-
Eugene But authored
Bug: 901563 Change-Id: Ia65425e4d47e79bfae1eb7bcd6f08aa0f4b641d5 Reviewed-on: https://chromium-review.googlesource.com/c/1321573Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606652}
-
Jun Mukai authored
I've just noticed that crrev.com/606339 causes a crash, and that's because PrintWindowHierarchy starts from a root window, which do not have a parent, but it tries to call IsToplevelWindow() which assumes the existence of the parent. BUG=none TEST=manually Change-Id: Ie4460302674d057a6c7960e0b012c80b63e06a2c Reviewed-on: https://chromium-review.googlesource.com/c/1327560Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#606651}
-
Xianzhu Wang authored
FrameSetPainter paints everything in the foreground phase, so a frame under frameset should paint its box decoration background in the foreground phase. Bug: 902274 Change-Id: Id56af37a478b8503f17199753a485f6fe1261c95 Reviewed-on: https://chromium-review.googlesource.com/c/1326205Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606650}
-
Hiroshige Hayashizaki authored
Keeping scoped_refptr<WebWorkerFetchContext> in WorkerFetchContextHolder cause WebWorkerFetchContext destruction on the main thread, because WorkerFetchContextHolder is destructed on the main thread. To avoid this, this CL passes WebWorkerFetchContext via GlobalScopeCreationParams to WorkerOrWorkletGlobalScope. This CL doesn't change the behavior. Bug: 880027 Change-Id: Idab91d31cafdb33b264662c5f1bef126d93ba9f3 Reviewed-on: https://chromium-review.googlesource.com/c/1198891 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606649}
-
Philip Rogers authored
web_frame_test.cc is huge! This patch splits out the blink->compositor tests into web_layer_test.cc. This is primarily a code move but the following renames have also been included: SlimmingPaintWebFrameTest -> WebLayerListTest SlimmingPaintWebFrameSimTest -> WebLayerListSimTest Change-Id: I78d2dbd242c1a69dbbc9a76dcf2be20087018508 Reviewed-on: https://chromium-review.googlesource.com/c/1327152 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606648}
-
- 08 Nov, 2018 26 commits
-
-
Findit authored
This reverts commit 0cfecb52. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 606552 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGNmZWNiNTI0ODcwNjZhZDBjYzU1Y2NmMTg2MzVlNmQyOGJkOWI1ZAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/16586 Sample Failed Step: network_service_browser_tests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay Original change's description: > [Media UX] Enable the pixel by pixel comparison test for Mac OS. > > 1. Tested on Mac and verify everything works as expected. > 2. Removed the unnecessary call of GetNativeWindow(). > 3. The RGB for GPU enabled and GPU disabled test images is slightly different. Additional check is needed. > > Bug: 898230 > Change-Id: I85bf2450862361572597632159de60db6abf2c22 > Reviewed-on: https://chromium-review.googlesource.com/c/1307062 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606552} Change-Id: I10a133230cad3256bf4e5e0c3c925920484ce6a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898230, 903580 Reviewed-on: https://chromium-review.googlesource.com/c/1327612 Cr-Commit-Position: refs/heads/master@{#606647}
-
Findit authored
This reverts commit a9531c4a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 606631 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E5NTMxYzRhYWU1Y2FhY2RhN2MxNDg1OGRlMzg2MGVmYjQxMjI4YjQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/4213 Sample Failed Step: compile Original change's description: > Android: Roll android_tools and fix lint errors > > Update lint to version 26.4.0-alpha03+. > > This is the first lint update since 2017 September, thus a long list of > TODOs is expected. > > TBR for mechanical fixes to existing lint errors that are only exposed > due to update. > > TBR=mheikal@chromium.org > > Bug: 900912 > Change-Id: I3335834ae308a3411ced51bb2c913b76a8f8d8c3 > Reviewed-on: https://chromium-review.googlesource.com/c/1327157 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606631} Change-Id: Ie3a61a6d093d8cd6426ddcd7bf833f98c9b4f78c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900912 Reviewed-on: https://chromium-review.googlesource.com/c/1327611 Cr-Commit-Position: refs/heads/master@{#606646}
-
Manu Cornet authored
Change-Id: If497956bc179864957dd21b8b88c8db354dd96af Reviewed-on: https://chromium-review.googlesource.com/c/1325069Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#606645}
-
Ehsan Chiniforooshan authored
Change-Id: I9f539e61174d0aa23767e9de9107b5fa8c606418 Reviewed-on: https://chromium-review.googlesource.com/c/1323690Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606644}
-
Max Rebuschatis authored
This is a reland of 126a1168 The fix in this change addresses compile errors on the Oculus platform. TBR=dcheng@chromium.org dcheng@chromium.org: please review, though there are no new changes to vr_service.mojom Original change's description: > Make XR FrameData and Environment mojo associated > > The XRFrameDataProvider now returns an associated > XREnvironmentDataProvider interface so that the > two share callback queues and thus allow strict > ordering of the two interfaces. This is critical > for frame synchronization between frames and the > associated environment data. > > Note: We can't just mark the interfaceptrs for > XRFrameDataProvider and > XREnvironmentIntegrationProvider as associated > in the XRSession struct. XRDevice implementations > mostly live on separate threads from the > XRFrameDataProviders, so we'd have extra thread > hopping. For the VR headsets we explicitly live > off the main thread to avoid latency, and because > we do some work that may block the thread the > XRFrameDataProvider lives on (for example waiting > for vsync, or submitting frames to headset APIs). > > Bug: 867057, 876135, 843376 > Change-Id: If2fb62fcd185825209dec08e421df05f34d41c30 > Reviewed-on: https://chromium-review.googlesource.com/c/1171794 > Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605545} Bug: 867057, 876135, 843376 Change-Id: If76578ebabbb40d03a21f6f557c5d4c27f69fc38 Reviewed-on: https://chromium-review.googlesource.com/c/1324089 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#606643}
-
Darren Shen authored
The virtual keyboard extension is responsible for choosing the size of the keyboard window. In test code, we mock out the extension but we don't set a size. This means that test code has to manually set the bounds of the keyboard window, which is a bit weird. Failing to set the size result in very confusing test failures too. Therefore, we set a default virtual keyboard size in the test KeyboardUI implementations. If test code need a specific size, they can always resize the window themselves. Bug: 849995 Change-Id: I3794f11719bcfe722317174d43492141e6f75b80 Reviewed-on: https://chromium-review.googlesource.com/c/1278462 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#606642}
-
Thomas Tangl authored
When sync is paused, a button to signin again is shown in the sync account control on the main settings page. Bug: 902949 Change-Id: I818034d4d6980ff3d26c4eb8429a13fe20a6fbf2 Reviewed-on: https://chromium-review.googlesource.com/c/1324399Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#606641}
-
Tony de Luna authored
It's not clear what preferring Ethernet or cellular means. Users can just disable WiFi if they want to 'prefer' their cellular network. Bug: 881557 Change-Id: I7e53ca9e4fac2be8f952f0081868a3c255f17f0e Reviewed-on: https://chromium-review.googlesource.com/c/1325150Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#606640}
-
Eric Roman authored
Change-Id: Ib616de76fcaca95b252183e85cc1d595b2b8d9fb Reviewed-on: https://chromium-review.googlesource.com/c/1323627 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606639}
-
dpapad authored
Bug: 902959 Change-Id: I6a5bfde6b6b81f16b34d0ae6b728a0aa26f869a3 Reviewed-on: https://chromium-review.googlesource.com/c/1327566Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606638}
-
Saman Sami authored
Currently this method earlies out and returns an empty SkBitmap if OOP-D is enabled. It should just proceed the same way as the non-OOP-D case. Bug: 903453 Change-Id: I0943279e2d98885682f5b8d4e619413293575b5a Reviewed-on: https://chromium-review.googlesource.com/c/1327418Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606637}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/edcefdcf7d5a..fc810ab24daa git log edcefdcf7d5a..fc810ab24daa --date=short --no-merges --format='%ad %ae %s' 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@fc810ab24daa The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I16312640a0f5faf7de821b917869b9f0c2127eae Reviewed-on: https://chromium-review.googlesource.com/c/1327346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606636}
-
Xiyuan Xia authored
Suspect http://crrev.com/c/1259296 fixed it. Bug: 888188 Change-Id: I40d9246fa5ad777cb91fd5aa9e740c1c550643bf Reviewed-on: https://chromium-review.googlesource.com/c/1327552Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606635}
-
dpapad authored
This is in preparation of fully removing neon-animation from the repository (although there is a long way to get there). Bug: 902959 Change-Id: Ia1444651b96fba4316f69cfeb65bf92177acb389 Reviewed-on: https://chromium-review.googlesource.com/c/1324993Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606634}
-
Alexander Alekseev authored
This CL converts discover App flag to feature and enabled it by default. Bug: 864686 Change-Id: Idf8dcce4982a16f92ed7b012525484963f799710 Reviewed-on: https://chromium-review.googlesource.com/c/1326221 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#606633}
-
Regan Hsu authored
of enabling and disabling features. Bug: 870138 Change-Id: Ia4e517b191d08ef906d359bf8e8decd627096f63 Reviewed-on: https://chromium-review.googlesource.com/c/1324852Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606632}
-
Peter Wen authored
Update lint to version 26.4.0-alpha03+. This is the first lint update since 2017 September, thus a long list of TODOs is expected. TBR for mechanical fixes to existing lint errors that are only exposed due to update. TBR=mheikal@chromium.org Bug: 900912 Change-Id: I3335834ae308a3411ced51bb2c913b76a8f8d8c3 Reviewed-on: https://chromium-review.googlesource.com/c/1327157Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606631}
-
Alexander Alekseev authored
This Cl delays showing sync settings screen to prevent race with restored tabs. Bug: 900697 Change-Id: Ia23c867974c5f7b80fedc73d71c29968e354c168 Reviewed-on: https://chromium-review.googlesource.com/c/1325210Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#606630}
-
Alexander Alekseev authored
Bug: 864686 Change-Id: I7032bd335ea625683176fc4d71c5285edecfc117 Reviewed-on: https://chromium-review.googlesource.com/c/1326224Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#606629}
-
Sam Maier authored
Bug: 898251 Change-Id: I552b1dfbe7d1cdd86f5cfdbf0116b895d255b903 Reviewed-on: https://chromium-review.googlesource.com/c/1320023Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#606628}
-
mark a. foltz authored
This addresses comments by palmer@ in Bug 749700. Specifically: 1. Remove XML scrubbing as it's fragile and only used for debug logging. 2. Allow http: and https: for DIAL application URLs. 3. Consolidate validation logic for DIAL application URLs. In addition some IWYU and other minor cleanups. Bug: 749700 Change-Id: Iddde911f2c2848708fcd2854acf98e26e0be8eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1322351Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606627}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/625c7d270c1b..b8b52b46f8db git log 625c7d270c1b..b8b52b46f8db --date=short --no-merges --format='%ad %ae %s' 2018-11-08 thestig@chromium.org Make CPDF_RenderOptions::m_Flags a struct of booleans. Created with: gclient setdep -r src/third_party/pdfium@b8b52b46f8db The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6aa9882d3aa7ce11dfc6dfd079cbbfb1fc3787cb Reviewed-on: https://chromium-review.googlesource.com/c/1327602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606626}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/993edbb4..511e861d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6200203ffc2b808e91daa255e006f7db41df119e Reviewed-on: https://chromium-review.googlesource.com/c/1327547Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606625}
-
Sebastien Marchand authored
Bug: 839878 Change-Id: I045921f965486b19efc67a0a2628e2907936f501 Reviewed-on: https://chromium-review.googlesource.com/c/1277273 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#606624}
-
David Jacobo authored
IntentPickerAutoDisplayService is a KeyedService (including a factory class) so intent picker UI can locally (i.e. within Chrome) check if such UI has been displayed before without the user taking action. The user ignoring the UI should be remembered, so we stop auto-displaying the UI and instead only show an entry icon in the omnibox, where the UI will be one-click away. Bug: 902657 Test: Build. Change-Id: I2e0333b8c7eba3af78a671a4f119b7c26fcc5283 Reviewed-on: https://chromium-review.googlesource.com/c/1303653 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#606623}
-
Reid Kleckner authored
Previously, alignof(int64_t) was 8 on i686, but now it is 4. This is true in GCC 8+ and the latest version of clang. These types have always only been aligned to 4 bytes in struct layout, so this should not have wide ranging implications for ABI stability. Bug: 900406 Change-Id: Ia2f0d87300679148d7ca653b7cc52fe9cf910bbc Reviewed-on: https://chromium-review.googlesource.com/c/1327606Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606622}
-