- 25 Jun, 2020 40 commits
-
-
rbpotter authored
The download button should have aria-haspopup='menu' when the Edited/ Original menu is available. Bug: 1078543 Change-Id: I8a070b81fe9e27f0cad5448f44ac245dbeada3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260780 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#782262}
-
Joel Hockey authored
This strings are from crrev.com/c/2262019. We will add them as a separate CL to ensure they are landed before branch. Bug: 1095889 Change-Id: I97639723846f08cb95774c8a6383e6d6d8ed9da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264183 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#782261}
-
Devlin Cronin authored
Add a TestExtensionDir::CopyFileTo() method that copies a given filepath into the temporary directory held by the TestExtensionDir. This prevents callers from having to either do the copy more manually (reading the content and then writing it) or poking into the TestExtensionDir's inner temp directory. Bug: None Change-Id: I3ce727548ff9a4184c33d57bbacaee7e132baa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265292Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782260}
-
Matthew Denton authored
Adds |additional_untrusted_authorities| to CertVerifier::Config. This will currently only be used on ChromeOS to expose additional temporary certificates to NSS when policy requires it. These certificates unfortunately round-trip through the NetworkService: when the policy-provided certificates are updated, ProfileNetworkContextService calls NetworkContext::UpdateAdditionalCertificates(). This in turn will call CertVerifierService::SetConfig() with the policy-provided certificates. This CL also instantiates the CertVerifierService on the IO thread (instead of UI) in the browser process on ChromeOS. This is because CertVerifierBuiltin for ChromeOS uses user slots, which are initialized on the IO thread. This CL also parameterizes the browsertests in //chrome/browser/chromeos/policy/policy_certs_browsertest.cc to run both with and without the CertVerifierService enabled, to test the changes in this CL. Bug: 1085379, 1015134 Change-Id: Ibb623d9e53a46819ea5152e72d4f343ae52e8d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243867Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#782259}
-
Regan Hsu authored
Specs: https://carbon.googleplex.com/cros-ux/pages/search-bar/style?q= Screenshots: https://drive.google.com/corp/drive/folders/1bM5wzS4OOKVR0Agco8Dt3GXPf1ZRKpTV Fixed: 1096875 Change-Id: I3bde5a7fa7a2d034cc18589e98121a10bb73551d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265397Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782258}
-
Will Cassella authored
Some VideoDecoder implementations must do non-synchronous work besides resource reclamation during their destruction process, this CL allows them to do that more cleanly and safely via an 'AsyncDestroyVideoDecoder' wrapper. All they need to do is implement a static 'DestroyAsync' method that takes an instance by unique_ptr, and they can post whatever tasks they need within that function without worrying about being destroyed when it returns. Change-Id: I05f258a4cda90b9850e1c4a22c1084bae2dda563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191275 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#782257}
-
Owen Rodley authored
This is currently in Gatekeeper. The Gatekeeper version will be removed once this is live. Bug: 1094768 Change-Id: I5631c0e2787434c1d4f859ee6095250c92490c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264184 Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#782256}
-
Regan Hsu authored
Bug: 1096884 Change-Id: I72cb4347b663f47c955a472bdd0222ad94dd7adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265457Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782255}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593043069-e9ed35a2ba4491e832399d01d535b62071a030c0.profdata to chrome-win64-master-1593046477-06178a9c216cc048eab05ba3ba80abffec05a54c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6db1b70dd371879fd58d3e17fad4fbe282c437cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265718Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782254}
-
Trent Apted authored
The DOM File() constructor is really slow. This takes the time to construct the `ReceivedFileList` in a 1000-file folder from ~400ms to ~8ms. Bug: b/159858476 Change-Id: Ie884e652bb06edbf775d66db57b8c88569654655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265698Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#782253}
-
Asanka Herath authored
Bug: 973801 Change-Id: If74c681e5187fe84dc68bf9c12b2b6db984fd02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254527 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#782252}
-
Ian Struiksma authored
captured sites tests were listed under chromium.fyi when they are actually under internal.chrome.fyi Bug: 1099009 Change-Id: I29abb1790378a9214b6186c0c9aa09834e570338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264470Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#782251}
-
Brian Sheedy authored
Moves the shared Skia Gold python code from //testing/ to //build/. The //testing/ location is causing issues for V8, as they include //build/ but not //testing/. Bug: 1098641 Change-Id: I9a0b6d5f8d0134f5c1f0caef765e9ecde9ad7360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264607 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782250}
-
Jia authored
This cl adds an observer to Searchhandler to observe changes in settings results availability, and refresh results when necessary. Settings team resolved a bug (crbug.com/1096867) in SearchHandler that refreshes stale results. This cl ensures we can pick up the changes in the Launcher too. Bug: 1068851 Change-Id: Icb3cdc7726320f132f558d8076017b4de846ab82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265694 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#782249}
-
Xiaohui Chen authored
Bug: b:154268518 Change-Id: I131c63ddbe59a70971a286f58243e701610945a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257401 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782248}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/55ae76d9fed9..6069b8345ecb 2020-06-24 thestig@chromium.org Add CFX_CSSComputedStyle::GetLastFontFamily(). 2020-06-24 thestig@chromium.org Mark many params as const in CXFA_TextParser methods. 2020-06-24 thestig@chromium.org Use CPDF_Dictionary::GetNameFor() to tighten checks. 2020-06-24 thestig@chromium.org Use CPDF_Dictionary::GetNameFor() in some tests. 2020-06-24 thestig@chromium.org Add CPDF_Dictionary::GetNameFor(). 2020-06-24 thestig@chromium.org Remove unused CPDF_Dictionary::GetFloatFor(). 2020-06-24 thestig@chromium.org Slightly reorder cpdf_dictionary.h. 2020-06-24 thestig@chromium.org Initialize CFX_CSSComputedStyle inner class members in the header. 2020-06-24 thestig@chromium.org Add third_party/base/containers/adapters.h. 2020-06-24 thestig@chromium.org Improve test coverage for CFX_CSSSelector. 2020-06-24 thestig@chromium.org Use std::move() with CFX_CSSValueList ctor. 2020-06-24 thestig@chromium.org Simplify CFX_CSSValueList. 2020-06-24 thestig@chromium.org Use size_t in more CSS classes. 2020-06-24 thestig@chromium.org Improve CFX_CSSStyleSheetTest. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I46ef846887ac41b4445c2e1c039fd873f5a128fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782247}
-
Xiqi Ruan authored
Shorten the announcement of ChromeVox when user types in the parent access code. Use a virtual text field, change the accessbility focus to input fields' parent, and customize its accessbility events. Vocalization example: Previous: 8, 1 of 6, Next number Now: 8 Bug: 974020 Change-Id: I72b93cadcfe495f8d7f835eac45d2843861d154b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181022 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#782246}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1b485322085d..afdbf8e6f881 2020-06-24 chemag@fb.com H264: Fix stap-a-to-annex-b loop over-read 2020-06-24 fippo@sip-communicator.org red: modify the encoder to send RFC 2198 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If593d70319c0e3d27da5153ac323740cabfec136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265487Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782245}
-
Xing Liu authored
Only show download later dialog when on metered network. Also refactor some code to use new network API. Bug: 1078454 Change-Id: I7217592b3dc79c3b2afb2e1c4a492d6e4a965d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261106 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782244}
-
tby authored
These metrics are useful for a while longer, for the suggested files experiment. This CL makes 2020/12/06 the date when all zero-state file metrics expire. Bug: 1097818 Change-Id: Iffd44003b4379009d92d1a6f3406288c2611f873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264090Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#782243}
-
Omid Tourzan authored
Using negative outline-offset to push outline into box border and add padding to put some distance between link text and its focus outline. Also remove the underline of "Learn more" link in the low space warning message to match the files-ng spec. Note: no need for this in the drive welcome message since it is inside a <cr-button> which removes the text underline style. Add 20px margin-inline-end on download warning element to space it away from the dismiss button. The 48px value in the design causes the text break into two lines at the default files app window size. Use 20px for now to avoid this line breaking. Bug: 1082539 Change-Id: I64794428dc48ecafc8a6d84e50725e5f735d9bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264088 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782242}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Ice2d60d28546fa755feac36dd8278e3e14256200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264810 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782241}
-
Kenichi Ishibashi authored
crrev.com/c/2253259 added helper functions to store/delete registrations. We can use these helpers in some other tests to remove duplications. Bug: N/A Change-Id: Ie6c245e8b484c9473d62f74bae1f6451208363d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264091Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782240}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/36bfd8956dd0..e0658a4adf12 2020-06-25 jbudorick@chromium.org Restore --output-device-blacklist option to provision_devices temporarily. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1098775 Tbr: oysteine@google.com Change-Id: I00a195d36cc758c51d088c769f4cbd32057a801a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265491Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782239}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/10e4a44ce651..2a6cc4f8fb40 2020-06-25 jiawei.shao@intel.com Optimize B2T and T2B copies with multiple array layers on Metal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I87259a28fa80c1e4bb20f2ae4371a58e6688c6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265554 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782238}
-
David Maunder authored
We have been calling the server too aggressively and need to reduce the calls. We achieve this by only allowing one call to the server every 5 seconds. Bug: 1093531 Change-Id: I4d0d263248b7489b1b688921382c4bb214810b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241348 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782237}
-
Reilly Grant authored
This change updates the Mojo interface provided to the renderer and implements the getInfo() method on the SerialPort object so that sites can determine the USB vendor and product IDs of a device. These properties are USB-specific and won't be present for other types of devices. These properties provide symmetry with the usbVendorId and usbProductId filter parameters a site can pass to navigator.serial.requestPort() and allow the site to automatically detect the model of a device in order to determine the protocol it supports. Bug: 1074383 Change-Id: I84e0028890c1ecb9598262594a55adbec7443b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236915 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#782236}
-
Yoshifumi Inoue authored
This patch changes "caret-ltr-right.html" to utilize |selection_test()| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: Ie030551e9656436a4c2ac02cc14127b98d294e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262693 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782235}
-
Rachel Wong authored
This change adds a policy that sets Suggested Content to default disabled for enterprise users. Bug: 1079169 Change-Id: I994ff0efd9c5ff7605f0508fdf1c3556b45ecccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255736 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782234}
-
Stephen Roe authored
If the runner logs directory is not specified, if there is an emulator ssh connection error output the serial log contents using python script logging. Bug: 1067356 Change-Id: I437b60dc3dda699d8f1215c1f1baaac72f451f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261637 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782233}
-
Peng Huang authored
The vulkan queue submission has been removed from GrContext::updateBackendTexture(), so the queue submission in the WrappedSkImage::Update() method is not necessary anymore. Bug: 1087063 Change-Id: Ic77cc4194867778ac4f4694c005644e32763299e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265375 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#782232}
-
Hiroki Nakagawa authored
This CL delays recording loading breakdown metrics for navigation until the current page navigates away. The motivation of this change is to make the timing to record them consistent with the timing to record other PageLoad metrics. The loading breakdown metrics were newly added in M85 (the current milestone), so this change doesn't mess up the metrics already recorded. Bug: 1068843 Change-Id: I3a1f9671465d3c131a1864bb18001277d045b069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253828Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#782231}
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/EzR30mgq8gBio73c57P_BOSZHQ1vp_pejDwHKnzEKO4C Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202006230800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I0c6d5b5265c0cd792ec977adc21622742251ccb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263633Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#782230}
-
Alexey Baskakov authored
WebAppFileHandlerManager::GetAllFileHandlers must return nullptr if web app is uninstalled. Semantically, app_id is a weak pointer. The WebApp object behind it can be destroyed. Bug: 1088434 Change-Id: Ic74545efbe4f9e1250e039bf88fd95dd46bcf342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264179 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#782229}
-
Ted Meyer authored
Bug: 1099034 Change-Id: Icabb126bfac5e69aa4d030cf68c63ef826ccfd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264945Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#782228}
-
Ben Joyce authored
Code coverages looks for files with a suffix __jacoco_sources.json. Need to have files match name this as right now, they have the suffix java_process_device_sources.json. Coverage has been broken because the new files are not named this after https://chromium-review.googlesource.com/c/chromium/src/+/2252690 landed. Bug: 1097815,1095770 Change-Id: Ie5571677ab1ef2ad7a6d4fc519b6068d0081f89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264469 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#782227}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593032304-90202fa1b4038f00c77b47bcef25599006092a46.profdata to chrome-win64-master-1593043069-e9ed35a2ba4491e832399d01d535b62071a030c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I722cb480291462bb13a7ddaa449d75801cd53d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265713Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782226}
-
Sara Kato authored
Update comments to follow convetions mentioned in https://developers.google.com/style/inclusive-documentation. Also perform some refactoring of other comments to ensure consistency/ readability. Bug: 842296 Test: N/A Change-Id: I389463cc5ccd8f21983ee83383df07521c58aa07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265695 Commit-Queue: Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#782225}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f08ecebda15a..0633c38c109f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150,chromium:1090082,chromium:1094506,chromium:1098971,chromium:834134 Tbr: melzhang@google.com Change-Id: I90d44bbe5d225ff3d7ab43829c777261b20a514c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265479Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782224}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I91925dd3fb2f6c0ac1186e653322d3a3fa1c8d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265755Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782223}
-