- 10 Nov, 2020 40 commits
-
-
Ioana Pandele authored
The toggle should be shown whenever the key icon is shown on sites which are blocked from saving passwords, but contain password forms. Bug: 1145173, 1044930 Change-Id: I1da5eca94d4118962f9c29b43f4caf1c8c56c538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526301 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#825830}
-
Jordan Demeulenaere authored
This CL adds a new can_match_multiple_elements flag to UploadDomProto to allow it to return the DOM of multiple elements matching the same selector. This CL also removes the ProcessedActionProto.html_source field and replaces it by a UploadDomProto::Result field. This means that newly built client won't work for scripts that use UploadDom until the associated backend code is implemented (which will be done in cl/341416176). Bug: b/166564516 Change-Id: I20f4e6f12fdf5106f4bbe297c4ecb16bcdc9205b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523035Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#825829}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38f3d771bd8e..952ef3e06472 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id0248168e1ffc644f4be36844e5eca6067884947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528641Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825828}
-
Claude van der Merwe authored
The RecordTotalCount metric is incorrectly logged as 0 during OOBE since the networks have not had a chance to merge. This CL 1. Adds a pref to avoid the incorrect log of 0 networks during OOBE. 2. Adds a Teardown in the unittests to temporarily fix flaky tests. Bug: 1135854 Change-Id: I03328caae2753b0331a9c5ed43d7b79de64dac44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519327Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#825827}
-
cfredric authored
This fixes the test flake. Bug: 1147062 Change-Id: Iacfa443eb74420e79ffb56d770d59388cabe94b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525767Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#825826}
-
Stephane Zermatten authored
With this change, it becomes possible, when building a selector, to require the matched element to have a nonempty bounding box. This is useful on its own, as setting an empty height or width is a strategy that's sometimes used to keep an element, such as a menu, on the DOM tree than can be revealed at the appropriate time by resizing it. Without this change, selectors would think that an element hidden in that way is visible. Bug: b/171464032 Change-Id: I1de9150a794d56e9bfb1ebdd95e86c724592380a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503736 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#825825}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 1145565 Change-Id: Id873d944e6e92d743bba116816b1c3f7c0bcabf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526168 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825824}
-
Matt Jones authored
This patch migrates the TopToolbarOverlay to use the new layouts module rather than the LayoutManagerImpl class. The old observer in the mediator has been replaced with the LayoutStateObserver and a new supplier has been added to the coordinator's constructor for the ResourceManager. Bug: 1070281, 1100332 Change-Id: I061ee98a3e7bb8db8f2a23d75573077bac0c271c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527010 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#825823}
-
Stephen Chenney authored
The various Blink.MainFrame Ratio metrics are essentially unused. The same data can be gathered from UKM using totals for time spent in BeginMainFrame. This change removes the Ratio UMA metrics and updates the UKM event to report BeginMainFrame times rather than percentages. Also clean up some now obsolete metrics that had not been marked as such. The privacy doc has been updated but privacy review is not required because we are reporting the same data in a different form (the values reported now could have been computed from the former values). Bug: 1138397 Change-Id: I6769c29a56a739e030e85262a33a79fd4d7471f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527581Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#825822}
-
Swapnil authored
We store error codes and number of fetch tries if the extension installation fails due to MANIFEST_FETCH_FAILED or CRX_FETCH_FAILED. We want to add these fields to the existing events for the event based reporting for force installed extensions so that detailed reason can be reported. Bug: 1048640 Change-Id: I124615d0a8ffa4b7f9991149054947a5cf391e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505983 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825821}
-
Findit authored
This reverts commit 45fe0314. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 825789 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ1ZmUwMzE0NTc4MGE4M2RmODM2YmNiMDNjNGE3MzNkNWFmNTkzYjQM Sample Failed Build: https://ci.chromium.org/b/8864008846435386704 Sample Failed Step: compile Original change's description: > a11y insepct reorg: move PropertyNode class to ui/accessibility > > Bug: 1133330 > Change-Id: I9103d0116c5822a0f9dc291a7a87bd5f902a4efa > AX-Relnotes: n/a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519755 > Commit-Queue: Alexander Surkov <asurkov@igalia.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825789} Change-Id: If5cefe8ce9b3efa19009c7b68d3e8e9c618b01a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528647 Cr-Commit-Position: refs/heads/master@{#825820}
-
Tommy Martino authored
This reverts commit 5e46febb. Reason for revert: Speculative revert based on Mac Builder clang segfaults Sample bad build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8864006321936062752/+/steps/compile/0/stdout Original change's description: > mac/ios: Use real response files instead of -filelist. > > Xcode 12 added support for real response files, so let's use them. > Allows making response file contents more like on other systems > (libs, solibs, frameworks, swiftmodules now go in the rsp file too), > and makes it theoretically possible to have object files with spaces > in their name. > > No intentional behavior change. > > Bug: none > Change-Id: I8c2d6ff1abd47261bf7674dc7bf4506814681ad4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527621 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Brett Wilson <brettw@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825480} TBR=thakis@chromium.org,brettw@chromium.org,mark@chromium.org Change-Id: I128e1fd1d69c56374629202935e6a12614fdc03e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529609 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#825819}
-
Henrik Boström authored
This reverts commit 46b6fd15. Reason for revert: camera.CCAUISmoke.fake is failing on chromeos-eve-chrome and camera.CCAUI* is listed as test coverage for this CL, so I am speculating that it is the cause. See: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11136 Original change's description: > [CCA] Run CCA as SWA by default > > Bug: b/172345161 > Test: tast run [DUT] camera.CCAUI* > Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825657} TBR=ortuno@chromium.org,wtlee@chromium.org Change-Id: I5464fbcd7f1a03cd157122ad66c6ee13ad111630 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/172345161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529360Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#825818}
-
Alex Turner authored
This metric will break out the activation state of frames that inherit their activation from their opener. This should help illuminate the impact from the recent change to allow inheritance from same-origin openers for certain mainframes (see crrev.com/c/2219104). Bug: 1055558 Change-Id: I5efbf94e90fa3953880d64f9934a770855aaa72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515181Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#825817}
-
Viktor Semeniuk authored
This change fixes the crash when username was changed to the empty one. Bug: 1147046 Change-Id: I0c9e24bce474639499865c06f1d9007776bc5c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526323 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825816}
-
Khushal Sagar authored
After the change in [1], we no longer ensure that the SkCanvas lifetime is tied to CanvasImageProvider. [1] : https://chromium-review.googlesource.com/c/chromium/src/+/2450842 R=aaronhk@chromium.org Bug: 1143229 Change-Id: If99ff121c221b6560da58596fc9faf11fe28dfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528615 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#825815}
-
Vladimir Levin authored
This patch ensures devtools doesn't try to generate grid information on locked containers, since the contents are not necessarily laid out or generated. R=chrishtr@chromium.org Fixed: 1139642 Change-Id: I5b279196cf147407abefa7ffa2264484fc698b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527941Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#825814}
-
Kent Tamura authored
For a historical reason, some form controls always clip the content, and should ignore the 'overflow' property. File upload control NG had a regression that it accepts overflow:visible. This CL disables it again. The new behavior is compatible with Safari and Firefox. Bug: 1139629 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Change-Id: I6b0b5a715a2c859f195bbf2473ead67cd22bd14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528812Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#825813}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604987499-7dfc90285fa0600b167fa15e7d7c9c3f744524d3.profdata to chrome-mac-master-1605009236-712b615a5b080d19851b96ffa1d3eb36eb083647.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I92d4b52db148fef1f5d93f2896e0bb72213c9e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529178Reviewed-by:
-
Antonio Gomes authored
.. window_properties.h. Also kFrameInactiveColorKey. This is the last step before moving default_frame_header.cc|h to //chromeos/ui/frame/. BUG=1113900 R=jamescook@chromium.org TBR=oshima@chromium.org Change-Id: I2355f497bd94a9569d9a35ff3f95c70c436201cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521114 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#825811}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7c2726770e4364b6c2ebd716f61d0a7d4d6fc346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529170Reviewed-by:
-
Zhenyao Mo authored
BUG=1117185 TEST=bots Change-Id: If904ab785166485812438a9bc2f2bedf16fec2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525853 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#825809}
-
Marc Treib authored
The existing versions of these histograms (without "2") are recorded for all users, whether they're opted in to the account-scoped store or not, so they contain a lot of useless entries. The new version "2" histograms are only recorded for opted-in users. The old histograms are *not* deprecated yet, in case we want to compare some numbers from M87 (which only has the old versions) with numbers from later Chrome versions. Bug: 1145971 Change-Id: I633769d4b77fbefef17014d613b83a45c3580b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526064 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#825808}
-
Olle Liljenzin authored
We see an increased number of crashes caused by uncaught exceptions indicating the camera was used after release. The reported crash is also reproducible on one of our test devices by opening certain chat pages in the Opera browser. Using the camera after release() was called is an error, but this would still happen if Camera#getParameters() fails with an exception because we would then call release() without nulling the reference to the released camera instance. Later on we will use the released instance to close the camera preview, causing a new exception that will crash the browser as it is not caught. This change fixes the use-after-release crash by nulling the camera reference after a failure, to prevent any further usage after the camera was released. Bug: 1125083 Change-Id: Ibbf3099636f3e25692fae4799255d04f2cfd4e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527138Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Olle Liljenzin <ollel@opera.com> Cr-Commit-Position: refs/heads/master@{#825807}
-
Sigurdur Asgeirsson authored
Replace ScopedObserver with base::ScopedObservation in /content/browser/site_per_process_browsertest.cc. ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1145565 Change-Id: I2f7b5f2f7892d2ffa57f5e964e0427842698c90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526166Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825806}
-
Shakti Sahu authored
This CL adds : 1 - Show a context menu item for Read later 2 - A New label to be shown until user clicks on the menu item Bug: 1145825 Change-Id: Ie0ccb1d56a76d3e6bf6ae38075d0a7bcbba6a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520278 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825805}
-
arthursonzogni authored
Previous patch removed functions non referenced by a caller: https://chromium-review.googlesource.com/c/chromium/src/+/2523114 Pulling the string further, this caused more functions not to have a any callers, which are removed here. Bug: 1146469 Change-Id: Ic82c95c07523d10e6d88d45ea2fa392562f05501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521190 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#825804}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604966213-470516c2fd4e526d214b1511f3d83ecfab2ce340.profdata to chrome-linux-master-1605009236-ea4b3e0cf6b6eb37089f063eb3b9762bfdc69494.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6aad459037da3c455f6d32726d3f101a61264510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529173Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4e32eb5788c..090c3b6d15c4 2020-11-10 sigurds@chromium.org Remove deepElementFrom{Event,Point} from prototypes 2020-11-10 aerotwist@chromium.org [unit test] Remap Elements tests to use entrypoint 2020-11-10 tvanderlippe@chromium.org Typecheck lighthouse/LighthouseReportRenderer.js with TypeScript 2020-11-10 tvanderlippe@chromium.org Typecheck timeline/EventsTimelineTreeView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f088e43d14c68db6749e537fd147cefaee055b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528207Reviewed-by:
-
Rakina Zata Amni authored
We're seeing some OOMs and want to investigate what's happening. Bug: 1147081 Change-Id: I9101462643783ea2e6fac50357b2c4043c8c808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528556 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#825801}
-
Yutaka Hirano authored
This CL introduces ReadableTransferringOptimizer and WritableTransferringOptimizer for the Transferable Streams optimization described in the following design doc. https://docs.google.com/document/d/19WpamKCysWHYGA6jIrlwZIYxhBrsHCDHYNd98Zl1u5w This CL doesn't change the behavior. Bug: 1146396 Change-Id: If19841e27594fa43442f24805e380b23bb0abb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522805Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#825800}
-
Maria Kazinova authored
Previously it was possible to generate a password on a password field outside the form tag but it was not filled, since formless fields were ignored in this flow. This CL fixes that. Bug: 1146005 Change-Id: I5bf6347c9666b6b7e4f1d796418597f27d5e8f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527144Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#825799}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604955437-61247d42a6140f126d61086b5421948904b6ffb0.profdata to chrome-win32-master-1604987499-d58c7c50ae14a2e4ca32a9270333a79aabab2447.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I69df425274f8405eb1818ecea1d2b9450039f6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528917Reviewed-by:
-
Torne (Richard Coles) authored
Don't take ownership fo the local ref returned by ANativeWindow_toSurface; just wrap it in a JavaParamRef to satisfy the interface temporarily. This is a speculative fix for the StrictMode crash; the introduction of this Adopt appears to be the only functional change in the culprit CL, so avoiding it might work; if so we can find a real solution afterward. Bug: 1146071 Change-Id: Ie817bfbfa7dc531b6e4ddacde42ee5c021948451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527563 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825797}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eba8b028ddbc..38f3d771bd8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5f450872598e10a8d6b103cbc864a50844415a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528618Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/139be0697741..c7c5d0ecc59d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hbos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1123216 Tbr: hbos@google.com Change-Id: I6072350a009840f75952db5dfdef893990c5b829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529169Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825795}
-
Polina Bondarenko authored
Add SnapshotHoursPolicyService to handle policy changes. BUG=b:170187468 TEST=components_unittests Change-Id: I1918d55d6e53b0085473f7bf650cf949767ed4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514148Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#825794}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1145565 Change-Id: If3dc3daa800da2d45c6a10e7561862eeb1368bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526922 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825793}
-
Sylvain Defresne authored
Refactor in https://crrev.com/c/2498546 incorrectly used the same value for -rpath for both applications and application extensions. This caused the CPE extension to fail at runtime to load the ChromeSSOInternal dylib. Use the correct value for -rpath for the application extension. Bug: 1147070 Change-Id: Id46a33c99b77e44f1874680a27bb04f56a1f347e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529111 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825792}
-
Nico Weber authored
The bugs preventing this are now fixed. Bug: 1143946 Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: I043d209e3ec41b708a2834c4a904dea79f9ffeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527884Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825791}
-
