- 23 Nov, 2015 40 commits
-
-
limasdf authored
C++ 11 enables containers that contain move-only type, scoped_ptr. So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap. BUG=554291 TBR=raymes@chromium.org Review URL: https://codereview.chromium.org/1468013002 Cr-Commit-Position: refs/heads/master@{#361118}
-
Nico Weber authored
Fixes the clang/win build after https://codereview.chromium.org/1439443002/ clang rightfully complains that UiThreadHelper has virtual methods, is deleted polymorphically, and doesn't have a virtual destructor: ..\..\base/sequenced_task_runner_helpers.h(40,5) : error: delete called on 'const device::SerialIoHandlerWin::UiThreadHelper' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] delete reinterpret_cast<const T*>(object); ^ ..\..\base/sequenced_task_runner_helpers.h(86,38) : note: in instantiation of member function 'base::DeleteHelper<device::SerialIoHandlerWin::UiThreadHelper>::DoDelete' requested here from_here, &DeleteHelper<T>::DoDelete, object); ^ ..\..\base/sequenced_task_runner.h(126,48) : note: in instantiation of function template specialization 'base::subtle::DeleteHelperInternal<device::SerialIoHandlerWin::UiThreadHelper, bool>::DeleteViaSequencedTaskRunner<base::SequencedTaskRunner>' requested here subtle::DeleteHelperInternal<T, bool>::DeleteViaSequencedTaskRunner( ^ ..\..\device\serial\serial_io_handler_win.cc(374,28) : note: in instantiation of function template specialization 'base::SequencedTaskRunner::DeleteSoon<device::SerialIoHandlerWin::UiThreadHelper>' requested here ui_thread_task_runner()->DeleteSoon(FROM_HERE, helper_); ^ Making the class final fixes this as it makes sure that nobody adds a subclass of UiThreadHelper. Also don't mix initializer styles for the different fields of this class. No intended behavior change. BUG=82385 TBR=juncai Review URL: https://codereview.chromium.org/1470983002 . Cr-Commit-Position: refs/heads/master@{#361117}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/76efc8f2..a40b4f5c Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1472873002 Cr-Commit-Position: refs/heads/master@{#361116}
-
svaldez authored
BUG=514767 Review URL: https://codereview.chromium.org/1423333006 Cr-Commit-Position: refs/heads/master@{#361115}
-
j.isorce authored
and when --use-gl=egl then the browser is showing garbage. Indeed in GpuCommandBufferStub::OnInitialize the call to context->Initialize(surface_.get(), gpu_preference_)" fails. The error actually comes from eglMakeContext which returns EGL_BAD_MATCH. Because surface config is not compatible with context config. Problem is that EGL_BUFFER_SIZE is always 32 for off screen surfaces (see gl_surface_egl.cc::InitializeOneOff). Whereas for on screen surfaces EGL_BUFFER_SIZE is the window depth. This depth is by default 24 unless --enable-transparent-visuals is passed to the command line. When using mesa the error is raised here: /* If the context has a config then it must match that of the two * surfaces */ if (ctx->Config) { if ((draw && draw->Config != ctx->Config) || (read && read->Config != ctx->Config)) return _eglError(EGL_BAD_MATCH, "eglMakeCurrent"); from: cgit.freedesktop.org/mesa/mesa/tree/src/egl/main/eglcontext.c#n630 This patch pass the main window depth from browser to gpu process though a new switch kWindowDepth. This allow GLSurfaceEGL::InitializeOneOff to select an EGLConfig that matches with future ON screen surfaces's EGLConfig. Also note that long term plan is to always enable transparent visual, see http://crbug.com/369209. This patch also move the kEnableTransparentVisuals switch from view to x11 switches as it is defined to x11 only. BUG=557389 R=jbauman@chromium.org, hendrikw@chromium.org, piman@chromium.org, sadrul@chromium.org, cwallez1@chromium.org, kbr@chromium.org Review URL: https://codereview.chromium.org/1429083002 TEST= chrome --use-gl=egl --use_virtualized_gl_contexts Review URL: https://codereview.chromium.org/1429083002 Cr-Commit-Position: refs/heads/master@{#361114}
-
sdefresne authored
BUG=None Review URL: https://codereview.chromium.org/1466343002 Cr-Commit-Position: refs/heads/master@{#361113}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/5931922997b8..8e8eda9d4d2e $ git log 593192299..8e8eda9d4 --date=short --no-merges --format='%ad %ae %s' 2015-11-23 msarett Switch Skia's libjpeg-turbo to 1.4.2 2015-11-23 kkinnunen Fix GLInterfaceValidation test after "Remove GrContextFactory::getGLContext" CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=jvanverth@google.com Review URL: https://codereview.chromium.org/1470953002 Cr-Commit-Position: refs/heads/master@{#361112}
-
sdefresne authored
BUG=553320 Review URL: https://codereview.chromium.org/1466363002 Cr-Commit-Position: refs/heads/master@{#361111}
-
wnwen authored
This CL is a precursor to expanding Clank stability scope to all OOM protected renderers that crash while Chrome is in the foreground. The difference in scope is effectively the number of renderers that crash as its corresponding tabs are all backgrounded. This transition time is one second before the OOM protection is dropped. Most, if not all, such renderer crashes are due to the Android OOM killer. Overall difference in proposed stability stats will not be much different, and will be easily seen with the new histogram. Expanding scope allows us to have native record which of the renderer crashes actually results in a minidump file being generated, thus demystifying whether the renderer was OOM killed or actually crashed. This native stat can be made more robust in the future, but this CL paves the foundation, assuming Tab.RendererExitStatus is comparable to Tab.RendererCrashStatus. Review URL: https://codereview.chromium.org/1447213002 Cr-Commit-Position: refs/heads/master@{#361110}
-
sdefresne authored
Unrecoverable SSL errors were broken in Merge 229993, by the upstream CL: https://codereview.chromium.org/23965003/. This fix removes the iOS specific interstitial.mm and uses interstitial_page_impl instead. It also adds support for unrecoverable errors, by returning a DENIED judgment to some errors. BUG=310607 TEST=Go to https://test-sspev.verisign.com/. Clicking on "Revoked" should trigger an unrecoverable error, clicking on "Expired" should trigger a recoverable error (with a "proceed anyway" button) Review URL: https://chromereviews.googleplex.com/12347017 Review URL: https://codereview.chromium.org/1469063002 Cr-Commit-Position: refs/heads/master@{#361109}
-
jyquinn authored
Removes ServiceIsNullForTesting override in FaviconServiceFactory to enable use of FaviconServiceFactory in tests. BUG=557415 Review URL: https://codereview.chromium.org/1458703009 Cr-Commit-Position: refs/heads/master@{#361108}
-
ulan authored
BUG=551798 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Review URL: https://codereview.chromium.org/1424213006 Cr-Commit-Position: refs/heads/master@{#361107}
-
sdefresne authored
BUG=None Review URL: https://codereview.chromium.org/1471763004 Cr-Commit-Position: refs/heads/master@{#361106}
-
sdefresne authored
The only usage of this method is in iOS-specific code that knows that it's talking to a WebOmniboxEditController, so it's unnecessary to fork omnibox_edit_controller.h to expose this method. BUG=305330 Review URL: https://codereview.chromium.org/1465253002 Cr-Commit-Position: refs/heads/master@{#361105}
-
sdefresne authored
BUG=None Review URL: https://codereview.chromium.org/1469053002 Cr-Commit-Position: refs/heads/master@{#361104}
-
sdefresne authored
This CL changes the iOS port to use IOSChromeMetricsServiceClient rather than its forked version of ChromeMetricsServiceClient. There is one intended functional change in that ChromeMetricsServiceClient::RecordCommandLineMetrics() was not ported to IOSChromeMetricsServiceClient; see crbug.com/375794 for details. Other than that, there should be no functional changes. BUG=512421, 375794 Review URL: https://codereview.chromium.org/1470963002 Cr-Commit-Position: refs/heads/master@{#361103}
-
sdefresne authored
Prior to this CL, when the ESC key was pressed, only the state presented by the BVC was dismissed. Moreover, the BVC dismissed blindly all presented view controller, such as the settings. It is the MainController responsibility to close the settings, as it is the presenter. This CL adds a new Chrome command that asks to dismiss all modals. BUG=none R=rohitrao@google.com Review URL: https://chromereviews.googleplex.com/265777013 Review URL: https://codereview.chromium.org/1469903002 Cr-Commit-Position: refs/heads/master@{#361102}
-
mvanouwerkerk authored
BUG=558402 Review URL: https://codereview.chromium.org/1467573003 Cr-Commit-Position: refs/heads/master@{#361101}
-
peter authored
BUG= Review URL: https://codereview.chromium.org/1469813004 Cr-Commit-Position: refs/heads/master@{#361100}
-
ccameron authored
Move from RenderProcessHostImpl::OnChannelEstablished to RenderProcessHostImpl::OnProcessLaunched, so that it comes in before the first burst of IPCs to the renderer. Change token DCHECKs to CHECKs, because they will crash the renderer later on. BUG=554541 Review URL: https://codereview.chromium.org/1463853002 Cr-Commit-Position: refs/heads/master@{#361099}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6029096..76efc8f2 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1469033002 Cr-Commit-Position: refs/heads/master@{#361098}
-
magjed authored
Reland of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #1 id:1 of https://codereview.chromium.org/1472713003/ ) Reason for revert: Mac Builder (dbg) does not even compile now... Original issue's description: > Revert of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #2 id:20001 of https://codereview.chromium.org/1460063003/ ) > > Reason for revert: > I'm speculatively reverting this CL as the cause for the failing Mac10.6 Tests nacl_integration test. The whole test fails with this output: > scons: done reading SConscript files. > scons: Building targets ... > Install file: "src/untrusted/pthread/pthread.h" as "scons-out/nacl-x86-64/include/pthread.h" > Install file: "src/untrusted/pthread/semaphore.h" as "scons-out/nacl-x86-64/include/semaphore.h" > Install file: "src/untrusted/stubs/crt1.x" as "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" > Func(["scons-out/nacl-x86-64/obj/tests/breakpad_crash_test/breakpad_untrusted_crash_test.out.tmp/crash_test.nmf"], []) > Install file: "src/untrusted/nacl/nacl_random.h" as "scons-out/nacl-x86-64/include/nacl/nacl_random.h" > Install file: "src/untrusted/nacl/nacl_dyncode.h" as "scons-out/nacl-x86-64/include/nacl/nacl_dyncode.h" > WriteManifestList(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner_nmf_test_list.js"], []) > Func(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner.out.tmp/random_test.nmf"], []) > Install file: "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" as "scons-out/nacl-x86-64/lib/crt1.o" > /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o src/untrusted/nacl/sigprocmask.c > dyld: Library not loaded: /usr/lib/libedit.3.dylib > Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang > Reason: image not found > > I'm thinking this might be caused by "Fix PNaCl toolchain build on Mac" https://codereview.chromium.org/1458713003 > that e.g. includes this change: > # Required SDK version and target version for Mac builds. > # See MAC_SDK_FLAGS, below. > MAC_SDK_MIN = '10.10' > MAC_DEPLOYMENT_TARGET = '10.6' > > Original issue's description: > > NaCl: Update revision in DEPS, 546ef11 -> b6ec17d > > > > This pulls in the following Native Client changes: > > > > 1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS > > 26a11d1: (stichnot@chromium.org) Update revision for PNaCl > > 3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS > > 7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc > > 1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS > > 0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch > > 9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host > > 7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX. > > 18e2d27: (erikchen@chromium.org) Add code to check for the OS X version. > > bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py. > > 079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS > > 4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac > > db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names > > d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl > > b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory. > > > > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8 > > > > BUG=none > > TEST=browser_tests and nacl_integration > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build > > > > Committed: https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f > > Cr-Commit-Position: refs/heads/master@{#360958} > > TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > BUG=none > > Committed: https://crrev.com/a503d57f1c4ec0f07b064247ee82c3e7d4ecd9dc > Cr-Commit-Position: refs/heads/master@{#361096} TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1472853002 Cr-Commit-Position: refs/heads/master@{#361097}
-
magjed authored
Revert of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #2 id:20001 of https://codereview.chromium.org/1460063003/ ) Reason for revert: I'm speculatively reverting this CL as the cause for the failing Mac10.6 Tests nacl_integration test. The whole test fails with this output: scons: done reading SConscript files. scons: Building targets ... Install file: "src/untrusted/pthread/pthread.h" as "scons-out/nacl-x86-64/include/pthread.h" Install file: "src/untrusted/pthread/semaphore.h" as "scons-out/nacl-x86-64/include/semaphore.h" Install file: "src/untrusted/stubs/crt1.x" as "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" Func(["scons-out/nacl-x86-64/obj/tests/breakpad_crash_test/breakpad_untrusted_crash_test.out.tmp/crash_test.nmf"], []) Install file: "src/untrusted/nacl/nacl_random.h" as "scons-out/nacl-x86-64/include/nacl/nacl_random.h" Install file: "src/untrusted/nacl/nacl_dyncode.h" as "scons-out/nacl-x86-64/include/nacl/nacl_dyncode.h" WriteManifestList(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner_nmf_test_list.js"], []) Func(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner.out.tmp/random_test.nmf"], []) Install file: "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" as "scons-out/nacl-x86-64/lib/crt1.o" /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o src/untrusted/nacl/sigprocmask.c dyld: Library not loaded: /usr/lib/libedit.3.dylib Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang Reason: image not found I'm thinking this might be caused by "Fix PNaCl toolchain build on Mac" https://codereview.chromium.org/1458713003 that e.g. includes this change: # Required SDK version and target version for Mac builds. # See MAC_SDK_FLAGS, below. MAC_SDK_MIN = '10.10' MAC_DEPLOYMENT_TARGET = '10.6' Original issue's description: > NaCl: Update revision in DEPS, 546ef11 -> b6ec17d > > This pulls in the following Native Client changes: > > 1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS > 26a11d1: (stichnot@chromium.org) Update revision for PNaCl > 3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS > 7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc > 1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS > 0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch > 9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host > 7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX. > 18e2d27: (erikchen@chromium.org) Add code to check for the OS X version. > bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py. > 079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS > 4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac > db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names > d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl > b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory. > > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8 > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build > > Committed: https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f > Cr-Commit-Position: refs/heads/master@{#360958} TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true BUG=none Review URL: https://codereview.chromium.org/1472713003 Cr-Commit-Position: refs/heads/master@{#361096}
-
stkhapugin authored
On iOS 9, evaluating '' + document always results in [object HTMLDocument], even for PDFs. This introduces another way of checking document type on iOS 9. Unfortunately, it doesn't work on iOS 8, so the old implementation needs to stay too. BUG=549604 Review URL: https://codereview.chromium.org/1458703004 Cr-Commit-Position: refs/heads/master@{#361095}
-
davve authored
While attempting to remove the layoutObject parameter the following observations were made: * The decoding forced by BitmapImage::imageForCurrentFrame will be deferred so the comment in the header may be removed. * BitmapImage::currentFrameKnownToBeOpaque() conservatively returns false for uncached images, not true. * Since decoding is deferred, there is no guarantee that the opaqueness metadata is available after the imageForCurrentFrame call has returned. It may increase the chance though, depending on image decoder for the particular image. NOTRY=true BUG=559131 Review URL: https://codereview.chromium.org/1454373005 Cr-Commit-Position: refs/heads/master@{#361094}
-
droger authored
Review URL: https://codereview.chromium.org/1467143002 Cr-Commit-Position: refs/heads/master@{#361093}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fcdcfb56..e6029096 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1466263002 Cr-Commit-Position: refs/heads/master@{#361092}
-
glider authored
BUG=542575 TBR=thestig@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1467203002 Cr-Commit-Position: refs/heads/master@{#361091}
-
magjed authored
Revert of The AllUrlsApiTest.WhitelistedExtension test should no longer flake. (patchset #3 id:40001 of https://codereview.chromium.org/1442593002/ ) Reason for revert: The WhitelistedExtension is still flaky on the XP Tests bot, see e.g. https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/41174 stdio output: [ RUN ] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages [1636:4084:1120/124530:WARNING:raw_channel.cc(208)] Shutting down RawChannel with write buffer nonempty [139/464] AllUrlsApiTest.WhitelistedExtensionRunsOnExtensionPages (TIMED OUT) Original issue's description: > The AllUrlsApiTest.WhitelistedExtension test should no longer flake. > > The test had begun to hang after the refactoring that changed the way the extensions are loaded and reloaded. As a result of that refactoring, the test loaded the pages and tried to get some response from the extensions before they had time to reload. > > This change introduces waiting for the extensions reload, so the test should no longer flake. > > BUG=174341 > > R=finnur@chromium.org > > Committed: https://crrev.com/454083864ede93660c2f08cf7d0e06ca10013c0d > Cr-Commit-Position: refs/heads/master@{#359537} TBR=finnur@chromium.org,voodoo@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true BUG=174341 Review URL: https://codereview.chromium.org/1469813003 Cr-Commit-Position: refs/heads/master@{#361090}
-
kcwu authored
A hole in a file is an area represented by zeros, which are not stored physically on disk (aka sparse files). Take 640x360 I420 input as an example. The padding size for three planes are 5120, 1280, and 1280. Note 5120 > 4k. That means for every frame, there is one page "hole" in the file. The hole page causes troubles for some systems. This CL fills holes with zero bytes. BUG=chrome-os-partner:41833 TEST=video_encode_accelerator_unittest Review URL: https://codereview.chromium.org/1324213007 Cr-Commit-Position: refs/heads/master@{#361089}
-
glider authored
Revert of Re-enable HTTP/2 over NPN (for OpenSSL). (patchset #3 id:40001 of https://codereview.chromium.org/1453903002/ ) Reason for revert: The CL has introduced massive MSan and Valgrind reports, see the bug. BUG=557197 Original issue's description: > Re-enable HTTP/2 over NPN (for OpenSSL). > > BUG=557197 > > Committed: https://crrev.com/0eb771aa98ba2bd4db0e2b82241afe8f5760c32e > Cr-Commit-Position: refs/heads/master@{#361053} TBR=cbentzel@chromium.org,bnc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557197 Review URL: https://codereview.chromium.org/1472743002 Cr-Commit-Position: refs/heads/master@{#361088}
-
tanay.c authored
Current Behaviour: Chrome : RTCIceCandidate.candidate = null => "" RTCIceCandidate.sdpMid = null => "" Firefox : RTCIceCandidate.candidate = null => "null" RTCIceCandidate.sdpMid = null => "null" After the change: Chrome: RTCIceCandidate.candidate = null => "null" RTCIceCandidate.sdpMid = null => "null" This aligns with the behavior on Firefox nightly BUG=497307 Review URL: https://codereview.chromium.org/1431793002 Cr-Commit-Position: refs/heads/master@{#361087}
-
alexclarke authored
Previously if there were N distinct delayed times for dealyed tasks posted to the scheduler, there would be N delayed tasks posted on the chromium run loop. We only really need to post timers for the next delayed task. This patch implements that. Caveat: because it's not possible to cancel tasks posted to the chromium runloop, we will still have more than one task outstanding if delayed tasks get posted in reverse order. BUG=510398, 546953 Review URL: https://codereview.chromium.org/1468443002 Cr-Commit-Position: refs/heads/master@{#361086}
-
alexander.shalamov authored
Based on review feedback, WebNFC specification was modified and requestAdapter() method was removed from NFC interface. Methods from NFCAdapter were moved to NFC interface. This patch adds new methods to NFC interface and aligns corresponding idl files with latest specification. https://w3c.github.io/web-nfc/#dom-nfc-push https://w3c.github.io/web-nfc/#dom-nfc-cancelpush https://w3c.github.io/web-nfc/#dom-nfc-watch https://w3c.github.io/web-nfc/#dom-nfc-cancelwatch BUG=520391 Review URL: https://codereview.chromium.org/1444303002 Cr-Commit-Position: refs/heads/master@{#361085}
-
mstensho authored
Floats' margins need special attention for pagination, because they are not to be eaten by page or column boundaries. Clamp strut to >= 0 in LayoutBlockFlow::setPaginationStrutPropagatedFromChild() instead of doing it (poorly) in calculateStrutForPropagation(). Removed calculateStrutForPropagation(), because there was hardly anything left there now (and this lets us make marginBeforeIfFloating() private). This function also turned out not to be universally usable, since we were already calculating the strut on our own in adjustLinePositionForPagination() in one case. R=leviw@chromium.org Review URL: https://codereview.chromium.org/1460203003 Cr-Commit-Position: refs/heads/master@{#361084}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/064d82a9..fcdcfb56 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1467113002 Cr-Commit-Position: refs/heads/master@{#361083}
-
mstensho authored
No multicol container should suggest to initially use a column height less than the height of the tallest piece of unbreakable content inside. TL;DR some related cleanup. Introduce the term tallestUnbreakableLogicalHeight in favor of minimumColumnLogicalHeight, as the latter could easily be confused with initial column height; the height found by InitialColumnHeightFinder, which is also sometimes referred to as initial minimal column height. Furthermore, there's already a concept of *maximum* column logical height in fragmentainer groups, which is derived from such things as CSS max-height. Since max-height actually trumps the height of the tallest piece of unbreakable content in multicol (while in CSS, min-height wins over max-height), it was just too confusing to keep using "minimum column height" for this. This change also makes it necessary to modify the containing column set when calculating the initial column height for fragmentainer groups, so this part kind of had to be moved from the const method calculateColumnHeight(). There was already code that walked around that method when calculating the column height, so being even more of a misnomer than before, it was renamed to rebalanceColumnHeightIfNeeded(). BUG=447718 R=leviw@chromium.org Review URL: https://codereview.chromium.org/1461923005 Cr-Commit-Position: refs/heads/master@{#361082}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/7ea33f5e1ae9..5931922997b8 $ git log 7ea33f5e1..593192299 --date=short --no-merges --format='%ad %ae %s' 2015-11-22 kkinnunen Remove GrContextFactory::getGLContext CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=jvanverth@google.com Review URL: https://codereview.chromium.org/1466223002 Cr-Commit-Position: refs/heads/master@{#361081}
-
droger authored
This CL renames the methods so that they are consistently using "BrowserState" instead of a mix of "BrowserState" and "ChromeBrowserState". Review URL: https://codereview.chromium.org/1463833002 Cr-Commit-Position: refs/heads/master@{#361080}
-
olli.raula authored
BUG=554289 Review URL: https://codereview.chromium.org/1465803002 Cr-Commit-Position: refs/heads/master@{#361079}
-