- 09 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7910a8f76121..a01ec53bddbd 2020-06-09 bsalomon@google.com Remove axis alignment restriction on small CPU blur 2020-06-09 johnstiles@google.com Revert "Add JavaInputStreamAdaptor files into third_party directory." 2020-06-09 bungeman@google.com Document skia::textlayout::Run is non-assignable. 2020-06-09 mtklein@google.com remove unnecessary hsw opts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087705 Tbr: bungeman@google.com Change-Id: Iabc6296c420b5c7e0a0a30870bb228bed20f7db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776564}
-
Eric Willigers authored
The app launch histograms remain useful until Chrome Apps are removed. https://blog.chromium.org/2020/01/moving-forward-from-chrome-apps.html June 2022: End support for Chrome Apps on Chrome OS for all customers. Bug: 1088772, 1088773 Change-Id: Id2fa7612d52719b814d8736252df1fc95c291516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224893Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#776563}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/630b884..46f53df 46f53df Add fuzzer to try ToUpper/ToLower by Frank Tang 53eca4c Cherrypick the upstream PR 1140 by Frank Tang ICU-13786 Fix addLikelySubtags/minimizeSubtags #1140 Bug: v8:10448, 1078274 Change-Id: I887bffd5df022689c7c9c07eef6b840a6755d81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235734Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#776562}
-
Rouslan Solomakhin authored
Before this patch, PaymentAppService would release its references in the destructor, which is the second phase of browser shutdown, as opposed to the KeyedService::Shutdown() method, which is the first phase, where all references should be released. This may have caused a crash when closing the browser. This is a speculative patch to have PaymentAppService release its references to the payment app factories during the first phase of browser shutdown. After this patch, PaymentAppService releases its references in the KeyedService::Shutdown() method, which is the first phase of browser shutdown. Bug: 1077713 Change-Id: Ic5785f703156bea2af7a1a03fca4ca6a39bb7dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236464Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776561}
-
Sami Kyostila authored
WebCore.ScriptedIdleTaskController.IdleCallbackOverrun was already removed from Chrome in 2017 by https://chromium-review.googlesource.com/803338. Bug: 1089649 Change-Id: Ib4b1ae39e78f64702815193601d18a0b5f373332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236144 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776560}
-
Etienne Pierre-doray authored
NonEmptyPaint3 is replacing NonEmptyPaint2. As a first step, expiry and owner is updated. https://groups.google.com/a/google.com/g/chrome-catan/c/BhJOc7JIYeY/m/KvfHr2sqBgAJ Bug: 1091379, 1089531 Change-Id: I71134b54c6455b366fdb3f65541a69499ea893e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231518Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#776559}
-
spdonghao authored
Bug: 1086961 Change-Id: If811181513eced84a7c92960520a5f8e5f398398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218849 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776558}
-
Jeffrey Cohen authored
Bug: 1083851 Change-Id: I569c5dc14de4d6590cbd96901ecae7b505dbdec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236248Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e95a3d28. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" b2436c3b "Ensure cloning a template element into an inactive document does not crash." 027aefc6 "OPTION element: Update OPTION label even if it has invalid markup" d29069f3 "Fix issues with declarative shadow dom <template> during parsing" 0776aa6d "Mark pointerevent_pointermove_in_pointerlock test non flaky" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Id25666c68e846253b2432891a6ee235dde7cc0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237647Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776556}
-
Mikhail Khokhlov authored
It turns out different devices have different limits for power rails counters, so we can't compute the exact drain value if we don't know the device. This CL replaces the exact value with an estimation in that case. Change-Id: I8b4f1f63a6b9716a119f5f0a8f001c7801e10eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236480Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#776555}
-
Xida Chen authored
TBR=treib@chromium.org NOTRY=true Bug: 1092924 Change-Id: If9da60f70fc19954493a6ae6bfe082644fe556a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237721Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776554}
-
Gavin Williams authored
These strings will show on Chrome OS Print Preview when the currently selected printer is in an error state. Bug: 1059607 Change-Id: Id87e35170b044d77809d6494e2e0b713d78c1dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228351 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#776553}
-
Andrew Xu authored
When hotseat enters extended mode from home launcher mode, hotseat's bounds undergo the following changes: (1) The origin of the hotseat bounds moves to left. (2) The hotseat bounds become wider. Meanwhile, the hotseat background's origin is related to hotseat bounds. Denote the background origin by |background_origin|; denote the hotseat bounds by |bounds_rect|. Then background_origin|.x is calculated roughly by the equation below: (1) |padding_inset| := (|bounds_rect|.width - space_taken_by_icons) / 2 (2) |background_origin|.x := padding_inset + |bounds_rect|.x |bounds_rect|.x becomes smaller while |padding_inset| becomes bigger. It is the reason why the hotseat bounds move back and forth. In this CL, the custom layer element is created for the transition between home launcher mode and extended mode. It ensures that the hotseat background varies linearly in screen coordinates. Bug: 1042911 Change-Id: Id91ce3ecf2bbee8509a3f794c6e943c6bf1d6ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225590 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776552}
-
Marc Treib authored
It's flaky (on both Win and Linux) TBR=wjmaclean@chromium.org Bug: 1092915 Change-Id: Ifaa41d2f19198a8d5fd05887a3f500acde15689f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237927Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#776551}
-
Becca Hughes authored
Remove associated origins as this is something we no longer need for launch. BUG=1091776 Change-Id: Iedadedc600948e8ae61fb088ff8b5e0824d8f661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232752Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#776550}
-
Joe Mason authored
R=siggi Bug: 1080672 Change-Id: I90a199b1133f10354ba444e2256069fa04ca4161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237708Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#776549}
-
Jorge Lucangeli Obes authored
The histogram was added in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2230224 BUG=1091286 TEST=validate_format, pretty_print. Change-Id: Ibd651812a608c7154eb997157b6c3465bc20f91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237707 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
-
Charlie Hu authored
Previously, oversized-images is migrated from feature policy to document policy in https://chromium-review.googlesource.com/c/chromium/src/+/2058702, but there are still expectation files and links to feature-policy-oversized-images-*. This CL cleans up those obsolete files and links. Change-Id: Ifd80e5ad59fa787164062a941f306c5149db3f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228360Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#776547}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a48dd43fe185..dffa944e0725 2020-06-09 tommi@webrtc.org Reland "Remove dead code from ModuleRtpRtcpImpl2" 2020-06-09 tommi@webrtc.org Deprecate a few unused methods in RtpRtcpInterface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2668c89f08ba5c1e6c89d2721842dfb393e05f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237205Reviewed-by:
-
Aaron Krajeski authored
Bug: 1091267 Change-Id: Ibe58b5778860d91d3181ded85024f27271d4a0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236040Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#776545}
-
Jeff Yoon authored
Migrate base::Bind calls in ios/components to base::BindOnce or base::BindRepeating as part of code health improvements Bug: 1007793 Change-Id: Ib25fed1c909c8d72628214a55bbd2d6213d42d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236281Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#776544}
-
Miguel Casas authored
This CL is a refry of crrev.com/c/2072621, where only the HDR DisplayColorSpaces are filled in and the SDR ones are skipped and left for a later CL. The original landed-and-reverted CL is kept in PS0 to ease review. Bug: 958166, b:158126931 Original CL description ----------------------------------------------- This CL adds code for populating the necessary gfx::DisplayColorSpaces in CreateManagedDisplayInfo for supporting SDR and HDR target color spaces (depending on the monitor capabilities and the big hdr flag). It needs a sibling CL to allow AR/B30 FBs on CrOs crrev.com/c/2078655, Tested with that CL and by playing an HDR video: the primary framebuffer format in /sys/kernel/debug/dri/0//state correctly changes to XB30, whereas when there are not HDR quads in the BufferQueue, it's XR24. Bug: 958166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072621Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#745461} Change-Id: I2700d4d22a6b7e3a91433e6ca5bd042760cf165b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235977 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
Matt Menke authored
SpdySession::CanPool() checks CertificateTransparency state, so in order to double-key the Expect-CT database, we need to pass the NetworkIsolationKey through CanPool() down to TransportSecurityState::CheckCTRequirements(). BUG: 969893 Change-Id: I612be66f8a530d01edd14b6286617e20a6b28f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212702Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776542}
-
Marc Treib authored
They're all very flaky. TBR=dschuff@chromium.org Bug: 1003259 Change-Id: Ibf8bd420fd9948ff1a0872df1778958c39759361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236143Reviewed-by:
-
Charlie Hu authored
Change-Id: Id82847e8f54f740cbc4cdbd9bf34000262882f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229208Reviewed-by:
-
Xida Chen authored
TBR=treib@chromium.org NOTRY=true Bug: 1092924 Change-Id: Iea95759a9cb37b9a11c76f5bfb2fb1763c6a7507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238008Reviewed-by:
-
Koji Ishii authored
This patch fixes: ObjectPaintInvalidatorTest.TraverseFloatUnderCompositedInline ObjectPaintInvalidatorTest.TraverseStackedFloatUnderCompositedInline when FragmentItem is enabled. Bug: 982194 Change-Id: I7857d063711669ac3f3a5b66ba1e114cc3db8f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237430 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776538}
-
Alexander Timin authored
Now DedicatedWorkerHost interface doesn't have any methods and this patch removes it. This patch can be easily reverted if the need for DedicatedWorkerHost interface appears again. TBR=haraken@chromium.org R=nasko@chromium.org BUG=1018601 Change-Id: Ia572e086aab3445cd96f5bac5b0cb89186b06ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203207Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776537}
-
Chris Fredrickson authored
This reverts commit 5bf5f652. Reason for revert: This cl caused a perf regression in the rendering.mobile and blink_perf.canvas benchmarks. Bug: 1092434,1087234,973801 Original change's description: > Include image data when reporting UKM from canvas readbacks. > > This is a reland of https://crrev.com/c/2207979, but which takes extra steps to avoid performance regressions. In particular: > * No additional overhead is incurred if the user is not in the identifiability study. > * The overhead of constructing the pixmap is posted to another thread, rather than holding up the current thread. > > Bug: 973801,1087234 > Change-Id: I7701c622e4d146504b1ea57d0f2047aa2a98ed9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224820 > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Cr-Commit-Position: refs/heads/master@{#775558} TBR=fserb@chromium.org,asanka@chromium.org,cfredric@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973801, 1087234 Change-Id: I5bc8452692562f8b82af0c3b0903327b86744cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236336Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. Note that an explicit conversion to WebMediaStreamTrack is added because the call crosses the Blink API boundary. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I342bd8d36dafeda513d339a3380c7076c2e406a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236276Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#776535}
-
Mason Freed authored
Prior to this CL, these errors were just logged to stdout; now they are proper console errors. Needed to add a non-WPT layout test here because there is no way to test console messages in WPT. Fixed: 1067488 Change-Id: I4c46c64dbc80449338c699490e1ab0dda32cd833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231918 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#776534}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. CL also, moves the file from renderer/platform/exported/mediastream/ to renderer/platform/mediastream/. BUG=704136 R=guidou@chromium.org Change-Id: I3626117d3945f043049aa8a3bc8dc36c8d8f9519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236014Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#776533}
-
adamta authored
Adds the Discover feed coming from the Discover provider to the NTP ContentSuggestions collection view. The feed is shown based on the feature flag, as well as the "Article Suggestions" setting in the settings menu. Will replace the Zine feed if the flag is active. Bug: 1085419 Change-Id: Iad9e94af68ad74e2d9028152cf696c7cb69d733e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230765Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#776532}
-
Bartek Nowierski authored
The hint points to a bit in the bitmap before which we know for sure all bits are 1s, so no need to scan those. Bug: 1086388 Change-Id: If1ff5dfb7a8faa2fd47937e44bb811af67bda7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230149 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776531}
-
Gavin Williams authored
This test was originally named ReasonFromPrinterStatus because the first version of this was testing the actual printer status enum codes, not the colors. Bug: 1059607 Change-Id: I953fa6ece3ad5bba8c6f515ebd05d0bc56d2df34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234547Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5fef85222ed..2a9754b30e90 2020-06-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1b37ea9126ea20d6551bfa08a08f911b4eabe3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237204Reviewed-by:
-
Shengfa Lin authored
This reverts commit 68c28c5c. Reason for revert: Test flakiness Original change's description: > [chromium] Re-enable testGetSessions > > Retried locally on Mac and Linux, the test seems fine. > > Bug: chromium:899919 > Change-Id: I48d50f2f25a7111d4713b1b826eca36893e03289 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236886 > Auto-Submit: Shengfa Lin <shengfa@google.com> > Commit-Queue: Shengfa Lin <shengfa@google.com> > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776318} TBR=johnchen@chromium.org,shengfa@google.com Change-Id: Idcfbd0cbf2f46210e4c81752c693fccab5dbdecc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:899919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237648 Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776528}
-
Tobias Sargeant authored
* Add comment to C++ enum indicating persitence in UMA * kCount -> kMaxValue, per UMA guidelines. * Remove lock and DCHECK that RecordMetrics is called on the UI thread. * Fix enums.xml, which listed enum values in the wrong order. Bug: 1083005 Change-Id: I4faf67d5614358d19e93df69128bba0fa68b561b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236136Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#776527}
-
Alex Rudenko authored
Disabling CL: https://chromium-review.googlesource.com/c/chromium/src/+/2235718 DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236400 Bug: 946975 Change-Id: Ib0b84bda186ed009b36f587ecfd540f2310e61bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236138 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#776526}
-
Xiaocheng Hu authored
The histogram is not under active monitoring, and we didn't receive any related alerts in ~20 milestones. Hence, this CL deprecates it. Bug: 1089650 Change-Id: If86e90c52095ab27ed419e6c618888733560d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236230Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
