- 03 Dec, 2020 40 commits
-
-
Robert Sesek authored
Bug: 1153883 Change-Id: I905596a4373b1381a1c882d65b83520d657b8246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565654Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833272}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/615ae5f5..9421b815 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6f0a21e32c18eb5dc43e95a17f108bdce78bf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571057Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833271}
-
Ehimare Okoyomon authored
After speaking with UX for both teams, it was decided that it would be best to only use one location icon for both page info / site settings and keyboard accessory. Change-Id: I74af67df53da05f358b8daa735d9bb5363c43982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566951Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#833270}
-
Oriol Brufau authored
This provides the expected behavior for caret browsing when there is shadow DOM. Bug: 1116663 Test: SelectionModifierTest.MoveCaretWithShadow Change-Id: I11fc7dac6aa8cbfc0d2ebba958b4e57807845414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485262 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833269}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c40073b687da..091617dda85b 2020-12-03 nisse@webrtc.org Change TestStunServer::Create to take a SocketServer rather than a thread as argument. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f26708f3a0b1fbf2e932a9b5d3409d6fe0e68c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833268}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45552c0f29d..9d937e6cbed6 2020-12-03 fmayer@google.com Merge "Ensure client sends /proc/<PID>/{mem,maps}." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I925b9665c71076692880f7e30cb7d761be466ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571177Reviewed-by:
-
sandromaggi authored
When navigating to a Google property, shutdown immediately (which destroys UI), without showing an error first. Bug: b/173986107 Change-Id: I0cd31a2d45d96410066bcc44c7873dae7ce54fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566964Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#833266}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6544c663aa7e..bdf70c39ad5a 2020-12-03 tvanderlippe@chromium.org Cleanup empty JSDoc comment 2020-12-03 tvanderlippe@chromium.org Cleanup devtools_module_entrypoints.gni 2020-12-03 jacktfranklin@chromium.org [Dark mode] disable patching for sourcesPanel.css 2020-12-03 jacktfranklin@chromium.org Load themeColors.css in karma unit tests 2020-12-03 jacktfranklin@chromium.org Enforce readonly string[] over ReadonlyArray<string> 2020-12-03 jacktfranklin@chromium.org Enable interaction tests 2020-12-03 wolfi@chromium.org [DarkMode] indexedDBViews.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1152736,chromium:1153281 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I386c4d810a9d9bf220a02ecfb0f7662fd3211502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571175Reviewed-by:
-
Marc Treib authored
Trivial cleanups: - Rename StartNextAssociation to RecordConfigurationStats (that's all it does now after previous cleanups; "association" doesn't exist anymore with USS). - Rename the existing RecordConfigurationStats to RecordConfigurationStatsImpl. - Update a bunch of comments to not refer to "association". - Remove download_started_ which was only used in a DCHECK. Bug: 1102837 Change-Id: I81c2b6fd485afe968b78d6e4007e925e30bc9dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567926 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833264}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/062280eeaa96..35dd9a4faaff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC antoniosartori@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: antoniosartori@google.com Change-Id: Ifeba502044510aaa9b84d0bff8ed3be17f8bdf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571171Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833263}
-
Maksim Moskvitin authored
The test was disabled for a long time. Let's try to re-enable it to see if still flaky. Bug: 1028968 Change-Id: Iee93b57cb6941ecb386751856136bf8deea0a5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568283 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Rushan Suleymanov <rushans@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#833262}
-
rbpotter authored
OS settings, bluetooth_pairing_dialog, nearby_internals, and profile_picker Change-Id: Iebddd6ee26b6e88a1b8fa047047ff7fd4a71a72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568442 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#833261}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606953494-c677054002543491cd062484a79764b665817c55.profdata to chrome-win64-master-1606964048-45fff1aeb7e9c3fd35f310aad8ee0c61f812a3a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11ba9998bcd2ba3d841aa15b55ad04663a679eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571051Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3668d352bc5f..5d8a07143377 2020-12-03 cwallez@chromium.org Suppress all end2end tests on Intel D3D12 with validation layers 2020-12-03 bryan.bernhart@intel.com Fix WindowsDebugLogger hang on release builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic88f64f4f9976a0e16f6bcbf0c57899a86f748af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570404Reviewed-by:
-
Rakina Zata Amni authored
Ensures we won't buffer too much data while deferred, and only defer for bfcache purposes. The max number of bytes is determined by the "max_buffered_bytes" param of kLoadingTasksUnfreezable, defaulting to 100000 bytes. Bug: 1147081, 1137682 Change-Id: I0c2f30024b3c3ddef34efb0a841050389f1238ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539215Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#833258}
-
Jan Wilken Dörrie authored
This change fixes several clang-tidy warnings in the password manager component. Bug: None Change-Id: I7c4b8ee0772082812bf0c2a54ac0608ed88599ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569743Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2c039921..615ae5f5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I04fb14df5e121a78e59472b9789b0fd077f113fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570864Reviewed-by:
-
Antonio Sartori authored
This reverts commit d2746236. Reason for revert: Causes "gclient runhooks" failure on "Cast Android (dbg)" (running 'vpython src/chrome/test/data/android/manage_render_test_goldens.py download' fails with "No such file or directory: '/b/s/w/ir/cache/builder/src/components/test/data/payments/render_tests'") Original change's description: > Remove unused */render_tests/*.sha1 > > The associated render tests now use an online platform to check for the > expected image (https://chrome-gold.skia.org/). All these hashed images > are doing in the repository is confusing developers who are new to > render tests, so let's remove them. > > Bug: 1103836 > Change-Id: Iaa541f22e6ba9002fadaae99b99d9003e4b7f5c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566796 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833249} TBR=bsheedy@chromium.org,triploblastic@chromium.org,victorvianna@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3bfbf3716718105c70c1d407e097d925244a0fb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567166Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#833255}
-
Side Yilmaz authored
This CL removes TODOs from CookiesFetcherUtil and CookieControlsServiceBridge classes. also adds comments. The current code works correct, even after Incognito CCT and non primary OTR profiles are introduced. - Since CookieControlsServiceBridge class is only for the incognito NTP and Incognito CCTs do not have an NTP, no need to pass non primary OTR profiles to CookieControlsServiceBridge. - Since |CookiesFetcherUtil#GetCookieServiceClient| is responsible of restoring session from cookies and Incognito CCTs do not support restoration, no need to change logic on CookiesFetcherUtil class as well. Bug: 1060940 Change-Id: I6d8ed6bdc8f52ce348b2dfbb57678151aa43e53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563551Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833254}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/093915377ad7..6544c663aa7e 2020-12-03 bmeurer@chromium.org [debugger] Don't load sources from stale raw modules. 2020-12-03 jacktfranklin@chromium.org [DataGrid] add dark mode colors 2020-12-03 jacktfranklin@chromium.org Ban underscored methods and properties in TS files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1155067 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If743c284791703197f11f9aefd9271ab4b3dae7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570403Reviewed-by:
-
Rakina Zata Amni authored
Introduces DidCommitSameDocumentNavigationParams, which currently only contains one field: is_history_api_navigation, to distinguish history API vs fragment change same-document navigations. This is needed to determine the "method" value for same-document navigations - the history API would override the method to "GET", while fragment navigations will reuse the method from the last navigation (for more details, see DocumentLoader::UpdateForSameDocumentNavigation). This CL also fixes code that either assumed all same-document navigations use GET (NavigationRequest::CreateForCommit), or all same-document navigations reuse last navigation's method (RenderFrameHostImpl::DidCommitNewDocument). See same-document navigation refactor doc: https: //docs.google.com/document/d/1a2rBxTR5vN6WD-LfJrF0FdEzMmFn_WVgeUS4I9z041k/edit?usp=sharing Bug: 1133115, 1131832 Change-Id: I85c5ab6b7ac75597a459a1faf9845000551e2314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556732 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833252}
-
Colin Blundell authored
This is a straightforward wrapper around //content's NavigationHandler#isExternalProtocol(), with the naming and semantics reversed to aid in clarity for external embedders. Bug: 1145983 Change-Id: Ie3c61e4436e4de1f5ff99c20a0435c19504b02e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554574 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#833251}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6e7167456b5e..c40073b687da 2020-12-03 philipp.hancke@googlemail.com doc: chrome://media-internals is useful for camera issues 2020-12-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a3682304..20fa2e0b (833048:833170) 2020-12-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6b50907e..a3682304 (832826:833048) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I293b4fabc5086dd8ebe0b40578f3a567ad453606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570402Reviewed-by:
-
Victor Hugo Vianna Silva authored
The associated render tests now use an online platform to check for the expected image (https://chrome-gold.skia.org/). All these hashed images are doing in the repository is confusing developers who are new to render tests, so let's remove them. Bug: 1103836 Change-Id: Iaa541f22e6ba9002fadaae99b99d9003e4b7f5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566796 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e7d45601101..062280eeaa96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC antoniosartori@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: antoniosartori@google.com Change-Id: I52fd90d214e0f190e9ae98b5d01100588072dd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570957Reviewed-by:
-
Ivan Šandrk authored
That bug was fixed a long time ago https://github.com/Microsoft/vscode/issues/35901 TBR=isandrk@chromium.org Change-Id: I00131047782889786137dacb8f1f1b156453386b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571115Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Auto-Submit: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833247}
-
Tim Volodine authored
MediaDevices.getDisplayMedia is not exposed on Android WebView. Update the not-webview-exposed.txt file and re- enable tests. BUG=1144241 Change-Id: Ic6167b0fa6ace6f9573306a773b52efa99d5b427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567162Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#833246}
-
Egor Pasko authored
=== API The current ModernLinker loading primitives look like: LoadLibraryCreateRelros(path, loadAddress, libInfo); LoadLibraryUseRelros(path, loadAddress, fd); This change replaces them with: LoadLibrary(path, loadAddress, libInfo, boolean spawnRelroRegion); UseRelros(libInfo); The UseRelros() can be called *while* the library code is running, atomically replacing the RELRO region with its version backed by shared memory, if all stars align. === Motivation The main motivation is to allow the App Zygote to provide the RELRO region on systems with App Zygote enabled, and use the usual mechanism when App Zygote is not available. === Implementation highlights With this change the ModernLinker still waits for mLibInfo to arrive from the browser process, as usual, but RELRO sharing already happens after the library is loaded. I believe, there is no code path to replace concurrently with execution. Semantically there are a few notable changes: 1. When spawned, the RELRO FD is sealed as PROT_READ, making it impossible to make it writable ever again even by privileged processes. This way we should not worry where the code runs, in the Browser process or in the App Zygote. 2. Library load ranges are explicitly including the range of PT_GNU_RELRO segment. It should not affect anything now, but can potentially eliminate hard to debug crashes in distant future. The main changes are in modern_linker_jni.cc where 'class NativeLibInfo' is introduced to hold basically the same information as the Java-side LibInfo, with the ability to perform the primitives described above, and import/export internally between Java-LibInfo and NativeLibInfo. Retrospectively the move into the class does *not* provide much useful encapsulation at the moment, but seems like a good direction if we later decide to use it for LegacyLinker, mock out parts for testing. The most part I dislike most is that the class behaves like two independent parts (LoadInfo and RelroInfo), some operations affect one, but not the other. I did not attempt to make the split, as things are still a bit coupled sometimes, maybe later. OK, this was long. Bug: 1154224 Change-Id: I88af048a298310b56b3205a2b2dd765e2c69759a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560308Reviewed-by:Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833245}
-
Nohemi Fernandez authored
Bug: 1131027 Change-Id: I66fb4bd7e41798cca4f693b8dff01167462dc673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568277Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#833244}
-
David Roger authored
The profile customization UI displays the (unconsented) primary account information. However, if the account is not present in cookies, there is no primary account in Chrome. In this case, the UI displays a placeholder account without badge. There is logic to update the account image when it becomes available, but there was no logic to update the badge. This CL changes the "isManaged" bit to be dynamic instead of static, and updates it when the primary account information changes. Fixed: 1153307 Change-Id: Idb91d874d269078751f50ccbf4044a076ffc815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568285 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833243}
-
Stepan Khapugin authored
Adds the blocking UI to the BVC. This required a move of the protocol registration to the BVWrangler. Bug: none Change-Id: I81d0a868989eee7fea7e8a5d53b03c380e42ee15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547700Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833242}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae504d46b4c4..a45552c0f29d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If6f02f8c952a4be402811346e18975db2a58db88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570863Reviewed-by:
-
Alexander Hendrich authored
This CL removes the kLoginScreenExtensions pref and instead maps the DeviceLoginScreenExtensions policy into the user policy ExtensionInstallForcelist (pref=kExtensionInstallForcelist) for the sign-in profile. This is done with the canonical LoginProfilePolicyProvider, which is also used for similar device policies that should be applied to the sign-in profile. This serves two purposes: 1) Unclutter extension install force-list prefs (see crbug.com/1151389) 2) Preparation to remove feeding device policies into user profiles (see crbug.com/1151940) Force-installed extensions on the login screen are still treated differently compared to force-installed in-session extensions based on the ExternalProviders used for the sign-in profile (see SigninScreenExtensionsExternalLoader usage in external_provider_impl.cc). Bug: 1151389, 1151940 Change-Id: I7b1112a36e9796adc4eeba611f628c25bc7350f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561847Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#833240}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4be156e9f6d..093915377ad7 2020-12-03 alexrudenko@chromium.org Revert "[e2e]: Stabilizing Font Editor e2e test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154489 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2c1ab98dbdc9f5e6c96ca3782223a3115a3746cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570028Reviewed-by:
-
Nektarios Paisios authored
Not all accessibility trees support ignored nodes. Hence, this patch ensures that comments in AXPlatformNodeDelegate that refer to ignored nodes clarify that they only apply for accessibility trees that support them. AX-Relnotes: n/a. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I715284ba966b2b35b2f9f0c5f76069b320cb063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570319 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#833238}
-
Corentin Wallez authored
This was forgetten when WebGPU was initially enabled on Linux. Bug: chromium:976495 Change-Id: I569436e5bb33bc17e52883490e7642596b4431b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566764 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#833237}
-
David Roger authored
A spinner has been added to the bubble, which makes the user experience much better while waiting. As a result, we can increase the timeout to allow cookies being injected correctly on the web. This change will also allow collecting more data about the actual time needed for the interception: with the current timeout, around 50% of the users are not able to complete the operation, which prevents even measuring any performance data or seeing any progress. Having a more reasonable timeout allowing most users to succeed will make it easier to track and measure the improvements. Bug: 1151313 Change-Id: Ia020bfcb5d36f06251abb26ac951ff9bc8ce7443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566946 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Ionel Popescu authored
This CL adds the missing dark mode background color for video/audio popup menus. The popup menus are: internal-media-controls-overflow-menu-list and internal-media-controls-text-track-list. The white flash was caused by their white background being visible until it was covered by the items that have the correct dark mode background color. Bug: 1148578 Change-Id: Ifa148ea039ecb3a3dca448adb9f3fda62225dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565072Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833235}
-
Alan Cutter authored
This reverts commit 9bdd1b02. Reason for revert: ../../chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc:164: Failure Expected equality of these values: kNumApps + kNumDefaultApps Which is: 8 service->GetNumSyncItemsForTest() Which is: 15 This test failure is fixed by a different revert: https://chromium-review.googlesource.com/c/chromium/src/+/2568995 This CL does not introduce any new app installations on start up to cause the app count to change. Original change's description: > Revert "Fix default web apps not appearing in app list/management/search on Chrome OS" > > This reverts commit 090a7e86. > > Reason for revert: Suspected it introduced sync_integration_tests failure in SingleClientAppListSyncTestWithVerifier.AppListSomeApps, see https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10364/overview > > Original change's description: > > Fix default web apps not appearing in app list/management/search on Chrome OS > > > > This CL updates Chrome OS default web apps to be deployed to Chrome OS's > > app surfaces (app list, app search and app management) while maintaining > > the "do not deploy to OS" logic for non-Chrome OS. > > > > This CL upstreams the "do not deploy to OS" logic in > > GetPreinstalledWebApps() up to > > ExternalWebAppManager::PostProcessConfigs() where it can apply to all > > preinstalled web app configs uniformally. > > > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478376&signed_aid=ic4Nc7r-RtFyMKtH3FYXtA==&inline=1 > > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478378&signed_aid=VMFIAzHdQv62wv7H0Cvz7Q==&inline=1 > > > > Bug: 1153233 > > Change-Id: Idcbb0d15fc8d3f333d1d59e27b8ff624fe7b1c64 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562625 > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#832686} > > TBR=alancutter@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org > > Change-Id: I291b2c2bb25ceb9a244382c4cee7ff190c36a493 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1153233 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566769 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832739} TBR=alancutter@chromium.org,olka@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1153233 Change-Id: I9154508d3884fa9296369d8d3976196f19c8d279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569497Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833234}
-
Patrick Brosset authored
DevTools wants to be able to display the baseline when items are aligned on it. So this change adds the offset information to the output that's already sent to the overlay frontend. Note that the item's margin is also added to the baseline's offset because the frontend only knows about item's margin boxes, so it needs an offset that's relative to that. This CL changes the format of the data sent to the frontend, so to avoid breakages if this change landed before the corresponding frontend CL, I will make sure to land the frontend first, with compatibility code for both formats. Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567355/ Bug: 1139949 Change-Id: I8c922cd07265b9dee3edc43330210cf935bd06fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567643 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833233}
-
