- 17 Nov, 2020 40 commits
-
-
Maggie Chen authored
Move GPU.SupportsDX12 and GPU.D3D12FeatureLevel from the GPU process to the browser process. These two histograms are lost when they are recorded in the info-collection GPU process. They are not allocated in the persistent histogram memory and the GPU process is terminated right after the histogram data is written. To preserve the data, we now record the histograms in the browser process. Bug: 775983, 1149617 Change-Id: Ia31195cfe5cc9a6ac86de830b53046285a49843e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542364Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828030}
-
Piotr Bialecki authored
Adjust namespaces of the already-moved classes, as well as move the class that was still left behind. Bug: 843374 Change-Id: I0d53115cb883450bd250ecdb6d74b6c2b68f6455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535215Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#828029}
-
Thomas Guilbert authored
debugger-inline-values-frames.js and reveal-execution-line.js are flaking across different bots. TBR: tasak@google.com Bug: 1149734 Change-Id: I17eda8a8f475aa98532771b122ef5d590a84c02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543085Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#828028}
-
Bartek Nowierski authored
While investigating a perf regression bug, I tried this CL and it looks it improved 1~1.5% on a couple scenarios, so might be worth taking. https://pinpoint-dot-chromeperf.appspot.com/job/117de375520000 Drive by: change a nearby DCHECK_LE to PA_DCHECK while at it. Change-Id: I048898938286c3347aeaf6c5672a1bb79bc90b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539221 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828027}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I0f4b9bbe80cccc936fb3caba46acd2b88fba511a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828026}
-
Dale Curtis authored
This always uses the unaccelerated path right now, if we find these cases are common, we will need to improve VideoFrameYUVConverter so the hardware based conversion process works. Note: This inlines the preferAcceleratedImageBitmap() function to make it more clear when the accelerated path is preferred. R=sandersd Bug: 1148800 Change-Id: I8f669ade90d9f4133ffe15a63c8c47d22a1dc286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542671 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828025}
-
Ravjit Singh Uppal authored
Added the option to switch to one time permission grant for Geolocations from the Page Info UI Bug: 1148335 Change-Id: I2b5f1c3d84138391c790d89c4db55ae21468e489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530009 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#828024}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e3efb253. With Chromium commits locally applied on WPT: cfe2227f "content-visibility: Rename tentnative test to non-tentative." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I552f8682ebb9246fb5e6e4d31c4c35eaa316f259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542609Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828023}
-
Ben Joyce authored
Collect the outputs and print it out as it would be if not ran in parallel. Bug: 1138506 Change-Id: I92a3e098f7ef4a02bfcf51d948810db91bf7d0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535668Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#828022}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da73999f798a..d4e6fb6573e0 2020-11-17 ehmaldonado@google.com [owners] Implement GetChangeApprovalStatus for Depot Tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I4f32bc0f5596d1fcece641ec20c46562d5fc1ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828021}
-
Kyle Horimoto authored
This CL removes the ConnectionStatus::kWaitingForConnectionInitiation enum value. In practice, we always get the OnConnectionInitiated() callback before the RequestConnection() callback is invoked, so this state should not exist. Bug: 1148152, 1106937 Change-Id: Ie659a875ae3a32ec62aa991398331617b2c33d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542573 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#828020}
-
Liquan (Max) Gu authored
Before the CL, the error handling logic lives in CPRService#showAppSelector(). After the CL, CPRService#showAppSelector() returns the error to PRService, and PRService handles the error. Bug: 1148902 Change-Id: I992b449eb5d406db6c110ce9d300c6b68afd5528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536996Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#828019}
-
evliu authored
This CL renames the "Live Captions" flag to "Live Caption". Bug: 1148994 Change-Id: I133513bd6912e9a5f9adb4023533546ef0c382a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538268Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Evan Liu <evliu@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#828018}
-
Pavol Marko authored
Instead of using string constants, introduce an enum for the selected nameservers type. This is less error prone and easier to read. Bug: 1108922 Change-Id: I05cc167f42467af8a6b78cb688b8239e8a896c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537678 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828017}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e551b3ce67d..04515da400d5 2020-11-16 srisser@google.com Don't auto append value of stringified enums If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If382c85f0b769fce5fae16b63bba80fa510b4430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828016}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making Permissions a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.permissions getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I45b857df7864ba50f38ebebd2afe358ae759914a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538056 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#828015}
-
Alfonso Garza authored
Two main changes to address flakiness: 1. Scroll to nickname before changing it. 2. Use grey_replaceText as recommended by EG. Evolved from previous CL https://chromium-review.googlesource.com/c/chromium/src/+/2380145 Fixed: 1106766, 1108809 Change-Id: I0acfc0980b95bc657d545c43d1a7e15410485747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493423 Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#828014}
-
Jeroen Dhollander authored
I tried compiling ChromeOS on a fresh installed gLinux and it failed: ACTION //chrome/browser/chromeos:device_policy_remover_generate(//build/toolchain/linux:clang_x64) FAILED: gen/chrome/browser/chromeos/device_policy_remover.cc python ../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py gen/chrome/browser/chromeos/device_policy_remover.cc ../../third_party/protobuf/python pyproto pyproto/components/policy/proto Traceback (most recent call last): File "../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py", line 63, in <module> sys.exit(main()) File "../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py", line 31, in main from chrome_device_policy_pb2 import ChromeDeviceSettingsProto File "pyproto/components/policy/proto/chrome_device_policy_pb2.py", line 7, in <module> from google.protobuf import descriptor as _descriptor File "../../third_party/protobuf/python/google/protobuf/descriptor.py", line 38, in <module> import six ImportError: No module named six This is not easy to work around as it requires pip for Python2 which is no longer available in apt, so I tried running the script in Python3 and that seemed to work. Bug: crbug.com/1112471 Test: compiled Change-Id: I777c7a1c4562eec500ea487f48f0337b51735010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542063Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828013}
-
Reilly Grant authored
Based on crash reports it appears possible for open() to return null without throwing an exception. getCameraParameters() handles this case gracefully by returning null but isZoomSupported() will then try to call release() on the null Camera. The release() call is unecessary because getCameraParameters() already releases the Camera on error. Bug: 1149283 Change-Id: I1a5522fa3179f3b6389e5dff83a0ca379f9f44ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542785 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828012}
-
James Cook authored
Chrome OS hides many paths from the user. Users can only browse to MyFiles, certain Android paths, and a selected set of mount points. For security-in-depth, Chrome OS restricts download paths to those directories and their subdirectories. Many of the path utilities functions used to check for these directories have ash dependencies that cannot be included in the lacros build. For now, restrict lacros downloads to the default Downloads directory and its subdirectories. We can revisit this as part of the Files work planned for early next year. Bug: 1148848 Test: expanded unit_tests coverage for lacros Change-Id: Ia7c41350dcfc29299579f9e7ecd4078e1eb00505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541124Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828011}
-
Takashi Sakamoto authored
This reverts commit 4f35dbaf. Reason for revert: Suspect causing chromedriver_py_tests failures on (none) GPU on Mac: - main.MobileEmulationCapabilityTest.testNetworkConnectionDisabledByDefault - main.ChromeDriverTestLegacy.testMobileEmulationDisabledByDefault - main.ChromeDriverTest.testActionsMouseDrag - main.ChromeDriverTestLegacy.testMouseDoubleClick ...215 more failure(s) (219 total)... First build failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/61407 Sample log: --- testWifiAndAirplaneModeEmulation (__main__.MobileEmulationCapabilityTest) ... ERROR testConnectToRemoteBrowser (__main__.RemoteBrowserTest) ... application requires at least Mac OS X version 10.11.0 (10.11.0), but is being run on 10.10.5 ( 10.10.5/14F2511), and so is exiting.Received signal 6 --- Original change's description: > mac: Update LSMinimumSystemVersion from 10.10 to 10.11 > > Bug: 1148931 > Change-Id: Ic0cdded0c1c4821689486cacd5790fce82c40c87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537057 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827937} TBR=avi@chromium.org,rsesek@chromium.org Change-Id: If527cdb6ffdde2807b2c9a2315316a8ae5699e24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542934Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828010}
-
Austin Sullivan authored
- This CL contains no behavioral changes - NFSManager stores flat_set of NFSWriterImpls rather than a UniqueReceiverSet of blink::mojom::NFSWriters - FileWriter destroys itself via disconnect handler - Opens the door for autoClose flag as described here: https://github.com/WICG/file-system-access/issues/236 Bug: 1135687 Change-Id: Icbc7375174ee2d48dca481d6490d5eddc282ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523653 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828009}
-
mlcui authored
Googlers: a screenshot of the new sub-labels can be found here: http://screen/345FdDordriQRcu Fixed: 1146366 Test: Manual test Change-Id: I49ca8a731b7ef1d63d794368ff27b355298e382d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525463Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Michael Cui <mlcui@google.com> Cr-Commit-Position: refs/heads/master@{#828008}
-
Patrick Monette authored
Bug: 971272 Change-Id: Ie8ab8512d9fc00ca0111b3f3bed1fc779593cad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522195 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828007}
-
Chris Harrelson authored
It should be ok to let animation timings go stale for such documents. This has a significant performance impact in the presence of many lazy-loaded iframes. Bug: 1137931 Change-Id: I394ae63ea2c220b175fd7724ff915c2786046a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536811Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828006}
-
Hirokazu Honda authored
This fixes an issue that FlushDone() in VideoEncoderClient will never be called when the test runs with --disable_validator and the VideoEncodeAccelerator doesn't support Flush(). Bug: None Test: video_encode_acclerator_tests --disable_validator on trogdor Change-Id: I8701a971deaa4cacfcd55a2c708de437a79ad863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537507Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828005}
-
Gordon Seto authored
Add ESimManager bindings to OS Settings and create FakeESimManagerRemote to use as a mock for unit testing. Bug: 1093185 Change-Id: I03ab65d280f497ef9fac39bd1b48cef725083441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536113Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#828004}
-
Fergal Daly authored
This is some ugly but temporary debugging to log extra information when we find the the view has no main frame but the local root does. Bug: 1139104 Change-Id: I791fc7572a4a5a5abf3c7c689c4029e1696bbd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532535Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828003}
-
Eric Lawrence [MSFT] authored
Remove the unneeded feature declarations now that passive mixed content is autoupgraded by default. Bug: 1042877 Change-Id: I60ab635bc7f75527ca27f0657719b1ef42dbe7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540654Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#828002}
-
Nektarios Paisios authored
On some platforms a node is represented as an "object replacement character" in the text of its parent node. When calculating the parent AXPosition of a text position, we added special logic that adjusts the resulting position to be either before or after the object replacement character depending on the navigation operation. For example, if we are trying to find the start of line, we need to move to before the "object replacement character". Similarly, we need to adjust to after the replacement character if we are trying to find the end of the line. This adjustment is not necessary unless there is some ambiguity in the original position. Ambiguity only occurs when the original position is not at the start and not at the end of its anchor. Unfortunately this special logic was not applied to tree positions, and it was inconsistently applied to text positions at the end of their anchors, hence this patch. Also fixes a few bugs in the CompareTo, SlowCompareTo and AtStartOfAnchor methods that were found during testing: 1. AtStartOfAnchor was using text offsets for tree positions, even though they might not have been calculated yet because AsTextPosition() hadn't been called. 2. CompareTo was adjusting both text and tree positions that are inside embedded objects to after the embedded object character for comparison purposes, even though the comment in the code only talks about text positions. Also the adjustment was done manually by adding or subtracting 1, which is error prone. Now the comparason is done by SlowCompareTo. 3. CompareTo and SlowCompareTo were not properly comparing a tree and a text position that have the same anchor. 4. SlowCompareTo was not comparing a tree with a text position by converting the tree position to a text position. It was doing the opposite, thereby losing information in the process. 5. SlowCompareTo was not taking embedded objects and affinity into consideration when comparing two text positions that are not ancestors of one another. 6. SlowCompareTo was not normalizing tree positions to the start of their anchors before comparing them, thereby running the risk of comparing an "After children" or an "After text" position with an adjacent "before children" or "before text" position and erroniously finding them to be equal. Split out from a larger patch that merges AXNodePosition and BrowserAccessibilityPosition into one class: https://crrev.com/c/2327552 AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: Icedaebca48468c95bdbf1fc5c10393c4ace7dadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343031 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828001}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e371caae2fd..bee2bff5b0e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1136305,chromium:1146954 Tbr: tguilbert@google.com Change-Id: I2266e8827053512a614f66c0bb57ed372d95ce73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542647Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828000}
-
Charlene Yan authored
- Update tests to verify tabstrip is not larger than parent when growing - Add a test to ensure the grab handle space is always visible - Update new tab button always visible test to match this - Rename kTabStripWidth to kTabStripRegionViewWidth Bug: 1141674 Change-Id: I7fa527ed836c78ea9a3c1958715dc83ba7893a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536238Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827999}
-
Charlene Yan authored
When the browser window is large enough, the tabstrip should expand to accommodate tabs dragging past the last tab. This is a test for crrev.com/c/2472577 Bug: 1141674 Change-Id: Icfb4b0d6b9ebfa243a0e352b0cef68a2a6f2c263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537068Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827998}
-
dpapad authored
The helper is no longer used. Mocking chrome.send() calls is happening via the use of browser proxies in all newer WebUIs. Fixed: 1148403 Change-Id: I543ad1d36a0a92110182b4998380b3061c478f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537770 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827997}
-
Luciano Pacheco authored
This CL changes Audio Player background page to run as JS module. Bug: 1133186 Change-Id: Ib9657c09bcea95deb97e63d19bfdfac88644daeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537287Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#827996}
-
Brian Geffon authored
To prepare for adding new channel types (ie. fast posix channels) we will need a way to extend existing Mojo NodeChannel messages. Bug: b:173022729 Change-Id: I56b80ed58f28d058927d94ef9421319fe547c719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538166 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#827995}
-
Michael Checo authored
Screenshot: http://shortn/_AyCiiMx92w - Center cards - Adjust margin within cards - Adjust card width - Remove minimum height requirement from cards Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4c4f31182c7c835f6015b15af0f5a3aab64f489d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530744 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827994}
-
Matthias Körber authored
Rename variables containing the parsing patterns. Removes auto& statements in favor of explicit type declarations. Removes spurious comments. Change-Id: I9ca9523a5039952ab7de9dbeaa45f0baaa476d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535770 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#827993}
-
Matt Menard authored
Refactor print server components from CupsPrintersManager into its own class. Bug: b:168650771 Change-Id: If62b27ffde97257e9e0ac5b745ceecdd13721fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521226 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#827992}
-
Nina Satragno authored
CTAP 2.1 devices support the authenticatorSelection command to get a touch. Use authenticatorSelection instead of creating a dummy credential on those devices. Fixed: 1039426 Change-Id: I89420f1a181470fbbcce59a6ca0cdf3a44bd2ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535874 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#827991}
-