- 20 Aug, 2018 40 commits
-
-
stkhapugin@chromium.org authored
Makes the accelerator omnibox button in the bottom toolbar dismiss the find in page popup on press. Bug: 863002 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic293d90856a10d08c50edf8987c3eb4838c2c395 Reviewed-on: https://chromium-review.googlesource.com/1181046Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584425}
-
Friedrich Horschig authored
This test is very flaky for quite a while now. For details, check the linked bug. TBR=ramyan@chromium.org, sky@chromium.org Bug: 871010 Change-Id: I5d64a708f84d11a9b4981edc2cf53ad6b1a4151d Reviewed-on: https://chromium-review.googlesource.com/1181048Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584424}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b2cf82b09b..ee3986dc7034 git log c6b2cf82b09b..ee3986dc7034 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 primiano@google.com TraceProcessor: Add magic ts_lower_bound to sched table Created with: gclient setdep -r src/third_party/perfetto@ee3986dc7034 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia8d46f7c91cfdd9ed273ae4d0b17e3b042648a33 Reviewed-on: https://chromium-review.googlesource.com/1180859Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584423}
-
Lucas Furukawa Gadani authored
Change-Id: I667124ece0bf1d0d39b493f859a284f028550036 Reviewed-on: https://chromium-review.googlesource.com/1179963Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584422}
-
Danyao Wang authored
gCrWeb is not injected for placeholder URLs, so CRWJSWindowIDManager ends up repeatedly injecting window ID for NTPs, which interferes with injected JavaScript for the next web page. This fixes PaymentRequestMiscellaneousEGTest/testMultipleRequests. It was failing because the payment request messages were ignored due to mismatched window ID. Bug: 874637 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9a4f95d8f2f767c27a0c8dd953bb0d9914b6c0ed Reviewed-on: https://chromium-review.googlesource.com/1179221Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584421}
-
Friedrich Horschig authored
As described in the linked bug, these tests should rather marked failing than reverting the rollout, so doing this now. They are failing _quite_ consistently but pass from time to time. TBR=robertma@chromium.org Bug: 875622 Change-Id: I34defdcd7ccda264b04acaf0ca90601668d35f80 Reviewed-on: https://chromium-review.googlesource.com/1181044Reviewed-by:
-
Yi Su authored
add an extra boolean arg to API in ImageDataFetcher and IOSImageDataFetcherWrapper to control cookies usage in requests. Change-Id: I1142ecf3b595f8ee060d28985183d28e0cdef218 Reviewed-on: https://chromium-review.googlesource.com/1174831Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584419}
-
Peter Beverloo authored
The API hasn't been adopted by developers leading to practically zero usage. Given that there isn't a clear path to interoperability either, let's remove it. This has been approved per the following Intent to Remove on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/18r3whCBv0I The specification draft has been updated to mention its obsolescence: https://wicg.github.io/budget-api/ There are a few bits of browser-side budget-related code that are being used by push messaging. This CL also moves the relevant class (BudgetDatabase) to the push messaging directory, and updated it to maintain logic, while removing the dependency on the Mojo types. Bug: 873540, 874450 Change-Id: I98dcefe5b4333b969dd3c9bd4c09e9aaf9d65579 Reviewed-on: https://chromium-review.googlesource.com/1176083 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#584418}
-
Ramin Halavati authored
Profile preferences are removed from the persistent storage list for incognito mode. Since these preferences are not written from incognito mode, this change should not have any behavioral effect. Bug: 861722 Change-Id: I430d9ee9db15576d31c822483a088306df4099aa Reviewed-on: https://chromium-review.googlesource.com/1180218Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584417}
-
Gauthier Ambard authored
On iPad, the LongPress tip should use the the kTabStripTabSwitcherGuide instead of the kTabSwitcherGuide. Bug: 875760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3dce36249a9b766e79473506770dd8fe565a0c28 Reviewed-on: https://chromium-review.googlesource.com/1180968Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584416}
-
Sriram authored
The failure is very rare but there is one on the Mac build [1]. There is a possibility of playedTime being 0 in callPauseIfTimeIsReached() in video-played.js file which i believe is hitting in this case. [1]: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4724 BUG=874799 Change-Id: Iffe3ac49d20664eb9f824e2a1dd24aaa371dcbb2 Reviewed-on: https://chromium-review.googlesource.com/1181007Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#584415}
-
stkhapugin@chromium.org authored
Avoids resetting the scale when -resetTransform is called. Bug: 869379 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id649065208060cf1c3fbd4394947acad2f67cec3 Reviewed-on: https://chromium-review.googlesource.com/1180896Reviewed-by:
-
Jérôme Lebel authored
This is a reland of 72bd9335 Fixing 2 test problems: + ChromeSigninViewControllerTest.TestConsentWithOKGOTIT* UnifiedConsentService needs UnifiedConsentServiceClient, local and user preference service. To make the unittest working, the UnifiedConsentService is prevented to be created. + GoogleServicesSettingsTestCase.testOpenManageSyncedDataWebPageWhileSignedIn To open the manage synced data web page, the user should be signed in without unified consent. Original change's description: > [iOS] Using UnifiedConsentService::SetUnifiedConsentGiven() in the settings > > This CL enables unified consent given when the user signs in to Chrome. > This CL also disabled and enables unified consent given when the user > toggles the corresponding switch on and off in the Sync and other services > settings screen. > > Bug: 827072 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5384052f4abe117e7816733e45dc4091afe55708 > Reviewed-on: https://chromium-review.googlesource.com/1165151 > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581873} Bug: 827072 Change-Id: Ideb01f7c7a5bd2f5e1b6d927eb590b681283aad7 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1172402Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584413}
-
Michael Lippautz authored
Bug: chromium:875044 Change-Id: I208aca1aeb3488d8880523c35f5e486962039ec6 Reviewed-on: https://chromium-review.googlesource.com/1179742 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584412}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bd6c7f9f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23089 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I694d18c78a1ed171d056338712357a681da1405f Reviewed-on: https://chromium-review.googlesource.com/1180856 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584411}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1c0cf3101d33..814f99cf275f git log 1c0cf3101d33..814f99cf275f --date=short --no-merges --format='%ad %ae %s' 2018-08-20 magjed@webrtc.org Android: Remove deprecated SurfaceTextureHelper methods 2018-08-20 titovartem@webrtc.org Eliminate SetClockOffset() from DirectTransport. 2018-08-20 peah@webrtc.org Correct audioproc_f to support the new echo canceller activation 2018-08-20 buildbot@webrtc.org Roll chromium_revision 63fab7f6..c092e144 (584203:584376) 2018-08-20 kwiberg@webrtc.org Use string_view instead of overloading for const string& and const char* Created with: gclient setdep -r src/third_party/webrtc@814f99cf275f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic8362b4f383db101cab3bd20927d413a71df7763 Reviewed-on: https://chromium-review.googlesource.com/1180857Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584410}
-
Friedrich Horschig authored
This disables all BrowserViewTests that haven't been disabled yet. Because these failures have always been Mac-only, reenable one disabled tests for non-Mac platforms. TBR=weili@chromium.org, bsep@chromium.org Bug: 875707 Change-Id: Ie0a24b706669d07577bf2413a61bd959d70950cc Reviewed-on: https://chromium-review.googlesource.com/1180975 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Lutz Justen authored
Moves - ForceSafeSearchPolicyHandler - ForceYouTubeSafetyModePolicyHandler - BrowsingHistoryPolicyHandler - SecureOriginPolicyHandler out of configuration_policy_handler_list_factory.cc to the places that use the prefs. Merely a cleanup CL - no other changes. BUG=chromium:872717 TEST=tryjobs Change-Id: Ic234b0aac5f869abe9dcb99908d4ffb615bc4f2c Reviewed-on: https://chromium-review.googlesource.com/1169173 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584408}
-
Koji Ishii authored
Following bot results are included. 8933 8941 8946 8949 8953 8959 8963 8964 8967 8970 8979 8981 8982 8983 8984 8988 8989 8990 8991 8992 8997 8999 3 lines were removed and 6 lines were deflaked by consecutive results since 8679. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I393e199d65c61e2793264aa041c47bf8a4d08e8b Reviewed-on: https://chromium-review.googlesource.com/1178581 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584407}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f62079a0f9e5..31458a557486 git log f62079a0f9e5..31458a557486 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 anthonyalridge@google.com Create functionality in plotter to allow deletion of old plots Created with: gclient setdep -r src/third_party/catapult@31458a557486 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ic5639c5ed7435989c3a78df3a2bf3399633b04c5 Reviewed-on: https://chromium-review.googlesource.com/1180848Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584406}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c7ca7b19c714..1c0cf3101d33 git log c7ca7b19c714..1c0cf3101d33 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 oprypin@webrtc.org Stop using typeof() GNU extension 2018-08-20 titovartem@webrtc.org Introduce SimulatedNetworkReceiverInterface. Created with: gclient setdep -r src/third_party/webrtc@1c0cf3101d33 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:427584 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d8c9cb255a1b391cc583d15ebf7da1ad5ce37cd Reviewed-on: https://chromium-review.googlesource.com/1180854Reviewed-by:
-
Paul Jensen authored
One of the top crashers in net/ is out-of-memory with data URLs that comes when the string is needlessly duplicated during unescaping. Looks like data URLs are being used to load fonts. I'm unescaping in-place to avoid requiring two copies of the string. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8724c62b254623e5025478b27388e42d5c4a1473 Reviewed-on: https://chromium-review.googlesource.com/1169635Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584404}
-
Guido Urdaneta authored
No-Try: true Change-Id: Ib2512dec81dcbf950c02eadf742828781d0fdb49 Reviewed-on: https://chromium-review.googlesource.com/1180962Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#584403}
-
Boris Sazonov authored
This CL moves the code from SigninView startAnimations/stopAnimations methods into separate AnimationLooper class that encapsulates animation looping logic. This class is then used in ConsentBumpMoreOptionsFragment to run the header animation. Bug: 869426 Change-Id: Ie305e4535adf27662d7d6724afc419b7bcfd8084 Reviewed-on: https://chromium-review.googlesource.com/1172688Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#584402}
-
Boris Sazonov authored
This CL changes "Settings" link in the sign-in and consent bump screens to point to SyncAndServicesPreferences instead of AccountManagementFragment. It also links Chrome sync notification to SyncAndServicesPreferences if UnifiedConsent feature is enabled. Bug: 872812 Change-Id: Ie36788228cad14de9b82edfbd0e6bf1d1d9e295d Reviewed-on: https://chromium-review.googlesource.com/1172973 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Implements the two methods on iOS. Bug: 726702 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib2a8a40be00c555096ca79915654d62e6ee1ac77 Reviewed-on: https://chromium-review.googlesource.com/1165085Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584400}
-
stkhapugin@chromium.org authored
Fixes a crash when there is no visible item. Bug: 819200 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc97de304a7720d7866b309cc436eb2938c833ce Reviewed-on: https://chromium-review.googlesource.com/1170778 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This test is known to be flaky and a change related to it didn't change that (see linked bug). TBR=keishi@chromium.org Bug: 862589 Change-Id: I3c64042bb3d36c9515d2b1b302d13b85fbbc8034 Reviewed-on: https://chromium-review.googlesource.com/1180963 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Scott Wu authored
Please see detail description in the bug. Bug: 875176 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib6c09079db1475deca5983a929335eda6e1bf1b3 Reviewed-on: https://chromium-review.googlesource.com/1179546Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584397}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I23e4307069ba1caa858f3b83e0c9586bf2da1251 Reviewed-on: https://chromium-review.googlesource.com/1180855Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584396}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0489ac9f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23088 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I54b4b16e7c3f82de26ab8ca6e0c3b99794fb0cf8 Reviewed-on: https://chromium-review.googlesource.com/1180846 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This adds tests that won't pass yet for a smaller CL. Split off of https://chromium-review.googlesource.com/c/chromium/src/+/1174204 Tests that: - FetchEventForNavigationHasThrottledRequest: The service worker fetch event observes headers modified by a throttle during navigation. This is valid in both NetworkService and S13nServiceWorker. - RedirectOccursBeforeFetchEvent: The service worker only sees the post-redirect request when a throttle redirects. This is valid in both NetworkService and S13nServiceWorker. - NavigationHasThrottledRequestHeadersAfterNetworkFallback: After a service worker falls back to network, the request contains the headers modified by throttles during navigation. This is only valid for NetworkService. Headers are not propagated to the network request in the S13nServiceWorker case. - NavigationPreloadHasThrottledRequestHeaders: When navigation preload is enabled, the navigation preload request contains the headers modified by throttles during navigation. This is valid for both NetworkService and S13nServiceWorker. Bug: 873575 Change-Id: Id7d74a9cf7f0a4f15eebe06882039a108e176263 Reviewed-on: https://chromium-review.googlesource.com/1180832Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Balazs Engedy authored
String no longer contains a placeholder, do not try to substitute one. Bug: 875531 Change-Id: I53acc969a58a270ed14011b37177329bbcaaf644 TBR: hongjunchoi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1180898Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584393}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9923353600ea..c7ca7b19c714 git log 9923353600ea..c7ca7b19c714 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 phoglund@webrtc.org Revert "Temporarily skip linux_internal on autoroller tryjobs." Created with: gclient setdep -r src/third_party/webrtc@c7ca7b19c714 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I892f6f7ccb491346ca1723f3cf40da7590b168c0 Reviewed-on: https://chromium-review.googlesource.com/1180847Reviewed-by:
-
Jan Wilken Doerrie authored
This change implements pairing on WinRT and adds appropriate tests. In order to encapsulate the implementation, a new BluetoothPairingWinrt helper class is introduced. For now only pairing via PIN code is supported. Bug: 821766 Change-Id: Ic0a64b4e79dd38f9c0ac86a25c0a878f1f70192c Reviewed-on: https://chromium-review.googlesource.com/1177741 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584391}
-
Yoshifumi Inoue authored
This reverts commit 2a82d4ff. Reason for revert: This patch still causes the crash with the CL[1]. [1] [1] http://crrev.com/c/1123018 [CI] Cleanup paint invalidation flags Original change's description: > Destroy paint fragment tree before destroying descendant layout objects > > This patch introduces |LayoutNGMixin::WillBeDestroyed()| and changes > |LayoutBlockFlow::DeleteLineBoxTree()| to destroy paint fragment tree before > destroying descendant layout objects to allow |NGPaintFragment| destructor can > access its associated |LayoutObject|. > > Before this patch, |NGAbstrctInlineTextBox::WillDestroy()|, which is called from > |NGPaintFragment| destructor, uses dead |LayoutText| == |NGPaintFragment| lives > longer than |LayoutText|. > > After this patch, |LayoutText| lives longer than |NGPaintFragment|. > > Bug: 874588 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Iade5c8a51a57da2e855a194caa098e90222a7804 > Reviewed-on: https://chromium-review.googlesource.com/1180828 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584385} TBR=yosin@chromium.org,kojii@chromium.org Change-Id: I0fb21ceab9c1b30bbc9b2cc4d0081c04108a3db1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874588 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1180902Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584390}
-
Benoit L authored
This reverts commit 3033b341. Reason for revert: Suspected culprit for crbug.com/875713 (broken official bots). Original change's description: > Add isolate-everything command to mb.py > > The command generates a .isolate for every compatible gn target. > > This will be used by the deterministic builder to check that all isolates > dependencies are identical between two builds. > > Change-Id: I4f6a515e49f9cc207dd2f54c796531d12dfeb771 > Bug: 870731 > Reviewed-on: https://chromium-review.googlesource.com/1176441 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584268} TBR=maruel@chromium.org,dpranke@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870731, 875713 Change-Id: I5110467272abbffc96bdfa8a11261822dd96a065 Reviewed-on: https://chromium-review.googlesource.com/1179862Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584389}
-
Fredrik Söderquist authored
TBR=schenney@chromium.org BUG=875411 Change-Id: I83c6386435a1d519359e41b9a38bb37d8c646900 Reviewed-on: https://chromium-review.googlesource.com/1180890Reviewed-by:
-
Tanja Gornak authored
Bug: 867334, 801985 Change-Id: I306bb35f1788acdfd83b772c428fd718ee13b61a Reviewed-on: https://chromium-review.googlesource.com/1154983 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#584387}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb65db10aa31..2c687ea6e0a9 git log fb65db10aa31..2c687ea6e0a9 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5055fba5692f..f26b27e29535 (1 commits) Created with: gclient setdep -r src/third_party/skia@2c687ea6e0a9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I9c646fc0b3b2404b443115fccec424472066cd35 Reviewed-on: https://chromium-review.googlesource.com/1180845Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584386}
-
