- 20 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3c13bf1fa865..026b1e2be09a 2020-07-20 aninditaghosh@google.com Merge "Load in trace_processor shell given file path to trace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia751c6308d0c6119f6e8da6fecaf6b3824fc5ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790137}
-
Alex Cooper authored
This reverts commit 715c3a3a. Reason for revert: Fix Test Class setup Original change's description: > Revert "Update vr_pixeltests exceptions" > > This reverts commit 7da56cfe. > > Reason for revert: Test is still failing: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20(dbg)(1)/83673 > > Original change's description: > > Update vr_pixeltests exceptions > > > > https://crrev.com/c/2304097 updated the tests that originally required > > this exception to be added so that they now automatically skip/pass on > > Windows 7, so we don't need to keep these exceptions anymore. > > > > Bug: 1106809 > > Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 > > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789684} > > TBR=thakis@chromium.org,alcooper@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1106809 > Change-Id: Id8a98cce9da8ec8933e75686718f92e7b7ec2d15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307011 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789861} TBR=thakis@chromium.org,aboxhall@chromium.org,alcooper@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1106809 Change-Id: Ia8e1f6261091de3bde7de3f55d4ea77771c1a59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307636 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#790136}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/5f43fedcddba..747e80a9b369 $ git log 5f43fedcd..747e80a9b --date=short --no-merges --format='%ad %ae %s' 2020-07-20 dneto [spirv-reader] Drop NonWritable NonReadable for now 2020-07-20 rharrison Fix issues with BUILD.gn 2020-07-20 dsinclair [msl-writer] Cleanups and refactors. 2020-07-20 dsinclair [msl-writer] Handle uniform buffers. 2020-07-20 dneto [spirv-reader] Support DescriptorSet and Binding 2020-07-20 dneto [spirv-reader] Handle old-style storage buffers 2020-07-17 dneto Rolling 6 dependencies 2020-07-16 dneto [spirv-reader] Support Location on module vars 2020-07-16 dneto [spirv-reader] Ignore empty string user names Created with: roll-dep src/third_party/tint/src Change-Id: I02397ad4a90cc8e31a6706d2e8258a3076728691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308453 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#790135}
-
Sammie Quon authored
NotificationMD already had a clip installed previously, so the mask code was never called, so its safe to just delete. ScrollArrowView has only one override ScrollableScrollArrowView which turns of ink drop ripples and highlights, so its safe to remove the ink drop codes. Test: manual Bug: 1056490 Change-Id: I3e4b068f3e819901b1da7d4ab42bc74e62a0295f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308450Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790134}
-
Kristi Park authored
Fix symbol not found error for org.chromium.base.annotations.UsedByReflection Change-Id: I7505cfe99a276ba6083f82521bb9f8c86cc7509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309132 Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790133}
-
Alexander Cooper authored
All code that previously referenced this feature has been removed, as the feature is now fully enabled. The flag wasn't removed with the code as I mistakenly believed that there were some finch configs that needed updating/removing that couldn't be updated/removed until Chrome stable had the flag enabled by default; however, after re-reading documentation it seems as though the corresponding finch configs should be left alone. This thus just removes the feature entry which is no longer doing anything. Fixed: 1090108 Change-Id: Iaf3a6121914be83ae72179bc0e89fa60a2d921f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308036 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#790132}
-
rbpotter authored
Adding closure targets for: destination_select_test destination_search_test destination_search_test_chromeos Bug: 1000989 Change-Id: Iac91004ee5b78120f2a894194a28a13f7626ca1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303875Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#790131}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I27938446752d625ed487061459879409a5eddd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308452Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790130}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ib9e97d0404d003c21fa1d2e1b6b5bcfdc7bad1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293008Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#790129}
-
Dave Tapuska authored
In order to move the RenderWidget handling of this message we must first move the message then we can progressively move the implementation. BUG=1097816 Change-Id: I8dbc29902fd0062f03ff938af4d56a16446d54df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302912 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790128}
-
Vasiliy Telezhnikov authored
This CL adds requests queue to FrameInfoHelperImpl to make sure all requests are ordered to keep VideoFrameFactoryImpl pipeline ordered. Before this change VFFI would cache FrameInfo to avoid thread hops to GPU thread and it was possible that some CreateVideoFrame requests will be completed out-of-order. After this change VFFI doesn't cache FrameInfo and always call FrameInfoHelper. FrameInfoHelper does all necessary caching to avoid unnecessary hops to GPU thread and guarantees that callbacks with FrameInfo will come in order. Change-Id: Iacb63cf3746991c911f1f0d5e3667db3dbd56c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304092 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#790127}
-
Jan Wilken Dörrie authored
This change prepares //net for the switch of base::string16 to std::u16string on all platforms. This was achieved by making net_unittests compile on Windows after the switch was made. Furthermore, it fixes small issues in //base and //sql. Bug: 911896 Change-Id: I11fd80998e9f5e954a87870533685a3f77fa42d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303431 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790126}
-
Kevin Marshall authored
Allow each fuchsia.web.Context's browser process to delegate the ambient-executable capability to child processes, but not to use the capability itself. Bug: 1106561 Change-Id: I886263daec4c4aea7fd3eb80dd5ab6c46a400cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303978Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790125}
-
Jun Mukai authored
ash_shell (and ash_shell_with_content) were introduced for quick-checking of ash behaviors, as it's fast to build. However, it's not used by many people, and I've noticed that it's broken in many ways. I believe no one is using it actually, so I think it's the time to remove it at all. ash_ui_perftests, which depends on ash_shell_lib_with_content, is also removed, as it was introduced for a purpose but isn't used actually. Bug: none Test: build passes Change-Id: I68d4de5b0172f51240a99e61facbe4f7ee606ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307909Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#790124}
-
Michael Spang authored
This reverts commit 0fc9ef09. Reason for revert: This no longer compiles, the flag is removed from our build after 0f1575a6 ("media/chromeos: refactor flags enabling new VideoDecoder"). Probably it's no longer needed. Original change's description: > chromecast: force disable new accelerated video decoder > > The new accelerated video decoder uses V4L2SliceVDA, which is > not supported by Cast devices. > > So instead, we will force disable use of this new decoder > through command line switch, which will fallback to use > VdaVideoDecoder, which uses V4L2VDA. > > Bug: b/158230739 > Test: Verify mirroring on Cast display devices > Change-Id: I7765e6861c09a0357e2d923a20c9a56c1bdcb065 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238876 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Commit-Queue: Peter Qiu <zqiu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776861} TBR=zqiu@chromium.org,halliwell@chromium.org,tguilbert@chromium.org,seantopping@chromium.org,yucliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/158230739 Change-Id: Idaac0f78fc54b6fb4bf0d2f028ad5be96cfd7ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306377Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790123}
-
Charlie Harrison authored
A previous change ensured that large custom cursors > 32x32 would be dropped if they are not fully contained with the visual viewport. However, the computation did not account properly for OOPIFs, where cursor coordinates were not adjusted to the viewport offset. This CL further adjusts the cursor rect by translating it to the root view's coordinate space via LocalToAncestorPoint, before checking for containment within the visual viewport. Bug: 1099276 Change-Id: I0a03e7cc249cd785f9e76f931cfc7931b127d56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278597 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#790122}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: I7c230f4a72a7bfccec5ad48c70aa8a39a099342e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292707Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ade0fed37fc7..6caaa1da7bfa 2020-07-20 bsheedy@chromium.org [Telemetry] Log screenshot output on failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106927 Tbr: sadrul@google.com Change-Id: Id15637220783b5da66311458cb7e83155b592a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308356Reviewed-by:
-
Xi Han authored
Bug: 1103838, 1092642, 1076274 Change-Id: I6bf58ef38c834ce15fae04f0743f646fcb98970f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290755Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790119}
-
Peter Boström authored
Bug: None Change-Id: Ib88ea119296aa359d03aad85a864bd203464fdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308691 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#790118}
-
Maxime Charland authored
This CL adds a label in the Recently Closed section of the Recent Tabs view to tell users this is where they will see tabs they recently closed. (Googlers only links) Screenshot: https://drive.google.com/file/d/1oKVGpIV26NS2Tb4GF1kWJZV0RItwsiFk/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: If33b1f650e978f1aca4260e9f76682f4defd8e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297919 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790117}
-
Maxime Charland authored
This CL adds PDF assets for the empty state of the Other Devices section in the Recent Tabs TableView. PDF assets will be used as vector images to display at big scale without impacting binary size. These assets will have colour information, so there will be one version for dark mode and another one for any appearance. (Googlers only links) Design Doc: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing UX Specs with mocks: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I396603d96ad72c7326f9652e884824c3f9e9b7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298054Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9e8e888b4ba8e46f7691a6c0a98804e813e20705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308033Reviewed-by:
-
Angela Yoeurng authored
This fixes a bug that causes a "ghost" remove suggestion button when button row is enabled, and removes duplicate logic. Bug: 1106062 Change-Id: I377b875fe2ec114c3ca9e708fa35cdf1c822f7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304938Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#790114}
-
Yao Xiao authored
- If there is a small overlay in the page (e.g. sticky ad on the side), and the user shrinks the viewport to make the overlay centered & relatively large, we don't want to consider it to be a "popup". - Changed all relevant tests to promise_test for better readability. - Removed most waitings in web_tests by disabling the frequency capping. - A bugfix: It was a no-op to compare last_detection_main_frame_size_ and main_frame_size after setting them equal. This patch moves the setting after the comparison. - An improvement/fix: for the current overlay candidate, always check element->IsAdRelated() in each detection, and update its ad status if it becomes an ad. Bug: 1032681 Change-Id: If1d945be69d51289cf3314b5700e265772f0087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291211Reviewed-by:
-
Yuwei Huang authored
* Add stream request support to ProtobufHttpStatus, which includes some refactoring in the code. * Make ProtobufHttpClient directly own the requests, to make lifetime managing less painful. Bug: 1103416 Change-Id: I9c1f62acb4e02cd968387bc4cc34db8dd6268c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299536 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#790112}
-
phillis authored
This moves installation logic for all OS hooks currently including shortcuts, shortcuts menu, file handler, run on OS login, quick launch bar to OsIntegrationManager. Bug: 1098027 Change-Id: I46765a7493274a545ffbfef274bdbfc7d3fecf2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272120 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#790111}
-
Christopher Cameron authored
If the default assignment operator is called when |this| is populated, then the members will be moved in declared order. As a consequence, |this->representation_| will be overwritten and therefore deleted before |this_->scoped_read_access_|, which will cause a DCHECK (because scoped accesses may not outlive their representation). Bug: 894929 Change-Id: If342c05343511074376ac360b12fe3dd0eca94b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307150Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#790110}
-
David Bienvenu authored
Adds base::debug::alias for key_path and value when reading from windows registry. Bug: 1106328 Change-Id: Ibb936708ffd8b2ce6b759e61095528db2990a483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304977 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790109}
-
manuk authored
Before this CL, the input 'yz' could autocomplete '[x]yz yz'. With this CL, 'yz' will instead autocomplete '[xyz ]yz'. This isn't common because providers don't usually suggest suggestions when they only match the input midword. But, in examples like the above, the 2nd match would allow providers to provide the suggestion while RAC would match the 1st occurrence of the input. Bug: 1062446 Change-Id: Ic41feb7845f51c488e7cf6e9b731af4b81f6d08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303645Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790108}
-
Wez authored
Bug: 1107418 Change-Id: I6f6523e7f40382658e2d3f34b04fe48464658759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306159 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790107}
-
Chris Harrelson authored
This code was originally added in [1]. The web_test added in that CL still passes, as does a subsequent related unittest added in another CL (PaintLayerPainterTest, PaintPhasesUpdateOnLayerAddition). I'm not sure what caused these to keep passing with the code removed - there is a reference in [1] to re-use of DisplayItemClient pointers, perhaps that was improved since then? [1] https://codereview.chromium.org/1403963002 The bug reported in issue 541544 also does not reproduce with this CL applied. Bug: 1104794 Change-Id: I91addcea57c217dd1f971fcc4dbae0cd518c7011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307610 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790106}
-
Richard Townsend authored
A change in dependencies means that a component with a MIDL dependency (third_party/iacccessible2) is now compiled for the x64 host and arm64. This caused problems because the host win_clang_x64 generated files typically live in out/<t>/win_clang_x64/gen/third_party/iaccessible2 whereas the arm64 files live in out/<t>/gen/third_party/iaccessible2, meaning that (when the path is rebased) the midl action tried to copy files from a missing win_clang_x64 directory in iaccessible2. Using the root_gen_dir instead fixes this depth mismatch. Bug: 1105878 Change-Id: I9403b0024c394b339168e47275d23240b55c3574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302054Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#790105}
-
Sergey Ulanov authored
Previously VideoCaptureDeviceFactoryFuchsia was logging an ERROR when DeviceWatcher connection is disconnected, while this error is expected in some environments. In this change: 1. Fixed CastRunner to close DeviceWatcher with ZX_ERR_UNAVAILABLE when no applications have camera access. 2. Fixed VideoCaptureDeviceFactoryFuchsia to avoid logging errors for ZX_ERR_UNAVAILABLE. 3. Improved handling of disconnected state in VideoCaptureDeviceFactoryFuchsia: now it will reconnect the channel in CreateDevice(). 4. Added unittests for (3). TBR=guidou@chromium.org Bug: fuchsia:54060 Change-Id: Ib39fd1ef0d1a787f762bcd961196800105e45b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246877 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8b4eeffd4628..b655a28e1097 2020-07-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0e43c49ac916751c4d7d87ca86db696bd7eb8bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308351Reviewed-by:
-
Akihiro Ota authored
This change does the following: 1. Adds CSS according to initial UI mocks 2. Adds JSDoc to member functions 3. Removes quotes from object keys 4. Removes underscores from function names. 5. Changes instances of "test" or "test area" to "practice" according to UX feedback. We also make these changes in the code for consistency. 6. Changes many instances of "container" to "screen". 7. Rename "routing page" to "main menu" per UI feedback. 8. General clean up and use less verbose language. --enable-experimental-accessibility-chromevox-tutorial flag. Manually verify that tutorial loads with new UI. Move through the tutorial using ChromeVox and verify no behavior change. Bug: 1075752 Change-Id: I4895d7ad153a5adf1fc1471b637ca0156cea6b99 AX-Relnotes: N/A Test: Run Chrome with the Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304443Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#790102}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If933bbfe386d8b33878d5bf963a8f9cad091d7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307657Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#790101}
-
Will Harris authored
The patching of user32!GetSystemMetrics no longer works on latest builds of Windows. The test is also disabled. There are tests for presence of the CFI flags in checkbins.py and a test for CFG within chromium binaries in base_unittests so no need for this additional test. BUG=584575 Change-Id: I0985d888ff371f826906639d3ca6faece50cb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308409Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790100}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b6e086dc..82a184f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc300c47989e819f4a249702fe58545dcdeae503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790099}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I22e106407b96ca34c09e819cd68d14a2ce5101db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308358Reviewed-by:
-
