GitLab

Revert of Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #1 id:1 of https://codereview.chromium.org/684253003/)

Reason for revert:
Ah, reverted the wrong CL.

Original issue's description:
> Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)
>
> Reason for revert:
> Should turn on logging in telemetry_gpu_tests in general.
>
> Original issue's description:
> > Add logs to debug a flakiness on GPU Mac bots.
> >
> > This is temporary and will be removed after we pin down the issue.
> >
> > BUG=424024
> > TEST=
> > R=kbr@chromium.org
> > TBR=dgozman@chromium.org
> > NOTRY=true
> >
> > Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> > Cr-Commit-Position: refs/heads/master@{#302371}
>
> TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=424024
>
> Committed: https://crrev.com/ec506e7f57922e5a068d76128f020877bc7986cb
> Cr-Commit-Position: refs/heads/master@{#302387}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/698783002

Cr-Commit-Position: refs/heads/master@{#302388}

Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)

Reason for revert:
Should turn on logging in telemetry_gpu_tests in general.

Original issue's description:
> Add logs to debug a flakiness on GPU Mac bots.
>
> This is temporary and will be removed after we pin down the issue.
>
> BUG=424024
> TEST=
> R=kbr@chromium.org
> TBR=dgozman@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> Cr-Commit-Position: refs/heads/master@{#302371}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/684253003

Cr-Commit-Position: refs/heads/master@{#302387}

NOTRY=true
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/695873003

Cr-Commit-Position: refs/heads/master@{#302386}

This is unnecessary as image ids are not reused. CreateImage will
fail if generation of image ids wraparound as negative ids are
considered an error.

R=piman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/689253002

Cr-Commit-Position: refs/heads/master@{#302385}

Cr-Commit-Position: refs/heads/master@{#302384}

BUG=

Review URL: https://codereview.chromium.org/694763003

Cr-Commit-Position: refs/heads/master@{#302383}

Only one should be set, so update functions to reflect this. In the rare
case both are set, always-on takes precedence.

BUG=397019

Review URL: https://codereview.chromium.org/685053002

Cr-Commit-Position: refs/heads/master@{#302382}

VC++ hits internal compiler errors on a source file in each of yasm and
libexif. This halts the build and prevents full analysis. Therefore this
change disables /analyze for those two projects, to increase total
coverage.

Also fix a typo in libexif's README.chromium

BUG=427616

Review URL: https://codereview.chromium.org/657883003

Cr-Commit-Position: refs/heads/master@{#302381}

Cr-Commit-Position: refs/heads/master@{#302380}

Chrome add "X-Chrome-UMA-Enabled" (and sometimes "X-Client-Data") headers while accessing Google servers if UMA is enabled.
This header is added before sending the request to the ServiceWorker.
So the request which is passed to the ServiceWorker contains this header.

If event.request.mode is 'cors' and event.request.headers has "x-chrome-uma-enabled", fetch(event.request) send a CORS preflight request.
This preflight request contains "Access-Control-Request-Headers: x-chrome-uma-enabled" header.
But the response from the Google server doesn't contain "Access-Control-Allow-Headers: x-chrome-uma-enabled" header.
So this fetch fails.

To avoid this problem this patch removes these headers before sending the request to the ServiceWorker.

This patch introduces ServiceWorkerContext::AddExcludedHeadersForFetchEvent() method and changes DevToolsNetworkTransactionFactory to call this method.

BUG=425649

Review URL: https://codereview.chromium.org/666973003

Cr-Commit-Position: refs/heads/master@{#302379}

This change renames MediaIndicatorView to MediaIndicatorButton, and then
merges-in the new functionality to support tab muting by clicking on the
indicator.  This is the "Cocoa port" of a previous change that added
this feature to the views UI: http://codereview.chromium.org/591963002

See change description in link above for details.

Also, this change resolves a long-standing bug where navigating back
into a NTP would leave the audio indicator turned on even though the NTP
does not emit sound.

BUG=360372, 344229
TEST=With --enable-tab-audio-muting, user can click audio indicator to toggle tab muting, or use the tab context menu to toggle muting of one or more selected tabs.

Review URL: https://codereview.chromium.org/688523002

Cr-Commit-Position: refs/heads/master@{#302378}

BUG=421291

Review URL: https://codereview.chromium.org/692523004

Cr-Commit-Position: refs/heads/master@{#302377}

This CL:
- Adds !defined(USE_ATHENA) ifdefs where Ash is used.
- Stops compiling KeyboardOverlayUI in Athena because it is not necessary
- Stops compiling in Athena for simplicity:
   DisplayOptionsHandler, PowerHandler, FirstRunUI

BUG=426561
TEST=None
TBR=oshima,estade,stevenjb

Review URL: https://codereview.chromium.org/684143003

Cr-Commit-Position: refs/heads/master@{#302376}

TBR=darin@chromium.org for trivial third_party/*/BUILD.gn changes

Review URL: https://codereview.chromium.org/698733002

Cr-Commit-Position: refs/heads/master@{#302375}

BUG=424453

Review URL: https://codereview.chromium.org/653283007

Cr-Commit-Position: refs/heads/master@{#302374}

Reduce the maximum number of Session ID cache entries to save
memory but increase the session ID cache timeout to be useful.

BUG=426630

Review URL: https://codereview.chromium.org/687343002

Cr-Commit-Position: refs/heads/master@{#302373}

BUG=416184
TEST=as in bug

Review URL: https://codereview.chromium.org/689163002

Cr-Commit-Position: refs/heads/master@{#302372}

This is temporary and will be removed after we pin down the issue.

BUG=424024
TEST=
R=kbr@chromium.org
TBR=dgozman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/684423005

Cr-Commit-Position: refs/heads/master@{#302371}

The BrokerProcess class is too complex. It both serves as management
of a new broker process, as well as the implementation of an
async-signal-safe IPC mechanism suitable to broker syscall.

We split the BrokerProcess class into 4 simpler classes. This will make it
easier to replace the broker process with a thread or a new Chrome process
type.

BUG=429028

Review URL: https://codereview.chromium.org/688843003

Cr-Commit-Position: refs/heads/master@{#302370}

They are no longer needed since nearly no extensions code gets built when extensions are disabled.

Review URL: https://codereview.chromium.org/672403002

Cr-Commit-Position: refs/heads/master@{#302369}

These calls are not available on MacViews without Aura, so put them behind an
interface through views::Widget.

BUG=425229

Review URL: https://codereview.chromium.org/693523003

Cr-Commit-Position: refs/heads/master@{#302368}

The mojo_surface_converters get their own file to avoid dependency
cycles between media/ and cc/

BUG=none
TEST=no more cycles when media depends on type conveters.

Review URL: https://codereview.chromium.org/691573003

Cr-Commit-Position: refs/heads/master@{#302367}

Previously the client cursor would revert to a default arrow if the
host cursor was hidden or empty, or in mouse-lock mode.

BUG=429368

Review URL: https://codereview.chromium.org/696873002

Cr-Commit-Position: refs/heads/master@{#302366}

Per mock:
https://beta-dot-folio.googleplex.com/chrome-ux/mocks/212-stars-iphone/20/phone#%2F05-detail-edit-bookmark.png%3Fc=hidden

All tags/filters associated with a bookmark should be displayed in
enhanced bookmark detail page. This CL introduced related APIs to jni
bridge for UI to retrieve.

BUG=NONE

Review URL: https://codereview.chromium.org/694093002

Cr-Commit-Position: refs/heads/master@{#302365}

Webkit roll 9eddd919681ed3642ac37d811e6b3f30e0f152db(r184753):2842c5f8ea181eb3415ae3b124b873eb4355e6e2(r184758)

TBR=morrita
BUG=

Review URL: https://codereview.chromium.org/695043003

Cr-Commit-Position: refs/heads/master@{#302364}

The root cause was that ImageTransportSurfaceFBO was using the pixel
size of the surface to early-out of surface reallocation. This is a problem
when scale factor changed and pixel size doesn't -- the change in scale
factor is never propagated to the underlying CALayer.

Move all logic for changing the size of the surface and for skipping
changes in the size of the surface to AllocateOrResizeFramebuffer.

Rename ambiguous sizes to be labeled as pixel_size or dip_size.

Remove a stray ScopedCAActionDisabler that does nothing (found by
inspection of nearby code).

Add myself as an OWNER for this path.

BUG=424713

Review URL: https://codereview.chromium.org/696823002

Cr-Commit-Position: refs/heads/master@{#302363}

Moving the DirectiveHandler to be owned by CopresenceManager. This also adds the ability to queue Directives. Tests will be forthcoming.

BUG=424253

Review URL: https://codereview.chromium.org/684273004

Cr-Commit-Position: refs/heads/master@{#302362}

GCC thinks that the create_flags parameter in the templated class
gin::Invoker constructor is going unused, even though it is definitely
being used as a part of a variadic template expansion. Convince GCC
that it is in fact being used by casting it to a void.

BUG=424334
TEST=Linux GN build of gin with is_clang=false
R=aa

Review URL: https://codereview.chromium.org/694063002

Cr-Commit-Position: refs/heads/master@{#302361}

BUG=159847

Review URL: https://codereview.chromium.org/690213003

Cr-Commit-Position: refs/heads/master@{#302360}

BUG=webrtc:3868

Review URL: https://codereview.chromium.org/689243002

Cr-Commit-Position: refs/heads/master@{#302359}

BUG=429372
NOTRY=true

Review URL: https://codereview.chromium.org/697783002

Cr-Commit-Position: refs/heads/master@{#302358}

options_ui is available.

For now this will be hosted on a new page options2.html since the
new options aren't stable yet. When they are, I'll switch over the
URLs.

R=mkearney@chromium.org
BUG=406890

Review URL: https://codereview.chromium.org/691283003

Cr-Commit-Position: refs/heads/master@{#302357}

We can't fix all instances of this warning at the moment (because of gmock
and because of blink apis, see bug). We've fixed many, but our bots still
show almost 20k warnings due to this warning, most of them in v8. That's already
fixed upstream, but v8 rolls don't happen often. Turn the warning off for now.

BUG=428099
NOTRY=true

Review URL: https://codereview.chromium.org/687343003

Cr-Commit-Position: refs/heads/master@{#302356}

This adds a page set that is useful to measure how good a browser
is at producing new content when scrolling a page fast.

MAX_SCROLL_LENGTH_PIXELS is changed into MAX_SCROLL_LENGTH_TIME_MS
to allow fast scrolling of large pages.

BUG=406404

Review URL: https://codereview.chromium.org/688423002

Cr-Commit-Position: refs/heads/master@{#302355}

$ git log bcb3bc303..41036ec83 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-10-31 jbauman Fix termination of initially-suspended processes at end of tests.
2014-10-24 maruel Quick fix to support query parameters in GETs.
2014-10-24 maruel Make test resilient to any umask and add workarounds for strace 2.8.

R=jbauman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/690333004

Cr-Commit-Position: refs/heads/master@{#302354}

TBR=isherman@chromium.org
BUG=429343

Review URL: https://codereview.chromium.org/692263002

Cr-Commit-Position: refs/heads/master@{#302353}

storage.sync MAX_SUSTAINED_WRITE_OPERATIONS_PER_MINUTE limit. I'll be relaxing
the quota over a few CLs and having 2 limiting mechanisms just complicates
things.

BUG=406406
R=zea@chromium.org

Review URL: https://codereview.chromium.org/685603003

Cr-Commit-Position: refs/heads/master@{#302352}

BUG=

Review URL: https://codereview.chromium.org/694573003

Cr-Commit-Position: refs/heads/master@{#302351}

The issue is after enabling sending device_id for LST, IssueToken
endpoint started returning "issueAdvice": "consent" for scope marked
 with per_device_authorization_required:true.

The solution is to pass the same device_id/device_type to approval url.

Tests:
Tested that for LST with device_id consent screen is only shown once.
After restart access token is issued without user interaction.

Tested that for LST without device_id no consent screen is shown.

BUG=403718
R=courage@chromium.org

Review URL: https://codereview.chromium.org/693203003

Cr-Commit-Position: refs/heads/master@{#302350}

Local search function has the same logic with how omnibox retrieves
bookmarks for a given keyword.

BUG=415774

Review URL: https://codereview.chromium.org/695493005

Cr-Commit-Position: refs/heads/master@{#302349}