- 22 Oct, 2018 40 commits
-
-
Yuichiro Hanada authored
We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 Test: Can type text on Wikipedia kiosk app. Change-Id: I594aa5c0730704b9ad922441187297bd707de20a Reviewed-on: https://chromium-review.googlesource.com/c/1291289 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601631}
-
Saman Sami authored
Since surface resurrection doens't work anymore, make sure the renderer allocates a new id every time it's visible, as the old surface might have been evicted. Bug: 893731 Change-Id: I44d715949f2ccc76a270feac9e6fb899a472cbbc Reviewed-on: https://chromium-review.googlesource.com/c/1293765Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#601630}
-
Saman Sami authored
Bug: 893850 Change-Id: Iee754cefbd083d0a21a2b672fb8e837eaab81c43 Reviewed-on: https://chromium-review.googlesource.com/c/1293712Reviewed-by:
-
Nico Weber authored
V8 currently writes the raw values for embedder fields always, so don't put pointers (which differ even between runs of the same binary, due to ASLR) in there until that's fixed. Instead, put a magic integer there and transform that to a pointer at deserialization time. (Also remove a redundant call from CreatePlainWrapper() -- the caller of CreatePlainWrapper() already sets the embedder field, no need to do that twice. This part is behavior-preserving.) Bug: 870584 Change-Id: I6b29286ec8c7a68a662d51c36b5642b968f2e343 Reviewed-on: https://chromium-review.googlesource.com/c/1293791 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#601628}
-
Sigurdur Asgeirsson authored
Bug: 891310 Change-Id: Ie467f737e76cc0125b03723e16c3c12bdaf41187 Reviewed-on: https://chromium-review.googlesource.com/c/1271380Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#601627}
-
Luke Zielinski authored
The logic allowing us to switch the active pref at runtime is no longer necessary since there is now only a single Extended Reporting pref in the system. Bug: 662944 Change-Id: I8ae0efa90ad488d7a93652268fad24f86ded70c2 Reviewed-on: https://chromium-review.googlesource.com/c/1286988 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601626}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: fast/css* Most of this patch is mechanical rebaseline, except that: - Some LayoutNG-specific baselines become redundant and are removed - One test is changed to fail in LayoutNG due to a known innerText bug Bug: 887148 Change-Id: I3cb1f410eb4544630498d451bf2e260d4be6bbec Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1282305Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601625}
-
Philip Rogers authored
This reverts commit 3d1759c9. Reason for revert: Due to crbug.com/897772, tests were not run. Original change's description: > [BlinkGenPropertyTrees] Promote BGPT to experimental > > BlinkGenPropertyTrees (BGPT) is an incremental step towards making > compositing decisions after the paint lifecycle phase. The primary > changes are to build property trees in blink and send a layer list to > the compositor, rather than building property trees in cc from a layer > tree. This patch marks the project as experimental which will give us > test and perf coverage on the bots. > > Sheriffs: This shifts time (e.g., we now run PaintArtifactCompositor > and no longer run the cc property tree builder) and will likely change > performance benchmarks. Because this is an initial trial, feel free to > roll this patch out. > > Bug: 836884 > Change-Id: Ia1073bdd0922503925c17161f052bdfcd94196b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1292555 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601429} TBR=pdr@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836884, 897772 Change-Id: Iee4fb4fc15e2400c85c9855f904bc4f4225eed71 Reviewed-on: https://chromium-review.googlesource.com/c/1293992 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601624}
-
Evan Stade authored
Bug: 855767 Change-Id: I6dfefc7aa5a8934ee41ae1ca07e15eabe5685377 Reviewed-on: https://chromium-review.googlesource.com/c/1292724 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#601623}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c0d048e784b..ea46bbbe607b git log 8c0d048e784b..ea46bbbe607b --date=short --no-merges --format='%ad %ae %s' 2018-10-22 treehugger-gerrit@google.com Merge "trace_to_text: Remove redundant code" Created with: gclient setdep -r src/third_party/perfetto@ea46bbbe607b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5734f4517ed6f2668f4f824418a431617c55aec0 Reviewed-on: https://chromium-review.googlesource.com/c/1293713Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601622}
-
Dan Sinclair authored
Change-Id: Ibdd326e93f3d00b7212e3ae30fc1f4210802a28f Reviewed-on: https://chromium-review.googlesource.com/c/1293751Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
Max Moroz authored
Bug: 817798 Change-Id: Ib8ede24df41747fbf72050b17d045f920c8c33af Reviewed-on: https://chromium-review.googlesource.com/c/1184048 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601620}
-
Kristi Park authored
The "Restore default shortcuts" menu option is not updated unless an onMostVisitedChanged event is sent. This only occurs when a URL/title of the new tile set is different from the current tiles. As such (after adding then removing a link), the restore default option will not be disabled after clicking since the tiles are considered unchanged. Now consider tiles with different sources to be unequal. Screencast: https://screencast.googleplex.com/cast/NTQ0MDY0MTk2MjA4MjMwNHw0MTY5NmRmYi1mNg Bug: 896566 Change-Id: I8c1474d2a567889fc5296c3a58228a92c3a67b71 Reviewed-on: https://chromium-review.googlesource.com/c/1292149 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601619}
-
Fabio Tirelo authored
Bug: 893592 Change-Id: I619bb47295302ba74301c327372206269c12bf23 Reviewed-on: https://chromium-review.googlesource.com/c/1293729 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601618}
-
Yi Gu authored
Suspecting patch crrev.com/c/1290916 causes test failures. As the patch was landed several hours ago, I'd like to disable the tests and assign the owner for review. TBR=skyostil@chromium.org NOTRY=true Bug: 897775 Change-Id: I416121366cae0d4503b1b02db075722be43db6a9 Reviewed-on: https://chromium-review.googlesource.com/c/1294129Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601617}
-
Saman Sami authored
Bug: 893850 Change-Id: Icb5d59ac7dd6a6cf1dfd6e17f913966d6d546c29 Reviewed-on: https://chromium-review.googlesource.com/c/1294012Reviewed-by:
-
Jesse McKenna authored
TaskScheduler: Delegate reinsertion of Sequences in SchedulerWorkerPool priority queue to TaskScheduler Bug: 889029 Change-Id: I424024245e74c0c08d76a94263c94fad7a3631cc Reviewed-on: https://chromium-review.googlesource.com/c/1271794 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
-
Morten Stenshorne authored
It's now to be resolved against the inline-size of the content area of the block itself [1]. Already fixed for legacy layout here: https://chromium-review.googlesource.com/c/chromium/src/+/1285109 We no longer need PercentageResolutionInlineSize(). [1] https://github.com/w3c/csswg-drafts/issues/2394#issuecomment-380429078 Bug: 884588 Change-Id: I7526bbdbab4cfc31cdfb4c8e1d83450e9d1eee1a Reviewed-on: https://chromium-review.googlesource.com/c/1292874Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#601614}
-
Xiaocheng Hu authored
This patch changes AbsoluteCaretBoundsOf() to take PositionWithAffinity instead of VisiblePosition to decrease the usage of VisiblePosition. It is also a preparation for bidi caret affinity. Bug: 657237, 894651 Change-Id: Ic55c037c058c1fe666ba89cbee502f7d0a74754b Reviewed-on: https://chromium-review.googlesource.com/c/1292726Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601613}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8fd32bf4423..333c890004ba Created with: gclient setdep -r src-internal@333c890004ba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib2e906902fe75024ccd589263f011e7512e99617 Reviewed-on: https://chromium-review.googlesource.com/c/1293711Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601612}
-
Yi Gu authored
This reverts commit 5f3d09d3. Reason for revert: ios-simulator was flaky. I reverted the original patch aggressively because the issue was marked as "tree closers". Relanding it now. Original change's description: > Revert "[iOS] Updating enable/disable items in the Google Services settings" > > This reverts commit 3b62417e. > > Reason for revert: Suspecting this patch caused gclient runhooks failing on ios simulator. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-xcode-clang/58250 > > Original change's description: > > [iOS] Updating enable/disable items in the Google Services settings > > > > "Google activity controls", "Encryption", and "Manage synced data..." > > is enabled when the user is authenticated and disabled otherwise. > > > > Screenshot shared with Chromium accounts: > > + Signed out: > > https://drive.google.com/open?id=19lXF2SdgpLdHUlTZ4WpxipDBdQNCshbU > > + Signed in with consent accepted: > > https://drive.google.com/open?id=1SV3HhbG3hAbre5mSe06Dhjda4dJC4cck > > + Signed in with consent not accepted: > > https://drive.google.com/open?id=1r5umMw6vf8yzh8X7V8V6LzRJVJLq8Rxs > > > > Bug: 883101 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > > Change-Id: I3e2180c83f42adccb2717f2fdb96efa254751bbc > > Reviewed-on: https://chromium-review.googlesource.com/c/1290937 > > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601537} > > TBR=jlebel@chromium.org,sczs@chromium.org > > Change-Id: Iac738ad46478cda09124b37b22b8936a8f8d7e20 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 883101 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/c/1293758 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601580} TBR=jlebel@chromium.org,sczs@chromium.org,yigu@chromium.org Change-Id: I65dadf64329be701eb5df6e99a183de60f9ad3d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883101 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1293996Reviewed-by:
-
Yi Gu authored
The following tests keep failing on Win and Mac. Add them to TestExpectation and add test owner for review. TBR=npm@chromium.org NOTRY=true Bug: 897775 Change-Id: I14898c603e5a280c747b8d016589c3760a172ee4 Reviewed-on: https://chromium-review.googlesource.com/c/1293995Reviewed-by:
-
Marc Treib authored
These tests make sure that the KEEP_DATA/CLEAR_DATA parameter to RequestStop() behaves as expected: With KEEP_DATA, the Sync data does not have to be redownloaded when Sync later gets turned on again. This holds even if Sync starts up in standalone-transport mode in the meantime. Bug: 893496 Change-Id: Ibd2167f201f5b973cadac936fdf6a97036bfc598 Reviewed-on: https://chromium-review.googlesource.com/c/1291393 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601609}
-
W. James MacLean authored
When an OOPIF touch selection controller client invalidates itself, it needs to remove its observer. Otherwise we could end up in a situation where, during shutdown, the manager itself goes away but is still registered as an observer with the FrameSinkManager. Bug: 897616 Change-Id: I9eac1b5d876a1b00784fee7a107dc0777bf624aa Reviewed-on: https://chromium-review.googlesource.com/c/1293750Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#601608}
-
Michael Lippautz authored
Most tests depend on the intercepting scope that sets a temporary visitor and restores the fixed wrapper tracing visitor. Avoid executing those tests with unified heap as they anyways become obsolete after launch. Tbr: haraken@chromium.org Bug: 843903 Change-Id: If106c9c873ab07d1bf2219454a25710a3dab6e2f Reviewed-on: https://chromium-review.googlesource.com/c/1293577Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601607}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/1293559 removed another SI. TBR=dpranke Bug: 897742,94925 Change-Id: I24dccd770fcba4f06bd85c6da7678adc95b40601 Reviewed-on: https://chromium-review.googlesource.com/c/1293795Reviewed-by:
-
Miguel Casas authored
This CL adds a UseCounter for HTMLCanvas lowLatency use cases, to complement said experiment, see the feature entry in https://www.chromestatus.com/feature/6360971442388992 Bug: 895907 Change-Id: I7e81c4f317816b301d0845fc4561c8966000db36 Reviewed-on: https://chromium-review.googlesource.com/c/1293557Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#601605}
-
Eugene But authored
Notable changes: - removed redundant tests from ErrorPageTestCase (error_page_inttest cover these cases) - removed ErrorPageGenerator class - removed ErrorPageContent class - removed code which shows alert for non-printable pages Bug: 725241, 694662, 840489, 859910 Change-Id: I0cad718200a3682633c0babf9b57b45cff39a579 Reviewed-on: https://chromium-review.googlesource.com/c/1289995Reviewed-by:Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#601604}
-
Dianna Hu authored
Add tests for HpackVarintDecoder based on hardwired values. This is in contrast with HpackVarintRoundTripTests that generate input values using HpackVarintEncoder. This allows testing handling of bogus input that HpackVarintEncoder would never generate. NOTE: To comply with Chromium presubmits, this change uses base::size() instead of arraysize. I have added a TODO to create a platform API for array size (such a SPDY API already exists), which I will then use here and backport to Google3. This CL lands server change 214792906 by bnc. BUG=488484 Change-Id: Id697f1cf5f7c1fefe9ae2ce400e9d46e45088c1f Reviewed-on: https://chromium-review.googlesource.com/c/1291815Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601603}
-
Justin Cohen authored
Moves ownership of the NTP coordinator from the NTP tab helper to the BVC. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I470d344778f844145bbd4a615f3753b3980f1614 Reviewed-on: https://chromium-review.googlesource.com/c/1287321Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601602}
-
Fady Samuel authored
Mac no longer needs FirstSurfaceActivation notification so this CL saves an IPC and deletes some unnecessary plumbing. Bug: 893850 Change-Id: Ie8fceb0de65ff9148ff349e8c298eb20be6aa7b5 Reviewed-on: https://chromium-review.googlesource.com/c/1292261 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#601601}
-
Gabriel Charette authored
The Lock is causing hangs because of priority inversion mixed with priority boosting (ScheduleWork() tends to boost the destination thread which may deschedule the posting thread; if the posting thread is a background thread this boost-induded-desched-while-holding-lock can cause a livelock). See https://crbug.com/890978#c10 for example crashes catching this. The Lock was only necessary for startup/shutdown and is being replaced by a lock-free atomic scheme in this CL. MessagePump::ScheduleWork() itself was already thread-safe (but the Android impl did unnecessarily check a non-atomic bool) This adds a WaitableEvent in ~MessageLoop(); hence the requirement for a wait-allowance in net's EmbeddedTestServer. TBR=zhongyi@chromium.org (embedded_test_server.cc side-effects) Bug: 890978, 874237 Change-Id: I0916e5a99035a935b0a23a770af256f334e78c43 Reviewed-on: https://chromium-review.googlesource.com/c/1278631 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Justin Cohen authored
This is in preparation for the BVC owning the NTP coordinator instead of the NTP tab helper, where the PageDisplayState saving logic will soon be removed. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I70e64e9822246a62bd00ab0fc09b167006b4bac5 Reviewed-on: https://chromium-review.googlesource.com/c/1287320 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#601599}
-
Yi Gu authored
TBR=tkent@chromium.org NOTRY=true Bug: 897764 Change-Id: I3a2dee4561c5f7f22436dcc002a5ba6d57a5502c Reviewed-on: https://chromium-review.googlesource.com/c/1293989Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80c6909bf7ee..294861ff957a git log 80c6909bf7ee..294861ff957a --date=short --no-merges --format='%ad %ae %s' 2018-10-22 bsalomon@google.com zero-init preallocated vertex/index space in drawing manager Created with: gclient setdep -r src/third_party/skia@294861ff957a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897409 TBR=brianosman@chromium.org Change-Id: I3beb2578a27feed9699d0e3ef0693548c39c8f2a Reviewed-on: https://chromium-review.googlesource.com/c/1292264Reviewed-by:
-
Scott Violet authored
The bubble implementation no longer needs the parent, instead it uses Screen::GetDisplayForNewWindows(), which is what the code was using parent for before. BUG=756059 TEST=none Change-Id: Ia58b6144cc6133027827f23ab240e094027c9a36 Reviewed-on: https://chromium-review.googlesource.com/c/1292513Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601596}
-
Jaeyong Bae authored
This status code is unused. So, it could be removed. Change-Id: I182eeca626434d8dcadfd35eec32350f081ae828 Reviewed-on: https://chromium-review.googlesource.com/c/1292930Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#601595}
-
Deepanjan Roy authored
This trace event is still actively used by catapult, and since network instrument v2 project is no longer being worked on, we should keep this event. Change-Id: Ia61df9fd01ecbb8bdc440cf76b826fc8e7fb7d68 Reviewed-on: https://chromium-review.googlesource.com/c/1286872Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#601594}
-
jdoerrie authored
This change applies clang-tidy's modernize-loop-convert [1] in /base. Reproduction steps: - run clang-tidy's modernize-loop-convert - run git cl format - manually remove unused constants due to -Wunused-const-variable [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 895746 Change-Id: I17cca09164d7ef795ae221994ecc65ca20abe0f2 Reviewed-on: https://chromium-review.googlesource.com/c/1282406 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fa20b7a3bd3c..8c0d048e784b git log fa20b7a3bd3c..8c0d048e784b --date=short --no-merges --format='%ad %ae %s' 2018-10-22 fmayer@google.com Move heapprofd into perfetto::profiling namespace. Created with: gclient setdep -r src/third_party/perfetto@8c0d048e784b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia7e17b7e3f3a7a41973a9748bec2bcb10c06d9da Reviewed-on: https://chromium-review.googlesource.com/c/1293709Reviewed-by:
-
