GitLab

AtomicOutput does not update file timestamp, and it prevents to invoke additional build steps when the file content is not changed.
This will be affective for some jar related actions. (e.g. mojo/protobuf generator for java)

Bug: 810298
Change-Id: If7b5dd4405214164818b18e49642fb29147667c8
Reviewed-on: https://chromium-review.googlesource.com/1123970Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572194}

This reverts commit e83d1f12.

Reason for revert: https://crbug.com/857437

Essentially, as well as adding if statements to all usages of mMenuButton within the class, you need to add if statements to all other classes calling 'getMenuButton()' (and ToolbarManager.getMenuButton() transitively).

Unfortunately this isn't so trivial for all the cases (eg, I'm guessing we still want to show the data saver when this feature is enabled, or the download text bubble?), so I'm reverting instead of attempting and TBRing a fix myself. Sorry!

Original change's description:
> Don't show top toolbar items when bottom toolbar is enabled
> 
> Remove the top toolbar buttons (home, tab switcher, and menu buttons)
> from their parent view and set them to null. Also add a bunch of
> null checks since now things can be null.
> 
> Bug: 852117
> Change-Id: I620f35f81388d1f4ac8791a9eb45576566474604
> Reviewed-on: https://chromium-review.googlesource.com/1105569
> Commit-Queue: Pedro Amaral <amaralp@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570578}

TBR=tedchoc@chromium.org,amaralp@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 852117
Change-Id: I2c16533f8dec11c5d11b920693157735e7438e89
Reviewed-on: https://chromium-review.googlesource.com/1124579
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572193}

AtomicOutput does not update file timestamp, and it prevents to invoke additional build steps when the file content is not changed.

Bug: 810298
Change-Id: I25fd08b2fb4eed98d25bdaf04437e85236391667
Reviewed-on: https://chromium-review.googlesource.com/1124136Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572192}

AtomicOutput does not update file timestamp, and it prevents to invoke additional build steps when the file content is not changed.

Bug: 810298
Change-Id: I4308ffb0c53325f3e4375ef85e7a8a302a8aac7b
Reviewed-on: https://chromium-review.googlesource.com/1124126
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572191}

LayoutImageResource::GetImage expects a zoomed container size (it passes
it unmodified to SVGImageForContainer::Create which unzooms it), so we
need to scale the viewport size before passing it.

Bug: 859774
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I24f7f0b1f402aaef112882ab146d573981889cae
Reviewed-on: https://chromium-review.googlesource.com/1124163Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#572190}

This is a reland of c0d56727

The fix helps only on Mac and Linux.

Original change's description:
> Fix fake audio setup in WebRTC audio perf tests.
>
> Change them to set up switches::kUseFileForFakeAudioCapture in
> SetUpCommandLine(), so that it can be propagated to the audio process.
>
> Bug: 850936
> Change-Id: Ia6cccc01d2b5fa7545abe8cb1554d72c33146566
> Reviewed-on: https://chromium-review.googlesource.com/1122857
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572142}

Bug: 850936
Change-Id: Ida4f3b888bc0332b68050d6b1cb8a0d5fef3cf32
Reviewed-on: https://chromium-review.googlesource.com/1124519Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572189}

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/957e7756634..2cb075fe26

Contains a fix for Khmer shaping.

Bug: 847034
Change-Id: I0ac1fdf4df69e5c5dd3cc8a877809db99ce40fda
Reviewed-on: https://chromium-review.googlesource.com/1123826Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572188}

Bug:chromium:818319
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I3a7b020744e9fa4ce73ef890ff744da1d0563327

NOTRY=true  # test by PRESUBMIT

Change-Id: I3a7b020744e9fa4ce73ef890ff744da1d0563327
Reviewed-on: https://chromium-review.googlesource.com/1124408Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#572187}

This reverts commit deb4b5a5.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 572182 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RlYjRiNWE1ZjQwMzllMDhkNWE1ZDMxZDVmN2NhMTQzN2I2OGE1ZmQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/68083

Sample Failed Step: compile

Original change's description:
> Reland "[scheduler] Add a perftest to measure basic scheduling costs."
> 
> This is a reland of 586e21ec
> 
> TBR=skyostil@chromium.org
> 
> Original change's description:
> > [scheduler] Add a perftest to measure basic scheduling costs.
> >
> > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452
> > Reviewed-on: https://chromium-review.googlesource.com/1085295
> > Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> > Commit-Queue: Alexander Timin <altimin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#566362}
> 
> Reviewed-on: https://chromium-review.googlesource.com/1097295
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#567645}
> Change-Id: Ia52d89c4321cf4a6d00c51f83ee5b52ea06769de
> Reviewed-on: https://chromium-review.googlesource.com/1122980
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572182}

Change-Id: Ia1c1d4413878bb5101cd696412e630ff3c90b343
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1124540
Cr-Commit-Position: refs/heads/master@{#572186}

This CL adds APIs to IdentityManager for obtaining the set of all
accounts with refresh tokens and querying whether the primary account
is available with a refresh token.

The design follows that of IdentityManager's caching of the primary
account information:
- IdentityManager initializes its state with the current state of
  ProfileOAuth2TokenService.
- IdentityManager updates this state in response to notifications from
  PO2TS that an account's refresh token was updated/removed.

This CL is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1098668 with
the following addition:

In https://chromium-review.googlesource.com/c/chromium/src/+/1098668,
we made the assumption that when IdentityManager receives a
notification from ProfileOAuth2TokenService that a token will be
revoked, it had previously known about that account (either because
the account was available at IdentityManager startup or because
IdentityManager previously received a notification from PO2TS that a
refresh token had been made available for the account). However, as
demonstrated in the linked bug, it turns out that this assumption is
not valid in one case: while loading tokens during startup, PO2TS
sometimes revokes tokens without having previously made them available.
This violation of IdentityManager's assumption causes a crash.

It is not feasible at the current time to change this behavior on the
part of PO2TS, as AccountTrackerService should be made aware of these
events so that it removes the accounts. However, this situation poses
a challenge for IdentityManager: Should it forward on the callback to
its own observers or not? In this CL, we fix the crash and additionally
nail down the semantics that IdentityManager sends token removed
callbacks only for accounts of which it previously knew the existence.
The reasons for making this choice on the semantics are twofold:

(1) Sending an observer callback that a token was removed for an account
that was not previously present in
IdentityManager::GetAccountsWithRefreshTokens() seems like a violation of
the principle of least surprise.
(2) It's not clear that AccountTrackerService will always know about the
account in this case, in which case we wouldn't have the full information
to forward on in the observer callback.

This does mean that
IdentityManager::Observer::OnRefreshTokenRemovedForAccount() is not
strictly identical semantically to
ProfileOAuth2TokenService::Observer::OnRefreshTokenRevoked(). However, we
strongly believe that the only consumer that needs to know about
revocations in this corner case is AccountTrackerService, which will not
be converted to depend on IdentityManager as it lives below
IdentityManager.

TBR=bsazonov@chromium.org

Bug: 806774
Change-Id: I9f77525e26825ab418b15c7d1c2a8e4f8e3b4910
Reviewed-on: https://chromium-review.googlesource.com/1124320
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572185}

Bug: 807724
Change-Id: I87cc7b2909df287ae7e70e8726eac63af2e541ab
Reviewed-on: https://chromium-review.googlesource.com/1120745Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572184}

This reverts commit 4da4a0c8.

Reason for revert: Failing on mac and windows.  I will add more comments to crbug.com/855234

Original change's description:
> Reland "Reland "gtest perf tests: Output well formed test results json""
> 
> This reverts commit 89c5e790.
> 
> Reason for revert: Testing possible fixes
> 
> Original change's description:
> > Revert "Reland "gtest perf tests: Output well formed test results json""
> > 
> > This reverts commit f02c92e1.
> > 
> > Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315
> > 
> > Original change's description:
> > > Reland "gtest perf tests: Output well formed test results json"
> > > 
> > > This reverts commit 9eeaba4e.
> > > 
> > > Reason for revert: Will re-land with fix
> > > 
> > > Original change's description:
> > > > Revert "gtest perf tests: Output well formed test results json"
> > > > 
> > > > This reverts commit 71b865f4.
> > > > 
> > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307)
> > > > 
> > > > Original change's description:
> > > > > gtest perf tests: Output well formed test results json
> > > > > 
> > > > > This CL changes the run_gtest_perf_test.py script to output well formed
> > > > > test results json.
> > > > > 
> > > > > Bug: 855234
> > > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1112635
> > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#570943}
> > > > 
> > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > > 
> > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 855234
> > > > Reviewed-on: https://chromium-review.googlesource.com/1118238
> > > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > > > Cr-Commit-Position: refs/heads/master@{#571083}
> > > 
> > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > 
> > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 855234
> > > Reviewed-on: https://chromium-review.googlesource.com/1118789
> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#571245}
> > 
> > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > 
> > Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 855234
> > Reviewed-on: https://chromium-review.googlesource.com/1119445
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#571321}
> 
> TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> 
> Change-Id: I25bc4bb1f77031d95dd70347bfed886112b76218
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 855234
> Reviewed-on: https://chromium-review.googlesource.com/1120798
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571968}

TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org

Change-Id: I031c5d6204e0b53fa2719168a38292455d676167
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855234
Reviewed-on: https://chromium-review.googlesource.com/1124539Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572183}

This is a reland of 586e21ec

TBR=skyostil@chromium.org

Original change's description:
> [scheduler] Add a perftest to measure basic scheduling costs.
>
> Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452
> Reviewed-on: https://chromium-review.googlesource.com/1085295
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566362}

Reviewed-on: https://chromium-review.googlesource.com/1097295Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567645}
Change-Id: Ia52d89c4321cf4a6d00c51f83ee5b52ea06769de
Reviewed-on: https://chromium-review.googlesource.com/1122980Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572182}

This will be used for orderfile generation benchmarks. More precisely,
they are thin wrappers around the system health benchmarks that make it
more convenient to run orderfile generation.

Bug: 843561
Change-Id: I5d3a2288d4f4a2f74004ef90f3cec0e4b44c7198
Reviewed-on: https://chromium-review.googlesource.com/1124161Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572181}

https://android.googlesource.com/platform/external/perfetto.git/+log/ce3f7b384d77..c56c2429b0f6


git log ce3f7b384d77..c56c2429b0f6 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 hjd@google.com perfetto-ui: Plumb trace_processor to javascript
2018-07-03 hjd@google.com perfetto-ui: Add deferred


Created with:
  gclient setdep -r src/third_party/perfetto@c56c2429b0f6

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I991045dc1e2a17250481a273b50bcd7a53d86b8a
Reviewed-on: https://chromium-review.googlesource.com/1124379
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572180}

https://chromium.googlesource.com/catapult.git/+log/cbfa46069e2b..c61a0380486a


git log cbfa46069e2b..c61a0380486a --date=short --no-merges --format='%ad %ae %s'
2018-07-03 nednguyen@google.com Revert "Only output the total histogram format if there is at least a single page that succeed"


Created with:
  gclient setdep -r src/third_party/catapult@c61a0380486a

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:859073
TBR=sullivan@chromium.org

Change-Id: Iaa7a6b9160b2e0235e160f8014e48b85bc4e2a82
Reviewed-on: https://chromium-review.googlesource.com/1123945Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572179}

As a cleanup, this CL removes ResourceFetcher::AddWarningConsoleMessage() and
instead implements ResourceFetcher::GetUrlsOfUnusedPreloads().

Before this CL, AddWarningConsoleMessage() printed warnings in the console via
an implementation of FetchContext because ResourceFetcher is in platform/ and
cannot access ConsoleMessage etc.

To simplify layering around that, this CL makes ResourceFetcher return URLs of
unused preloads and a caller (i.e., LocalDOMWindow) in core/ print warnings with
the URLs.

Bug: 845285
Change-Id: I241c9567ba79df0ec24f8817cf6045456e44b75b
Reviewed-on: https://chromium-review.googlesource.com/1124137Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572178}

Now NewPasswordFormManager waits for server predictions for 500 ms
before filling (kMaxFillingDelayForServerPerdictions const). But this
const was taken arbitrary. This UMA measure time of receiving credentials
from the password store and server predictions in order to understand
which delay would be right.

Bug: 831123
Change-Id: I42ee476fc949dca63fc7978b94998a20a1ac5e69
Reviewed-on: https://chromium-review.googlesource.com/1120253
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572177}

This fixes a bug where removing a device did not result in stopping all
its associated streams.

A unit test for this requires a minor refactoring to remove the
MediaStreamManager dependency from MediaDevicesManager, and will be
provided in a follow-up CL. This CL is deliberately simple in order to
make merging easier.

Bug: 856658
Change-Id: I84ef2856195cc7650bb08992d2095f8f853e9ea9
Reviewed-on: https://chromium-review.googlesource.com/1124323Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572176}

https://webrtc.googlesource.com/src.git/+log/0ea751539e3a..a8eb1e619eb9


git log 0ea751539e3a..a8eb1e619eb9 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 oprypin@webrtc.org roll_deps: Accept any prefix (like 'git_revision:'), not only 'version:' for CIPD
2018-07-03 ishankhot@fb.com Make ReceiveSendsFromThread use Dispatch
2018-07-03 sprang@webrtc.org Add sprang@ as owner of simulcast.cc/h
2018-07-03 buildbot@webrtc.org Roll chromium_revision a1981d69..f6935ecd (571936:572058)
2018-07-02 emircan@webrtc.org Add VP9 profile negotiation to SDP


Created with:
  gclient setdep -r src/third_party/webrtc@a8eb1e619eb9

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:858978,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ifef1fa58091510e43a491c29a74d787c9667284e
Reviewed-on: https://chromium-review.googlesource.com/1124419Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572175}

ResourceLoader is not used by network service, therefore
Net.HttpResponseInfo.ConnectionInfo.MainFrame and
Net.HttpResponseInfo.ConnectionInfo.SubResource histograms will not be
recorded after network service launches.  This CL obsoletes these two
histograms, and a follow-up CL will add new histograms in the network
service code path.

Bug: 859546
Change-Id: I37e190c1ef060642c08f95314ce52428542a5a2d
Reviewed-on: https://chromium-review.googlesource.com/1122712Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572174}

This reverts commit 6bdafce4.

Reason for revert: This CL is breaking the child ordering of tabs creating with Long Press on a link -> Open in a New Tab. They are now opened after the last page opened with ToolsMenu -> Open New Tab. See crbug.com/859508

Original change's description:
> Pass current tab as opener when opening new tab
>
> Pass the current tab as the opener when opening a new tab.
> This allow selection the previous current tab when the
> tab is closed via "pull-to-close" action or via the new
> "close" action in the UI refresh.
>
> The current tab is passed when tab is opened via ([*]
> denotes that this behaviour is added by this CL):
> - open tab in background
> - "New Tab" menu action [*]
> - captive portal detection [*]
> - search by image [*]
>
> Bug: 661988
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Iecf41a8c0b3cfe465b3ff95a1061c97739b4ed79
> Reviewed-on: https://chromium-review.googlesource.com/1068680
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561427}

TBR=marq@chromium.org,sdefresne@chromium.org,eugenebut@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 661988, 859508
Change-Id: I14e6f2350bad216381224aaf3319018e1c1ffdf1
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1124279Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572173}

This replaces SyncService::QuerySyncStatusSummaryString (which didn't
really make a whole lot of sense in the first place) and
SyncService::GetEngineInitializationStateString (which is now simply
a subset of the new State).

Bug: 839834
Change-Id: I9e3d9785a9bbafe5b8a7397b4a7c6c97acf9adf9
Reviewed-on: https://chromium-review.googlesource.com/1118223
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572172}

This is a prerequisite for switching WindowedNotificationObserver to use
base::RunLoop instead of deprecated MessageLoopRunner. There were two
nested waits for the same notification which does not make sense and
does not work as is with the upcoming change.

This CL was split out from https://crrev.com/c/982612 and uploaded by
git cl split.

R=jochen@chromium.org

Bug: 668707
Change-Id: I217e5ea431d4a58b15ed1eef51a912142124c8b8
Reviewed-on: https://chromium-review.googlesource.com/1120488Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Alexander Semashko <ahest@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#572171}

This adds tests FullStartupSequenceFirstTime and
FullStartupSequenceNthTime, based on the new SyncService::State enum.
To be able to properly test the full flow, this also introduces a
MockSyncEngine (previous tests use a Fake, which bypasses some steps).

Bug: 839834
Change-Id: I145becf840f476d73815526b8abd43a9bfa159b8
Reviewed-on: https://chromium-review.googlesource.com/1118383
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572170}

web_url_request.h is used in 3,600+ compilation units, and this CL
reduces its estimated pre-processed size from 2.82MB to 0.31MB.

Bug: 242216
Change-Id: I60209d15fd6faac4a2bab5696ef307a1b90d6b10
Reviewed-on: https://chromium-review.googlesource.com/1124254Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572169}

resource_client.h is used in 1,600+ compilation units, and this CL
reduces its estimated pre-processed size from 4.04MB to 1.73MB.

Bug: 242216
Change-Id: Iae174451fe424d9765b0ada17c0fef8e9190839c
Reviewed-on: https://chromium-review.googlesource.com/1124269Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572168}

https://html.spec.whatwg.org/multipage/dom.html#html-element-constructors
> 7. Let prototype be Get(NewTarget, "prototype"). Rethrow any exceptions.

As the specification says, we should rethrow. Removing a v8::TryCatch
instance in V8HTMLConstructor::HtmlConstructor() works as "rethrow".

Bug: 854887
Change-Id: I6b2d6ae829453270fe4437a87e65528525c64990
Reviewed-on: https://chromium-review.googlesource.com/1124129Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572167}

Debug data is added to traffic_annotation_auditor_test to search for
win-annotator-rel FYI bot bug.

Bug: 844014
Change-Id: Ie0a8b34cb725b02fad08fbdc4e0918d373b9e1a7
TBR: georgesak@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1123832Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572166}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ce703ef..91a410dd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I009c94e1e7cd6df185ec31651dd7b550546cebfe
Reviewed-on: https://chromium-review.googlesource.com/1124110Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572165}

This patch introduces a new test case for Element#innerText to verify that
result has a collapsed whitespace due by soft line break.

In the test case, the layout object associated to space character between
<span> elements, doesn't have neither InlineTextBox and NGPhysicalTextFragment.
Thus, Element#innerText implementation should detect this and handle it.

Bug: 651764
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia25d06a2a3fe993f2e966188b81f9e9c1d0fe982
Reviewed-on: https://chromium-review.googlesource.com/1124264Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572164}

This reverts commit c0d56727.

Reason for revert: Win tests are still broken :(
https://uberchromegw.corp.google.com/i/chromium.webrtc/builders/Win7%20Tester/builds/43887/steps/browser_tests

Original change's description:
> Fix fake audio setup in WebRTC audio perf tests.
> 
> Change them to set up switches::kUseFileForFakeAudioCapture in
> SetUpCommandLine(), so that it can be propagated to the audio process.
> 
> Bug: 850936
> Change-Id: Ia6cccc01d2b5fa7545abe8cb1554d72c33146566
> Reviewed-on: https://chromium-review.googlesource.com/1122857
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572142}

TBR=hbos@chromium.org,olka@chromium.org

Change-Id: I0a9dffe2824ac3fff218193fabe5caa39cb2a5cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850936
Reviewed-on: https://chromium-review.googlesource.com/1124359Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572163}

We defined two LayoutBox elements list to identify grid items that need
to perform a pre-layout: orthogonal and baseline items. We were
creating these lists as part of the PlaceItemsOnGrid logic.

This design has 2 main problems that lead to bug 855844, and likely
many other:
  * The PlaceItemsOnGrid function is not executed completely if the
grid is not dirty.
  * There might be items in the list that should not be there due to
style changes; also, some should have been added for the same reason.

The simplest and safest approach is to avoid such lists and identify
the items needing pre-layout during the first steps of the grid's
layout logic.

Since style changes affecting either the writing-mode or the Self
Alignment properties of a grid item will force a re-layout of the grid
it belongs to, we can be sure that all the grid items will perform the
pre-layout, if they needed to.

Bug: 855844
Change-Id: I396524b0fc6a4816bcb7962997f129a325c04934
Reviewed-on: https://chromium-review.googlesource.com/1122623
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572162}

This reverts commit 330fc4a1.

Reason for revert: speculative revert to fix views_unittests (https://bugs.chromium.org/p/chromium/issues/detail?id=859829).

Original change's description:
> Make all MacViews windows potentially draggable.
>
> This fixes the PiP window not being draggable on Mac.
>
> Bug: 849983
> Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75
> Reviewed-on: https://chromium-review.googlesource.com/1121145
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572038}

TBR=avi@chromium.org,sdy@chromium.org

Change-Id: Ic1e718a03d272c2c1b4646ead018ad776d03fd18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849983,859829
Reviewed-on: https://chromium-review.googlesource.com/1124299
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572161}

This change modifies base::win::Vector to use ComPtrs in the backing
storage for types derived from IUnknown.

Bug: 821766
Change-Id: Ib531a3e3c15e8cae1ec94de3f11b36d01b7a5acf
Reviewed-on: https://chromium-review.googlesource.com/1120337
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572160}

We tripped over this when adding Unicode 11 emoji. There is no need to
introduce an additional obstacle for characters that the OS or our Emoji
fallback code might already know about but our ICU might not have been
updated yet.

Bug: 850336
Change-Id: I0748ac5b755a2d8c3b92be9c9e21cf96ed75be16
Reviewed-on: https://chromium-review.googlesource.com/1122407
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572159}

Enable the feature by default and remove waterfall config.

R=skyostil@chromium.org,rkaplow@chromium.org
TBR=kenrb@chromium.org
BUG=806271

Change-Id: I20627952407b2cb7926060b5d36d3ef5fa2db60e
Reviewed-on: https://chromium-review.googlesource.com/1102505Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572158}

This CL creates ReadingListCoordinator, which uses UITableViews and
replaces the old UICollectionView-based implementation.

Bug: 805209
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I59acbe85cb389c69462bb72ddb7858acb1249c55
Reviewed-on: https://chromium-review.googlesource.com/1104941
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572157}

https://skia.googlesource.com/skia.git/+log/37774c911e68..d7425b58df89


git log 37774c911e68..d7425b58df89 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
2018-07-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a72f400c5ff3..92da844eb754 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@d7425b58df89

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: I02bdfffe800af4d31a8cad450a8478410422c299
Reviewed-on: https://chromium-review.googlesource.com/1123946Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572156}

This CL adds a unit tests for the unified consent service. The current
tests only covers the non-personalized services. It should be enhanced
to also include the sync-related part once teh unified consent starts
managing the sync state.

This CL also makes the following changes:
* replaces the dependencies of the service on profile_sync_service
with a dependency on the more generic sync_service
* enabled Url-keyed anonymized data collection when unified consent
is enabled.

Bug: 823809
Change-Id: I2ab27429272ecccfbd254ffc4100234ce95623df
Reviewed-on: https://chromium-review.googlesource.com/1122858
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572155}