- 29 Jan, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad90d3c6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6cb70f31f7ed9b10d54402ce47cf35254399ee54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736231}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/821d564bc789..873d0470b40d git log 821d564bc789..873d0470b40d --date=short --first-parent --format='%ad %ae %s' 2020-01-29 kainino1@gmail.com Make a source_set for libshaderc_spvc (#976) Created with: gclient setdep -r src/third_party/shaderc/src@873d0470b40d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I2eb8ab67eacae0f4fa2e76ea9f6c42e3e218e48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736230}
-
Eriko Kurimoto authored
This CL adds upgrade-indecure-requests web-platform-tests for module shared workers "sharedworker-module" is added to spec.src.json and it auto-generates tests. Bug: 824646 Change-Id: I3d75f4b7b1af93c12548331ad46e5f812205ea00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024249Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#736229}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b6bf0b2546f3..5d3173be305d git log b6bf0b2546f3..5d3173be305d --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5146474c..fa85f826 (735951:736081) Created with: gclient setdep -r src/third_party/webrtc@5d3173be305d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8ef6f8a4feef338fd1764ebb6ef65f17d140316c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026927Reviewed-by:
-
Darren Shen authored
Extending by 3mths since we haven't launched the feature yet. Bug: 1043719 Change-Id: I28153a747b57918b73b13e4197fc7684beeaccd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023708 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#736227}
-
Alex Cooper authored
There are currently two separate implementations of the same code. Upcoming refactors to split the installation and consent flow logic from each other will make three implementations. Create a utils file so that the Android runtimes can share the implementation of this method. Fixed: 1046593 Change-Id: I55a20229f0150aea2f27df333245d31094cbee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026651 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#736226}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I32c2947ce269b9bf83057cfe152b3794154b7147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026471Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736225}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e5e522c140a2..94294b48c239 git log e5e522c140a2..94294b48c239 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 tsepez@chromium.org Avoid including string_view_template.h directly. 2020-01-28 tsepez@chromium.org Remove CPDF_Dest::GetRemoteName(). 2020-01-28 thestig@chromium.org Change various CMap code to take a ByteStringView. Created with: gclient setdep -r src/third_party/pdfium@94294b48c239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3fdcbab40660e9deb754212d640c985e46fe3bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026410Reviewed-by:
-
Isabella Scalzi authored
Use |fakeMouseClick| instead of |simulateUiClick| and select the file to open the context menu on using |selectFile| rather than relying on right clicking. Also change |openQuickViewViaContextMenuCheckSelections| to use |fakeMouseClick| as well to see if |simulateUiClick| is the cause. Bug: 1038799 Change-Id: I7de92609e061b62bc351cfb4a5bef3eb0965a21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026548 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736223}
-
sreejakshetty@chromium.org authored
Methods declared in content/public/common/navigation_policy.h |IsBackForwardCacheEnabled()|, |isProactivelySwapBrowsingInstanceEnabled()| are not used outside content/ are exposed in public. Moving these methods to content/common/ API to follow the policy: -> browser process only -> content/browser -> renderer process only -> content/renderer -> browser & renderer process -> content/common Change-Id: I42dd780646f7da832dba9067974ddbd9909fe1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019033 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736222}
-
yilkal authored
This CL prevents users from making multiple requests from the same tab for the same host address. The requests can be repeated by opening a new tab. The requests can be repeated in the next session. Bug: 1045155 Change-Id: If0a7549fe7509ff6ece8c1701e449294a85c56aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020543Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#736221}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/2d483ad845f1..5ef4f21a9 $ git log 1dc01cf32..5ef4f21a9 --date=short --no-merges --format='%ad %ae %s' 2020-01-28 wub gfe-relnote: Introduce kDefaultUdpPacketControlBufferSize and use it in QuicPacketReader as the control buffer size. No behavior change, not protected. 2020-01-28 fayang gfe-relnote: In QUIC, remove largest_sent_packets_ from unacked_packet_map. This only affects QUIC versions with TLS handshake. Protected by disabled gfe2_reloadable_flag_quic_enable_version_t* flags. 2020-01-27 rch gfe-relnote: n/a - Remove the #if MMSG_MORE wrapper around kNumPacketsPerReadMmsgCall in quic_packet_reader.h 2020-01-27 vasilvv Remove quic_bbr2_sender. 2020-01-27 wub gfe-relnote: In QuicPacketReader, change the use of QuicSocketUtils to QuicUdpSocketApi. Protected by --gfe2_restart_flag_quic_remove_quic_socket_utils_from_packet_reader. 2020-01-27 dschinazi Update IETF QUIC to draft 25 2020-01-27 fayang gfe-relnote: In QUIC move NeuterUnencryptedPackets and NeuterHandshakePackets from quic_sent_packet_manager to unacked_packet_map. Refactoring only, no functional change expected, not protected. 2020-01-27 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_delete_send_rst_stream_inner 2020-01-27 renjietang Remove using_default_max_streams_ from QuicStreamIdManager because the manager now has initial stream limit 0. 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_version_negotiated_by_default_at_server 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_log_ack_aggregation_stats. 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_exit_probe_bw_down_after_one_rtt. 2020-01-27 ianswett Deprecate gfe2_reloadable_flag_quic_use_common_stream_check 2020-01-26 bnc Buffer priority values in PRIORITY_UPDATE frames for not yet open streams. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I33f398b4add6b8c7fa86b08396cf4fb893ed41ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025569Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#736220}
-
Jie Jiang authored
Android use ReadRemoteRssi() to get the RSSI value for a connection. Currently we are using GetInquiryRSSI(), which cannot get the correct RSSI value for a connected device, and makes some Android apps unhappy. This change uses GetConnectionInfo() instead. BUG=b:147787450 TEST=Manually test with nRF and Fitbit. nRF can read RSSI value correctly; Firmware update of Fitbit works well now. Change-Id: I0dc13f58f430954772551165009d5ea7f26445c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004429 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#736219}
-
Gabriel Charette authored
TBR=fdoray@chromium.org Bug: 1026641 Change-Id: Id22f4e3e66ce2127e4cec8a9ceddcf63c107abbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026311Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#736218}
-
Sophie Chang authored
Note that I have not exposed the public interface yet since I want to make sure this is sound before migrating consumers over to this method. Bug: 1036490 Change-Id: Id44d5f09a17287a2ba28eb7593ebd41ff082bd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024164Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736217}
-
Ian Barkley-Yeung authored
Noted that two vlog messages in BrokerProcess::Init() are going to be referenced from ChromeOS integration tests, to warn people not to change them. https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2006009 is the CL adding the reference. BUG=chromium:1038463 TEST=tast -verbose run --extrauseflags chrome_internal my_crbook ui.ChromeCrashLoggedIn.* ui.ChromeCrashNotLoggedIn.* with this and 2006009 and 2004088 Change-Id: I4bec0bcdbb9fae631e4311d746fbb68a416f3709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006188Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736216}
-
Hans Wennborg authored
Bug: 1046362 Change-Id: Icdcc5226c4bb0ee6c8d58b33bb70f3494c55313e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026967Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736215}
-
Theresa Wellington authored
Previously, each client of SelectableItemView used <include> to embed modern_list_item_view inside a LinearLayout in their XML hierarchy. This created an odd dynamic where SelectableItemView only worked if the extending sub-class included this layout. In this CL, modern_list_item_view.xml is updated to include the wrapping LinearLayout, and SelectableItemView inflates this layout and attaches it to its view hierarchy, simplifying usage expectations. BUG=1003939 Change-Id: Ibeea314b4579c6b1eaa03e8c1ca60ab8c2010acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024495 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#736214}
-
Nick Diego Yamane authored
This is part of the patch series migrating PlatformEvent to ui::Event (formerly using XEvent) in Aura/X11 in order to eliminate this fundamental difference/incompatibility between Ozone and non-Ozone X11 ports. Design doc [1] describes in details such effort. This CL, particularly, is meant to ensure XEvent => ui::Event translation code (x11_event_translation.{h,cc}) is equivalent to constructing ui::*Event using the PlatformEvent ctors, the mechanism used so far to do such "translation". To achieve it, events_unittests have been modified to use the brand new X11 event translation code as well as fixing discrepancies found along the way. Most of them are trivial and this change does not bring any behavioral change. [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc Bug: 965991 Change-Id: I1b738fd20c21233a611a0661b76da7fcdf176613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022322 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#736213}
-
Daniel Libby authored
This is used internally as ScrollGranularity enum value, so convert from being a double to the real type. Note that we're currently keeping the double version for script bindings of Blink's ScrollState. There is a behavioral change where the ScrollStateInit deltaGranularity is no longer round-tripped correctly but the ScrollCustomization feature was never shipped and no longer being pursued. R=bokan@chromium.org Bug: 1045306 Change-Id: I8092ebe8ee4833f2566b234660b8c4b5880e51f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026468Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736212}
-
Joshua Bell authored
A transaction watchdog timer intended to guard against hung renderers would be scheduled even if the transaction backend still had tasks to perform, which could be blocked on other backend work. The watchdog timer should only be started if the backend is only waiting on the front end. Add the extra condition. Bug: 1045585 Change-Id: I86e978faa9735e1b7a89a10660f1c747237b3c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026109Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#736211}
-
Hiroshi Ichikawa authored
Bug: 1023250 Change-Id: I9105894e5f3544cb52ef686b1abb8753455b3e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022023Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#736210}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1045684 Change-Id: If2cd41468f23949b2b42dda35ebee99a9297ec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023346 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736209}
-
Jimmy Gong authored
- Previously we appended the license to the os-credits page URL. - This is incorrect as we need to create the URL with the license as a reference fragment. eg. chrome://os-credits/#license - Update tests to reflect this. Bug: 1044646 Test: unit + browser tests Change-Id: I0bbb8067cbffdbcd14ab1ff4b37014c8ef7424ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015674 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#736208}
-
David Bokan authored
After r735931, Mac web_tests run with smooth scrolling enabled like other platforms. However, this makes some web_tests flaky. These are proving difficult to find so I'm marking them flaky for now rather than constantly revert/relanding the code changes. TBR=flackr@chromium.org Bug: 944583 Change-Id: Ifdf21c5550bf0982d5d8d4f83a29cff22865f3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026754Reviewed-by:
-
Mitsuru Oshima authored
R=yigu@chromium.org Bug: 1043465 Test: run 100 times and no flaky Change-Id: I64aef46f8f61a5bde32d678a91301f9ea9304b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026508Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima (slow in TOK) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#736206}
-
Andrew Xu authored
This CL adds the metrics which indicate whether the drag on window from shelf ends normally or gets canceled. Bug: 1041609 Change-Id: Ibbbce1b3523558340fe299e3e4ecc139573bba4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023852Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736205}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6148d3266a2..b8692a1901e0 Created with: gclient setdep -r src-internal@b8692a1901e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1012975,chromium:1023913,chromium:1034774,chromium:1039877,chromium:1045987,chromium:927262 Tbr: jbudorick@google.com Change-Id: Iabf5f8a43f7e5040fca0e16ed9d954141582196f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026171Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736204}
-
Andrew Xu authored
When shelf is under gesture scroll, the scroll animation to adjust the scroll offset triggered by bounds change may conflict with the scroll gesture. As a result, user will feel hard to scroll the shelf during bounds animation. This CL prevents scroll animation from being started if shelf is under gesture scroll along the main axis. Bug: 1046568 Change-Id: Ib5d00c457e442e657d928046a4f03a43093f0a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026173 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
tby authored
I've also added jiameng@ as an owner to the metrics while I'm here. Bug: 881215 Change-Id: Ia14c2314775d2e3eaff84334f0aca4edab986757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010597 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
-
nancy authored
TODO: handle context menus for extensions opened in windows. BUG=1038487 Change-Id: I88607aef9465bff272362acb96e17ee370e72607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022585Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Suspected culprit CL: https://crrev.com/c/2006485 TBR=lazzzis@google.com Bug: 1046317, 1046316, 1045729 Change-Id: I44124aeb3d9729bda8eac714998a2ef24de9ad79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026255Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736200}
-
Sophie Chang authored
Bug: 1036490 Change-Id: Ib8bec196e208c0bbb86ec670ba48a7b2c859d565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025914Reviewed-by:
-
Ahmed Fakhry authored
This is a preparation work for adding support for renaming desks. BUG=1040980 TEST=Manual, no change in functionality. Change-Id: Ic5f846a0ef1f8fa6c975ec06a22263ce99107846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026692Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#736198}
-
Christopher Thompson authored
This adds a new interstitial page for the legacy TLS warning. It generally follows the SSL interstitial, but with different strings and a different icon (the (i) info icon). The test interstitial is available at chrome://interstitials/legacy-tls Screenshot: https://drive.google.com/file/d/1MkWCqWKtQwo7k-ybYjKotYJDjTzRwcd0/view This also refactors the legacy TLS browsertest classes slightly, basing them on SSLUITest rather than CertVerifierBrowserTest, brings in the mock cert verifier explicitly. It also adds a SetPolicy() method to SSLUITestBase (to complement the EnablePolicy() method, but for policies that take base::Value types, in this case for the SSLVersionMin policy). Overall, this makes for a slightly simpler class structure and lets us reuse all of the infrastructure setup by SSLUITest (since CertVerifierBrowserTest is fairly simple in comparison). The new cert error is introduced in https://crrev.com/c/1894616. Support for the control site list will be added in https://crrev.com/c/1906779. Bug: 896013, 1039756 Change-Id: Ic3242178239ac8c68d02fe0a2a21a52638146580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940707 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736197}
-
Jongmok Kim authored
In the function ‘Tab:OnMouseReleased’, fix the tab to close only if the mouse event is a middle click. Bug: 947613 Change-Id: I7248b014f9774fe33f49de7f8c8f1ef08cc9d862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024134Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#736196}
-
Lachlan Ford authored
Enables OpenXR as a default VR backend. Change-Id: I620c01a7a674c32874a83d2551f4b1c94663b746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001581Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736195}
-
Robert Ogden authored
Defaults to 1. Bug: 1023485 Change-Id: Ia76fe2e0150b60f3a4e15b5bcdb674de63899c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025570 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#736194}
-
Dan Harrington authored
We are not settings these parameters, and have no plans to set them. Bug: 1044139 Change-Id: I7c024b5bf01fafc8771ea2cd3f511ead085360ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012885Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#736193}
-
Alex Cooper authored
The "RequestSession" flow for a typical VR Session requires bouncing calls through a few asynchronous API's via callbacks. Currently there are four pieces of data which get constantly passed through these callbacks, as they needed at various stages of the request flow. Unfortunately, since a second "RequestSession" request may come in during this asynchronous work, this data cannot just be cached on the VRService class. This change cleans up some of the pattern to make this more readable by creating a struct to hold this data, so that only one object needs to be consistently forwarded around by the code. Bug: 1045130 Change-Id: I4a64eaba2944ddfe4304a20e023acc0100c834f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024267 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
