GitLab

TBR=sky@chromium.org

Bug: 822311
Change-Id: I26c95431a3497795cf7c44ec9663bc152f0d394c
Reviewed-on: https://chromium-review.googlesource.com/963837
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543415}

This CL sets up a common font environment for all tests to run under.  In
particular:
* All gtests and layout tests start with the same font config.
* The font config is isolated from any system font settings.

These changes were necessary:
* Moved fontconfig_util_linux.* into //base so that SetUpFontconfig() could be
  called during common test setup.
* Made DejaVu Sans the fallback sans font instead of Arial (ie the system font
  matched when the font family is set to 'sans').  The gtests used to use DejaVu
  Sans for this font (usually), but the layout tests used Arial.  I sided with
  the gtests in this case because it's easier to rebaseline the layout tests
  than to fix a slew of gtests.
* Added DejaVu Sans Bold to test_fonts.  Some gtests expected a bold default
  font.
* Moved third_party/content_shell_test_fonts to third_party/test_fonts.
* Fixed gtests broken by the new config.
* Rebaselined layout tests.
* Use bundled fontconfig for ChromeOS, matching the behavior on Linux.  (Only
  for desktop ChromeOS builds.  Real ChromeOS builds will still use the system
  fontconfig.)

Additionally, building the fontconfig cache is a nontrivial task.  It can take
~600ms when done from scratch.  To fix this, fontconfig cache files are saved to
the out directory.  Fontconfig initialization takes < 1ms with this
optimization, and the initialization only needs to happen once per test suite,
not at the beginning of each test.  Finally, to prevent the 600ms from being
added to the first test suite to run, the cache files are generated as part of
the build.

The tests still pull in system fonts from msttcorefonts, but those should soon
be replaced by alternatives in third_party/test_fonts.  Once this is done, this
should fix font related test failures caused by differences between Linux
systems or system font configurations.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng;master.tryserver.chromium.linux:linux_arm
BUG=787020,818136

Change-Id: If6bcbd35bddf86dec3f02d105d8be551b898e9b2
Reviewed-on: https://chromium-review.googlesource.com/938578Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543414}

Actually somehow serializing these is going to be more difficult, but
this will at least help to not crash for tests that hit this codepath.

On of several changes towards making uploading blobs with network service work.

Tested in a separate CL because multiple unrelated bugfixes are needed to make this
all work and testable (https://chromium-review.googlesource.com/c/chromium/src/+/963008).

(see also some of the discussion in https://groups.google.com/a/chromium.org/d/msg/network-service-dev/Jby2gkdDhi8/3GURbFqRAAAJ
where the problem of serializing uploaded blobs in history was mentioned)

Bug: 821878, 777879, 761117
Change-Id: Id60791d26bc2f53c79290305cd25f7a95f247a85
Reviewed-on: https://chromium-review.googlesource.com/963015Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543413}

Since Chrome side never knows the identifier of requesting Android
package, pass the package name to Chrome side so that Chrome side can
respond correctly.

Bug: 776476
Bug: b:24572867
Change-Id: I14d29245d43d91bb43d83df0cfae23809d1bfd02
Reviewed-on: https://chromium-review.googlesource.com/954402Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#543412}

It is common for CLs to have no other changes to platform/ aside from creating
or updating a feature. platform/OWNERS review is more or less a rubber-stamp
in such cases. This expedites landing such CLs.

Change-Id: If5ae29e7969f1c9647b0310b28a689be1bf28d18
Reviewed-on: https://chromium-review.googlesource.com/909412
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543411}

Instead, use the size as calculated at compile time.

TBR=afakhry@chromium.org,stevenjb@chromium.org

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I33db6470385597e83c1459a7a9ef803d687568a7
Reviewed-on: https://chromium-review.googlesource.com/961125Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543410}

When sign-in or sync is not allowed by GPO policy,
the sign-in/sync promo should be hidden and
clicking the profile card should direct to
managePeople instead of syncSetup.

Bug: 801383
Change-Id: Id58ae3ffd7dbcca79a9ee42baa0dac6264726031
Reviewed-on: https://chromium-review.googlesource.com/962427
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543409}

Tests either progressed further or actually passed with
ScopedMacViewsBrowserMode.

BUG=817419
TBR=dvadym@chromium.org
Mechanical change to chrome/browser/password_manager/*

Change-Id: I9743ead8bd481e44f279f24b40d7e2f528c2948a
Reviewed-on: https://chromium-review.googlesource.com/963784Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543408}

BUG=817419

Change-Id: I27a6cbcd664f9de0a3f1c05cdb6b682c4ad9e64f
Reviewed-on: https://chromium-review.googlesource.com/963299Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543407}

Remove Download.DatabaseInvalidState, it's not used and not in
histograms.xml.

Bug: 642288
Change-Id: I586701a9e20f10e483bb4b3b524eefafed5ea0c2
Reviewed-on: https://chromium-review.googlesource.com/963692Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543406}

Bug: 820161
Change-Id: I5a458a374890a285daa594b3c2ca72a821d2f93a
Reviewed-on: https://chromium-review.googlesource.com/955891Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543405}

TBR=mfoltz@chromium.org

Bug: 822300
Change-Id: Ie6f6ab2d24a28c7fab95764185f6e548aae23cd2
Reviewed-on: https://chromium-review.googlesource.com/964543Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543404}

Also add some helpers to allow running the gl_tests with EGL / GLES2.

BUG=584248
TEST=gl_tests --gtest_filter=*GpuOESEGLImageTest.EGLImageToTexture*

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5177062eb7c28b59fc2684ef7fc665271b53c12d
Reviewed-on: https://chromium-review.googlesource.com/958908Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543403}

The PreconnectManager issues preconnect requests only after it
preresolves a host name. If a fixed proxy configuration is in place,
there is no need to make a DNS request.

Bug: 808036
Change-Id: I15f6baf6405386fd6bd8154b2691c5b858c6e04b
Reviewed-on: https://chromium-review.googlesource.com/958913Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543402}

In this change, I've added a backplane over which we have a different
cursor appearance. Dragging on this backplane will cause the content
quad to be repositioned. Further, if you drag beyond a threshold, the
repositioning takes effect immediately when the button is released.
This allows for very easy drag-and-drop repositioning while still
permitting clicking to get into a persistent resize mode.

Bug: 963001
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I265e2d8b187893eb07053a005cb02e6b3edfcc16
Reviewed-on: https://chromium-review.googlesource.com/963672
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543401}

Clean up {Hid, Ble}Device by consolidating shared constructs and
rename constants with prefix U2f to have prefix Fido. More specifically,
 1) Consolidate HidDevice::State / BleDevice::State into U2fDevice
    interface.
 2) Rename BLE constants (e.g. service id) to have fido as prefix.
 3) Move U2fDevice::ProtocolVersion to fido_constants.h
 4) Delete u2f_command_type.h file. This contents in this file is
    neither U2F nor correct. U2fCommandType enum currently mixes
    HID command type and BLE command types. Remove the file and
    add separate command type enums in fido_constants.h

Bug: 821215
Change-Id: I45bce9323ac95d83c31e7b90a2548b745d9e00b2
Reviewed-on: https://chromium-review.googlesource.com/961618
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543400}

Traffic annotation auditor checks that test annotationa are only used in
test files with whitelisted keywords in file path.
File path white list checking is updated to accept wildcards.

Bug: 690323
Change-Id: I5ccde0bb3d449fa75667bf1b293bd533fdfcd2c0
Reviewed-on: https://chromium-review.googlesource.com/947945Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543399}

The process of fixing these tests uncovered a real bug in the Cocoa
BrowserActionsContainerView: it was always resizable even when highlighting.
This change:

1) Fixes that bug;
2) Adds an abstract CanBeResized test helper;
3) Implements that test helper for Cocoa and Views windows;
4) Marks the two drag & drop tests as Views-window-only, since the mechanics of
   drag & drop aren't exactly compatible between the two platforms.

Bug: 817408
Change-Id: I3a1316df05ff5aa1b3ae29c815fec6bac8062ad1
Reviewed-on: https://chromium-review.googlesource.com/963289
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543398}

Too many SavePageLaterCallback functions caused problems in
jumbo builds. Since two of the three were just empty functions
this patch replaces them with base::DoNothing()

Change-Id: Ie9c939ee10674cdab77aab0a9ade65d70293fb0c
Reviewed-on: https://chromium-review.googlesource.com/964441Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#543397}

Using wpt-import in Chromium e9aa1b1b.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13871

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org, ksakamoto@chromium.org:
  external/wpt/css/css-font-loading

TBR=lukebjerring

No-Export: true
Change-Id: I8a7a897ab34c8fc16b4af15d3993b5b4f9ab6cc3
Reviewed-on: https://chromium-review.googlesource.com/964254
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543396}

This Origin class is better than nothing however I feel more tests will
need to be added.

Bug: 821795
Change-Id: I069cf3556af12268f5ae97b8cda0634800f3112c
Reviewed-on: https://chromium-review.googlesource.com/963325Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543395}

Move all encoding/decoding/request specific logic in U2fDevice interface
to U2fRequest interface.

Bug: 810229
Change-Id: I62c721fcfe5be2c3efc1bfd87920ef020ad60198
Reviewed-on: https://chromium-review.googlesource.com/927105
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543394}

Merge the screenshot descriptions produced by the instrumentation tests
into a single description. If the tests are run locally print a link
to this description, if the are run remotely add a link to the
description to the json file produced by test_results_presentation

Change-Id: Ia9dd491460633148283bed66949cec47a410dea3
Reviewed-on: https://chromium-review.googlesource.com/952972Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Anthony Berent <aberent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543393}

FindIt identified the following test as flaky:
    BackgroundFetchBrowserTest.OfflineItemCollection_VerifyIconReceived

Let's disable it while we figure out why it's flaky.

TBR=nator
NOTRY=true

Bug: 822276
Change-Id: Ibe4ecd89cc30cdf54fda474a2bed960e599557b0
Reviewed-on: https://chromium-review.googlesource.com/964443Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543392}

This CL does a few things:
1. Replaces HashPrefixMatches which was implemented with a custom binary
   search with a custom iterator and std::binary_search.
2. Adds a perftest stress testing this method.

Running the perftest before and after the binary_search change shows that
using binary_search improves performance by 30-40%. This was measured
on Linux using a release (non-official) build.

It is also imo a code health win, as an iterator is easier to reason
about than a custom binsearch algorithm.

Bug: 787092
Change-Id: Ic8be26b11ef750c70ee241dfb2718a3c0855fc8c
Reviewed-on: https://chromium-review.googlesource.com/959623
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543391}

- Crashing frequently so disabling as per the other tests in this
class.

TBR=hbos@chromium.org

Bug: 800465
Change-Id: I40a62fce9a353902525e1e3f69adc573b6d00334
Reviewed-on: https://chromium-review.googlesource.com/964521Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543390}

This CL customizes the deletion animation for tab grid cells via the
standard UICollectionViewLayout APIs.

Animation is done by adjusting the final layout attributes of the cell
in -finalLayoutAttributesForDisappearingItemAtIndexPath:. Because cells
may disappear for non-deleting reasons, the layout also needs to track
which cells are being deleted during each update cycle.

Bug: 804553
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8566a5aff832ac8844d2d89639599b1b2372a27d
Reviewed-on: https://chromium-review.googlesource.com/964223Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543389}

This CL creates the custom selection control for the tab grid and
wires it into the TabGridViewController.

There are extensive comments in the TabGridPageSelector class.

Some things to note:

* Labels are used in place of assets for now.

* Dragging the slider in the control isn't possible yet.

* The view controller doesn't yet update the tab counts in the control.

Bug: 804500, 804581
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If561619091271b7086989f68bb76edb5bd64c16b
Reviewed-on: https://chromium-review.googlesource.com/962791Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543388}

This class is in charge of uploading a single WebRTC event log
to the Crash server.

Upcoming related work:
* Update chrome://webrtc-logs
* Fix the known issue where the log is read into memory in its
  entirety prior to initiating the upload.
* Compress the log on disk while writing.

Bug: 775415
Change-Id: Ie5713143b3bc532ac07dd830aecf927698577f18
Reviewed-on: https://chromium-review.googlesource.com/958511Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543387}

Bug: 816620
Change-Id: I25d8b9d627578946a6c4adb2c220c9401f21c59b
Reviewed-on: https://chromium-review.googlesource.com/959677Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543386}

We were previously using the "experimental" field in the JSON returned by
`git-cl try-results`, but that field actually corresponds to whether a
recipe is running in experimental mode. See e.g.

    https://cs.chromium.org/chromium/infra/recipes-py/recipe_modules/runtime/api.py?q=is_experimental&sq=package:chromium&l=27&dr=CSs

What we need is the "cq_experimental" tag that really indicates whether a
trybot is scheduled in an experimental commit queue per

    https://cs.chromium.org/chromium/infra/go/src/infra/libs/bqschema/buildevent/completedbuild.go?type=cs&sq=package:chromium&l=31

This tag is also used by the Buildbucket Gerrit plugin to split bots into
experimental and non-experimental ones.

Bug: 792652, 821445
Change-Id: I267bf033729b6a74382d018cb3da06c64dc7b207
Reviewed-on: https://chromium-review.googlesource.com/964121Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#543385}

The previous [Bool|Int|String]SyncStat classes relied on raw pointers
into base::ListValue, which is bad because they become invalid when
the actual std::vector backing the list gets resized. They're replaced
by new SectionList/Section/Stat classes that are less fragile.
While we're here, this also updates the code to use the new base::Value
APIs, i.e. using values instead of unique_ptrs.

Bug: 702230
Change-Id: I5da50857587acb50ffb8849a7fa2cf8dabce9e45
Reviewed-on: https://chromium-review.googlesource.com/955324
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543384}

Use --disable-features=FixAltGraph to return to the old behaviour.

Bug: 25503
Change-Id: I1297812b5c6201d84b46ae4f4b320ed5e403f7a1
Reviewed-on: https://chromium-review.googlesource.com/963790Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543383}

The patch uses Node::isConnected() and Document::IsContextDestroyed()
predicates to compute whether a Node is detached or not. This information
is then propagated to all ScriptWrappables.

DevTools shows detached nodes with the "Detached" prefix. For example,
"Detached HTMLDocument" or "Detached Window".

Bug: 811925
Change-Id: Ib7987f578cc513b6bdfcfe084c885cbff84a4dba
Reviewed-on: https://chromium-review.googlesource.com/961401
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543382}

This CL adds TCP socket API to network service.
This is partly based on mandoline implementation
(https://codereview.chromium.org/1873463003/)

Two TCP socket interfaces are added.
- TCPConnectedSocket
- TCPServerSocket

Change in reland:
- Removes TCPSocketTest.ReadAndWriteMultiple because
  base::RunLoop().RunUntilIdle(), when used in conjunction with the rest of the
  test logic, times out sometimes on iOS bot. We have a better
  version of this test (ReadAndWriteMultipleWithMockClientSocket) written using
  mock sockets. See crbug.com/822058

R=mmenke@chromium.org
TBR=miu@chromium.org
TBR=tsepez@chromium.org

Bug: 721401, 822058
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I71cde7f2a16d022e888d62a6fec3d4fd5917b6e9
Reviewed-on: https://chromium-review.googlesource.com/964250
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543381}

This is not strictly required for issue 797292 (filesystem:
support with network service), but it should make that implementation
slightly more efficient and better to land in its own CL.

Bug: 797292
Change-Id: Ia6a20ded0f0c414d632530805bc3ae3eb3053328
Reviewed-on: https://chromium-review.googlesource.com/960922Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543380}

Add unnecessary value containing "DEFAULT" in the name just to
make ProtoBestPractices check happy.

Bug: 704091
Change-Id: I99e62d9d711eef17a783408c0fbe62b115b7ac68
Reviewed-on: https://chromium-review.googlesource.com/951249Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543379}

This reverts commit 901d5088.

Reason for revert: Didn't address concerns of where this API should live. In particular DNWA isn't the right place, it should be on Widget.

Original change's description:
> Ignore window [de]activation in content_browsertests.
> 
> These events can happen when another test starts or finishes and cause
> frame/widget focus state changes, breaking some tests.
> 
> Bug: 695054
> Change-Id: I9ab6b3887c00421d4c6f96dd508e912b23706176
> Reviewed-on: https://chromium-review.googlesource.com/926368
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru>
> Cr-Commit-Position: refs/heads/master@{#543328}

TBR=sky@chromium.org,dcheng@chromium.org,jam@chromium.org,dpranke@chromium.org,ahest@yandex-team.ru

Change-Id: Ia3b8b9eabb4463ddcd22e81cec1f5ee7fffa639e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 695054
Reviewed-on: https://chromium-review.googlesource.com/963658Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543378}

This reverts commit e0de6d37.

Reason for revert: Speculatively reverting to try and fix compile error:

https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/133884

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FAndroid_Builder%2F133884%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout


Original change's description:
> webrtc-internals: dont repaint invisible graphs
> 
> avoids repainting stats graphs that are not visible.
> Visibility is determined as described in
>   https://stackoverflow.com/a/21696585/4352772
> 
> BUG=678292
> 
> Change-Id: Ib7ac623f8d961359e4915b3f5580734fb1328bec
> Reviewed-on: https://chromium-review.googlesource.com/602270
> Reviewed-by: Tommi <tommi@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543372}

TBR=tommi@chromium.org,hta@chromium.org,philipp.hancke@googlemail.com

Change-Id: Id9328a3cc5275ae2143243055f575e142c88d943
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 678292
Reviewed-on: https://chromium-review.googlesource.com/963657Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543377}

This reverts commit 9eaaf8d9.

Reason for revert: Speculatively reverting to try and fix compile error:

https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/133884

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FAndroid_Builder%2F133884%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original change's description:
> webrtc-internals: only highlight currently active connection
> 
> and remove the class from any past ones.
> 
> BUG=678292
> 
> Change-Id: I5a3bc354f45363573ed8604fbbc27ee2530faa66
> Reviewed-on: https://chromium-review.googlesource.com/615500
> Reviewed-by: Tommi <tommi@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543371}

TBR=tommi@chromium.org,hta@chromium.org,philipp.hancke@googlemail.com

Change-Id: Ibaa7ea4489e195b39180ad24efdb21796e285faf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 678292
Reviewed-on: https://chromium-review.googlesource.com/964394Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543376}