- 23 Nov, 2020 40 commits
-
-
Jérôme Lebel authored
-[SceneController openUrlFromSettings:] is only used by -[SceneController closeSettingsUIAndOpenURL:]. So the code from |openUrlFromSettings:| is moved into |closeSettingsUIAndOpenURL:|. Change-Id: Idd6c58f0d813f3b6412148e21d424ec9c4567c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550813 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830166}
-
Henrik Boström authored
The investigation of https://crbug.com/1148964 has concluded, the bug fixed, and this crash is no longer reproducible. Cleaning up these CHECKs that were added during the investigatiton of that issue. Bug: chromium:1148964 Change-Id: I45cd82bcfd8ec12c455927cd12f622e09f895e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552398Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#830165}
-
Victor Hugo Vianna Silva authored
Instead of writing METHOD_NAME(_, ..., _) when matching a method call, one can simply use METHOD_NAME. The CL applies this change for the following directories owned by the sync team. components/sync components/sync_device_info components/sync_user_events components/browser_sync components/sync_preferences components/sync_sessions ios/components/webui/sync_internals components/history/core/browser/sync components/password_manager/core/browser/sync ios/chrome/browser/sync chrome/browser/sync chrome/browser/ui/sync chrome/android/java/src/org/chromium/chrome/browser/sync chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync ios/web_view/internal/sync components/sync_bookmarks chrome/browser/sync Bug: None Change-Id: Ic85900a04304ad53cd9c39d448495db32e5a0282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552399Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#830164}
-
Nikita Podguzov authored
* For DlpRulesManager the variables are replaced by base::MakeFixedFlatMap * For DlpContentManager the variable is replaced by std::array Bug: 1151356 Change-Id: Ibd38634040743e78178932c4bb368f99af22be72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550832Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#830163}
-
Morten Stenshorne authored
TBR=ikilpatrick@chromium.org Bug: 1151880 Change-Id: I1476157ac973a53d753f6c517943e78cdf8acd39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552400Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830162}
-
Rainhard Findling authored
Removes kPasswordsCompromised, kExtensionsReenabledByUser, and kExtensionsReenabledByAdmin from the SafetyCheckHandler. Those are no longer used, since the WebUI strings are nowadays constructed directly in C++ and are sent to UI in WebUI updates. Bug: 1015841 Change-Id: I76baf7916c9fcafab7a0e3aee6b9c2abe3ca151f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552782Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#830161}
-
Philipp Hancke authored
GICE was removed in M43 BUG=webrtc:4299 Change-Id: Ia993601e16948de380ed968e3d1ead2e5bf7a34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552868Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#830160}
-
Alex Ilin authored
This reverts commit e9391ceb. Reason for revert: causes failures on Lollipop Phone Tester https://crbug.com/1151882 Original change's description: > Don't call restoreTabs(false) on background thread > > The TabState replacement CriticalPersistedTabData makes the assumption > that it is called from the UI thread. This is not the case in for > restoreTabs(false) which is explicitly called on the background thread > and causes the new Tab persistence system to crash. After a deep dive, I > determined that restoreTabs(false) is equivalent to loadNextTab() > because all the code in restoreTabs is skipped except for loadNextTab() > (since setActiveTab is false). After studying loadNextTab() I found that > the 'heavy lifting code' (e.g saving, deletion) is explicitly called > on the background thread so calling loadNextTab() or restoreTabs(false) > from the background thread is not necessary. Calling loadNextTab or > restoreTabs(false) from the UI thread will not cause a performance > regression as the 'heavy lifting' code is already delegated to the > background thread and in doing so will result in the correct consumption > of CriticalPersistedTabData. > > Bug: 1148972 > Change-Id: I15cfd90125039cf957b88148881765a59fda4556 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548503 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: David Maunder <davidjm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829318} TBR=mpearson@chromium.org,nyquist@chromium.org,dtrainor@chromium.org,davidjm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148972 Change-Id: I0542f6655a1e592d3d070462d5a02734b660a299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553425Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830159}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I46b4f9df894545d5269a016218b9365b27ed7561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830158}
-
Jan Wilken Dörrie authored
The move of StrongAlias to the base:: namesapce introduced a minor error to the Blink C++ Style Guide. This change fixes this. R=pkasting Bug: None Change-Id: I81e28b23d9ad4dc2c90189588afe13720e1226d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554572 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#830157}
-
Maksim Moskvitin authored
This CL adds a simple throttling mechanism for requests towards vault service: once a request is failed due to potentially transient error (i.e. the error that doesn't require fixing the local state), following request for the same account are throttled for a fixed period of time (controlled using FeatureParameter). Throttling survives browser restarts, but handles system time changes. Bug: 1102340 Change-Id: If31831749e1795f2273a5067279ee8218b032111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526067 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#830156}
-
Clemens Arbesser authored
There was a request by our translators to increase the char limit. According to #32 in the linked bug, removing this char limit should be ok because line wrapping in ChromeBasePreference is supported. Bug: b/173131782 Change-Id: Ife1e915e5a7a15a09f6dc354c527a067969bce13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554570 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#830155}
-
dpapad authored
There were 2 separate (but related) bugs in |getPageAtY_| 1. The |y| position could be larger than the bottom of the last page in the document due to fractional pixel values. Previously the function erroneously returned the first page (index 0) as the result, instead of returning the last page. 2. The |y| position could be larger than the bottom of the last page in the document due either the presence of a horizontal scrollbar, which causes the viewport to grow by the thickness of the scrollbar (usually 15px), or due to a zoomed out viewport. Again the first page was erroneously returned, instead of the last page. With the above fixes: - A user noticeable error in the page indicator field is fixed. - An assert() statement has been added in getMostVisiblePage() which would have caught the original bug in the first place. Bug: 1150339 Change-Id: Ic93e6f0da751840343ba706280db68d8b96d5f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546486 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#830154}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3583a63a0f86..1810c4a6af75 2020-11-23 wolfi@chromium.org [TS] Port BottomUpProfileDataGrid.js to TypeScript 2020-11-23 mathias@chromium.org Remove custom Array.prototype.partition 2020-11-23 janscheffler@chromium.org [Recorder] Enable recorder test again 2020-11-23 petermarshall@chromium.org [typescript] TypeScript-ify source_frame/SourcesTextEditor.js 2/2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a9f0bd50501af0fae78abf56646108956beebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553900Reviewed-by:
-
Colin Blundell authored
Safe browsing errors are currently folded into the OTHER_ERROR type by Navigation#getLoadError(). In fact, embedders need to be able to distinguish safe browsing errors from other types of errors. To do so, this CL introduces a new SAFE_BROWSING_ERROR load error type and configures the implementation to send this error type on safe browsing errors. Bug: 1149955 Change-Id: Ic70620ace6ebc79575f19dfe39898c9682146193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551118 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#830152}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic7e3f55119dd266d166ca9a40c382b386de13754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549442Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#830151}
-
Vidhan authored
The AlternativeStateNameMap is used: 1. In Filling of state selection boxes 2. For comparison of profiles 3. Merging profiles that are similar. 4. Determining ADDRESS_HOME_STATE votes to be sent to the server. Bug: 1111960 Change-Id: I2bff7888b1563655c0aecea3c1ad680da6cb9b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471396 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#830150}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eaff47190b82..33ae0b2d78ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hendrich@google.com Change-Id: Iee8405702d5514d9cf2540f06bc0335035f21621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830149}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d33d0fe9. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I23c5ca438bfb15628b3f650e13e84a137ee5ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551403Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830148}
-
Jan Wilken Dörrie authored
This reverts commit d3d9bac0. Reason for revert: https://bugs.llvm.org/show_bug.cgi?id=48048 got fixed. Original change's description: > Revert "[base] Add NO_UNIQUE_ADDRESS attribute" > > This reverts commit d3742a4b. > > Reason for revert: https://crbug.com/1144431 > Bug: 1144431 > > Original change's description: > > [base] Add NO_UNIQUE_ADDRESS attribute > > > > This change adds the HAS_CPP_ATTRIBUTE and NO_UNIQUE_ADDRESS macros to > > base/compiler_specific.h. This allows using the C++20 no_unique_address > > attribute in prior dialects if the compiler supports it. > > > > Bug: None > > Change-Id: I6aff82e7b195f5eaf93551049c9dfa6a3fd1fbc6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510396 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822768} > > TBR=dcheng@chromium.org,jdoerrie@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: None > Change-Id: I375099e835dbc7d4cab98cc15faf66124335bb0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514208 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823202} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144431 Bug: None Change-Id: Ieffa10dce233eb19f7dbfbcea449ea08e2f2b1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546008Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830147}
-
Robbie Gibson authored
Before, when switching to incognito using the Thumb Strip, the BVC ended up having a frame.y = 36 (or some other non-zero constant). It looks like the BVC is currently positioned by frame, and my guess is that somehow, the position of some other element + constraints caused the BVC's frame to change after it was set. However, the BVC's frame could be set by constraint, as it should always be that value. Bug: 1094335 Change-Id: Iedeedadf7ac7c7e842ebe4af02d8e62ed3b6a7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549947 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Henrik Boström authored
CL 2551665 fixed a bug relating to SampleBufferTransformer's fast path not considering IOSurface-less pixel buffers and added test coverage that the fast path always outputs a pixel buffer with an IOSurface. However, in CL 2551665 these IOSurface-less pixel buffers are created without content; CreateSampleBuffer is ignoring the RGB values. This CL addresses that and improves the test coverage, but because we pass all the tests, this CL won't have to be backmerged to M88. It's a testing-only change. This CL: - Creates IOSuface-less pixel buffers in the specified color. - Verifies that both the "pixel transfer" path and the "libyuv" path are able to scale IOSurface-less pixel buffers and that the color is correct. - Verifies that regardless of technique we output an IOSurface-backed pixel buffer. With this CL, all possible camera output formats are both supported and well tested. Bug: chromium:1148964 Change-Id: Ic016e3109de42d73a39b5a7e0a155b56c87e0cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553551Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/805e8b59..847989b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6c2f527a04f26c52d28d2e5e42f005eefca918d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553871Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830144}
-
Henrik Boström authored
When the M88 cut was made, the kDefaultBufferPoolSize was 10. While investigating https://crbug.com/1148964 we disabled and then re-enabled the InCaptureConvertTnoNv12 feature and along the way changed the pool size to 5 (trying to see if the issue was related to running out of handles, but that wasn't the case). To ensure M88 and Canary uses the same pool size, this CL restores the old pool value to 10. If we decide to change the pool size we should do that in a separate easily back-mergeable CL, but there have been no signs yet that 10 is too many. Bug: chromium:1148964 Change-Id: Ib122ca1ed9ca061951ee5d77dfa3ddbd84d90f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553548 Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606089386-838f65aaa60be12e40b29c2cb3db20695d2661d9.profdata to chrome-win64-master-1606110698-fe2030373d9d56b0c47d89f10e41d9fcfb737790.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I002d0228f7fdc1cdfd23aeb56767169120d2fda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554419Reviewed-by:
-
Tanmoy Mollik authored
This reverts commit d26915b9. Reason for revert: Tests still failing Original change's description: > Reland "[Test] Refactor BookmarkPersonalizedSigninPromoDismissTest" > > This is a reland of f4a2ff7e > > The cl was reverted because testPromoNotShownAfterBeingDismissed and > testPromoImpressionCountIncrementAfterDisplayingSigninPromo were flaky. > > After looking into more details about why the tests are flaky it seems > that SyncTestRule calls > NativeLibraryTestUtils.loadNativeLibraryAndInitBrowserProcess() as part > or rule set up. Other tests like BookmarkBridgeTest and BookmarkModelTest > uses ChromeBrowserTestRule which also calls this method during rule > setup. Changing AccountManagerTestRule to ChromeBrowserTestRule should > fix it. > > > Original change's description: > > [Test] Refactor BookmarkPersonalizedSigninPromoDismissTest > > > > Refactor BookmarkPersonalizedSigninPromoDismissTest to use > > AccountManagerTestRule and ChromeActivityTestRule instead of > > SyncTestRule so that it can be batched easily. > > > > Bug: 1145843 > > Change-Id: Ia005508ccd84c439b04b25a65af0930b5a15ee0e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527021 > > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > > Reviewed-by: Alice Wang <aliceywang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827278} > > Bug: 1145843 > Change-Id: I261da247b78cd33d2314be6aa40668a9dcdafa98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540669 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828412} TBR=treib@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145843 Change-Id: Ifdd6babc6ded7b5f1fc98c07eb0a8f0a17f1189f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553424Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830141}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a304f111386d..9304577415d5 2020-11-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bfc1b42f to a41860e8 (83 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ibf4f0af477106361ad3aaebefc8d43ecc21306e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554415Reviewed-by:
-
Kevin McNee authored
g_oom_handling_function is currently declared static in a header file, meaning that each translation unit that includes it gets a separate instance of it. This is set in partition_alloc.cc and called from partition_root.cc, so this function will never actually be called. We make g_oom_handling_function extern so that we read and write the same instance of the variable. Bug: None Change-Id: I92488bb7f9898961d719bb60270bdd9b846cf81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549466 Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830139}
-
dpapad authored
Also change parse_html_subset.js to initialize the parse-html-subset TrustedTypes policy lazily, only when it is actually used, to avoid having to allow that policy in the CSP configuration on the C++ side for cases where parse_html_subset.js is just a transitive dependency and not actually used (which is the case for chrome;//view-cert). Bug: 1149868 Change-Id: I1a8f32f3289f6068c0eafbb80cdc046451fc028e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544067 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#830138}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cb4bb2088ad7..844c1542a1f4 2020-11-23 landrey@google.com Speed up upload status info requests that require full info If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1122516 Tbr: sadrul@google.com Change-Id: I8d853eacb610155dbc8af2df2631759bd24a46a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553110Reviewed-by:
-
Ian Barkley-Yeung authored
Prevent duplicate and unwanted JavaScript error reports by: * Allowing pages that report errors in other ways -- or that we just don't care about -- to disable WebUI JS Error Reporting. * Blocking reports from other frames. If a WebUI page has an iframe containing another WebUI page, both WebUIMainFrameObservers will see the errors for either page. Only report errors for the main frame of this WebUI. * Blocking non-chrome:// URLs. WebUI pages with chrome-untrusted:// frames may host non-Chrome content which we don't want error reports from. This is the heart of "step 5" in the design document. Remaining work includes calling DisableJavaScriptErrorReporting for the essential apps & essential inputs that would otherwise double-report, and possibly carving out exceptions from these blockers for pages that have a good reason (such as chrome-untrusted:// pages that still expect to only serve up Chrome-owned content.) Bug: chromium:1121816 Change-Id: I57005c9a85b5700ead7d1123627191f1cbfda33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535490Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#830136}
-
Henrik Boström authored
In https://crbug.com/1148964 it was discovered that assumptions that SampleBufferTransformer was making did not always hold. For example, SBT assumed that if the camera produced pixel buffers then those pixels buffers would contain IOSurfaces, but this was not always the case. This was fixed so now I'm looking at other assumptions. Similarly, SBT assumes that if the camera produces a SampleBuffer that doesn't have a pixel buffer, this must be the MJPEG case. This CL promotes a DCHECK for this into a CHECK so that we don't run the risk of having hard-to-debug crashes happening if there are any cameras out there in the wild where this does not hold (hopefully not). Bug: chromium:1148964 Change-Id: I3e063dd7ed48962d31c7fd46a9a66de7e8337498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554597 Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34a1660229e0..3583a63a0f86 2020-11-23 mathias@chromium.org TypeScriptify platform/utilities.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie568986f4141eab51af0d63754b1e060e3e81c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553893Reviewed-by:
-
Alexander Hendrich authored
TBR=yukishiino@chromium.org Bug: 1151861 Change-Id: I5ffe50d52c18ba5126ea644d8dd40619ba778405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554562 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830133}
-
Nazerke authored
This CL updates the switch to the active webstate according to the tapped tab in the TabStrip. This CL doesn't update the tabstrip UI, i.e doesn't highlight the selected tab. Bug: 1128249 Change-Id: I89041c22d27df2d171821c6d5fc7342c99ab06db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550711Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#830132}
-
Fredrik Söderqvist authored
The new class DrawInfo packages the various parameters used when drawing an SVGImage - container size, zoom and URL. The intent is to reduce the amount of arguments that needs to be passed around as well as prepare for better (more centralized) handling of the container size to get better control of the various representations used (FloatSize, LayoutSize, IntSize). Also move DrawNeedsLayer() closer to its user and perform minor tweaks to DrawPatternForContainer() (reorder matrix setup; return PaintRecord directly to MakePaintRecord). Change-Id: Id231682c9d85a322a3c585a75b2793a68628c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550915Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#830131}
-
Clemens Arbesser authored
Before this change, the progress bar for trigger scripts would flakily not show the progress correctly due to missing change notifications. Bug: b/173790448 Change-Id: I4bb51ceee69f81ad41d69739a20f0c4b1e38d60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550918 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Denis Kuznetsov authored
This call was only used to update passwords for legacy supervised users. Bug: 1150430 Change-Id: Ib313d42f103aeebbf845570443c8dfaddaf92de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550904 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830129}
-
Daniel Hosseinian authored
Bug: 1026195 Change-Id: I6bd42a7c4611dac978f812af701317c5f50660f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553870 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
By default, absl/flags are disabled on mobile platforms. This is a problem for some test binaries. The best way to avoid ODR is to define ABSL_FLAGS_STRIP_NAMES=0 at build level. Since Chromium doesn't use absl/flags, this CL just default to flags always ON (they only affect test code). Bug: None Change-Id: Ie51744937125fbb89be39eacf388f43d6054d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552391Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830127}
-
