GitLab

Lifecycle changes should not occur during a11y serialization.
This adds a safety check that triggers a DCHECK when that occurs.

Bug: 1025740

Change-Id: I858b7e437eeb97e3d0284192bda39128c16b6b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113076
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755878}

Some debug border are sized to the size of a layer which can be
arbitrarily large. It will fail deserialization if the area overflows
int. Simply drop these borders to avoid renderer being killed.

Bug: 1066139
Change-Id: Ie51e327383fd594ac5cb551a94b945f9645fa7f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134187Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755877}

Bug: 1066929, 1015841
Change-Id: I457629cf885c669a9fe67440e3a30e2f61f6ed82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134371
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755876}

Adds the ability for non-public Android Chromecast to pass a flag to
disable sandboxes on utility process creation. This targets the
ability to use this flag so it cannot be used accidentally.

Bug: b/118772032 (internal)
Test: Local builds including using the flag verification.
Change-Id: I17bd1318796f4fed6400e2b2486954af384ba494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122469Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Brett Kilty <brettk@google.com>
Cr-Commit-Position: refs/heads/master@{#755875}

WPTs testing navigator.credentials.get() webauthn extensions were
expecting errors incorrectly:

* Unrecognized extensions are ignored instead of failing the request
  https://w3c.github.io/webauthn/#sctn-extensions
* null, empty array, and non sensical objects evaluate to dictionaries
  with undefined key values, which means they should also be ignored
  https://heycam.github.io/webidl/#es-dictionary

Fixed: 875444
Change-Id: I5b2cd3d421dc3cddc7010ff3f365314e25cf2a06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133159Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755874}

Also fix the test type for mac and win bots.

Bug: 1050517
Change-Id: I2df12f92e5775b6b3af71cdcaef6844d877d1fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134227Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#755873}

The task runner (`base::sequence_manager::internal::TaskQueueImpl::TaskRunner`
 -- child of `base::SingleThreadTaskRunner`) being held in
`unfreezable_message_filter_` refers to an object of
`base::sequence_manager::internal::TaskQueueImpl::GuardedTaskPoster`,
which holds an object of `base::internal::OperationsController`, which
then holds an object of `base::WaitableEvent`, which finnally holds an
open mach port.

The issue also impacts other systems like Windows / Linux.

Bug: 1063577
Change-Id: I5e34c71953835d9312360d349072ec4809f00d11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132536Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755872}

They should just match //sandbox/OWNERS.

Change-Id: I98c4de76dbc05481d64893d985a29b4b6f832e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134526Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755871}

With this cl Android native payment apps can declare a list of supported
delegations in their manifests. The Pay intent sent to these apps is
populated with paymentOptions and/or available shippingOptions (if
needed). The received response is then parsed to construct the payer
data according to the requested payment options.

This cl covers sections 1 to 3 of the design doc:
https://docs.google.com/document/d/1YKQxCrhWlACt9KNSMYvdOx6bNuu9YPJj9cY8CFKdTD4/edit?usp=sharing

Bug: 1026667
Change-Id: I5e2e2e80abd395cef386e2f3bfcbd3181f1d685f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129954Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755870}

HTMLOptionElement's NamedConstructor's arguments should have
default values of "" (empty string) instead of IDL null.
(It's not allowed to initialize non-nullable DOMString with
IDL null.)

Bug: 839389
Change-Id: Ifab7058697b98be497c7e794ee173165dcaf10cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134027Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755869}

#cr_define_end is a special comment leveraged by
polymer_modulizer() and js_modulizer() BUILD.gn rules, when
auto-converting files to JS modules.

Bug: 1045266
Change-Id: Ia1be68bf63753be9fd38c3066246d34f58afc3b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133234Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755868}

This CL triggers a lookalike safety tip if enabled by a feature
parameter. The set of TLDs searched for is also configurable via
feature parameter.

This code is trivially changeable to trigger the Lookalike interstitial
instead of a Safety Tip. A Safety Tip was chosen since we already have
experiment infrastructure (i.e. feature flags) and we're not yet sure
about the false positive rate of the heuristic.

This CL also slightly also changes the target embedding logic. Target
embedding is now no longer detected if the eTLDs overlap, such as in
google.co and google.co.uk. This reduces false positives.

TBR: cthomp@chromium.org
Change-Id: I3b9a97d613b90b10ee85426c0ee27aab9adcf1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119374
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755867}

This test tried to use a service whose factory is null in test mode.
It would work if run standalone because the factory was _also_ not
properly registered on startup, so the testing factory would never be
set to null.  However, if run in a batch with other browser tests, a
previous test's access to the factory would register it; the next
browser startup would null its testing factory; and then this test
would crash.

This fixes both problems: registers the factory, and sets a non-null
testing factory.

Bug: none
Change-Id: I877cb9b7c58e82de17888b52d7d6ddc34f5bec27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133626Reviewed-by: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755866}

Bug: 1052060
Change-Id: Idc3dc5220a822234222dc77f583ba119558ccce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095771
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755865}

R=jbudorick@chromiums.org

Bug: 1065848
Change-Id: I9fada9d16a5a5cb468777160fab9662a05c76016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133150Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755864}

BUG=1063749
R=jfernandez@chromium.org

Change-Id: Ide065e86f3a9950ba0ff7f8ce177ee37f41b6af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133910
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755863}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c980dbf22c82..7b793647316c

git log c980dbf22c82..7b793647316c --date=short --first-parent --format='%ad %ae %s'
2020-04-02 surma@chromium.org Fix size calculations in ExpandableTextPropertyValue

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@7b793647316c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1024721
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8f322feb682f3b47cbc5b2edbb8c21c64f371bfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755862}

This records the group ID and header text of suggestions in the
additional_info field of AutocompleteMatch.

That way, we can show this extended metadata in chrome://omnibox
in a lightweight way (without adding a whole new column or something).

This will be useful for Moe and I (and others) to debug the header
text feature as we are developing it.

I really like the extensible additional_info dictionary by the way.

Bug: 1052519, 1052522
Change-Id: I1409b6e6fd775149f6ca9c67e793f49c031c7251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132958
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755861}

|LayoutText| and |LayoutInline| has functions to check
whether they produced inline fragments or not in slightly
different ways. Also we have |DCHECK| to do it for
|LayoutBox|. This patch adds |HasInlineFragments()|,
unifying these code.

This is also used when associating |NGFragmentItem| with
|LayoutObject| in <crrev.com/c/2117558>.

This patch has no behavior changes.

Bug: 982194
Change-Id: Ie2bee2531189b7707773aab388ca51d5d112c030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133535
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755860}

This CL records the smoothness for shelf icon animations which are
usually triggered by adding/removing a shelf icon. In detail, there are
three kinds of icon animations: (1) Move icons (2) Fade in an icon
(3) Fade out an icon.

This CL should be landed after https://crbug.com/1051490 is fixed.

Bug: 1049702
Change-Id: I8c47ba3a3111a2bc8a7361ddcc12420d45308cef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105675
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755859}

This change initiates bookmark reuploading for pre-existing bookmarks
which are stored locally. A new field is introduced to BookmarksMetadata
to determine if local bookmarks were reuploaded.

To prevent the case when the bookmark specifics is committed without
favicon the entity is marked as unsynced after it was committed. In this
case the entity will be committed again when the favicon is loaded.

Bug: 1061411
Change-Id: I4a26a2babceb99a0f6532d2357884c75aff9fc05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127032
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755858}

After clicking the toggle button to enable/disable the extension, the
icon of the next extension is getting selected. This issue is a
regression from[1].

[1] https://crrev.com/c/1567561

Bug: 1060114
Change-Id: I14c4f713e6819267724baec6d9cbdcba7de74f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133986Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755857}

The use case to be supported is efficiently running Streams of
RTCEncodedVideoFrame in a Worker. In this case, RTCEncodedVideoFrame
are serialized to the Worker.

Serialization is supported only in the same process as a shallow copy
where the underlying webrtc frame is shared among the original and
the deserialized object.
See https://github.com/alvestrand/webrtc-media-streams/issues/5

Bug: 1052765
Change-Id: I1e2d9bcd2e24ef6aa6a7688f34283a81e6d23172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083297
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755856}

https://swiftshader.googlesource.com/SwiftShader.git/+log/cb58662302c8..0774188da4bb

git log cb58662302c8..0774188da4bb --date=short --first-parent --format='%ad %ae %s'
2020-04-02 sugoi@google.com Fix ImageView size computation

Created with:
  gclient setdep -r src/third_party/swiftshader@0774188da4bb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I3841763048a804d2ba9f6787a00b453d946b6d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134348Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755855}

This change enables on-device history ZPS suggestions for users
who are not signed in to Chrome on Android.

Bug: 956837
Change-Id: I689960538b1087eac9355ba0b20da7310f5e3daa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132864
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755854}

Support parsing and serialisation of the new from-font keyword in
text-underline-position.

Introduce a RuntimeEnabledFeatures flag UnderlineOffsetThickness for
guarding new underline features.

Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/D6S8JRPYtDA

Bug: 1067242
Change-Id: Id118e538af20276929fe92d235ce1920c0f6234a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120715
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755853}

TBR=govind@chromium.org

Change-Id: Ic424c696f824bc2e4e34d32baf36e0f0a4f64d46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132691Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755852}

This CL removes the spinner located at the top of the passwords popup.
Instead, each button that can trigger it, will show the spinner to its
left.

See the linked bug for a screenshot and a brief screencast.

Bug: 1066470
Change-Id: I17c625e194842c55d2b313da85dcfb7712d23625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129709
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755851}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9db428f4f78e..cd454025b331

git log 9db428f4f78e..cd454025b331 --date=short --first-parent --format='%ad %ae %s'
2020-04-02 pkasting@chromium.org Revert "Reland "git-cl: Execute clang-format-diff.py using vpython.""

Created with:
  gclient setdep -r src/third_party/depot_tools@cd454025b331

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1066187
Tbr: agable@chromium.org
Change-Id: I84b6620405b662aff0f1d730b22c855ad4bc699b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134349Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755850}

Not sure how that eluded scrutiny for so long :]

TBR: awhalley
Bug: None
Change-Id: I66c65daa67cae3dc64a268a566b17b4a2450da21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133418Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755849}

In AndroidPaymentAppFinder#findAndroidPaymentApps, this CL adds a
support for it to know whether it is running in a TWA that is installed
from AppStore.

Bug: 1064740

Change-Id: I4e21787294f1e7a2e471f80b452ebdd0a9ab77e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128831
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Auto-Submit: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755848}

This patch is step 3 in [1] and we adds a new RequestDestination field
in the structs / params where only RequestContextType is used.
If we are finish current step then RequestContextType field will be deprecated.

[1] https://docs.google.com/document/d/1kXXnH_27aJYGqjwbXLW6Bs9fW2xFhvZs8gJcXb4xnhQ/edit

Bug: 889751
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
Change-Id: I7930af1123af4f4c5a810428ab5921182156e899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129455Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755847}

This matches what we do with various other classes like Profile to allow
the client to mock for tests.

Bug: 1054160
Change-Id: I9dc34dbf5309ea071aeeb1d0fd2081a171c82085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133877
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755846}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/792d24ae70ef..b6fff1b9fabd


Created with:
  gclient setdep -r src-internal@b6fff1b9fabd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ib34175c564aeefeaac08e84f46ab1a5f4ba13870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134347Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755845}

OnFinishImplFrame call might happen when the corresponding frame is in a
stage rather than BeginImpl or BeginMain. This change checks for the
other reporters as well.

Bug: chromium:1067245
Change-Id: I9b30c78ed5d43397f94ec627c2f7bd099a92f522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133868Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755844}

Bug: 1045454
Change-Id: I99904af6881daa31cf6bb401f7ea29116cfe5bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132406
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755843}

Since TabGridPanelToolbarCoordinator only handles layout inflation and
PropertyModel creation, this CL removes this class and moves related
logic back to TabGridDialogCoordinator.

Bug: 1067080
Change-Id: I188d3de5a8d1baf064ddd22f857a110b815ba4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133077Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755842}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I14dbec1680af528f3f7ca40bf88f01059c927fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134351Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755841}

When the client receives BookmarkSpecifics with a legacy title field
only it will fill in new field and commit changed data to the server
again in future. Reupload of updated specifics may be done after
receiving of initial merge data or after browser restart.

Bug: 1061411
Change-Id: Id7efe057208dc5482b4fdd6773ac561ef79d9640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105335
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755840}

Add a DCHECK that will be triggered only on address sanitizer builds,
but importantly, will trigger on clusterfuzz builds.

The hope is that we clusterfuzz will file bugs on us with test pages
that will reproduce the problem.

If this technique works, we can look at adding it in other helpful
places, such as for some of the DCHECKs in ax_selection.

Bug: None
Change-Id: I643ec0fb6c40f4063d437f62384211483bb50868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133027
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755839}