- 25 Sep, 2019 40 commits
-
-
jonross authored
This test apparently fails on all variants of SkiaRenderer on Android, not just Vulkan. I'm suppressing it for now. TBR=ynovikov@chromium.org Bug: 1007019 Change-Id: Id89860b02bc29d113863af60f6d776fd87117602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825464 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699942}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cf0e9d93f177..6ac5a9250dff git log cf0e9d93f177..6ac5a9250dff --date=short --no-merges --format='%ad %ae %s' 2019-09-25 beaufort.francois@gmail.com Add label to command buffer and compute pass descriptors Created with: gclient setdep -r src/third_party/dawn@6ac5a9250dff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I00603d83e31f1acb073fe227523280115560aee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825740Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699941}
-
Evan Stade authored
This was necessary to help write a unit test that verifies behavior when an OTR profile is removed, but this part is split from that test because it's independent and potentially affects many tests. This CL also invalidates all weak pointers for Browser at the start of its destructor. This avoids re-entrant calls to Browser during its destruction, which suddenly became a problem in some unit tests because TestingProfile runs a message loop till it's empty, which allows delayed calls to Browser methods to run on a partially destroyed Browser object. For example, in one test, Browser::CloseFrame was running after being posted from TabStripEmpty. Bug: none Change-Id: I209f9501d61ca4fe08aa5c9228d0da6f4c72e664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823826 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#699940}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/121f6b79..a2830ee1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4f4184286eab89537985db8764508bc57e9e4381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825400Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699939}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7211cf64444c..6a5cb2517a2c git log 7211cf64444c..6a5cb2517a2c --date=short --no-merges --format='%ad %ae %s' 2019-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6a5cb2517a2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I49d4d967b92fc4e4e041ae6e42e6724087a9936c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825694Reviewed-by:
-
Victor Costan authored
IndexedDBCursor now calls IndexedDBTransaction::UnregisterOpenCursor() in Close(), which is called by the destructor. The previous setup missed an edge case where calling IndexedDBCursor::Close() directly would not unregister the cursor. This behavior was relied upon in IndexedDBTransaction::CloseOpenCursors(), but was not intended at other callsites. Bug: 1005753 Change-Id: I91944138d05faa2d91ecc03b1040ec16ca1a7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821675Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#699937}
-
Connie Wan authored
Address remaining comments from https://chromium-review.googlesource.com/c/chromium/src/+/1809546 Bug: 905491 Change-Id: I92242ff19cd8c0d85500e7dd66b76a4d1b29fab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818434 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#699936}
-
Kyle Horimoto authored
Previously, this was created lazily, but we want this to be created whenever the Profile is created. Change-Id: If4c288d55a6ef03805c125ebadf514c965cf9ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825777 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#699935}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: I1e633b64e04b6acfbe63c141ecd287020d43b536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814696Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#699934}
-
Petr Smirnov authored
Add functionality for disabling back button on ErrorScreen. Bug: 1005151 Change-Id: Ic62ca8d56f529d60c2e45c9d2d8e4fcbfeb420d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807230Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Petr Smirnov <petrsmirnov@google.com> Cr-Commit-Position: refs/heads/master@{#699933}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9776ca2c2a0d..b88dac708caf git log 9776ca2c2a0d..b88dac708caf --date=short --no-merges --format='%ad %ae %s' 2019-09-25 tcwang@google.com afdo: Clean up HWTest on chell-chrome-pfq. Created with: gclient setdep -r src/third_party/chromite@b88dac708caf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I82cb3c9fdbc59f29e515749e182979f08517b208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825739Reviewed-by:
-
Andrew Luo authored
Bug: 1000798 Change-Id: Ia8135bde0b9c3a4af662de0646b6fd6d0a75959f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811942 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#699931}
-
Andrew Luo authored
Bug: 1000738 Change-Id: Ic39f9cc17ccfe671eade0548d4d7aad0b6761e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817363Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699930}
-
Lukasz Anforowicz authored
The functionality of ChromeContentBrowserClientExtensionsPart::ShouldAllowOpenURL is already covered by ExtensionNavigationThrottle. Bug: 1003957 Change-Id: I0ad1329933f44681baf67168f3f932ff89598ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804598 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699929}
-
Robbie McElrath authored
This creates a new BUILD.gn file for everything in //aw/browser and removes unused dependencies. Test: ninja -C out/aw system_webview_apk; gn check out/aw android_webview/browser Bug: 934152 Change-Id: I2f94e67d57c3a48687c44ddb475f529e67dc7389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824018Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#699928}
-
Matt Amert authored
Bug: 1007464 Change-Id: Ia3daa354ae93f2d2fb99f0b289df1e0a8e4190f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819777 Commit-Queue: Matt Amert <Matthew.Amert@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#699927}
-
Sigurdur Asgeirsson authored
This is a reland of 75bbdfb2 Original change's description: > Mojo: Dump core on a configurable queue length threshold. > > Bug: 1003391 > Change-Id: Ibdc72029f647eff989bebb9b6542cffb8273064a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815847 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699387} Bug: 1003391 Change-Id: Ia90ea86025c4180a5cf417a1296c4a4a7bf03d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824123Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699926}
-
Stephen McGruer authored
There were some remaining tests in the Blink-internal version that were not present in the external/WPT version, so port those over. Bug: 900581 Change-Id: I40d09b0bd87abe9294e82818688ce60332317438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824122Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699925}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/096b08fa42e8..d4c75347e4d3 git log 096b08fa42e8..d4c75347e4d3 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 hckim.kim@samsung.com Vulkan: Enable GPU conversion from RGB16F to RGBA16F Created with: gclient setdep -r src/third_party/angle@d4c75347e4d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Icb4dbb8ded746fa1bbeaf6572b8525e0e01e8aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825469Reviewed-by:
-
Alexandre Frechette authored
Bug: 995977 Change-Id: I7694d116a912e05fe36cf4388d85e1121e9307d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815848Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#699923}
-
Khushal Sagar authored
R=ericrk@chromium.org Bug: 889328 Change-Id: Ib68a1bf13ba6c916b736242ab6ec49023703a304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820204 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#699922}
-
Kristi Park authored
Show a "Sending..." confirmation message when sharing a URL from the omnibox entry point. This replaces the OS level confirmation notification, and will be shown regardless of success/failure. Screencast: https://drive.google.com/open?id=1mUZTuhXeE_cYfPMHZAiJjCPMVgH8xpSu Bug: 1002967 Change-Id: I4c803cd2edaf80e83d6751b5bf73447e09406d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808499 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699921}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c712e962b647..1585d7e108ef git log c712e962b647..1585d7e108ef --date=short --no-merges --format='%ad %ae %s' 2019-09-25 mtklein@google.com opt skottie_tool into thread-local strike caches 2019-09-25 robertphillips@google.com Split out check_base_readbacks sub-test in BackendAllocation tests 2019-09-25 mtklein@google.com dump frame time stats in skottie_tool 2019-09-25 brianosman@google.com Particles: Added particle flags for tracking state (one-time triggers, etc) Created with: gclient setdep -r src/third_party/skia@1585d7e108ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I20a9e0a794b78a88a2f2c898b067717d4c689c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825682Reviewed-by:
-
James Cook authored
It needs to be wide enough to show the magnifying glass, since the horizontal scroll bar doesn't affect the header. Bump from 200px to 300px. I missed this in: https://chromium-review.googlesource.com/c/chromium/src/+/1815905 TBR=ortuno@chromium.org Bug: 1001466 Change-Id: I12e63b8e86cc72241a9d6b51d0f4933d94e6bbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825470Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#699919}
-
James Cook authored
Show the temperature and schedule controls after the user toggles the feature on. Off state: http://screen/NK2AKv3TTBJ On state: http://screen/e1cehFw9nV3 Add a little bit of padding at the bottom of the sub-page when Night Light is disabled such that when the user enables Night Light they can see that there are more controls below. Bug: 1000683 Test: added to browser_tests Change-Id: I31a68362f8452178fda96a8fac783c7c6e600495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825659 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699918}
-
Sven Zheng authored
When testing against external servers with prod gaia account, we need to make sure the account is in clean status. To do this, we clean the test account by sending a CLEAR_SERVER_DATA message before running test case code. TEST: sync_integration_tests.exe --gtest_filter=TwoClientTypedUrlsSyncTest.SyncTypedRedirects_E2ETest --sync-url=https://clients4.google.com/chrome-sync/dev --sync-url-clear-server-data=https://clients4.google.com/chrome-sync/dev --sync-user-for-test=<test account email> --sync-password-for-test=<password> --enable-pixel-output-in-tests --gtest_repeat=2 With this change, the test will pass. Without this change, the test will pass and then fail on second time. It's because the account is 'dirty' when running second time. The above command can only be run for googlers, and please ask me for user/password if you need. Bug: 992143 Change-Id: I0339e905c0b34be8eb6d109671590ba26bd0b5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814687 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699917}
-
John Chen authored
Disable the following flaky tests on Linux and Mac perf bots: * system_health.common_desktop/multitab:misc:typical24 * system_health.common_desktop/multitab:misc:typical24:2018 * system_health.memory_desktop/multitab:misc:typical24:2018 * tab_switching.typical_25/multitab:misc:typical24 TBR=crouleau@chromium.org NOTRY=true Bug: 1008093 Change-Id: I7e88ae7325d8858fe6e9c3d376ce2c295af11dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825161Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699916}
-
Nicolò Mazzucato authored
The tracing categories have been added to the DataSourceDescriptor, so that is possible to retrieve them through the ConsumerPort. Change-Id: I779c8ebcb20028e2707ff9a29a14a5749ab07896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814357 Commit-Queue: Nicolò Mazzucato <nicomazz@google.com> Auto-Submit: Nicolò Mazzucato <nicomazz@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#699915}
-
Chris Lu authored
There is no need for ViewportAdjustmentExperiment since the only experiment remaining is just the kSmoothScrollingDefault feature flag. GetActiveViewportExperiment() can just be a function that returns whether or not smooth scrolling is turned on. ViewportAdjustmentExperiment is still needed for downstream compatibility, and will be removed in a subsequent CL. Unused features and experiments are removed from code as well to preface their official removal in FullscreenFeatures. Bug: 914042 Change-Id: Ib86fd4f9a53c9aed3509214f8dc232f624d9b004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815497Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#699914}
-
Chandani Shrestha authored
This change runs axe test in 3 scenarios: 1. Pattern form opened 2. Pattern added in the list 3. Error message validation Bug: 963183 Change-Id: I2a0face5eba7a7631261d619126131b631ceab34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652050Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699913}
-
Andrew Grieve authored
More hardening against verification failures caused by inlining. Also removes some unnecessary passing around of Application context. TBR=agrieve # Trivial change to ui/android Bug: 1006812 Change-Id: Icde0541166a7cac69edaf1a7638c41827c2711ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819354 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Thanh Nguyen authored
This CL doesn't change any logic. It moves SearchRankingEventLogger to search_result_ranker, which is a more suitable place. The proto is deleted because it's not currently being used. This CL will be followed by several CLs that refactors the class. Bug: 1006133 Change-Id: I1b9180a6b9613d0627a1a00ca8cf55204c4987b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816058Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#699911}
-
Wez authored
Switch the tests that expect a call ot GetRouteTable() to explicitly wait for that to happen, rather than attempting to flush all pending events from both Thread and main loop. Bug: 973242 Change-Id: I0e19bb46aa7bf119fa8d6721e6f2f2a42e93a49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820205 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#699910}
-
Shimi Zhang authored
Bug: 997362 Change-Id: Iebe27e720c942c1014981926b83fb1fafd57c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824278 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#699909}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I27f4d213b84a3c7f41ec94759d397bfb694374de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798606 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#699908}
-
Nate Fischer authored
The record_netlog.py previously had a false positive when the package of interest was a substring of a running process (ex. "com.foo" and there's a process named "com.foo.persistent"). Substring matching was not intended, so switch to GetApplicationPids() which does not perform substring matches. Searching for exact package names usually suffices (and this is just a best effort attempt to detect if the app is running), so we should just minimize the false positive rate. Test: Try with "com.google.android.gm" when "com.google.android.gm.persistent" is running Change-Id: I3204131aaaf53df9d7972f8bce37602dfd8324d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820091Reviewed-by:
-
Bailey Berro authored
This fixes a bug where rotation was not persisted properly for displays set to a non-native resolution. ManagedDisplayInfo::native_ represents whether the object comes from DisplayChangeObserver [1]. ManagedDisplayMode::native_ represents whether the display is using a native resolution [2]. Previously, these values were incorrectly used interchangeably in DisplayChangeObserver::CreateManagedDisplayInfo(). This CL introduces ManagedDisplayInfo::from_native_platform_ to track whether the object comes from DisplayChangeObserver. ManagedDisplayInfo::native_ will now be used to track whether the display is using the native resolution. 1- https://cs.chromium.org/chromium/src/ui/display/manager/managed_display_info.h?rcl=661dcc6c712db426e252a8bccecfad50baecdce7&l=334 2- https://cs.chromium.org/chromium/src/ui/display/manager/managed_display_info.h?rcl=189281e03cf1b236600cd5fb6e6bbc049bdb4f60&l=65 Bug: 968224 Change-Id: I0eb4da445682481ced2b55a23e3a0ace6995a8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793745 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#699906}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09aa96cf69bd..370924be227a Created with: gclient setdep -r src-internal@370924be227a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9851cb3a54a7b532cfebb3c40f2a1405f139f833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699905}
-
Nate Fischer authored
No change to logic. This reorders Java modifiers to conform to the JLS style guide, which is enforced by a new presubmit check (https://crrev.com/c/1803140). This also adds curly braces to for loops, as this is also a presubmit requirement. Bug: 1003711 Test: git cl presubmit --upload Change-Id: Ice355c6453b4e88c28dacc07d91ade61a1e2d09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823813 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Vikas Soni authored
A DCHECK became invalid after a recent refactoring. Move the DCHECK to more appropriate place. BeginReadAccess() could be called multiple times on a single shared image in which case this DCHECK is valid only for the first call. once |promise_texture_| is created and cached, this DCHECK becomes invalid. Change-Id: Ia77759ca7797675adbcf41a78c1086e3aebba2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822318Reviewed-by:
-
