GitLab

There is a need to express localizable strings in //services code.
This CL introduces all the bits necessary to define translated resources
in a new //services/services_strings.grd file and moves a single string
(pertaining only to a service defined in //services) from the Chrome GRD
to the services GRD.

This is a precursor to simplifying expression of out-of-process service
registration by allowing service manifests to include a resource ID
directly in their definition.

Bug: 895615, 915806
Change-Id: I76d420266fb5528f407b624838172c267666654b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615701Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#663919}

As per the spec, the driver is expected to return a valid timestamp from
the call eglGetFrameTimestampsANDROID() when its not
EGL_TIMESTAMP_PENDING_ANDROID or EGL_TIMESTAMP_INVALID_ANDROID.
But currently few buggy drivers returns an invalid timestamp 0.

We fix/workaround this in chrome by returning the presentation time
as TimeTicks::Now() (snapped to the next vsync) instead of 0.

Bug: 966638
Change-Id: I5075dda0739f02029922ebbc20c09656fb0e87ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631354Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663918}

When an input_source is marked as removed, its gamepad needs to also be
marked as disconnected.  To facilitate writing tests for this, the blink
web_test mocks were also updated to allow for connecting/disconnecting a
gamepad object.

Also includes very minor cleanup to the test that was used as a pattern
when creating the newly added web_test.

Bug: 963013
Change-Id: Ia985b548dbc6b1e7052a6189a484b6a93298e2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626885Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663917}

Bug: none
Change-Id: I05f25bc8f472d44660a8f98fb3b92b32ceebf3c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631940
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663916}

This "Turn off" button just resets the content setting to the default
setting, which is now BLOCK.

Bug: 965760
Change-Id: I32002bfdcad61ee36041d1ecb733b4cdc52981ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629041
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663915}

https://pdfium.googlesource.com/pdfium.git/+log/7eadbd640fc4..12d7da217249


git log 7eadbd640fc4..12d7da217249 --date=short --no-merges --format='%ad %ae %s'
2019-05-28 thestig@chromium.org Remove CPDF_Array::GetFloatAt().
2019-05-28 thestig@chromium.org Roll buildtools/ c79f3482c..0218c0f9a (18 commits; 5 trivial rolls)
2019-05-28 thestig@chromium.org Roll build/ 578c66146..4cebfa34c (159 commits)
2019-05-28 thestig@chromium.org Roll tools/code_coverage/ 90f3a1ede..b53d904eb (1 commit)
2019-05-28 thestig@chromium.org Roll tools/clang/ 2db48c749..9d46446d5 (6 commits)
2019-05-28 thestig@chromium.org Roll tools/clang/ 4e32649d7..2db48c749 (24 commits)
2019-05-28 thestig@chromium.org Roll third_party/catapult/ cca9447f6..a7b331246 (73 commits)
2019-05-28 thestig@chromium.org Roll third_party/depot_tools/ ccd2b4da9..26af0d34d (112 commits; 68 trivial rolls)
2019-05-28 thestig@chromium.org Roll third_party/icu/ ae4b77dc8..64e5d7d43 (4 commits)
2019-05-28 thestig@chromium.org Roll third_party/binutils/ 2be73f7fb..92bfa0a5d (1 commit)
2019-05-28 thestig@chromium.org Roll third_party/googletest/src/ 9997a830e..f71fb4f9a (8 commits)
2019-05-28 thestig@chromium.org Roll v8/ ed14aba38..c4c480a41 (655 commits)


Created with:
  gclient setdep -r src/third_party/pdfium@12d7da217249

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: Ia7c442f48a6df03779ea7b8254a8659a40e4a07d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632797Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663914}

Recent UMA metrics suggest that AddLoginSync() unexpectedly fails to add
remote passwords the password manager when processing remote passwords
from the server. This CL is introducing a UMA metric to record the exact
reason of failure.

Bug: 902349
Change-Id: I71eaf22c35211f363123f21ef2d8dd78085206bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630478Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663913}

This CL does a few things to unify the usage of minimal_symbols
throughout mb_config.pyl:
1) It turns it on for all Goma mac builds, to match Win and other
   platforms
2) It removes it from configs which also specify release_trybot,
   where it is redundant
3) It renames a couple configs to better reflect their unique pieces

Bug: 966342
Change-Id: I6e12efbbe981e8eccbaa831430f8d833bd90e715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628815
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663912}

With display locking, the subtree we have might not be laid out, and
is not visible. Hence, we should not generate subtree intersection
observations.

This patch implements this by skipping computation for locked subtree
elements.

R=chrishtr@chromium.org, rakina@chromium.org, szager@chromium.org

Bug: 945531
Change-Id: Iab4b91eb0c964a369901bc4ec322f4a421a8103f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614029Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663911}

These filed belonged "with the remote cocoa stuff", but at the time
there was no such place, or that place was tied to views, which didn't
seem right.

Now there is a "remote cocoa stuff for the browser process" place (well,
created by this patch).

Move the things that belong in that place to that place.

R=ellyjones
TBR=avi (content/)

Bug: 958255
Change-Id: I168a259403756cb429f772618161946373470db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629042
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663910}

This reverts commit 1ffb9166. Since
we are coming up on the M76 branch point, restore the ZIP extraction
size limit. I'll roll this out when M75 is released, fixing the bug.

Bug: 959628
Change-Id: Iba156644101a1297cf03a129eea756020efe7fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631895Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663909}

With it we can know the associated blink-side identity of the cc layer,
e.g. the GraphicsLayer, DOM node, etc.

It also gives ForeignLayerDisplayItems meaningful debug names.

TBR=kylechar@chromium.org (for ui/compositor because of added 'const in a cc::LayerClient method)

Change-Id: I52f1839b406439fa2cf5b0a203a4e1f88929c345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629292
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663908}

Previously the code used a |pendingOutput| string which was concatenated
with "+=" every time a new output line was added. Converting |pendingOutput|
to an Array and generating the final string only at the end is more
efficient.

Also performing some other minor cleanups.

Bug: None
Change-Id: I779ea4a0ea0097be70815f69759804b2e31d173b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629790
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663907}

In https://cr-rev.appspot.com/c/1594825 I refactored histogram reporting
and accidentally changed it to only report error values and never report
that a GWP-ASan crash was seen. Fix that.

Bug: 956824
Change-Id: I4a1a55fe45db380fc5a00952f304212698c37994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632896
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663906}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0210991491ea..fd40163541b4


Created with:
  gclient setdep -r src-internal@fd40163541b4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com

Change-Id: I8fb753e9b0d66c0e39b2043bc545e3dda041a6aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632800Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663905}

This is the 7th refactoring CL aimed at reducing duplication and
inconsistency for classifying omnibox results.

Navsuggests can come from either the search or zero suggest providers.
The zero suggest provider removes all bolding. Moreover, navsuggests do
not classify their descriptions (though they should and a future CL will
address this). So this CL impacts only search provider navsuggests'
contents.

In addition to migrating from unique classification logic to shared
classification methods, this CL affects the text and styling of
navsuggest contents:

1) Previously, navsuggests allowed mid-word matches; e.g., the user
input 'acebook' could match 'f[acebook].com'. With this CL, mid-word
matches are prohibited which is consistent with the other providers and
Google.com.

2) Previously, navsuggests did not break the user input into words;
e.g., the user input 'https://facebook' did not match
'https://m.facebook.com'. With this CL, the user input is broken into
words on whitespace and special characters, similar to other providers,
and the user input 'https://facebook' matches
'[https]://m.[facebook].com'.

3) Previously, navsuggests did not break the suggest text into words,
meaning the entirety of the user input must match; e.g., 'facebook.com/
learn' did not match 'facebook.com/business/learn'. With this CL, the
suggest text is also broken into words on whitespace and special
characters, similar to other providers, and the user input
'facebook.com/ learn' matches ‘[facebook.com]/business/[learn]’.

4) Navsuggests derive their content text from formatting their URLs.
They trim their URL prefixes if the user input does not match the
prefixes; e.g., the user input 'facebook.com' would hide 'https' and
'www' from the resulting navsuggests. Because of (2) and (3) above, the
user could explicitly type a prefix and it would be trimmed from the
navsuggest text anyways; e.g., the user input 'http/facebook.com' would
display the navsuggest 'facebook.com/device'. With this CL, the user
input 'http/facebook.com' will display the navsuggest
'[http]://[facebook].[com]/device'.

Bug: 366623
Change-Id: I3ae684c1ea0ea75c91ecf1bb2b702144ebf9d640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562300
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663904}

Adds a class that enumerates the type of success or failue of a
CryptAuth v2 DeviceSync attempt as a
CryptAuthDeviceSyncResult::ResultCode. Instances of this class
potentially hold a new ClientDirective from the SyncMetadataResponse.
This object is passed to the CryptAuthScheduler after a DeviceSync
attempt finishes. The result code will be used for UMA metrics.

CryptAuthDeviceSyncResult is analogous to CryptAuthEnrollmentResult
which was used from CryptAuth v2 Enrollment.

Bug: 951969
Change-Id: Ie662e32a37718ade77f98ee127b52fb269aa37bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631764
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663903}

Since UpdatePlayState() depends on |highest_ready_state_| we should call
it after SetReadyState() has been called. This is potentially causing
the perf issues on macOS.

BUG=965684

Change-Id: I053c71b2d1d5ffac5fa31de70e63c08488037a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629588
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663902}

Instead of kUseTransforms from callers or forced by the implementation,
this CL make it by default. kIgnoreTransforms should be used if the
caller doesn't want transforms in some special cases.

To avoid accidentally changing the behavior, I created the final patch
in the following steps:
Step 1:
a) Added kIgnoreTransforms along with kUseTransforms in MapCoordinatesFlags;
b) Removed the default parameter values of MapCoordinatesFlags from
   geometry mapping functions;
c) Added DCHECK((mode & kIgnoreTransforms) || (mode & kUseTransforms)) to
   ensure that the caller must explicitly choose between kIgnoreTranforms
   and kUseTransforms;
d) Modified all callers to explicitly specify kIgnoreTransforms or
   kUseTransforms based on their original behavior.
e) Made all tests pass
https://chromium-review.googlesource.com/c/chromium/src/+/1621707/3

Step 2:
a) Remove kUseTransforms from MapCoordinatesFlags
b) Remove DCHECK((mode & kIgnoreTransforms) || (mode & kUseTransforms))
   from geometry mapping functions
c) Remove kUseTransforms from call sites

This CL should not change any existing behavior.

Change-Id: I860cde66f47f0c72509a21615afaefcb4851e4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621707
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663901}

Cleans up some more code related to the removed functionality.

Bug: 931388
Change-Id: I971b25e5f8deefe24ef08ae4c2b4e8445d91c763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629031Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663900}

This is where we actually use the cryptographer, or at least after
ongoing migrations are completed and SyncEncryptionHandlerImpl goes
away (replaced by NigoriSyncBridgeImpl).

Before we start refactorings, let's move the code to its final
location.

Bug: 967417
Change-Id: Ibef976dc05802585d872b937293098e76fd99c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631652Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663899}

Screenshot in bug.

Bug: 967356
Change-Id: Ife9734992e838236b38bb67dbb850111def88956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631935
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663898}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I680873cd19a6fdb0628236dbf9bcf326f090722f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632799Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663897}

Texture::CompatibleWithSamplerUniformType only expects to run with
"renderable" textures, where the base level is initialized - in
particular it expects a valid internal_format/format/type.
Some old logic was skipping a check for GL_TEXTURE_EXTERNAL_OES,
allowing textures for which we didn't know the size, but that ends up
allowing uninitialized textures. Nowadays we should always know the size
even for those, so remove the logic skipping the initialized level check.

Bug: 966936
Change-Id: I61f64fe4fa7551ed7640f41fc0ea1111edb641bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629792
Auto-Submit: Antoine Labour <piman@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663896}

This module does not have actual tests yet, but it was tested with
print_js_egetest.mm which had local modifications.

Notable changes:
 - add ios_web_eg2tests_module module
 - rename ios_chrome_eg2_test_app_host to ios_chrome_eg2tests
 - rename ios_web_shell_test_app_host to ios_web_shell_eg2tests
 - rename ios_web_shell_eg2tests to ios_web_shell_eg2tests_module

Bug: 866147
Change-Id: I38e0ab1b76ba9cc56bb2b0af0cfc731d03b36f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628171Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663895}

Bug: 649904,893460
Change-Id: Ibcc86ddb575d939bf27bf754b4fcf84d1c75767d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622599Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#663894}

Bug: None
Change-Id: Id8f2804e499d80f5756192d44f11edbcfcbefdef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632118Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663893}

The counter can (rightfully) underflow when an object is promptly freed
directly after performing a GC.

Also fixes an issue where the linear allocation area is accounted as
allocated only when setting up the new area. This can yield in negative
overall size if measured before that update happens.

Bug: 948807
Change-Id: I288b607761d5017192ab9bd3c0fe6a13bef52884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631597
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663892}

This reverts commit 6862f77d.

Reason for revert: bug 966345

Original change's description:
> Remove default padding for cue text rendering
> 
> Per spec there is no default padding for text track cue rendering.
> Removing the default padding for cue text.
> 
> BUG=930608, 843136
> 
> Change-Id: If931c1faff528a87d8a78808f30225ebe2377072
> Reviewed-on: https://chromium-review.googlesource.com/c/1475567
> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#633624}

TBR=fs@opera.com,mlamouri@chromium.org,srirama.m@samsung.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 930608, 843136
Change-Id: If1183f0ef2b03f287b7ba562b4b45f5fff242b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628480Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663891}

This patch runs dawn_end2end_tests using the wire to add
additional test coverage for dawn_wire.

Bug: dawn:158
Change-Id: I9cdd6f6eed27882278399f62936d5e8203516dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589441
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663890}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/604b5dab..bcf517c0

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8e298fde0d2cba8cacac20e69e9c4f1eee6d387c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632791Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663889}

Implements the `profile` method on Performance, which starts and returns
a new JS sampling profiler attached to the isolate given a sampling
interval and maximum buffer size.

Bug: 956688
Change-Id: I71e9c3eb43e738b1ee1874a6efba8dece64c7330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629710Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#663888}

This patch ensures that we don't process display-locked elements when doing
font collection. In NG this can cause a DCHECK since
we might not have laid out the contents of the locked element. In general,
the contents are not painted or visible so there is no need to collect
font information on them.

R=chrishtr@chromium.org, rakina@chromium.org

Bug: 966754
Change-Id: I807eaa387f7a4893be7de9566c9c9a95181237b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629052
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663887}

Bug: 918221
Change-Id: If776b242d76315f4bebc8c38c0dd0e2d2800cfda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620965
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663886}

Bug: 731375
Change-Id: I6677bac3709b88de2c424526a5f72bd7ecb8403e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632911
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663885}

- changed the strings to match the new spec
- used ui::GetChromeOSDeviceName() in the notification text to
  show the correct device type (Chromebook/Chromebase etc).
- changed the notification type to NORMAL
- changed the display source from custom to default ("Chrome OS")
- changed the notification icon, used a MD asset
  (ic_info_outline_48px.svg scaled to 96px)

Bug: 957178
Test: manual
Change-Id: I3bf29c6ca8dba98fd80d9a43637354e560f0ca4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617012
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663884}

This CL is adding a finch experiment to study impacts of moving to
PlatformFontSkia. Every dependency to PlatformFontWin got removed and
the code is ready to move to the PlatformFontSkia. We would prefer to
ship a experiment to see what are the unstable part of it and look to
performance metrics.

R=robliao@chromium.org,asvitkine@chromium.org
CC=tapted@chromium.org,drott@chromium.org

Bug: 944227
Change-Id: Id44e455a552fd993dddf8714b284b5074cfbbe89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630222Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663883}

This is a reland of 964fde12,
which was reverted at 043d9f87
because of a bug.

This reland fixes the bug by setting optional params correctly
in git_cl.py.

Original change's description:
> [blinkpy] Always suppress stderr of git-cl
>
> * stderr is now always ignored for git-cl (i.e. the optional argument is
>   removed from GitCL.run as no one uses it).
> * Instead of only excluding stderr from the return value, we now throws
>   away stderr completely by redirecting it to DEVNULL so that the logs
>   don't get polluted.
>
> Some drive-by pylint fixes are applied.
>
> Bug: 953499
> Change-Id: I5668576e1cc3dfe2a83a7cafc12a09f4a0029358
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628606
> Auto-Submit: Robert Ma <robertma@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#663599}

Bug: 953499
Change-Id: Idccc65e089ee67f744411752800f41fd63a93d92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631765Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663882}

Most of the Create*Command() functions in session_service_commands.cc
have the same few lines at the end. These can easily be extracted into
a separate function.

Change-Id: Ie3275bd75f25c2abf171e18df5ea597fed4b02cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610529Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663881}

Add pixel-by-pixel comparison tests for play/pause controls in PiP. Modify the pixel comparison function to use an actual (expected) image instead of just RGB values.

Change-Id: I1604df59d390a460fe5a0200cbae273bdd60e023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574451
Auto-Submit: Clifford Cheng <cliffordcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663880}