GitLab

TBR=jln@chromium.org,thakis@chromium.org

Review URL: https://codereview.chromium.org/1646813004

Cr-Commit-Position: refs/heads/master@{#372260}

Removed Emulation.ViewportChanged event.
Removed unnecessary methods from MediaQueryInspector.

BUG=540864

Review URL: https://codereview.chromium.org/1641003003

Cr-Commit-Position: refs/heads/master@{#372259}

TBR=caseq
NOTRY=true

Review URL: https://codereview.chromium.org/1648183002 .

Cr-Commit-Position: refs/heads/master@{#372258}

The current visible rect computation logic with property trees assumes that
whenever a layer's target is different from its clip node's target, it is
because the layer has a clip parent. But, this case is possible even when the
layer has a scroll parent. When we have scroll parent, we need to apply scales
differently because clip parent is an ancestor but scroll parent is not.

BUG=576959
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1643053002

Cr-Commit-Position: refs/heads/master@{#372257}

Just skip expressions that are dependent on template parameters, treat
them as non-constant.

R=dcheng
BUG=581218

Review URL: https://codereview.chromium.org/1645243002

Cr-Commit-Position: refs/heads/master@{#372256}

Added two new tests that allow to measure latency of the new
WebRTC-based protocol.

BUG=547158

Review URL: https://codereview.chromium.org/1642793002

Cr-Commit-Position: refs/heads/master@{#372255}

Don't make the test fail all the time, I hates it.

R=dcheng
BUG=578344

Review URL: https://codereview.chromium.org/1644233002

Cr-Commit-Position: refs/heads/master@{#372254}

BUG=582274
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/1643093002

Cr-Commit-Position: refs/heads/master@{#372253}

Suspicion is that CreateTrialsFromSeed() is being called more than
once, so add some CHECKs that will help diagnose it. If it's not
being called twice but the same field trial is being registered
twice, this can also cause the same issue - so catch that too.

BUG=359406

Review URL: https://codereview.chromium.org/1632913004

Cr-Commit-Position: refs/heads/master@{#372252}

BUG=531710

Review URL: https://codereview.chromium.org/1638413004

Cr-Commit-Position: refs/heads/master@{#372251}

This might help improve the performance of copies from the buffer, particularly inside UpdateSubresource in the GPU driver.

BUG=524305

Review URL: https://codereview.chromium.org/1635183003

Cr-Commit-Position: refs/heads/master@{#372250}

The format of WebUSB descriptors as defined by the draft specification
has changed. This patch brings Chrome up to date.

BUG=492204

Review URL: https://codereview.chromium.org/1646783002

Cr-Commit-Position: refs/heads/master@{#372249}

TODO: root cause and re-enable.

BUG=571898

Review URL: https://codereview.chromium.org/1644183002

Cr-Commit-Position: refs/heads/master@{#372248}

The flag "treat non-secure origins as non-secure" allows connection info
popup to be opened for HTTP connections. This patch ensures that the
certificate viewer cannot be opened for these connections.

In the longer term, we may want to change or remove the connection info
popup for insecure HTTP connections.

BUG=563619

Review URL: https://codereview.chromium.org/1541733002

Cr-Commit-Position: refs/heads/master@{#372247}

Trickily enough, there were two matchers triggering this rewrite:
- the reference to the field being initialized in the synthesized copy
  constructor
- the reference to the field being copied in the synthesized copy
  constructor

BUG=581871

Review URL: https://codereview.chromium.org/1639133004

Cr-Commit-Position: refs/heads/master@{#372246}

When there's no identifier to rename, don't try to
GetNameForDecl(), and always use getName() consistently.

R=dcheng
BUG=578344,581902

Review URL: https://codereview.chromium.org/1642323002

Cr-Commit-Position: refs/heads/master@{#372245}

Also fixed up some cpplint warnings in
chromecast/base/device_capabilities_impl{.h,_unittest.cc}

BUG=NONE
TEST=Built and ran code; cast_base_unittests

Review URL: https://codereview.chromium.org/1642143003

Cr-Commit-Position: refs/heads/master@{#372244}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7d3030eb345a..055fd6cc0a45

$ git log 7d3030eb3..055fd6cc0 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1644193002

Cr-Commit-Position: refs/heads/master@{#372243}

https://chromium.googlesource.com/chromium/src/+/4835c7b56

BUG=485650
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1649973002 .

Cr-Commit-Position: refs/heads/master@{#372242}

Reland of Src-ify Android Tests. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/1643803004/ )

Reason for revert:
should be ok now

Original issue's description:
> Revert of Src-ify Android Tests. (patchset #3 id:40001 of https://codereview.chromium.org/1649593002/ )
>
> Reason for revert:
> build presubmit flake broke the build side test, so we can't double test. will reland later
>
> Original issue's description:
> > Src-ify Android Tests.
> >
> > build-side is here: https://codereview.chromium.org/1645723004/
> >
> > BUG=525873
> >
> > Committed: https://crrev.com/4abea28bed4a20fb89a1fc65eafcfb772ce0ca0f
> > Cr-Commit-Position: refs/heads/master@{#372108}
>
> TBR=dpranke@chromium.org,jbudorick@chromium.org,tandrii@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=525873
>
> Committed: https://crrev.com/b8a0d10cebc4a73c7cae0d2e40fb538906e9b84e
> Cr-Commit-Position: refs/heads/master@{#372119}

TBR=dpranke@chromium.org,jbudorick@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525873

Review URL: https://codereview.chromium.org/1641983006

Cr-Commit-Position: refs/heads/master@{#372241}

https://chromium.googlesource.com/chromium/src/+/65da63c42

BUG=240845
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1646183002 .

Cr-Commit-Position: refs/heads/master@{#372240}

This CL changes the Template Expressions from using
a ${ to identify the start of an expression, to using
$i18n{.  The intention is to reduce (eliminate) false
positives when searching for expressions that need
replacement.  This CL also prepares for the replacement
work to be done in a background thread and used on a
broader set of files.

BUG=506009

Committed: https://crrev.com/5aa7fd5f14e49c65ebba87e4248424d622b92930
Cr-Commit-Position: refs/heads/master@{#371537}

Review URL: https://codereview.chromium.org/1585923011

Cr-Commit-Position: refs/heads/master@{#372239}

https://chromium.googlesource.com/chromium/src/+/ba696d0d2

BUG=240845
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1642263003 .

Cr-Commit-Position: refs/heads/master@{#372238}

https://chromium.googlesource.com/chromium/src/+/510e13d15

BUG=569643
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1649953002 .

Cr-Commit-Position: refs/heads/master@{#372237}

- Added RemoteChannelMain and RemoteChannelImpl to serialize and transmit
  inter-proxy messages between the main and impl components of the
  compositor using protobufs.
- Added RemoteChannelHost to be used by the cc embedder as the API for
  interacting with the impl components of the remote compositor.
- Added tests to verify the initialization and shutdown sequence for the
  remote compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1513643010

Cr-Commit-Position: refs/heads/master@{#372236}

BUG=529938

Review URL: https://codereview.chromium.org/1643523006

Cr-Commit-Position: refs/heads/master@{#372235}

This is currently necessary as windows may supply values not in the
enum list. Without extensible a validation error is generated, so that
you can't type ':' among others.

BUG=582279
TEST=none
R=yzshen@chromium.org
TBR=yzshen@chromium.org

Review URL: https://codereview.chromium.org/1644633007

Cr-Commit-Position: refs/heads/master@{#372234}

BUG=582274,582277
TBR=glider@chromium.org,lfg@chromium.org

Review URL: https://codereview.chromium.org/1649943002

Cr-Commit-Position: refs/heads/master@{#372233}

BUG=514815, 581951

Review URL: https://codereview.chromium.org/1641323002

Cr-Commit-Position: refs/heads/master@{#372232}

Still detect the situation when the app is creating WebView from two
processes sharing the same data dir, but do not throw a RuntimeError,
only print a warning.

BUG=558377,582146

Review URL: https://codereview.chromium.org/1641383002

Cr-Commit-Position: refs/heads/master@{#372231}

- VS2013 doesn't support constexpr
- windows.h defines helpful things like min and max macros
- Use HANDLE instead of HFILE

BUG=none

Review URL: https://codereview.chromium.org/1646823004

Cr-Commit-Position: refs/heads/master@{#372230}

Revert of GN: Use special toolchain for nacl64.exe, force is_component_build off (patchset #2 id:20001 of https://codereview.chromium.org/1580723006/ )

Reason for revert:
We are seeing errors on Win x64 fre/chk GN build bots and this is the most likely cause.  Reverting.

Original issue's description:
> GN: Use special toolchain for nacl64.exe, force is_component_build off
>
> The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
> compatible with component-style builds.  Build nacl64.exe in a special
> variant of the x64 toolchain, wherein is_component_build is always false.
>
> BUG=512869
> R=bradnelson@chromium.org, dpranke@chromium.org
>
> Committed: https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
> Cr-Commit-Position: refs/heads/master@{#372217}

TBR=bradnelson@chromium.org,dpranke@chromium.org,mcgrathr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512869

Review URL: https://codereview.chromium.org/1643803006

Cr-Commit-Position: refs/heads/master@{#372229}

This CL adds CombinedDesktopMediaList class and its associated unit tests. It intends to support chrome tab capture for JavaScript API chooseDesktopMedia().

Design document is in
https://docs.google.com/document/d/1zZOiayDzVkuIQ3twEdiE6S-LTXz9fWOGKjbMIsLTcAk/edit#heading=h.cetuprbl19fv

BUG=557222

Review URL: https://codereview.chromium.org/1622733002

Cr-Commit-Position: refs/heads/master@{#372228}

On VS2015:

d:\src\cr3\src\tools\battor_agent\battor_sample_converter_unittest.cc(28): error C2397: conversion from 'double' to 'int16_t' requires a narrowing conversion

R=brucedawson@chromium.org, charliea@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1648123002

Cr-Commit-Position: refs/heads/master@{#372227}

This CL adds valgrind config in mb_config.pyl for valgrind bots
on chromium.memory.fyi

R=dpranke@chromium.org
BUG=572694

Review URL: https://codereview.chromium.org/1648803002

Cr-Commit-Position: refs/heads/master@{#372226}

artOffset`.

Just only recognize with `percentage` when return value on
`startOffset` that is normalize value between 0 and 1.
Because occur to the problem on `SVGTextLayoutEngine::begin-
TextPathLayout`.

So check whether percentage or not, If no percentage, don't
recognize to normalize value.

BUG=576702

Review URL: https://codereview.chromium.org/1580293008

Cr-Commit-Position: refs/heads/master@{#372225}

BUG=266276

Review URL: https://codereview.chromium.org/1577723002

Cr-Commit-Position: refs/heads/master@{#372224}

--site-per-process flag.

Also resolved the flakiness as a side product.

BUG=373155,568710

Review URL: https://codereview.chromium.org/1585003002

Cr-Commit-Position: refs/heads/master@{#372223}

This supports communication via Google api to get an auth
code for GMS Core client and pass it to ARC instance. There
are two types of getting the auth code. Firstly, we try to
get it silently and secondary, in case when an additional
input is required from the user WebView dialog is shown.
Changed logic of starting ARC instance. Now its start is
controlled by ArcAuthService after communication with
Google auth servers.

BUG=571146
TEST=Provide additional unit_tests.
TEST=logcat shows that auth code is passed to ARC instance.
     Both modes are tested: silent and WebView based (can
     be forced by re-imaging)

Review URL: https://codereview.chromium.org/1618193003

Cr-Commit-Position: refs/heads/master@{#372222}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be0306ff..0e000221

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1641133006

Cr-Commit-Position: refs/heads/master@{#372221}