- 14 Oct, 2019 40 commits
-
-
Adithya Srinivasan authored
[sheriff] This is a reland of bf1742a3 to disable a flaky test until adithyas@ can take another look. Original change's description: > Portals: Disable TouchInputTransferAcrossReactivation > > Test fails flakily on all aura platforms. > > Bug: 1010675 > Change-Id: Ic1906b0421dab41ddc14f36462aff459867afc33 > Tbr: lfg@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836007 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702230} Bug: 1010675 Tbr: lfg@chromium.org Change-Id: Icbddd9cb318b1bf25678b4e812a62382e953a937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860297Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705591}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/6a2609dae219e4300dfc62b2a37f10b5c845547b..bc4c09df6416a3a0d0cf321c6c13023c77e2fec4 The following commits have Chromium bugs associated: bc4c09df6 Add a function to derive an EC key from some input secret. Bug: 1010968 Change-Id: I84d0b5bac83df17a747f64f94c24d1368f36c7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857519 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705590}
-
Tom Anderson authored
Also needed is [1] in webrtc, which fixes some build warnings. Could land in parallel. [1] https://webrtc-review.googlesource.com/c/src/+/156980 BUG=1012850 Change-Id: Ia24e490db5e71cf1add0e10f4c1264aefb69143c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859935 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#705589}
-
Nico Weber authored
This was a workaround for a toolchain problem we no longer have -- lld-link has thin static libraries and this is a no-op for it for that reason already. Bug: 857060 Change-Id: I98002cf0dbf70e9cfffb880d9c24984bed2ff51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860034 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#705588}
-
Matt Jones authored
This patch ensures the open and close events are only called a single time for the tests in BottomSheetObserver. Change-Id: I98b1dce25be5aa7e55cdcbead90518954b8747d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857543 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#705587}
-
Yves Arrouye authored
The SysInfo class will provide Chrome OS version from parsing the LSB_RELEASE file, so call it on Chrome OS too. Bug: chromium:1012048 Test: Manual Change-Id: Iba0e3a6d85005a1429f96c0a2d56eea11f8c465f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848503Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#705586}
-
Xianzhu Wang authored
To avoid too long filenames on Windows. TBR=johnchen@chromium.org Bug: 1014132 Change-Id: I062d56c0e75a34f6ce65ae4dffd84a7531e6716e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860499Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#705585}
-
Allen Bauer authored
Bug: 1005568 Change-Id: Ibc875c0628e355a06c2e334c9f97c5f4f6715322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853131 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#705584}
-
Maks Orlovich authored
The test is making a 3rd-party accessible cookie; we're going to require those to be secure. Also fix a bug in the test --- it was trying to append http:// twice. Bug: 1006816 Change-Id: I0d2cda25892b6633b0bc9c362d735540cde456b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860099 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705583}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I39f8c0d2e1e5052036822ec3804958496a31f2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705582}
-
Maks Orlovich authored
It's setting a 3rd-party-accessible cookie, so it must be secure Bug: 1006816 Change-Id: I1a2511f9f682ddf103beba987d76e013d0b2750a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860102Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#705581}
-
Evan Stade authored
Bug: 268984 Change-Id: I6a460108f1cce3c4fd45c243dd254d8877327eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851928Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705580}
-
edchin authored
Adds single web state closing test to WebStateList unittests. Change-Id: If129d6465d3e89047a044eaf8d3e25c8f450b1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860124 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705579}
-
Robert Sesek authored
These were disabled because they were flaky on 32-bit kernels and some Linux environments (like Chromecast). Rather than setting up the complex process hierarchy to have a real ptracer/tracee relationship, just issue the ptrace calls and test for the right error and/or death. Bug: 934930 Change-Id: Ib2d97ab25e7931d2b5ba8bd607f9db36184eb4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856798 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705578}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_fullscreen_options.h file was moved to third_party/blink/public/common/fullscreen. Since the file is no longer in the public/web/ directory we are also renaming it to fullscreen_options.h (and the struct defined in it to FullscreeOptions). Bug: 1008303 Change-Id: If96a8263b3bb696931ce9af4846f3d6dcbc40698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852288Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#705577}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71bbf632..f98ffad2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0de18aadff439c3f2d3e9146fc72df8761a52272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859838Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705576}
-
Elly Fong-Jones authored
One override of this method was a replacement with an identical implementation in BubbleDialogDelegateView. The other was BaseDialogContainer, which is part of the app info dialog. BaseDialogContainer originally moved *from* using a DialogClientView *to* using its own ClientView to fix https://crbug.com/445695, which was about the dialog having a strange default button. Since that time, DialogClientView became perfectly happy to have no default button, so I think that fix is now obsolete. That allows BaseDialogContainer to use DialogClientView again, which means most of the reimplementation of DialogClientView there can be removed. Unfortunately there is one remaining override of this method, in AssistantContainerView, so it can't yet be marked final. Bug: 1011446 Change-Id: I9331e847ec2572b4d6dc5e5e2909882ececd9da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856538Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705575}
-
Fredrik Söderquist authored
The interval timer could end up racing with the animation update timer, meaning that the new animation values had not yet been applied when the |retries| counter reached zero and the assertions were made. Refactor the test to trigger the next "action" (new pair of clicks or checking the result) when one of the timed elements listening on the "b.click" event has begun. Also change |retries| into counting how many clicks are remaining (rather than how many interval timer firings). Bug: 1013736 Change-Id: I374cb9c499ca18a791f76dabcb1db8bcd6f38461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859955Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#705574}
-
sczs authored
Uses the InfobarDelegate Icon to populate the Banner's icon. Screenshot: https://drive.google.com/open?id=1ig7tT72B6mFsqHtrAmDO5ANww6HKEGpj Bug: 961343 Change-Id: If9b8cddfd41b3cef7bc45e7165234f543b3a681d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857048Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#705573}
-
Sergey Kuznetsov authored
https://chromium-review.googlesource.com/c/chromium/src/+/1658231 is't enough for arm64, because __NR_membarrier (which code is 283) is greater than MAX_PUBLIC_SYSCALL (which is 279) -> rules was not applied. Increase MAX_PUBLIC_SYSCALL && add test. Bug: 966433. Change-Id: I99ed038dea7b2a332dd70fb75b97d908f5d2ca9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856160 Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705572}
-
edchin authored
This CL adds |-willCloseAllWebStates()| and |-didCloseAllWebStates()| to the WebStateListObserver. This allows observers to know when CloseAll has been called. This gives observers ability to batch process operations instead of processing each close individually. This CL will be quickly followed up with the first use case -- RecentTabs. In RecentTabs, the close all operation should be batched instead of being processed one at a time, which causes a UI freeze. Bug: 994229 Change-Id: I9dd47786c508409690e4a753593505d5da71d11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854463 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#705571}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be6f2ffa0faf..50dc0de928ba git log be6f2ffa0faf..50dc0de928ba --date=short --no-merges --format='%ad %ae %s' 2019-10-14 hjd@google.com Merge changes Iebde5f76,I8e5b4e64,I21d2b89e Created with: gclient setdep -r src/third_party/perfetto@50dc0de928ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6ad7fae0f12761c6629a36f98b3fb1760e797d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705570}
-
Thomas Tangl authored
... to the regular and the guest profile menu. Bug: 995720 Change-Id: I3fc6e47dce135e42b5861ed593a65ba81cde1a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859991Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#705569}
-
Raymond Toy authored
To facilitate optimizations for the delay node processing, split out the sample-accurate path and non-sample-accurate path into independent bits of code (mostly duplicated now). Then we can look at optimizing each path independently. No functional changes. Bug: 1012198 Change-Id: I6170aaa3a6c0dfc7ecf96c20963a4edcdac8a920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856725Reviewed-by:
Andrew MacPherson <andrew.macpherson@soundtrap.com> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705568}
-
Rune Lillesveen authored
Bug: 680331 Change-Id: I0ac853b95d453221cdc62517ef201858c55e0696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859785Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705567}
-
Deepanjan Roy authored
- Adds a directory under tools/perf/core where all the tbmv3 code will be landed as we're experimenting with them. - Adds a very basic run_tbmv3_metric script. Currently it consumes the output of trace processor and prints it back to the terminal. In subsequent CLs we will turn this output into a python histogram and output that instead. - Adds console_error_metric as an example tbmv3 metric. You can run it using ./run_tbmv3_metric.py --trace TRACE_FILE --metric console_error_metric Bug: chromium:1012687 Change-Id: I668268e707ae633b271256125e8a6d78701906f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846065 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#705566}
-
Juan Antonio Navarro Perez authored
These benchmarks no longer work as intended. These have been superceeded by gcMetric at: https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/metrics/blink/gc_metric.html Bug: 1011787 Change-Id: I6f20d4df4491de5c611fb9ff3376d68029c5feef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859963Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#705565}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1c834ea5451c..9bc8545214f9 git log 1c834ea5451c..9bc8545214f9 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 wbbradley@chromium.org build api metrics: ingest metrics from build_image Created with: gclient setdep -r src/third_party/chromite@9bc8545214f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If34f7b10df19f0eaa426dc16c88270d2a934a7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705564}
-
Mikhail Khokhlov authored
This is a reland of [1] with file paths in tests fixed for windows platform. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1849855 Bug: 981349 Change-Id: Ie52c40573f47a30363b3bae3db0ad5052115c1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857131Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#705563}
-
Amr Aboelkher authored
A device policy which controls the full-screen and docked magnifier accessibility features on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_screen_magnifier_enabled policy to 1, open System Tray => "Accessibility", check that "Fullscreen magnifier" is displayed with a green check in the login screen, and "Docked magnifier" is not displayed in the login screen. 2. Set the login_screen_screen_magnifier_enabled policy to 2, open System Tray => "Accessibility", check that "Docked magnifier" is displayed with a green check in the login screen, and "Fullscreen magnifier" is not displayed in the login screen. 3. Set the policy to 0, open System Tray, check that "Docked magnifier", and "Fullscreen magnifier" are not displayed in the login screen. Bug: 552439 Change-Id: I0f736f3c2c2410d8e281d03f61e3fb85e6ea4619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859981 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#705562}
-
Philip Rogers authored
Previously, "transform: translateZ(0)" was used as a compositing trigger in web tests. This patch updates these cases to use "will-change: transform" which is more explicit. Bug: 1012775 Change-Id: I35cccc654da8df868ce54e0d4e4ad9e1551b1552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854168 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705561}
-
Jochen Eisinger authored
Looks like the helper was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1640718 Bug: 934009 Change-Id: I04ea55f0b550d0d5ff80af5b913ad7ce073377dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859978 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#705560}
-
Ben Pastene authored
Those rotations were moved to internal configs a while ago, so milo/rotang can't see who's oncall. So they've been listed as 'none' for a while now. Also remove the 'chromiumos' header, which nothing in this file uses. Change-Id: I60282240593acfc24eae3662cfe3929ec45ace66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857097Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#705559}
-
nancy authored
When ArcAppListPrefs is destroyed, ExtensionApps doesn't clear the arc_prefs_. So ExtensionApps still calls arc_prefs_ to remove itself from the observer list, which could cause the memory issue, when ArcAppListPrefs is deleted first. Update ArcAppListPrefs to notify the observer, ExtensionApps, when ArcAppListPrefs is destroyed. Note: ExtensionApps doesn't depend on ArcAppListPrefs, becuase even if no ARC on the Chrome OS, ExtensionApps still exists. BUG=1013850 Change-Id: I389e7b7c2d4e11a5af7f927a1595f75d7b2cc1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857840 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705558}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/5843bfd65204..f76cf2ae5e7a $ git log 5843bfd65..f76cf2ae5 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 wub gfe-relnote: Implement QUIC MTU discovery v2. Protected by --gfe2_reloadable_flag_quic_mtu_discovery_v2. 2019-10-11 bnc Make QpackDecoderStreamSender buffer serialized instructions. 2019-10-11 rch Rename QuicSpdySession::SendMaxHeaderListSize() to QuicSpdySession::SendInitialData(). Make this method private and use max_inbound_header_list_size_ explicitly instead of requiring it to be passed in by the caller. 2019-10-11 rch Improve QuicSpdyStreamTest to call OnCryptoHandshakeEvent on the session to ensure that the various HTTP/3 initialization steps happen, matching what happens in production. 2019-10-11 vasilvv Create a shared interface to access QuicTransport*Session::IsSessionReady(). 2019-10-11 vasilvv Implement the QuicTransport server session subclass. 2019-10-10 rch Disable EndToEndTestServerPush.ServerPushOverLimitNonBlocking when http/3 is used Flip the chrome value for v99 to true Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: Idfc9ef147b5115a5ca2511b6180018f4f9205074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859494Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#705557}
-
Asanka Herath authored
While //net's header parser will reject strings with embedded NULs, HttpCHttpContentDisposition can be invoked directly on some arbitrary string. It should handle NULs gracefully in this case. Bug: None Change-Id: I31b7a89d27ebc01d8311d5fde156672d974543e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857520Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705556}
-
Tommy Steimel authored
This reverts commit c8281a39. Reason for revert: compile failing on many bots. Example: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/80546 Original change's description: > Include bloat: don't include browser_process_platform_part.h in browser_process.h > > Avoiding this include reduces the number of preprocessor tokens in > browser_process.h from 1,336,923 to 359,170. > > TBR=antrim > > Bug: 1014009 > Change-Id: Icc613c2889a6ca5fd5dd4b55a6bdd6b2772bcd4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856965 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705554} TBR=antrim@chromium.org,thakis@chromium.org,hans@chromium.org Change-Id: I5cb9d9c669bd7bf991a6eac0a24fca9076fb3d0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860277Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705555}
-
Hans Wennborg authored
Avoiding this include reduces the number of preprocessor tokens in browser_process.h from 1,336,923 to 359,170. TBR=antrim Bug: 1014009 Change-Id: Icc613c2889a6ca5fd5dd4b55a6bdd6b2772bcd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856965 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705554}
-
Oleh Lamzin authored
Add comment to the ApplyUsbEthernetMacAddressSourceToShill function if MAC address source is not specified yet. BUG=b:132240657 TEST=none Change-Id: I086eacbaeed7ddaf1b3ea4d9568b8cf78210be7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849857Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#705553}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c34e434df0d7..a4828a13c27a git log c34e434df0d7..a4828a13c27a --date=short --no-merges --format='%ad %ae %s' 2019-10-14 egdaniel@google.com Remove GrPixelConfigIsAlphaOnly call and transition calls to it. 2019-10-14 robertphillips@google.com Plumb GrPrimitiveType down to GrProgramDesc::Build Created with: gclient setdep -r src/third_party/skia@a4828a13c27a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Ia8ed9bf3914dbc6ca819311d1d1d45620cfd7ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859943Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705552}
-