Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 03 Dec, 2017 12 commits
    • Xing Liu's avatar
      Revert "Fix DownloadHistoryCheck on windows continuous builder." · cf116cc7
      Xing Liu authored 
      This reverts commit 2dcec349.

Reason for revert: Still flaky, see
https://bugs.chromium.org/p/chromium/issues/detail?id=791213

Original change's description:
> Fix DownloadHistoryCheck on windows continuous builder.
> 
> Currently it's flaky that a partial buffer is read through network
> pipeline when the first history db record is generated.
> 
> This CL changed the observer to be able to optionally wait for a
> certain number of bytes read from network IO.
> 
> Bug: 788160
> Change-Id: I110653433e8c80c2dabf9f3162df99d7bb354e86
> Reviewed-on: https://chromium-review.googlesource.com/790946
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Commit-Queue: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519930}

TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 788160
Change-Id: If59f7f82c7bd2a75bbc4655f665fc9f9581e170e
Reviewed-on: https://chromium-review.googlesource.com/804648Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521233}
      cf116cc7
    • Pavol Marko's avatar
      Enable client cert auth for sign-in frame StoragePartition · 230ea2c9
      Pavol Marko authored 
      Enable client certificate authentication in the sign-in profile for
the StoragePartition which is currently used by the sign-in frame.
Additionally, wire up the DeviceLoginScreenAutoSelectCertificateForUrls
policy to content settings on the sign-in screen.

BUG=723849
TEST=browser_tests --gtest_filter=WebViewClientCertsLoginTest.*

Change-Id: Ic5345bc3446c621008088909771c6eca445aa3f3
Reviewed-on: https://chromium-review.googlesource.com/790295
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: default avatarRyan Sleevi <rsleevi@chromium.org>
Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521232}
      230ea2c9
    • Robert Sesek's avatar
      crash_keys: Remove old "bad_histogram" key. · 97461ea2
      Robert Sesek authored 
      Bug: 598854
Change-Id: I380ef1cb8bf2de2a72d52091b619b374b4dc3c33
Reviewed-on: https://chromium-review.googlesource.com/804338
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521231}
      97461ea2
    • Ricky Liang's avatar
      media: upgrade camera module to support v2.4 API · 9359982d
      Ricky Liang authored 
      - Sync mojom files from arc-camera repo, which include Mojo
  interface updates for v2.4 API.
- Hook up the new functions in v2.4 API in unit tests.

BUG=36378334
TEST=unit tests
TEST=Make sure camera works on Soraka.

Change-Id: I428af0c37f706905eb20c43ea06c227995345855
Reviewed-on: https://chromium-review.googlesource.com/798933Reviewed-by: default avatarWu-Cheng Li <wuchengli@chromium.org>
Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521230}
      9359982d
    • Takashi Toyoshima's avatar
      Reland "ResourceLoadScheduler: add traffic monitoring metrics" · 83ff34c2
      Takashi Toyoshima authored 
      Explicit PLATFORM_EXPORT for an inner class static method
was needed for Windows.

This is a reland of 1cb7ac27
Original change's description:
> ResourceLoadScheduler: add traffic monitoring metrics
>
> This patch adds TrafficMonitor to count number of resource
> requests and bytes of received data. Data are counted
> per-frame basis, and classified by main frame vs sub-frames,
> and throttled vs not-throttled.
>
> Bug: 789354
> Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff
> Reviewed-on: https://chromium-review.googlesource.com/795482
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521202}

Bug: 789354
Change-Id: I9cf5edb2c8af0b5ecc09bf0b4deaba90e9f3fd66
Tbr: kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/804707
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: default avatarTakashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521229}
      83ff34c2
    • Gabriel Charette's avatar
      Introduce RunLoop::OverrideDelegateForCurrentThreadForTesting(). · 1ef212bd
      Gabriel Charette authored 
      This is a prerequisite to enable ScopedTaskEnvironment MOCK_TIME
on top of any RunLoop::Delegate (i.e. on top of MessageLoopForUI/ForIO).

This CL also removes RunLoop::Delegate::Client::IsNested() as it
was a mere shortcut for its TLS complement and had to switch to
using TLS itself to remain valid in override scenarios...
Ran base_perftests.exe --gtest_filter=*MessageLoop* in static/Release
and things look the same.

Bug: 708584
Change-Id: I143f6e6afb47de11f95702c337dbe63eb0887596
Reviewed-on: https://chromium-review.googlesource.com/784214
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: default avatardanakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521228}
      1ef212bd
    • Gabriel Charette's avatar
      Make RunLoop::Delegate methods public. · 46c535d2
      Gabriel Charette authored 
      This mimics the pre-existing paradigm for MessagePump::Delegate :
public methods on Delegate which are then privately inherited.

There were cr-dev discussions on these topics (composition vs private
inheritance) but I don't see a reason to deviate from the
pre-established MessagePump paradigm here.
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/XdsXTHy9lis/discussion
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/CwzjcWd9cYM/discussion

I did consider composition here (e.g. with a private RunDelegate
class in MessageLoop, but the many outer_-> in
Run/Quit/EnsureWorkScheduled made it ugly.

R=danakj@chromium.org

Bug: 708584
Change-Id: I42830b3a28d29b1a518db4cfc767a655de491a90
Reviewed-on: https://chromium-review.googlesource.com/798290Reviewed-by: default avatardanakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521227}
      46c535d2
    • Christopher Cameron's avatar
      viz/mac: Prepare the ground for CoreAnimation plumbing · 4bc282bb
      Christopher Cameron authored 
      The parameters for sending a CALayer tree from the GPU process to the
browser process will have to be shuffled a bit for viz. Before doing
this, clean up the existing path.

Current relevant sequence of events:
  * gpu::ImageTransportSurfaceOverlayMac populates
    gpu::SwapBuffersCompleteParams in the GPU process.
      * Structure includes gfx::SwapResponse,
        gpu::TextureInUseResponses, and CALayer parameters.
  * gpu::CommandBuffer un-and-re-packs this structure as
    GpuCommandBufferMsg_SwapBuffersCompleted_Params to send via IPC.
  * gpu::CommandBufferProxyImpl::OnSwapBuffersCompleted then
    un-and-re-packs that structure as two separate arguments
      * gfx::SwapResponse
        * Is consumed on all platforms
      * gpu::GpuProcessHostedCALayerTreeParamsMac
        * Is consumed by GpuOutputSurfaceMac only, passed by pointer
        * Includes gpu::TextureInUseResponses as a member
  * These arguments ultimately resurface in a function named
    OnGpuSwapBuffersCompleted in viz::DisplayOutputSurface or
    content::GpuBrowserCompositorOutputSurface (or subclasses thereof).

The reason for this patch is that, in viz, we will need to split up
gpu::GpuProcessHostedCALayerTreeParamsMac, because different
parts go to different places. In particular:
  * The actual CALayer-related parameters need to go up to the browser
  * The TextureInUseResponses parameter just goes to the GLRenderer
Since we're doing surgery in the neighborhood, some of the
un-and-re-packing can be done away with.

The changes made are:
  * Add a new gfx::CALayerParams structure
      * In gfx because it will be passed into ui code on the browser
        side.
      * Not ifdef-ed out on non-macOS (though is largely depopulated)
        to avoid ifdef-spaghetti (an is_empty parameter will be used
        for early-out)
      * Keep the IOSurface as a mach port much longer, because viz
        will need to re-pass it to the browser side (via mojo).
  * Populate gpu::SwapBuffersCompleteParams with all three
    separately-destined components:
      * gfx::SwapResponse (as before)
      * gpu::TextureInUseResponses (as before)
          * This is not ifdef-ed out even though it is macOS-only
            avoid preprocessor-spaghetti and to help testing.
      * gpu::CALayerParams (new)
          * This was previously just inline
  * Move gpu::SwapBuffersCompleteParams from service into common
      * This is passed without any inspection or modification from
        gpu::ImageTransportSurfaceOverlayMac to *GpuOutputSurfaceMac,
        where its sub-parts finally diverge.
      * This lets us remove the un-and-re-pack of parameters.
  * Delete the redundant structures:
      * GpuCommandBufferMsg_SwapBuffersCompleted_Params
      * gpu::GpuProcessHostedCALayerTreeParamsMac

Bug: 772576
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8fd06898a4b1f8432b563c0bc63975787b05cb46
Reviewed-on: https://chromium-review.googlesource.com/798642Reviewed-by: default avatarccameron <ccameron@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521226}
      4bc282bb
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ d75f3f99d..79ee73938 (1 commit) · 69666610
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/d75f3f99d47b..79ee73938d7d

$ git log d75f3f99d..79ee73938 --date=short --no-merges --format='%ad %ae %s'
2017-12-03 update-skps Update SKP version

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I4f430a68a384684569935c5d26ccd2b74b9f484b
Reviewed-on: https://chromium-review.googlesource.com/804917Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521225}
      69666610
    • Dmitry Skiba's avatar
      Categorize undispatched VIEW intents sent to .Main alias. · b90f227f
      Dmitry Skiba authored 
      Bug: 789732
Change-Id: I660cad683bcc96772ddb5fc25f1a94ae8a988bb6
Reviewed-on: https://chromium-review.googlesource.com/803617
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: default avatarMaria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521224}
      b90f227f
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ 1ec99b9b8..d75f3f99d (1 commit) · f35305d8
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/1ec99b9b8e27..d75f3f99d47b

$ git log 1ec99b9b8..d75f3f99d --date=short --no-merges --format='%ad %ae %s'
2017-12-01 fmalita Fix SVGPong slide crash in Viewer

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: Idff805c9e8eeb8ab6a3fffc4c5e26152ae9235d0
Reviewed-on: https://chromium-review.googlesource.com/804705Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521223}
      f35305d8
    • Jungshik Shin's avatar
      Disallow extremely rarely used LGC character blocks. · 9538209b
      Jungshik Shin authored 
      Explicitly disallows the following blocks.

Latin Ext B (Pinyin subblock), Latin Ext D, Cyrillic Ext B/C,
Greek Ext, Latin Additional (other than Vietnamese).

Note that Latin Ext C & E, Cyrillic Ext A do not belong to
[:IdentifierStatus=Allowed:] and need not be explicitly
banned.

218 characters are blocked. In the Unicode set notation, they're

[:IdentifierStatus=Allowed:] &  [:Ll:] &
[[\u01cd-\u01dc] [\u1c80-\u1c8f][\u1e00-\u1e9b]
 [\u1f00-\u1fff][\ua640-\ua69f][\ua720-\ua7ff]]

Below are the number of domains blocked before and after this CL out of
about a million .com domains as of 2017-11-30.

  6400 : before this cl
  7058 : after this cl
   658 : additional domains blocked with this CL


Bug: chromium:770709
Test: components_unittests --gtest_filter=*IDN*
Change-Id: I4de1df5f79b43d9ceddfd01c7dd9af61d1a0e130
Reviewed-on: https://chromium-review.googlesource.com/802978
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521222}
      9538209b
  3. 02 Dec, 2017 28 commits