- 12 Apr, 2018 40 commits
-
-
Tetsui Ohkubo authored
According to UX spec, FeaturePodButton has two click targets: the icon and the labels. If the feature supports both toggling and the detailed view, icon click toggles the feature and label click shows the detailed view. To implement this, this CL * Renames FeaturePodControllerBase::OnPressed() to OnIconPressed(). * Adds FeaturePodControllerBase::OnLabelPressed(). It forwards to OnIconPressed() by default. TEST=manual BUG=821671 Change-Id: I484b31a6b3a418c529de0c3957f823c33aadaf4d Reviewed-on: https://chromium-review.googlesource.com/1010682Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#550273}
-
Kyle Horimoto authored
They now include fields needed for the MultiDevice setup flow. Bug: 824568, 752273 Change-Id: Ie1375ae3a288fc0fb34e047cd20f81ea45cb1ea7 Reviewed-on: https://chromium-review.googlesource.com/1008202 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#550272}
-
Wenzhao Zang authored
The "current_wallpaper_.reset()" call in |ReloadWallpaper| was deleted earlier since it was believed to be useless, but without it, the |WallpaperIsAlreadyLoaded| check returns true which prevents wallpaper reloading. This results in a bug when the wallpaper has special shape (e.g. square) and it must be reloaded in order to fit a different display size. Also modified the |WallpaperBlurDisabledByPolicy| test since the author of the test was not aware that DEVCIE wallpaper only exists in login screen so most parts of the test are not meaningful. Bug: 831794 Change-Id: I7e2c78157eacc9034bb39de1a7a00729f8a26ec2 Reviewed-on: https://chromium-review.googlesource.com/1008604Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550271}
-
Sergey Berezin authored
BUG=790168 R=tandrii@chromium.org Change-Id: Ica651a82c9f29a47ee32e0b48b556da6768c0cc7 Reviewed-on: https://chromium-review.googlesource.com/1006190 Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#550270}
-
Robert Ma authored
Apparently tryserver.chromium.mac doesn't exist any more and mac_chromium_rel_ng has been fully migrated to LUCI. Change the configuration accordingly. Change-Id: I00b2aadb1096ef0e05eb8aeb7f6254d69f28078f Reviewed-on: https://chromium-review.googlesource.com/1010742Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#550269}
-
Patrick Noland authored
Add logic for building request protos and parsing response protos Add and record fetch-related histograms Add networking logic Update the traffic annotation and un-deprecate it Add tests for the above Bug: 807697 Change-Id: I4d3196190a9e0340bc8d4022af166596209cdc74 Reviewed-on: https://chromium-review.googlesource.com/999036 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Adam Michalik <xyzzyz@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#550268}
-
Mustafa Emre Acer authored
This CL triggers a reportNetworkConnectivity call when an SSL interstitial is to be displayed and either the only error is a name mismatch or that a known captive portal certificate is observed. This will cause Android to re-evaluate its captive portal status on all networks. Android may decide to put up a system notification if it detects a captive portal. Bug: 825970 Change-Id: Ifedcd7db0d184c9e4f7c2156df37766d7c298928 Reviewed-on: https://chromium-review.googlesource.com/996900 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550267}
-
Kevin Marshall authored
This test fails ~70% of the time on Win10, so disabling it for now. TBR=eirage@chromium.org Bug: 831796 Change-Id: Iaf5892327efe48ddbd1f2fe38f7f36a35a8bea20 Reviewed-on: https://chromium-review.googlesource.com/1008174 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550266}
-
Ken Russell authored
Make GpuFeatureData collection robust to GPU process crashes. On many of the VMWare Windows VMs used for testing, Chrome's GPU process crashes during startup. This was causing DevTools' SystemInfo collection to break, the browser to crash, and Telemetry to fail to start the browser, causing failures of the telemetry_perf_unittests and telemetry_unittests suites. Instead, robustly report that all GPU features are disabled, which causes the associated tests to be skipped. Bug: 800453 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If80125798064316e0033fddd2d43f04748c76778 Reviewed-on: https://chromium-review.googlesource.com/952778 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#550265}
-
Pavel Feldman authored
Bug: 831773 Change-Id: Ia5dfad17af526b495c38d6827292364a1d505dba TBR: dgozman Reviewed-on: https://chromium-review.googlesource.com/1010476 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550264}
-
Jamie Madill authored
The failure expectations are restored for two of the three new tests. Marking as flaky - if they continue to fail despite the flaky suppression we will need to mark them as failing. Bug: 696345 Bug: 818383 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8ac5db7e2c75f2c50cbea42523767336e5c431ea Tbr: geofflang@chromium.org Tbr: jdarpinian@chromium.org Tbr: kbr@chromium.org No-try: True Reviewed-on: https://chromium-review.googlesource.com/1010770Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#550263}
-
Yuwei Huang authored
Previously we never refresh the host list after it gets loaded, which increases the host-offline error by a lot. This CL fixes this by triggering host list refresh when the app is brought back from background (applicationDidBecomeActive:) and when the user is disconnected from the session (viewWillAppear:). Bug: 830849 Change-Id: Iddbef200cd894bbe60c2a1b42330a186eda80c76 Reviewed-on: https://chromium-review.googlesource.com/1003141Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550262}
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' third_party/blink`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done One include was added to third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc which previously depended on ptr_util.h being included by one of its headers. Bug: 755727 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I425109636a07f0f54c0f9a1019a5633fab153722 Reviewed-on: https://chromium-review.googlesource.com/1010266Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550261}
-
sczs authored
Initial CL for hooking up the Bottom Toolbar button to present ClearBrowsingData modally. In the future the presentation of the ClearBrowsingData VC will be done inside the NavigationController, this CL is just the first step for that. Bug: 805201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie950199bd14c7b256db62880983ba7166390e28f Reviewed-on: https://chromium-review.googlesource.com/1000405 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550260}
-
Sergey Ulanov authored
Zircon no longer logs to serial port by default on x64. Added kernel.serial=legacy flag to make sure logging still works with newer SDK. Change-Id: I1758d900baefbc3ce4e992cc29bc6cc467dca7dc Reviewed-on: https://chromium-review.googlesource.com/1008632Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550259}
-
erikchen authored
On ChromeOS, the off-the-record profile always exists, so the check was preventing heap dump uploads. We already refrain from heap profiling incognito renderers, so the check was not providing additional utility. Change-Id: Ie72aec8f9dddd12a26c37eeeeefb1172ed6bd64b Reviewed-on: https://chromium-review.googlesource.com/1010525Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550258}
-
https://pdfium.googlesource.com/pdfium.git/+log/87b67f842fe5..e6d4559a1b6c $ git log 87b67f842..e6d4559a1 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 thestig Clean up some CFX_RenderDevice code. 2018-04-12 tsepez Bounds check in CPDF_CMap::GetNextChar. 2018-04-12 dsinclair Remove CXFA_DocumentParser::m_bDocumentParser flag 2018-04-12 dsinclair Fixup CFX_XMLParser::GetStatus return 2018-04-12 dsinclair Remove CFX_XMLDoc and call the parser directly 2018-04-12 dsinclair Cleanup CXFA_FFDoc 2018-04-12 dsinclair Rename CXFA_SimpleParser to CXFA_DocumentParser 2018-04-12 dsinclair Fold CXFA_DocumentParser into CXFA_FFDoc 2018-04-12 dsinclair Retrieve the XML tree in the DocumentParser 2018-04-12 dsinclair Allow retrieving the XML tree from the CFX_XMLDoc 2018-04-12 dsinclair Merge CFX_XMLParser and CFX_XMLSyntaxParser 2018-04-12 dsinclair Cleanup some CFX_XMLParser code 2018-04-12 dsinclair [xfa] Remove form checksum abilities Created with: roll-dep src/third_party/pdfium BUG=chromium:831100 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I969480c7afe092585a38c33ee21e397149412764 Reviewed-on: https://chromium-review.googlesource.com/1010465 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550257}
-
Oksana Zhuravlova authored
This change updates the ContentSettingPatternSource struct to have a value member instead of unique_ptr. Bug: 646113 Change-Id: I40dba73510b5d5c0fb34d34ff04fe492916031ad Reviewed-on: https://chromium-review.googlesource.com/1005882Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#550256}
-
Ryan Sleevi authored
Cleanup the URLRequestContext* family of classes by ensuring that they take an SSLConfigService as a scoped_refptr<>, rather than as a raw pointer, as they will retain it locally. Also, remove some unnecessary net:: qualifications on classes, given that these classes now live in //net. BUG=none Change-Id: I8518f5c77a6e2981900c3e38a7589e97ff1f0335 Reviewed-on: https://chromium-review.googlesource.com/1010304Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550255}
-
Ehsan Karamad authored
This CL introduces the bare feature. 'vertical-scroll' intends to block specific sandboxed frames (which do not have the feature enabled) from interfering with user's vertical scrolling in the page. The details are explained in the document: https://docs.google.com/document/d/1qiWelnMlsOHuT_CQ0Zm_qEAf54HS5DhoIvEDHBlfqps/edit?usp=sharing The actual logic for blocking such frames will land in follow-up CLs. Bug: 611982 Change-Id: I17bfc3e421cda06c4cba40efb6de046bed66bd14 Reviewed-on: https://chromium-review.googlesource.com/1007843Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550254}
-
Minh X. Nguyen authored
Change-Id: I27e87c6d385c7414dc7f1f1a4ed5f5e0ba74eb4e Reviewed-on: https://chromium-review.googlesource.com/988744 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550253}
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' ui`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done Bug: 755727 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0da214ef2afbb6d41d1a14ee21ac91df34ddb2e2 Reviewed-on: https://chromium-review.googlesource.com/1007893Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550252}
-
Min Chen authored
dismiss on internal display. Crashed happened because of CHECK_GE(force_hidden_counter_, 0). Remove |force_hidden_counter_|. Update backdrop state in UpdateBackdrop instead. Bug: 822096 Change-Id: I06bd4c3012bb646c4ef0608d7b7ae48e9a321542 Reviewed-on: https://chromium-review.googlesource.com/1002863 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550251}
-
vitaliii authored
After crrev.com/c/1004896, all user consent events, which were persisted when sync was disabled, are resubmited to sync when sync is enabled. In this CL, the user consent events whose |account_id| differs from the sync account are not resent to sync. Instead they are just left in the persistent store waiting for the proper account to start syncing. This CL does *not* include any garbage collection. This also does not prevent recording consents for a different account via calling RecordUserEvent when sync enabled. However, this should not happen. Bug: 781765 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I91c7844b03fc4e2606c254c8aae6347faa364cdb Reviewed-on: https://chromium-review.googlesource.com/1007063 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#550250}
-
Michael Thiessen authored
https://chromium-review.googlesource.com/c/chromium/src/+/1007922 failed to account for the animation cancel logic properly. Bug: 831589 Change-Id: I46081899198e1381310c758bc9e6f937ddf1cd2f Reviewed-on: https://chromium-review.googlesource.com/1010524Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#550249}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/d636fe53af52..be5df6080154 $ git log d636fe53a..be5df6080 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 marpan vp9-svc: Make constrained_layer_drop default for svc. 2018-04-05 jianj Fix settings for num of tiles in samples & tests. 2018-04-06 marpan vp9-svc: Hybrid search on spatial layers whose base is key. 2018-04-06 marpan Revert "vp9-svc: Fix to first superframe when inter_layer is off." 2018-04-04 marpan vp9-svc: Fix to first superframe when inter_layer is off. 2018-04-05 marpan vp9-svc: Fix to disable cyclic refresh on key superframes. 2018-04-05 johannkoenig update codereview.settings 2018-03-27 johannkoenig ios configure: quiet shell warning 2018-04-03 marpan vp9-svc: Fix in choose_partitioning for different scaling. 2018-04-03 linfengz rm CONVERT_TO_SHORTPTR in vpx_highbd_comp_avg_pred 2018-04-03 marpan Fix to svc sample enocoder for visual studio build. 2018-04-02 johannkoenig remove support for yuv 411 2018-04-02 marpan vp9-svc: Fix to svc sample encoder for write_out. 2018-03-30 jzern vp9_datarate_test: relax over shoot constraints 2018-03-30 jianj VP9 SVC: Write bitstream for each spatial layer in sample. 2018-03-30 jianj Code cleanup for datarate tests. 2018-03-28 jianj Split datarate_test.cc to vp8, vp9, svc ones. 2018-03-27 johannkoenig helper script for sanitizer testing 2018-03-26 linfengz Shrink size of mode_map in struct TileDataEnc 2018-03-26 linfengz Update sad4d x86 functions Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I49e1a06d1f7ab71c77bc0cdbc11fddd0cdcd4cc7 Reviewed-on: https://chromium-review.googlesource.com/1008641Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#550248}
-
Kristian H. Kristensen authored
One last spot where we need to adjust the internalformat to match the new default buffer format on Ozone. Bug: 829943 Test: Boot to login, verify screen not black Change-Id: Id45eac8cbd029dfbaea03d46effe5efb1fc7dc55 Reviewed-on: https://chromium-review.googlesource.com/1000406 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#550247}
-
rodmartin authored
This feature allow users to export the policies in a JSON file. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I708abc3465ecf2a469979fb7d13b22ed947ed392 Reviewed-on: https://chromium-review.googlesource.com/966590 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550246}
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' cc gpu`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done Bug: 755727 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5e19711f9932ba6ef30c8361fd62387bfab507ac Reviewed-on: https://chromium-review.googlesource.com/1007894Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550245}
-
Jun Choi authored
Change-Id: I9a2ad98352d6057ea81b898d789081baaf101742 Reviewed-on: https://chromium-review.googlesource.com/956267 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550244}
-
Filip Gorski authored
* Creates a CSMetricsReporterProvider, which creates CSMetricsReporter * Gives the CCSService repsponsibility for proxy creation and injection of a freshly made metrics reporter. * Moves metrics reporting to CCSServiceProxy Bug: 824183 Change-Id: I68df53707160a08038f7cf9666a13c0cd5d56dee Reviewed-on: https://chromium-review.googlesource.com/1006481 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550243}
-
Ria Jiang authored
RenderWidgetHostViewChildFrame::GetParentView can be null for guest views, use RenderWidgetHostViewGuest::GetOwnerRenderWidgetHostView instead. Bug: 829264 Test: PDFExtensionHitTestTest Change-Id: I5d695b33e741006f528ba090aa994e6aadc64c40 Reviewed-on: https://chromium-review.googlesource.com/1007487Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550242}
-
Xiaocheng Hu authored
The function is unused after crrev.com/c/1000952. It's also a bad-designed function due to the requirement of a seemingly redundant parameter. Hence, this patch removes it. Bug: 822575 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iefdc4a9f6cde0d8f5edfc6d4c75750b1655f6c39 Reviewed-on: https://chromium-review.googlesource.com/1007973Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#550241}
-
Yaron Friedman authored
WebContents.getContentBitmapAsync was unnecessarily passing the bitmap to java before compressing it and saving to disk. Instead, changes the API so that the caller provides a directory in which to grab screenshots, and then WebContents seemlessly creates a new temp file, compresses to jpeg and saves to that directory, requiring 0 java heap allocation. As part of this async screen capture, also get a public Uri for exporting via ContentProvider because all clients do this anyway. BUG=651348 Change-Id: I6be01348f225adfa370c6a5e08ebd57f15e8fe93 Reviewed-on: https://chromium-review.googlesource.com/935670Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550240}
-
Rayan Kanso authored
Dispatch instance of BackgroundFetchUpdateEvent with a backgroundfetched event. Add suitable constructors to BackgroundFetchUpdateEvent and BackgroundFetchSettledFetches. Add WebKit Layout test for BackgroundFetchUpdateEvent. Bug: 822765 Change-Id: I557bd4f599009841444cbe2cbc53c4419e37892f Reviewed-on: https://chromium-review.googlesource.com/1005055Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#550239}
-
Moe Ahmadi authored
This CL replaces the js intervals, introduced in crrev.com/c/943321 for tracking form related changes, with a MutationObserver. The new approach allows for tracking a wider range of changes to the forms more reliably which can be used for detecting known cases of dynamically changing forms. There's also a slight performance gain based on the following benchmark averaged over 10 runs: http://browserbench.org/Speedometer2.0/ MutationObserver: 33.45 +/- 0.59 Intervals: 32.60 +/- 0.27 This CL also makes other changes to make dynamic form filling work on iOS. Change-Id: Ibc4acae07bed1f207de84ab3e084402f6ed3cca2 Reviewed-on: https://chromium-review.googlesource.com/994053 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550238}
-
Dmitry Gozman authored
- Do not mistakenly disable emulation in wrong RWHI. When cross-process iframe goes away, we cleanup and disable emulation, which did mistakenyl go to parent's RWHI. - Include emulation agent for OOPIFs to support touch emulation. Otherwise Emulation.setTouchEmulatioEnabled goes nowhere. - Prevent crash in swapping in due to early context initialization. With touch emulation enabled, we initialize origin trials on document load, which may be an initial empty load. This can trigger window proxy initialization and check when swapping in later. Bug: 826651 Change-Id: I33a9de9383810cebab449cb2d02c14c54f5980a3 Reviewed-on: https://chromium-review.googlesource.com/1003324Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550237}
-
Wei Guan authored
This is because changes to use the Chrome OS Audio Service (CrAS) are not backwards compatible. BUG=831250 Change-Id: If7eb2ff01224fc16c76574e53e29ff6eacc41ec0 Reviewed-on: https://chromium-review.googlesource.com/1004922 Commit-Queue: Wei Guan <weigua@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#550236}
-
agrieve authored
This reverts commit 0c15ca3a. Reason for revert: Supersize now deals with thin archives as of 6a15a6c4 Original change's description: > Disable thin archive builds on Android. > > Temporary fix while support is added to supersize. > > Bug: 830843 > Change-Id: I677782d52c9927ed08d2a07c5272c18a0901e3d6 > Reviewed-on: https://chromium-review.googlesource.com/1003999 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549397} TBR=thakis@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830843 Change-Id: I10a8c141be3808b7095f686c44127f7a102abb7d Reviewed-on: https://chromium-review.googlesource.com/1010322Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550235}
-
Michael van Ouwerkerk authored
Bug: 800421 Change-Id: Ia33bdfadc93c39c92a6b7ce33c0bf3fbc82a52a6 Reviewed-on: https://chromium-review.googlesource.com/1007722Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#550234}
-