- 29 Aug, 2020 23 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb235b33d3dd..f609a00aca46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mek@google.com Change-Id: I7ef36658b5380598760b6eda34cf5a2dddd3899c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383031Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802877}
-
Rulong Chen（陈汝龙） authored
One large favicon might cause an OOM crash when it is converted to a Java-backed Bitmap in Android. Failing to render the favicon still seems preferable than *ever* crash here. R=torne@chromium.org,boliu@chromium.org Bug: 1112794 Change-Id: Idca46d2e1484ce4538b79e8df6910de7b18ef1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376929 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802876}
-
Dirk Pranke authored
The "generic_wrapper" scripts now being generated during the build need to know whether or not to use Xvfb when running a test; this CL adds that logic. Bug: 816629 Change-Id: Ic2cae1295d7edf583236d6d2640c220c883324ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370507 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#802875}
-
Maksim Ivanov authored
Enable for Chromium the "bugprone-use-after-move" diagnostic provided by clang-tidy. This check attempts to catch bugs when a C++ variable is used after it was std::move()'ed elsewhere. This diagnostic was discussed at https://groups.google.com/a/chromium.org/d/topic/cxx/IDD4f6Pmnxc/discussion (see also the doc attached to that thread). Bug: 1122844 Change-Id: I9aa1996dcac8307259d86821ce7b4f5cf2175dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383010Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802874}
-
zhaoyangli authored
Replicated iOS 13.6 form factors to iOS 14 in the full-configs CQ bot. Moved iOS12 runtimes on full configs bot to ios-simulator-noncq for capacity restrain. Bug: 1123108 Change-Id: I34109ef9278b916de94457b12f4c247eac54d073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382223Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#802873}
-
Richard Knoll authored
This removes all hardcoded strings from the HTML WebUI files and adds proper strings to the grdp file. Also replaces the button to configure the device name externally with an inline edit control. Bug: None Change-Id: Ibd2a17b5b9b8234633399fd6c50fae11fc15e45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376857 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802872}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9100465414a9..5ac807b26749 2020-08-28 cclao@google.com Vulkan: Let stageSubresourceUpdateAndGetData use ctx staging buffer 2020-08-28 jmadill@chromium.org Enable -Wreturn-std-move-in-c++11. 2020-08-28 jmadill@chromium.org Enable -Wbad-function-cast. 2020-08-28 timvp@google.com Add third_party/abseil-cpp to ANGLE 2020-08-28 cclao@google.com Vulkan: Fix alignment issue with context staging buffer 2020-08-28 lehoangq@gmail.com Metal: Fix handling of vertex attrib offset not multiple of 4 2020-08-28 jmadill@chromium.org Enable two override suggestion warnings. 2020-08-28 cnorthrop@google.com Capture/Replay: Track groups of strings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: Manhattan MEC works again Change-Id: Ic6832b238622ddf56538b74026ca8185cb59a9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802871}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb7c6ea5..4b3de99d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad218fcbb8d2f936003619ed6f262dd3841e0620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802870}
-
Peng Huang authored
This is a reland of a37811d1 Original change's description: > SkiaOutputDevice: use buffer format passed to Reshape > > Bug: 1108406 > Change-Id: Iaca79e3b6c1d66e421711c46f75a1cb614b7f961 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378745 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802450} Bug: 1108406 Change-Id: Iec517b1f5b711d9457a09841cedd2db22b520aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382197Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802869}
-
Andrey Kosyakov authored
This reverts commit 82b85893. Reason for revert: let's give this test another change. it seems to reliable pass for me locally and I think the original failure was rather due to a front-end race fixed here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2242769 Original change's description: > Revert "DevTools: add tests for extensions on DOM UI pages" > > This reverts commit 3c0f2556. > > Reason for revert: test is extremely flaky > > Per https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBicm93c2VyX3Rlc3RzQERldlRvb2xzRXh0ZW5zaW9uVGVzdC5UZXN0RXZhbHVhdGVPbkNocm9tZVNjaGVtZQw this flakily fails about 10 times an hour. > > Original change's description: > > DevTools: add tests for extensions on DOM UI pages > > > > This is the chrome-side counterpart of > > https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128732 > > > > Bug: 1059577, 795595 > > Change-Id: Iec2ee772a42b4c7bc2249627c0839f7506f0cd1d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129344 > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#756375} > > TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,bmeurer@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1059577, 795595 > Change-Id: I2919088167b064086b315d8c3a64df569d95c844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188512 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#766575} TBR=dgozman@chromium.org,mek@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1059577 Bug: 795595 Change-Id: Ibd719500160685664de90415d718b88b4621b52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382487Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#802868}
-
Himanshu Jaju authored
Removes pending TODO and implements the test for registering a send surface when we are already receiving incoming files. Change-Id: I9dd8955b4c423ed6b567ebb2028ed839b9a1f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382753 Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
Austin Eng authored
Mapped GPUBuffers' memory is owned and externally managed by dawn_wire. Using EmptyDeleter tells the backing store this allocation does not hold memory and will not increase GC pressure. Bug: 1061960 Change-Id: Ia44a5dc1be89d7b55540247c90bce614172fa2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380086 Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#802866}
-
Lei Zhang authored
Make PrintViewManager::PrintForSystemDialogNow() consistent with PrintViewManagerBase::PrintNow(). Disconnect from the existing print job before starting a new one. Bug: 704900 Change-Id: I40a2fae0f22651be489596c34c448b84c1665503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382615Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802865}
-
Daniel Classon authored
This is a reland of dd30c5d1 Change was unrelated to the test failures. Original change's description: > [CrostiniPage] Link "Set up Crostini" search result to the setting > > Fix a bug where the "Set up Crostini" search result did not connect to > the eponymous setting, so the setting was inaccessible for deep linking. > > Bug: 1084154 > Change-Id: I0b5452425eb19203c61c8b45ba4d2d96afc16264 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380749 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Daniel Classon <dclasson@google.com> > Cr-Commit-Position: refs/heads/master@{#802704} TBR=khorimoto@chromium.org,dclasson@google.com Bug: 1084154, 1123194 Change-Id: Ia08b6010bba1975e446174c552f465d4d5d49765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383091Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
David Black authored
This delegate is the first of the `HoldingSpaceKeyedServiceDelegates` to be added. A follow up CL will refactor existing service logic into a `HoldingSpaceDownloadsDelegate` and `HoldingSpacePersistenceDelegate`. The delegate added in this CL is tasked with watching the local file system for changes to files backing holding space items. It notifies the service on file removal so that it can perform model updates. Currently, a watcher is added per file but this will later be changed to a single watcher per directory. This CL is mostly concerned with getting things in place and additional optimization can come later. Bug: 1122418 Change-Id: I9a796bd1318268a62e0c7227a9a299b566cc2ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382399 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802863}
-
rbpotter authored
Fixed: 1123220 Change-Id: Iefc01cc978f6aff863f3c4244c32ed57b137df59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382884Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802862}
-
wutao authored
Bug: b/164190937 Test: manual Change-Id: I8b2f4bf1ec90cb1869add3f1f71c8b96175589a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382214 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802861}
-
nancylingwang authored
The new app icon factory code in AppService calls display::Screen::GetScreen to get the scale, so in unit tests, sometime, it crashes: 0x7f3430a96390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #4 0x558ca24e91ea (anonymous namespace)::GetPrimaryDisplayScaleFactor() Modify unit tests to set the TestScreen. Built bots run 20 times, and there is no flaky tests for BuiltInAppTest.Build. BUG=1115837 Change-Id: Id3ad017f5e15dbadfc6b28ef0d65295bfcc799b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379419 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802860}
-
Thomas Guilbert authored
WebCodec already has UseCounters on its different subcomponents. Origin trial infrastructure cannot aggregate UseCounters. This CL adds a global counter that tracks anytime WebCodecs is used, to allow running an origin trial. Bug: 1123170 Change-Id: Ic8c816d99af16c78a50ebc16d693362368a7483b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382408 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#802859}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae1672bdb5c3..6fd391a016f3 2020-08-28 herb@google.com uv in x - fix iphone6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ia54f3d5e2bd63b26676d4a830693a371bdf3198f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382018Reviewed-by:
-
Brandon Jones authored
Blink counterpart to https://bugs.chromium.org/p/dawn/issues/detail?id=502 Due to an issue with Blink's bindings generation this CL needed to be a bit sneaky about handling the method overloading, which resulted in some annoying manual validation. The alternative, however, would be exposing a different method name which would add several more steps to the whole deprecation process, so this feels worthwhile. Bug: 1121762 Change-Id: I3f4ac324c6d91a27bfd5fabb17b1b142f7021598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376456 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I93ca2df444e6277bfe02c22ac19666f0a137896b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383231Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802856}
-
Maggie Chen authored
This reverts commit 8ce938a2. Reason for revert: <Suspect this CL breaks Linux FYI Ozone bot and Linux FYI SkiaRenderer Vulkan (NVIDIA)/(Intel HD 630) > Original change's description: > Reland "Reland "X11 and Ozone: enable use_x11 and use_ozone"" > > This is a reland of 75363679 > > Original change's description: > > Reland "X11 and Ozone: enable use_x11 and use_ozone" > > > > This is a reland of f985905e. > > > > This change broke our headless build: > > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. > > assert(ozone_platform_x11) > > ^----- > > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. > > "//ui/events/platform/x11",. > > > > Fix: > > Don't include x11 build for headless case. > > > > Original change's description: > > > X11 and Ozone: enable use_x11 and use_ozone > > > > > > This is the final change that enables use_x11 > > > and use_ozone for Linux builds and (as it was > > > before) excludes X11 for chromeos, chromecast, > > > lacros. > > > > > > in order to run ozone/X11/wayland, one must pass > > > —enable-features=UseOzonePlatform > > > —ozone-platform=x11 or wayland. otherwise, > > > non-ozone/X11 is used. > > > > > > it’s also possible to completely disable X11 > > > so that clients, who need that kind of build can > > > continue to have that. > > > > > > Bug: 1085700 > > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > > Cr-Commit-Position: refs/heads/master@{#801523} > > > > Bug: 1085700 > > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#801692} > > Bug: 1085700 > Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802773} TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I093bf5be51d6858d895c59d6bb31f3aa61c162b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383110Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802855}
-
- 28 Aug, 2020 17 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af2dca5c5320..79257bae3c9a 2020-08-28 lalitm@google.com Merge "tp: fix startup metric when success is seen multiple times" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8fd84566dd12f0cc0bdc1f2df9a5d20005d6a028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382501Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3a542a140fac7a43a24de761e6f46afb31e166a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382506Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a745d8886808..bb235b33d3dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mek@google.com Change-Id: I31f257e95524fe3b9fd7b7a66a54a904809bcfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382505Reviewed-by:
-
chrome://multidevice-internalsRegan Hsu authored
* New PhoneHub tab to chrome://multidevice-internals * Adds a toggle that when flipped on, will cause a FakePhoneHubManager to be used instead. Screenshot: https://screenshot.googleplex.com/7dimKet6oWrzeR4 Bug: 1106937 Change-Id: Ib2697abfaf15153b394689a804ff5ff73994ed15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380608Reviewed-by:
-
Mohammad Refaat authored
for iOS 13 we added fetchDataRecordsOfTypes call to make sure that cookiestore exist. but with iOS 14 this doesn't seem to be enough as the order of callbacks is not grantueed anymore. We have to wait for the fetchDataRecordsOfType callback to finish before asking for cookies operations. Bug: 1121425 Change-Id: I6a52e54ff2663ac77e8edc6dde1359a68f11604e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381091 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Jesse McKenna authored
This change skips attempting PWA launcher update if the launcher path does not exist. Chrome updates PWA launchers by iterating over a list of enabled bookmark apps. It determines each app's expected launcher path and attempts to update it. This fails if the launcher path does not exist. This change saves time spent attempting update when it's not necessary, and should reduce noise in the WebApp.Launcher.UpdateResult metric. Bug: 1123064 Change-Id: Ibb30bb054ad338b84f8fe6ab66f919d800755ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382752Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#802849}
-
Dana Fried authored
As pointed out, the IDS name of the string was previously changed, but the comment associated with it was not. This makes the comment both correct in context and follow the inclusive code guidelines. Skip-Translation-Screenshots-Check: True Bug: 1100024 Change-Id: I8a5dfa4e1a2f641c710aa636ba0be351f2d2e246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373946Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#802848}
-
Alan Screen authored
Cleanup born from move of printing::ColorModel enum into mojom in r799398. Reduce the number of static_cast<int> in the code by updating the API to accept printing::mojom::ColorModel in as many places as possible. Bug: 809738 Change-Id: Ib1d0024a94e21b9bf982174d99e85b04616f1009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368082Reviewed-by:
-
Zach Trudo authored
CloudPolicyClient must be built on the main UI thread, this means that it needs to be built asynchronously. Bug: chromium:1078512 Change-Id: I7aca6e9085091a8ac4d2c6209e10260f1295c450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368318 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#802846}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2014e7b9290e..a2e6c1a149f4 2020-08-28 capn@google.com Optimize multisample resolve with SSE2 instructions 2020-08-28 capn@google.com Add a fast multisample resolve code path 2020-08-28 capn@google.com Make multisample resolve a Blitter method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3f6c31b6221b3b4cf12bc265a6fce2f959b1b817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382696Reviewed-by:
-
Bence Béky authored
Follow-up to https://crrev.com/c/2380573. Change-Id: I9dfff2099fd47601998ff775d019e79d7710c2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382198Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#802844}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1e3f57ef7c0..af2dca5c5320 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie0f95ddc51a0a5bd4b15cd081a1bb2352cf1cc22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382306Reviewed-by:
-
Yuly Novikov authored
Flaky timeout. TBR=bsheedy Bug: 1122373 Change-Id: I5a10681d5d0bc5dea24c168c9c27e254623cdce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382409 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#802842}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3e6999154e2cbb54e35a1428762970d973732f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382871Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802841}
-
Mei Liang authored
This CL uses AccessibilityNodeInfo to set the checked state of the selectable tab, so it can be used by the accessibility services. Bug: 1117205 Change-Id: Ia42b44fc2c280ceb690c2b08114368279a541d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380412 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802840}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e87a9ab4a13..ae1672bdb5c3 2020-08-28 egdaniel@google.com Remove the kFramebufferOnly flag from our validation checks again. 2020-08-28 herb@google.com secure AtlasLocator 2020-08-28 herb@google.com store the page bits in U only If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ie25f6878190999ad6e0094bcae281e98ef46d627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382503Reviewed-by:
-
Himanshu Jaju authored
Replacing my name with correct crbug issues. Change-Id: I9911cbfa68b6f41a50cf9c7aecfb4f9045fdcd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382830Reviewed-by:
-
