- 28 Jan, 2020 40 commits
-
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for GetSafe()/SetSafe(). However, secialization is not really necessary here with templates and can be moved into GetSafe()/SetSafe() methods without changing generated code. Bug: 819294 Change-Id: Ib6d7b7760b7b1f3f88a395f5ab3fb4788defbb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010793Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#735766}
-
Jeremie Boulic authored
Extend storage handler's tests by checking my files size computation. The "My files" row on the setting's storage page displays the size of My files and android play files (excluding apps). The Downloads folder is bind mounted on [android files path]/Download. The files in these folders shouldn't be counted twice. This test registers a temporary location for My files and Android files, for a given profile, and tests that the size computed under "My files" produces the expected output. Bug: 1013459, 1044495 Change-Id: Ib5f6b58a73eb6b732f88c9117bbfefbcdc179f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016689 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#735765}
-
Takashi Toyoshima authored
This is a reland of 6e293feb Original change's description: > OOR-CORS, WebView: Add CORS tests for requests from custom schemes > > Behaviors have been unclear, but if requests are made from a custom > scheme, the Origin header in outgoing requests should be set to > "<scheme>://" without containing the host:port part those are > officially required to be a proper origin for such special cases > in WebView. > Servers can use "Access-Control-Allow-Origin: *" or > "Access-Control-Allow-Origin: <scheme>://" to permit such accesses. > > This patch adds tests to verify these behaviors to keep compatible > behaviors. > > Bug: 1035366 > Change-Id: Ia08e7b4ed764225566c3b09edef2980cfa1b1b70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010591 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735332} Bug: 1035366 Change-Id: Ic63d48287fa789dfb1697426dd47168068a97127 TBR: torne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024649Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735764}
-
Takashi Toyoshima authored
Update the plan to remove it at m84. This is because there is an agreement that 4 milestones notice will be provided prior to removing the policy. https://www.chromium.org/Home/third-party-developers Bug: 1036230 Change-Id: I7e8a710a116df37ea6099a2036f7f471b4394f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022363 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735763}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7ee8ca5a321c..067755621ca9 git log 7ee8ca5a321c..067755621ca9 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 748ad200897b..34e16df059f8 (6 commits) 2020-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fcef6dcb6ab2..086aded3cb74 (9 commits) Created with: gclient setdep -r src/third_party/skia@067755621ca9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I923b79be89a026e7478243f1b2228b1846d297d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735762}
-
matterchen authored
Port forwarding in Cros will allow users to add new ports and activate, deactivate and remove existing ports. When any of the utilities are called, the port forwarding library will invoke the permission broker client to change the ChromeOS port forwarding settings. In future work we will also save port forwarding preferences such that a user's preferences will persist over container shutdown. Revert CL comment: Reason for revert: CrostiniPortForwarderTest.AddPortDuplicateFail failing on Linux Chromium OS ASan LSan Tests (1) First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36750 Failure example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890488549187658624/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniPortForwarderTest.AddPortDuplicateFail__status_CRASH_/0 Actions taken: Built tests and ran with address sanitizer, confirmed existence of issue. Made appropriate changes and confirmed address sanitizer does not raise issues anymore. everything builds Bug: chromium:848127 Test: crostini_port_forwarder_unittest.cc (+Address Sanitizer) and Change-Id: Ib1d1b901b9f9e45fb7e85feaa0b97be026feabac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018363Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#735761}
-
Hitoshi Yoshida authored
Adding it misleads as if the interface is originally defined in core/. For example, ServiceWorker is defined in modules, and includes a mixin AbstractWorker which is defined in core. Then ServiceWorker's |components| returns both core and modules. This CL skips adding component information in merging mixins to prevent such troubles. Bug: 839389 Change-Id: I63dd8cdb3c75f56bfa5ba22d06042de42712b6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024230 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#735760}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/11b66cf1103c..8a6f9a03f020 git log 11b66cf1103c..8a6f9a03f020 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 steveanton@webrtc.org Export IceParameters::Parse for use in Chrome Created with: gclient setdep -r src/third_party/webrtc@8a6f9a03f020 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044521 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7785fc63d9476cad6ef8f29e9fed1ec54017d970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023882Reviewed-by:
-
Clark DuVall authored
Some of the menu items were showing up as @<id> because the wrong Resources were used to resolve IDs from the menu. This is fixed by overriding getTheme() if we have a resources override context, so anybody who uses the resources from the theme will get the correct object. Bug: 1046158 Change-Id: I3e22f385ba01eb5cc9bc49c7cf9d98e98386ccf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024151Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#735758}
-
John Chen authored
Includes tests in virtual/text-antialias directory. TBR=wangxianzhu@chromium.org Bug: 1028242 Change-Id: I4f4148a990c193a1405e81a954b17341bed365e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023524Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735757}
-
Morten Stenshorne authored
BreakBeforeChildIfNeeded() needs to make the block-offset relative to the fragmentainer, so passing an offset that's relative to the BFC gives less work than passing one relative to the containing block. This is just cleanup - no behavior changes. Change-Id: I49fa3415e37191e285c2d4844465862d46ebc58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023887Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#735756}
-
Findit authored
This reverts commit 2fe77415. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 735748 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJmZTc3NDE1NjI3YjAzZGEwYWYwZWRhZjA3Y2ZmOWNjY2MzYTI4MzYM Sample Failed Build: https://ci.chromium.org/b/8890045091910242336 Sample Failed Step: compile Original change's description: > [Structured metrics] Add metric collection and upload logic. > > This is the final CL for the core of the structured metrics system. It > ties together the KeyData class (for managing keys and computing hashes) > with the metrics provider, and implements logic to: > > 1. Hash and store incoming structured metrics events. > 2. Provide stored metrics events for upload. > > It also adds integration tests for the system, checking that an event > created through the public API is correctly prepared for upload. > > Other misc changes: > > - Some minor refactoring of event_base.{h,cc} and equivalent changes > to events_template.py, to fix some bad style. > - Added a missing RemoveObserver call to the metrics provider dtor. > > Bug: 1016655 > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735748} Change-Id: I49a0897dee3a1a5df3b07f60abdf53da74c568c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024575 Cr-Commit-Position: refs/heads/master@{#735755}
-
David Vallet authored
Note that this still lets you selecting the language and ordering for accept-language requests, just that the option of using the language as "System text" is disabled. Currently we offer Norwegian Nynorsk as an UI language. The removed code tries to map it to Norwegian Bokmål, but these two languages are similar, but not the same (https://www.skapago.eu/en/bokmal-nynorsk/). Furthermore, since we don't actually map it (https://source.chromium.org/chromium/chromium/src/+/master:ui/base/l10n/l10n_util.cc;drc=4d93574ee586e569d9412f837c74824eb79ba02e?originalUrl=https:%2F%2Fcs.chromium.org%2F) the language actually fall-backs to english when selected. Since Norwegian Nynorsk is actually not a supported language, it is better to not offer it as a system language. TEST=manual (ChromeOS on linux) Bug: 1044756 Change-Id: Ice228606313c603cd1214703b024b8f370c5ccb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024128 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735754}
-
Jay Harris authored
This is in preparation for the file handling origin trial, where file handling will be available on a per app basis. This CL makes no functional changes but instead changes the API used to check if file handling is enabled. Old Check: if (base::FeatureList::IsEnable(blink::features::kFileHandlingAPI)) New Check: if (file_handler_manager().IsFileHandlingAPIAvailable(app_id)) Currently, the implementation of |IsFileHandlingAPIAvailable| is simply the old check. In https://crrev.com/c/1940001, this will be changed to also be true if |app_id| has a valid FileHandling API origin trial token. Note: This also restricts file handling in extensions to extensions where from_bookmark() is true (this should have always been the case). Bug: 1028448 Change-Id: I525bb7bf03f052b79721fdc13fb154b34fa411a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016688Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#735753}
-
Ankit Kumar 🌪️ authored
This CL introduces a new accessibility role type named kPdfActionableHighlight which is needed to make highlights in PDF accessible. There is no existing role type which can effectively denote a PDF highlight, hence the need for a new role type. Bug: 1008775 Change-Id: Ia57a273561c82fc5b7daf2dad96f479e34cc0636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914140Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735752} -
Ian Clelland authored
This also removes the virtual test suite, and the failing test expectations from the experimental build. The default values for the two initial features are also set to their correct web-compatible defaults. Bug: 993790 Change-Id: I308676b0c63524ad4a229a03940b928f95a384c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019464 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735751}
-
Hugo Benichi authored
It is sometimes necessary to correlate Android logs with host logs for a specific network service for debugging some connectivity issues. This is difficult to do with anonymized logs from feedback reports which do not have GUIDs or SSIDs. This patch adds to ARC++'s net.mojom NetworkConfiguration objects the DBUS path of the associated shill service. This will allow ARC++ to print it in logcat and dumpsys without leaking any PII. The service path is essentially a monotonically growing integer that does not persist after reboot. dumpsys wifi. Bug: 147270970 Test: flashed ARC and Chrome on eve, manually checked logcat and Change-Id: I61c1a7b3b5476975a72e31347b6af485f9e0961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021786Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#735750}
-
Aaron Leventhal authored
When an expectations file for accessibility dump tree or event tests has more lines than the actual output, the test must fail. Without this change, the following will produce false positives in our test results: - Expected events the end of event expectations, but are not fired, - Expected objects at the end of the object hierarchy that do not exist in the actual object hierarchy. Bug: None Change-Id: I4bb65bb73b0d8af7380c85e59c7891c466c95fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015429 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
tby authored
This is the final CL for the core of the structured metrics system. It ties together the KeyData class (for managing keys and computing hashes) with the metrics provider, and implements logic to: 1. Hash and store incoming structured metrics events. 2. Provide stored metrics events for upload. It also adds integration tests for the system, checking that an event created through the public API is correctly prepared for upload. Other misc changes: - Some minor refactoring of event_base.{h,cc} and equivalent changes to events_template.py, to fix some bad style. - Added a missing RemoveObserver call to the metrics provider dtor. Bug: 1016655 Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735748}
-
Jeremie Boulic authored
Initial tests for the settings' storage management UI. Testing the UI behavior when simulating message callbacks from the back-end. The focus of these tests is on the upper part of the storage page, with global statistics related to the local filesystem. Other tests for each row of the storage page coming in follow-up CLs. "totalSize" removed from 'storage-size-stat-changed' callback message. Its value isn't used on the JS side. browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest" Test: Bug: 1044495 Change-Id: I2541e563ab0885c87a43800e32e297d5c3abb2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014629 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
rbpotter authored
- Use Polymer.Templatize instead of extending Templatizer behavior, since Templatizer behavior is now legacy/deprecated. - Add a closure compiler target for settings idle load This is in preparation for migrating settings idle load to Polymer 3 Bug: 1042558 Change-Id: I820f1a51aff09478277f3aae1ad1611fdc334a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023472 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735746}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd7fd960be69..7ee8ca5a321c git log fd7fd960be69..7ee8ca5a321c --date=short --first-parent --format='%ad %ae %s' 2020-01-28 bsalomon@google.com Fix bug in NPOT shader wrap mode impl Created with: gclient setdep -r src/third_party/skia@7ee8ca5a321c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I48062d91e7dbcced3184ead6e04552d8c2531156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024568Reviewed-by:
-
Kinuko Yasuda authored
- Blink.CookieJar.SyncCookiesSetTime - Blink.CookieJar.SyncCookiesTime Bug: 1032107 Change-Id: I2bf177f31246ebb6eefe4fc5d50772614dce65c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018904 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#735744}
-
Kenichi Ishibashi authored
This is similar to crrev.com/c/2018625 but for GetUserKeysAndDataByKeyPrefix(). Bug: 1039200 Change-Id: Idb4d36a9582860a9bbd8f30bad21ba56ae587849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022364 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#735743}
-
Jay Harris authored
This will allow us to clean up expired file handlers in this CL: https://crrev.com/c/1940001 Bug: 1028448 Change-Id: I69ba5d2ea8822a0ec3743b0255f38a2a3f243076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018566 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#735742}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbc74b472299..b83d660071cb Created with: gclient setdep -r src-internal@b83d660071cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1023913,chromium:1028270,chromium:1044158,chromium:1045987,chromium:1046119 Tbr: jbudorick@google.com Change-Id: I89ced6aeaf3515aa4486e18534e0c7e07d43c46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023881Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735741}
-
Kent Tamura authored
They are unnecessary since crrev.com/735492. This CL should have no behavior changes, however this updates a rendering test for empty lines. Bug: 1040828 Change-Id: I83c665eb2a136a98d5f9dbcc8b435964fb177c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024187Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ib96f3bad7f62353c68162330789b58726cce8afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024469Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735739}
-
Shakti Sahu authored
This CL changes the prefetch tab title text from Articles for You to Explore Offline. Bug: None Change-Id: I52bd208106ed1d73e685690cf0c57896322f50ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021294 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#735738}
-
Joel Hockey authored
This fixes crashes in incognito mode where CrostiniManager is null. Bug: 1038164 Change-Id: I9da95285a32a643246c4b16376f0af4fa2c31567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024587Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#735737}
-
Xing Liu authored
Currently when clicking on the "Review" button, on Mac, it will always not navigate to the expected URL. On Debian, sometimes nothing happens. On Mac, if the notification has no origin, then click event will not be forwarded to NotificationHandler. This CL removes the origin check. Also changed the URL navigation API used to open the URL. TBR=dtrainor@chromium.org, peter@chromium.org Bug: 1042124 Change-Id: Ife2c1a5e5949b1d933e4048dfa11a62144ba6bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023747Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735736}
-
Kinuko Yasuda authored
Having 'for_blink' typemap that is mostly same as the original one feels a bit awkward (also services/network directory talking specifically about 'blink' seems a bit of layering violation). Bug: 787254 Change-Id: I16a6164f52a6c4c4defd00e4107d7d741d838463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016524Reviewed-by:
-
Gabriel Charette authored
As agreed upon in design doc @ https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit?ts=5e1c66d5&pli=1#bookmark=id.ll79iqi5rlpp base::ThreadPool counterpart to move away from post_task.h is @ https://chromium-review.googlesource.com/c/chromium/src/+/1977964 API usage migration will be done in a follow-up mega CL. This CL at least uses it in its own tests. See https://chromium-review.googlesource.com/c/chromium/src/+/2015655 for how this will look in practice for a few callsites. Bug: 1026641 Change-Id: I98771fd68a513bf0a4776672a8d75fcbbb200bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014055 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735734}
-
Gabriel Charette authored
Migrates everything in base/task but post_job.h and lazy_task_runner.h which will be migrated in their own CLs. Bug: 1026641 Change-Id: If58acf8dd79ef848a16df210d4a283db10231a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996991 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#735733}
-
Yue Zhang authored
Bug: None Change-Id: I6712fb9a0c2df38a6c7a9612420f362258984ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024114 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735732}
-
Junbo Ke authored
Hit ERR_READ_IF_READY_NOT_IMPLEMENTED in SocketDataPump::ReceiveMore() when switching the Cast HTTP server to network::server::HttpServer. Add the implementation to unblock the migration. Bug: b/118771830 Merge-With: eureka-internal/342047 Test: CQ & manual Change-Id: I44666fa5b7f741d757c4382798b69f461a1e7fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018597 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#735731}
-
Jeremie Boulic authored
Initial tests for the StorageHandler, C++ side of the storage management page. Testing functions retrieving storage statistics of the local filesystem. Test: unit_tests --gtest_filter="*StorageHandlerTest*" Bug: 1044495 Change-Id: I8632f4607360deb4c0b4068d2db545e08a8db406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016767Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d1d9d35216b..086aded3cb74 git log 2d1d9d35216b..086aded3cb74 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 syoussefi@chromium.org Return the correct location count for matrices in structs 2020-01-27 courtneygo@google.com Vulkan: Allow user to specify preferred device Created with: gclient setdep -r src/third_party/angle@086aded3cb74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I83036211488fab82c887122d9488629831df7b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023872Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca7b3bf33052..9d635962bc78 git log ca7b3bf33052..9d635962bc78 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 ukai@google.com OWNERS: add ukai for cipd_manifest.* Created with: gclient setdep -r src/third_party/depot_tools@9d635962bc78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8067646c54fa0f6dc73e4a231751db45aa1217cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023878Reviewed-by:
-
Piotr Bialecki authored
- hit test subscription should fail when the session has ended - implement feature descriptor and feature policy for hit test - add WPTs to check whether subscription succeeds/fails appropriately Changes: Change-Id: Ib7735ca3c1015a4e3742c71d6d144e24a79c935e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019608 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735727}
-
