GitLab

BUG=598332

Review-Url: https://codereview.chromium.org/2304703003
Cr-Commit-Position: refs/heads/master@{#416455}

https://chromium.googlesource.com/skia.git/+log/54682e856cb6..af92a7f85a5f

$ git log 54682e856..af92a7f85 --date=short --no-merges --format='%ad %ae %s'
2016-09-03 mtklein kNumWindows is only used in GPU builds

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2305203002
Cr-Commit-Position: refs/heads/master@{#416454}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/54acca7c4f74..4f812c9035e6

$ git log 54acca7c4..4f812c903 --date=short --no-merges --format='%ad %ae %s'
2016-09-03 perezju [Telemetry] Switch ShouldTearDownStateAfterEachStoryRun to True as default

BUG=640990

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2307273002
Cr-Commit-Position: refs/heads/master@{#416453}

In response to ESCAPE key desktop chrome is selecting all the contents
of Url bar. Making same behavior in Android Chrome as well.

BUG=631075

Review-Url: https://codereview.chromium.org/2211433002
Cr-Commit-Position: refs/heads/master@{#416452}

clip-path's are applied before fragmentation, which means that we need
to adjust the coordinate space for the clip-path and its reference box
"manually" to get the correct visual coordinate space.

Also fix the origin used for clip-path to be the top-left corner of the
reference box. This only applies when SVG <clipPath> elements with
clipPathUnits='userSpaceOnUse' is referenced.

BUG=626097
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2300383002
Cr-Commit-Position: refs/heads/master@{#416451}

The original fix meant that SendThemeImage() always fell back to
SendThemeBitmap(), which wasn't desirable.

BUG=442384, 497949
TEST=Navigate to chrome://theme/IDR_SETTINGS_FAVICON@16x.  The resulting image should be large.

Review-Url: https://codereview.chromium.org/2279373002
Cr-Commit-Position: refs/heads/master@{#416450}

Cr-Commit-Position: refs/heads/master@{#416449}

https://pdfium.googlesource.com/pdfium.git/+log/d21f22e2c07d..738766eefaf1

$ git log d21f22e2c..738766eef --date=short --no-merges --format='%ad %ae %s'
2016-09-02 jaepark Clean up redundant code in PDF_ENABLE_XFA guard in FFLCommon.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2311543003
Cr-Commit-Position: refs/heads/master@{#416448}

Change flags up to the state at Fri Sep  2 21:57:45 EDT 2016
https://codereview.chromium.org/2309613002/

Round results of multiplying QuicBandwidth and QuicTime::Delta rather than truncating.  No behavior change expected.

This will result in slightly more accurate time calculations, but should
not make any real impact, since we should not be relying on
microsecond-level-precision to that extent.

Chromium bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=640984

Merge internal change: 131334594
https://codereview.chromium.org/2309603002/

Fix QUIC end to end tests to actually run the individual params one at a time as the comment says.

Merge internal change: 131328806
https://codereview.chromium.org/2307253002/

Improve test case naming in stateless_rejector_test

Old:  [ RUN      ] Flags/StatelessRejectorTest.InvalidChlo/0
New:  [ RUN      ] Flags/StatelessRejectorTest.InvalidChlo/v36_ENABLED

Merge internal change: 131205533
https://codereview.chromium.org/2311543002/

Limits only 16 new QUIC connections can be opened per epoll event.

Change QuicBufferedPacketStore to buffer early arrived packets as well
as CHLO and use this to buffer CHLOs whose connection's creation is
postponed.

Protected by --quic_limit_num_new_sessions_per_epoll_loop.

Merge internal change: 131102299
https://codereview.chromium.org/2310543002/

Include the two QUIC version sets in connection close details.

Merge internal change: 131098194
https://codereview.chromium.org/2292083006/

Allow QUIC servers send a TTL for the server config, as opposed to explicit expiration, to mitigate client clock skew. Protected by enabled --quic_send_scfg_ttl.

Merge internal change: 131052582
https://codereview.chromium.org/2305513003/

Add new connection option (BWS2) for an alternative bandwidth resumption experiment.

Merge internal change: 131048253
https://codereview.chromium.org/2293173004/

Clean up QuicCryptoServerStream::GenerateConnectionIdForReject code

Merge internal change: 130997336
https://codereview.chromium.org/2289363003/

Remove deprecated flag --quic_neuter_unencrypted_when_sending

Merge internal change: 130989175
https://codereview.chromium.org/2297883002/

Store the QUIC server's crypto config expiration time explicitly in the client's CachedState, instead of parsing it out of the server config each time.

In preparation for the REJ containing a TTL instead of an explicit
expiration, to mitigate clock skew.

Merge internal change: 130965621
https://codereview.chromium.org/2289243003/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2308043003
Cr-Commit-Position: refs/heads/master@{#416447}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/31399854..3fd3ba53

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2302303003
Cr-Commit-Position: refs/heads/master@{#416446}

Eventually these classes are intended to replace ScriptValueSerializer and
ScriptValueDeserializer as they exist today.

BUG=chromium:148757

Review-Url: https://codereview.chromium.org/2305703002
Cr-Commit-Position: refs/heads/master@{#416445}

I believe this was introduced in https://codereview.chromium.org/1467603002 .
Previously, URLRequestChromeJob::DataAvailable() called NotifyDone() directly in
the case of a failed request, but it was changed to call ReadRawDataComplete(),
which is only appropriate when you've been reading data, i.e. the request is in
the IO_PENDING state.  (The function DCHECKs that that's the case, and that
DCHECK is what's failing.)

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2279293004
Cr-Commit-Position: refs/heads/master@{#416444}

Revert of Remove unneeded split_count assignments (patchset #4 id:60001 of https://codereview.chromium.org/2311493002/ )

Reason for revert:
Due to this landing after my revert of Brett's change, it broke the world, e.g. https://build.chromium.org/p/chromium/builders/Android/builds/61684 . Since I'm not sure if the patch is quite right, I'll revert this too.

Original issue's description:
> Remove unneeded split_count assignments
>
> Refactoring of WebKit gn files has made splitting libraries less
> necessary. This broke generating of build files. This change
> removes the unneeded assignments.
>
> The error, in the generate_build_files step, was:
>
> C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
>   -> returned 1
> ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no effect.
>     split_count = 5
>                   ^
> You set the variable "split_count" here and it was unused before it went
> out of scope.
> See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be included.
>     "//third_party/WebKit/Source/core",
>     ^---------------------------------
> GN gen failed: 1
>
> It first appeared in build 10455:
> https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10455/steps/generate_build_files/logs/stdio
>
> Suspect is crrev.com/2299143005
>
> TBR=brettw@chromium.org
>
> Committed: https://crrev.com/f7d8febdf0166e2193b5e34e81b6b9dfb9ffd7c4
> Cr-Commit-Position: refs/heads/master@{#416441}

TBR=brettw@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2303293004
Cr-Commit-Position: refs/heads/master@{#416443}

Review-Url: https://codereview.chromium.org/2311573002
Cr-Commit-Position: refs/heads/master@{#416442}

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10455/steps/generate_build_files/logs/stdio

Suspect is crrev.com/2299143005

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2311493002
Cr-Commit-Position: refs/heads/master@{#416441}

This change enables keyboard focus, as well as making the button show
as a button on screen readers.

No UI change, except that the button has a ripple now. The ripple was
missing.

BUG=626879,643309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2305973002
Cr-Commit-Position: refs/heads/master@{#416440}

Revert of Inline core HTML and SVG sources in the GN build. (patchset #1 id:1 of https://codereview.chromium.org/2299143005/ )

Reason for revert:
This broke official builds, see https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10455 :

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm.

Original issue's description:
> Inline core SVG sources in the GN build.
>
> This adds targets in the corresponding directories where the various SVG files
> live. The SVG files are kept in separate targets in the "layout" and "style"
> subdirectories so that the current separation of SVG code is maintained.
>
> TBR=dpranke
>
> Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
> Cr-Commit-Position: refs/heads/master@{#416283}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2308953002
Cr-Commit-Position: refs/heads/master@{#416439}

Revert of Move more of webcore_remaining into GN build files. (patchset #2 id:20001 of https://codereview.chromium.org/2301383003/ )

Reason for revert:
Trying to get https://codereview.chromium.org/2308953002/ to apply

Original issue's description:
> Move more of webcore_remaining into GN build files.
>
> This makes more GN build files for various subdirectories of core and adds the
> file lists from the .gypi to those files.
>
> Since there are now so many places requring WebCOre boilerplate, this adds a
> new template for defining core components that automatically does most setup.
> This also cleans up the existing callers.
>
> Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
> Cr-Commit-Position: refs/heads/master@{#416344}

TBR=dpranke@chromium.org,dglazkov@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2304353002
Cr-Commit-Position: refs/heads/master@{#416438}

This CL wires getting/setting |fillLightMode| parameter
in idl/mojom/jni files, updating LayoutTests.

Factored out photo-related settings configuration
in VCCamera2.java in configureCommonCaptureSettings(),
that is also a bit polished for better understanding
of how 3A configurations work together.

Also renamed MeteringMode's "unavailable" with "none"
following the Spec. ("none" is more descriptive since
it's used for getting and setting state).

BUG=518807

Review-Url: https://codereview.chromium.org/2301053004
Cr-Commit-Position: refs/heads/master@{#416437}

CompositorFrame is to be submitted from OffscreenCanvas from
either main or worker thread (but not both at the same time);
therefore, another interface "OffscreenCanvasFrameReceiver"
is created only when commit() is invoked.

This CL follows the class design structure in this diagram:
www.lucidchart.com/documents/view/346a55cc-0ab1-48e8-9d34-90f59d36094e

Currently, we only submit a Green color frame for simplicity.
More CLs will follow to fill in image data to the compositor
frame.

BUG=563852

Review-Url: https://codereview.chromium.org/2294963002
Cr-Commit-Position: refs/heads/master@{#416436}

Cr-Commit-Position: refs/heads/master@{#416435}

BUG=555865

Review-Url: https://codereview.chromium.org/2292393004
Cr-Commit-Position: refs/heads/master@{#416434}

This is the first part of a multi-part series of patches:

   1   This patch
   2-N Additional support in Blink, Media Router, UX, etc.
   N+1 https://codereview.chromium.org/2148643002 with Intent to Implement+Ship

This patch:

- Adds support to WebPresentationClient for passing multiple URLs to startSession/joinSession/setDefaultPresentationUrls
- Updates PresentationService mojo interface
- Updates PresentationServiceImpl/PresentationServiceDispatcher
- Passes a single URL from Blink to WebPresentationClient
- Passes a single URL from PresentationServiceDispatcherImpl to MR
- Updates unittests

BUG=627655

Review-Url: https://codereview.chromium.org/2174693004
Cr-Commit-Position: refs/heads/master@{#416433}

BUG=643383

Review-Url: https://codereview.chromium.org/2308893002
Cr-Commit-Position: refs/heads/master@{#416432}

This change rolls in a few changes:
- Removes DelegateState::PAUSED_BUT_NOT_IDLE state.
- Removes all blocks against suspending prior to kHaveFutureData.
- If suspended, triggers resume when prior to have kHaveFutureData
if the didLoadingProgress() timer reports true.
- Always notifies the delegate of DelegateState::GONE; this ensures
the idle timer is always restarted if we didn't quite get enough
data to reach kHaveFutureData.
- Fixes pause timer to handle newly supported background video;
which doesn't set a state of DelegateState::GONE

BUG=612909, 643383
TEST=new and updated unittests.

Review-Url: https://codereview.chromium.org/2289543005
Cr-Commit-Position: refs/heads/master@{#416431}

BUG=598073, 504347

Review-Url: https://codereview.chromium.org/2302873005
Cr-Commit-Position: refs/heads/master@{#416430}

https://pdfium.googlesource.com/pdfium.git/+log/fc1d16f76f17..d21f22e2c07d

$ git log fc1d16f76..d21f22e2c --date=short --no-merges --format='%ad %ae %s'
2016-09-02 tsepez Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.
2016-09-02 tsepez Remove CFX_Matrix::Copy() in favor of assignment
2016-09-02 tsepez Make CPDF_GeneralStateData private.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2305173002
Cr-Commit-Position: refs/heads/master@{#416429}

And tidy up proguard_config -> proguard_preprocess_config rename

Verified locally that ChromePublic.apk had no size change from
this patch.

BUG=640836

Review-Url: https://codereview.chromium.org/2310473002
Cr-Commit-Position: refs/heads/master@{#416428}

BUG=641594

Review-Url: https://codereview.chromium.org/2286883003
Cr-Commit-Position: refs/heads/master@{#416427}

CancelPendingSeek() was called from the render thread, but the
WeakFactory in FFmpegDemuxer is for use on the media thread.

BUG=643441
TEST=none

Review-Url: https://codereview.chromium.org/2305923002
Cr-Commit-Position: refs/heads/master@{#416426}

* Improve comments
* Eliminate -webkit-transition that seems to do nothing
* Group related CSS selectors near each other in preparation for combining/modifying them
* Don't use RTL folder images on Mac (see https://cs.chromium.org/chromium/src/chrome/browser/resource_delegate_mac.mm?rcl=0&l=50 )
* Use "x .y" instead of "x > * > .y" when the two will select the same elements, for brevity
* Remove unnecessary size arg to getFaviconImageSet() (matches default value)
* Don't use the name "scale_factor" for floats relating to scale, as "scale" and "scale factor" are distinct concepts.  Use "scale" when that's what is meant.
* Avoid unnecessary using directives.
* Use a helper function to avoid repeating the same multi-part conditional
* NULL -> nullptr
* Improve function and variable names
* Eliminate NOTREACHED() that can, in fact, be reached

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2278423002
Cr-Commit-Position: refs/heads/master@{#416425}

Delete corresponding GYP files.

TBR=dpranke
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2304303002
Cr-Commit-Position: refs/heads/master@{#416424}

OSCrypt can now save its encryption password in gnome-keyring, where
that library exists.

BUG=602624

Review-Url: https://codereview.chromium.org/2297573002
Cr-Commit-Position: refs/heads/master@{#416423}

https://pdfium.googlesource.com/pdfium.git/+log/bbee445c5a77..fc1d16f76f17

$ git log bbee445c5..fc1d16f76 --date=short --no-merges --format='%ad %ae %s'
2016-09-02 tsepez Make CPDF_Path have a CFX_Path rather than inheriting

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2302743005
Cr-Commit-Position: refs/heads/master@{#416422}

BUG=609156

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2306183002
Cr-Commit-Position: refs/heads/master@{#416421}

invalidateCaret() once had another caller, but that day is long gone, as in, yesterday.

Review-Url: https://codereview.chromium.org/2306813004
Cr-Commit-Position: refs/heads/master@{#416420}

Made changes so that MacViews can accept drops from
other applications.

BUG=599585

Review-Url: https://codereview.chromium.org/2307633002
Cr-Commit-Position: refs/heads/master@{#416419}

This inlines the .gypi variables and deletes the obsolete files.

TBR=dpranke

Review-Url: https://codereview.chromium.org/2308173002
Cr-Commit-Position: refs/heads/master@{#416418}

BUG=635203

Review-Url: https://codereview.chromium.org/2272493002
Cr-Commit-Position: refs/heads/master@{#416417}

When building midi_manager_winrt.cc, following warning is raised:
warning C4467: usage of ATL attributes is deprecated.

Attributed ATL code has been deprecated. New code style can be found in
https://msdn.microsoft.com/en-us/library/mt723604.aspx.

BUG=512433

Review-Url: https://codereview.chromium.org/2301523008
Cr-Commit-Position: refs/heads/master@{#416416}