- 21 Jul, 2020 40 commits
-
-
Ben Kelly authored
This CL consists of the following changes: * Plumbing to remember the request method used to load a fetch Response. * Storing the request method alongside the Response in cache_storage. * Using this information in the padding computation. * Black box http web test. Bug: 1039882 Change-Id: Ifcf4a638b1de857260bf44e5683224410dc7bf26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303770Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#790370}
-
Maksim Sisov authored
This patch resolves mostly to the following pattern: #if defined(USE_X11) DoThis(); #elif defined(USE_OZONE) OzonePlatform::DoThat(); #endif Two ifdefs are combined to a single ifdef now with if (IsUsingOzonePlatform()) condition is added. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ie8f8560ffb9ab7ab24b10412a5a612c3cc279373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250250 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#790369}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1a073785503..0bc68bd16484 2020-07-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision be103000..abd2dc65 (790129:790286) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I532e7ffb44b83fdfa0d9ab253e320234b700b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790368}
-
Hyunjune authored
getPointAtLength[1] on SVGGeometryElement should throw InvalidStateError for with non-rendered, so this patch throws InvalidStateError if there is no LayoutObject on the target element. [1] https://svgwg.org/svg2-draft/types.html#__svg__SVGGeometryElement__getPointAtLength Bug: 972979 Change-Id: I26eb5330127ebbca9fbf55d796ce8159a09bfcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147168 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#790367}
-
Vasilii Sukhanov authored
Fixed: 1066048 Change-Id: I37daeeec01b97dd14246635322b44b9649e32cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308716 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#790366}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9818fd6fc72..0dd63428948f 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from dd3511549b18 to bfe4f378aee6 (1 revision) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 717e7877cac1 to 8b5ed4448dfe (3 revisions) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ea6f21a052c9 to 97f9923235cf (4 revisions) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b1346703979e to 7cc0ead05174 (5 revisions) 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9eef54b2513c to b99a6a727318 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I57cf82e25ebb906497eeaea20fd9a2c89dc8446c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309287Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790365}
-
Gyuyoung Kim authored
This CL migrates FrameHostMsg_DidStopLoading to content's FrameHost interface. The existing OnDidStopLoading is renamed to DidStopLoading. This CL moves BrowserTest.RenderIdleTime test to WebContentsImplBrowserTest.RenderIdleTime and calls mark_child_process_activity_time() through DidStopLoadingInterceptor to support the test. Bug: 1102421 Change-Id: I1bc9ea2de247637350c4081f752c5dea8eef0917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306502 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790364}
-
Maria Kazinova authored
Got rid of duplicated arguments and combined two methods that did the same ting at one. Change-Id: I5990718aa6201bc4e10f21d5cda4a4c9521dee2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307369 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790363}
-
Dave Tapuska authored
For some odd reason I felt it correct to add two methods named very similar that had different functionality. Remove the TextInputType method that does not query the pepper text input type and use the GetTextInputType method that actually does. BUG=1106562 Change-Id: I5adf9722e6483e23b25324c66365a9236157c0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307649 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790362}
-
Anders Hartvoll Ruud authored
This reverts commit 07fcd1a4. Reason for revert: Test become super-flaky (score:1568) after deflake-attempt Original change's description: > Update controls-strict.html. > > Initially meant to reduce flakiness but may not be related. However, the > rewrite itself may not be a bad idea for readability. > > Bug: 1103820 > Change-Id: I16420d0bbccd9665df6b3abd48139ed774ab934b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304447 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790180} TBR=mlamouri@chromium.org,steimel@chromium.org Change-Id: I2ca5e6698585e40f469e1a1ad0d5291393f129eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308421Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#790361}
-
Leo Lai authored
With preparation status as true by default in fake attestation client this test item doesn't suffer from repeationg loop and can pass now. Bug: 1107426 Change-Id: I12ccbbb323f530c19c5dc60d046af613758a3a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308626Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#790360}
-
Victor Hugo Vianna Silva authored
Bug: 1090931 Change-Id: Ia9780192a2ff860f1d59834e61ca5ab89443b9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309432 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790359}
-
Mohamed Amir Yosef authored
Bug: 1107422 Change-Id: Ib3f37fa164053f4afacf9db646bf62fef8007cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308714 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790358}
-
Clemens Arbesser authored
Also adds support for interrupts (currently untested). Interrupts in general appear to have very poor coverage. I created b/161652848 to track this independently. Bug: b/145043394 Change-Id: I48a4cdaf9a0bf45b0e206f8bf2787a13122c45d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306037Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790357}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595310726-5356636057416b4e4d905dcd6e997d2e9409d66f.profdata to chrome-mac-master-1595330901-a1487ea0e73c84091ecbf3f0440329cfe99905ef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7a793f4c809ebcd6ddba8d5d9c639cf61d16d4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790356}
-
Omer Katz authored
Incremental marking can get steps that are entirely consumed by flushing of v8 references. This steps contribute to time spend processing worklists on the main thread, but don't contribute any marked bytes. This thus affects our marking speed computation and results in lower than actual marking speed. The lower speed leads to longer step duration which causes marking to do more work than actually needed on the mutator thread. Step duration for minimum steps (i.e. step meant to mark just 64kb) could reach over 0.5ms due to this and similar issues. Ignoring flushing time in the speed computation prevents these uncontrolled false drops in marking speed and maintains a mostly consistent minimum step duration. Bug: 986235 Change-Id: I23132d65680ef19bedad8d8efffd0b92d439af1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297500 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790355}
-
Eric Leese authored
The test needs to be temporarily disabled, but I previously set the test expectation based on an earlier version of the cl I am trying to check in. (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2266998) Bug: chromium:1094436 Change-Id: I85389a4db43630f2948f0677e5537483dbcb300d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308413 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#790354}
-
Anders Hartvoll Ruud authored
There seems to be no reason to copy it. Change-Id: I89779533927d3b3d2a3ca912226eba723d9bc5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306149 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790353}
-
Ian Barkley-Yeung authored
Add unit tests for FileEnumerator::GetInfo(), since it didn't have any. Change-Id: Ia15f59c89349943b4f44ef7eeb7ba0d561ace45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297816 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790352}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/596f21fb..c29401c0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia5e61888d307477909227e073034c3906b26d526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309740Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790351}
-
Hiroki Nakagawa authored
As a part of the OnionSoup project, this CL moves transferrable_url_loader.mojom from content/public/common/ to third_party/blink/public/mojom/loader so that subsequent CLs can move content::ChildURLLoaderFactoryBundle that depends on this mojom file into third_party/blink/. This is a mechanical change, and doesn't affect functional behavior. Bug: 860403 Change-Id: I83c77e2d2dfd2da4068580b75b953d0c83e12f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306123Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790350}
-
Mark Brand authored
Change-Id: Ic2a90c5348e7f23366ff7325d418ce6ba53ca81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302057Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#790349}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e687db2bbe11..e875f72dc66f 2020-07-21 rmistry@google.com Add documentation link for canary bots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I85e19904878037852738f4c75cb9d8e5a2ecea56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790348}
-
Eliot Courtney authored
This CL moves a bunch of code to WaylandSurface. It also tries to minimize access to the underlying wl_surface* but it's not always possible - some code locations need to access the pointer to create other wayland objects. This CL also tries to reduce the assumption that a single WaylandSurface corresponds to a single WaylandWindow - hence adding root_surface etc everywhere. Bug: 1099838 Test: unit tests; running chrome still works Change-Id: If2c9fb028d7494003c493cda761c643a98b0b23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299662Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#790347}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I3311290b6fe2d59b9f4fedbce9f0e5bb2a06a102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309435Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790346}
-
Andreea Costinas authored
This CL implements requesting proxy authentication credentials from the NetworkService instance of the primary user Profile's default StoragePartition when System-proxy signals that it requires credentials. System-proxy is a new system service on CrOS that performs authentication and connection setup for CrOS services and ARC apps that are proxy aware, but can't perform the authentication challenge themselves. Bug:1042642 Test:unittests, services_unittests, manually on DUT Change-Id: I1d79da46ee9537c75131ff5e734fb39e525e0d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279193 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#790345}
-
Wez authored
The experiment is currently being reviewed, so extend the histogram lifetimes to allow data to continue to be gathered. Bug: 1053628, 1097845 Change-Id: I19771134bbdd3a5cc24ae651acf2e8f62c91f3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270304 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790344}
-
Leo Lai authored
The default failure should not happen because of unprepared attestation; instead it should controlled by thw allowlisting mechanism. Otherwise, the retry logic could cause long testing time or even timeout. As for testing, chromeos:chromeos_unittests and all affected browser_tests are passed. Bug: 1107426 Change-Id: Ie23d2618069b0511323d0f686a64ddfe0e05a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308625Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#790343}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a9b96ff8e9f..c1a073785503 2020-07-21 titovartem@google.com Add per source network statistics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe3a31bf54bd7850989ac45b5ec9a04bef5926f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790342}
-
Melissa Zhang authored
This CL adds targets to the sharesheet bubble and lifecycle support for those targets. Clicking on a ShareAction target now triggers the bubble to show the ShareActionView. Bug: 1097623 Change-Id: Ibbe829f3ea303588fcc90eb2ae9d7d1b662fc0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305820 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790341}
-
Mugdha Lakhani authored
Bug: 1096088 Change-Id: I6095d886525546e8cd0a44b37eb1ac9eded7e376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235717 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#790340}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e810d53b527e..57d7441b354d 2020-07-21 jacktfranklin@chromium.org Fix acorn deps 2020-07-21 mathias@chromium.org Clean up inspector overlay HTML 2020-07-21 alexrudenko@chromium.org Fix grid gap hatch fill 2020-07-21 tmathmeyer@chromium.org Fix text wrapping 2020-07-20 wolfi@chromium.org Fix frame tree persistence of selected item 2020-07-20 pfaffe@chromium.org [wasm debug] Implement auto-stepping with the experiment. 2020-07-20 aerotwist@chromium.org Migrates host to devtools_entrypoint 2020-07-20 jacktfranklin@chromium.org Update component_docs README 2020-07-20 pfaffe@chromium.org [wasm debug] Add an API for Language Plugins Extensions 2020-07-20 jacktfranklin@chromium.org Migrate `front_end/bindings` to `devtools_entrypoint` 2020-07-20 alexrudenko@chromium.org Add showTrackSizes to the grid overlay 2020-07-20 petermarshall@chromium.org tests: Always specify a timeout for waitFor/Function 2020-07-20 aerotwist@chromium.org Migrates a11y to devtools_entrypoint 2020-07-20 aerotwist@chromium.org Moves generated scripts to devtools_module 2020-07-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-17 fawazm@google.com [WebAuthn] Enable selecting active authenticator 2020-07-17 changhaohan@chromium.org Add e2e test for computed tab's "Show all" functionality 2020-07-17 sigurds@chromium.org Link to related panels from the frame details view 2020-07-17 sigurds@chromium.org Update Protocol Definitions 2020-07-17 tvanderlippe@chromium.org Stop building formatter_worker-entrypoint with build_release_applications 2020-07-17 janscheffler@chromium.org [WebAuthn] Add owners file for webauthn 2020-07-17 tvanderlippe@chromium.org Move acorn entrypoint to front_end/third_party/acorn 2020-07-17 szuend@chromium.org Don't add sourceURL comments to HTML and Markdown files 2020-07-17 szuend@chromium.org Build 'marked' module with TypeScript infrastructure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663,chromium:1083146,chromium:1093247,chromium:1095617,chromium:1099162,chromium:1101738,chromium:1105765,chromium:1105770,chromium:1105808,chromium:1106251,chromium:1106681,chromium:1107681 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifba1dfedccb9867db18c3e1b2ac34d8db488b034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309284Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790339}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7169639e. With Chromium commits locally applied on WPT: 9ca607f9 "[XHR] Replace whitelist with cors-safelisted" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id803842daa7bccafdf517d92fa8325da53b27b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309736Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790338}
-
Olya Kalitova authored
Updates Plugin VM Product Analytics string on trancparency panel (chrome://management). Test: manually using YAPS Bug: b/150908305 Change-Id: Id4d99e1b1729b9c5f6a2dcf93d47c9cb69146386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306094Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#790337}
-
Saurabh Nijhara authored
This CL updates the subtitle string for update required screen in offline mode as per UI. Bug: 1106768 Change-Id: Ieb84f4439ef3fdf93d5353da9b19fa8ba3ca2ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308711Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#790336}
-
Wanchang Ryu authored
There are many places defining __has_builtin(x) to 0 if __has_builtin is not defined. When building chrom with gcc, depending on include file it can be undfined or defined to 0. So SUPPORTS_LOCATION_BUILTINS can be different depending on include header file before including base/location.h file. This patch changes checking defined(__has_builtin) to defined(__clang__) for using __has_builtin macro. This would be enough to detect clang compiler for using __has_builtin. Here is a link error what I met when compiling with gcc and this patch fixes below link error. g++ -Wl,--version-script=../../build/linux/chrome.map -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,-z,defs -Wl,--as-needed -fuse-ld=gold -Wl,--threads -Wl,--thread-count=4 -m64 -Wl,-O2 -Wl,--gc-sections -rdynamic -pie -Wl,--disable-new-dtags -o "./chrome" -Wl,--start-group @"./chrome.rsp" -Wl,--end-group -latomic -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -latk-1.0 -latk-bridge-2.0 -lcups -ldbus-1 -lresolv -lgio-2.0 -lexpat -luuid -ldrm -lxkbcommon -lm -lz -lwayland-cursor -lwayland-egl -lwayland-client -lpci -lasound -lpangocairo-1.0 -lpango-1.0 -lcairo -latspi -lgtk-3 -lgdk-3 -lcairo-gobject -lgdk_pixbuf-2.0 obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/print_dialog_gtk.o):print_dialog_gtk.cc:function PrintDialogGtk::SendDocumentToPrinter(std::__cxx11::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::allocator<unsigned short> > const&): error: undefined reference to 'base::Location::Current()' obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/select_file_dialog_impl_kde.o):select_file_dialog_impl_kde.cc:function gtk::SelectFileDialogImpl::CheckKDEDialogWorksOnUIThread(): error: undefined reference to 'base::Location::Current()' obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/print_dialog_gtk.o):print_dialog_gtk.cc:function PrintDialogGtk::ReleaseDialog(): error: undefined reference to 'base::Location::Current()' obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/select_file_dialog_impl_kde.o):select_file_dialog_impl_kde.cc:function gtk::SelectFileDialogImplKDE::CreateSelectFolderDialog(ui::SelectFileDialog::Type, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, base::FilePath const&, unsigned long, void*): error: undefined reference to 'base::Location::Current()' collect2: error: ld returned 1 exit status Change-Id: Ic025681762c2c4efafe6f1e972d78dcf85b89c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303232Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wanchang Ryu <wanchang.ryu@lge.com> Cr-Commit-Position: refs/heads/master@{#790335}
-
Aaron Tagliaboschi authored
Bug: 924047 Change-Id: Iaffbf6fd73993ea4db3cdc89f94ca9dc3710b86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307090Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#790334}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9491204a8a8..83406a9d26a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andruud@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025990,chromium:1101820 Tbr: andruud@google.com Change-Id: Ie4090f8c20907b24068813948d9060d85d117720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309278Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790333}
-
Anders Hartvoll Ruud authored
This flag is an remnant of the old way of resolving variables, and is no longer needed. Change-Id: I5f013b65b3fd2a653cbb98846689b0e00c48046a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306089 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790332}
-
Swapnil authored
We need to improve on installation time for the force installed extensions. For this, we first need to investigate which stage takes more time. After CRX has been downloaded, it's installation happens in several stages (verifying, unpacking etc), and now InstallStageTracker tracks these stages so that we could get a better idea that which stage is more time consuming. This is a prework for adding UMA statistics for reporting time taken for each stage. Bug: 1102806 Change-Id: I1a484363ef06f8f04787ddb8086dbb401523206f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283607 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#790331}
-