- 18 Jun, 2020 40 commits
-
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: Icb955af0161e3e4b2dbdcd0c283a2aa631c4f799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249389 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779750}
-
Nidhi Jaju authored
Upon investigation of a recent bug reporting the Chrome browser hanging during startup, it was found that ServiceWorkerStorage::GetAll Registrations() is called which may take a considerable amount of time. Hence, by removing this call and just getting Registered Origins instead of all registrations, this issue should be resolved. The call to the ServiceWorkerContextWatcher class was also removed from ServiceWorkerContextWrapper, along with GetAllRegistrations() being replaced with GetRegisteredOrigins(). Bug: 807440 Change-Id: I99ef9895ca28dd5ba8977fe422a3d92099527765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239590 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779749}
-
Mikel Astiz authored
This logically reverts the old https://codereview.chromium.org/551843003 because meanwhile the Sync Directory has been deprecated in favor of a new codepath, Unified Sync and Storage (USS). Change-Id: I80e66c304b76a8d9edffe1a4657ba0c2513f2ff4 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250042Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779748}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae1892d4e4ce..c6d6e06a5c45 2020-06-18 nisse@webrtc.org Delete OpaqueTransportParameters and SDP attribute x-otp 2020-06-18 deadbeef@webrtc.org Disable SCTP asconf and auth extensions. 2020-06-17 mbonadei@webrtc.org Remove //tools_webrtc/sancov. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I428362d3fba349b961f4ee515c06c3f7d5beef04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779747}
-
Michael Ershov authored
Compare public key inside the certificate and public key from key pair to make sure that they are the same and certificate was issued for the expected key pair. Bug: 1045895 Test: CertProvisioning* Change-Id: I37a72a8b1c39e424782826f6ba278365af4c4b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246687Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#779746}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/22e7befe144d..22b0828640fb 2020-06-18 cbruni@chromium.org Revert "Avoid UpdateTrafficSettings when possible" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: Ic55014c0911d3be0c47ec37e3267860f2d7d9810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251718Reviewed-by:
-
Karandeep Bhatia authored
Currently a *compromised* web renderer can request any extension resource from an extension that has web accessible resources (WAR). This was necessary earlier since: - extension iframes didn't always live in the extension process when embedded in a website. - We needed to allow extension subresource requests from such iframes. These subresources didn't need to be web accessible. - This meant that the browser needed to allow cross renderer requests to such resources. - Hence as a compromise, at the browser level we allowlisted any cross renderer subresource request to an extension with WAR. However, now extension iframes should always have their own process. Hence the browser side check can be made more strict to disallow cross renderer requests to non web accessible resources. Note that we already block access to non web accessible extension resources at the renderer level. BUG=1093570, 179127, 173688. Change-Id: I20523db2d1629f3714d3c84a27e0904ed4f1b27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244433 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779744}
-
Victor Hugo Vianna Silva authored
For a b4p user, in case some password has copies attached both to the device and the Google Account, attempting to delete it should show a dialog that allows selecting which copies to remove. This CL implements this dialog but does not yet wire it in. Some details in the UI are left for future CLs, such as the user avatar and displaying the website associated with the password to be deleted. Note RemovePasswordBehavior is not used here, for reasons that are better explained in crrev.com/c/2246157. Screenshot of implementation: https://screenshot.googleplex.com/hZnTiuy80tL Screenshot of mock: https://screenshot.googleplex.com/pGV0iMTQBxw Bug: 1049141 Change-Id: I50ca0e5bfc99dbc76c12c345c00f82788bbc377c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248180 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#779743}
-
Maxim Kolosovskiy authored
This reverts commit b1d0fc82. Reason for revert: failures of AssistiveWindowControllerTest https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests?limit=200 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19523?blamelist=1#blamelist-tab Original change's description: > Use SuggestionDetails struct for showing suggestion > > In preparation for adding show_setting_link param for personal info > suggestion. > > Bug: 1094267 > Change-Id: Id9e4a5d5de335613df93bf80142a3df8bb564fd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243073 > Commit-Queue: My Nguyen <myy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779566} TBR=keithlee@chromium.org,curtismcmullan@chromium.org,myy@chromium.org Change-Id: I66864faf4aac2f9c8ad10ecc22eba71b32005750 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250107Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779742}
-
Maxim Kolosovskiy authored
This reverts commit bd23dace. Reason for revert: in order to resolve merge conflict for https://chromium-review.googlesource.com/c/chromium/src/+/2250107 Original change's description: > Add preference for personal info suggester showing setting link > > Should stop showing setting link after showing 10 times or when user > have accepted it. > > See: http://go/personal-info-setting-link > > Bug: 1094267 > Change-Id: I9d9c5f09aa77f56445722c5fd626a8caaa04da7d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245583 > Commit-Queue: My Nguyen <myy@chromium.org> > Reviewed-by: Jing Wang <jiwan@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779602} TBR=shend@chromium.org,myy@chromium.org,jiwan@chromium.org Change-Id: If873508473e418a2c9fd93d2b31fd47d05aa902b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250253Reviewed-by:
-
David Roger authored
The parameter has changed on the Gaia server from mlreuse to reuseCookies. Fixed: 1072463 Change-Id: I5d1d889b14c3229f55d1638dbb4f2f07bc7622df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249958Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#779740}
-
Benoit Lize authored
ParkableStrings can be written out to disk, but this is not always the case, as writing is disabled in several cases: - When the renderer's associated profile is an incognito one - When the browser failed to open the file - When writing failed at some point Capture the frequency of these events in a histogram. This requires making the feature accessible to blink, so it moves from content to blink. Bug: 1029320 Change-Id: I671db1e92fcabc24c383551621ef93febd197cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249858Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779739}
-
Maxim Kolosovskiy authored
This reverts commit 676d0cb1. Reason for revert: reverting this CL to resolve merge conflicts to land https://chromium-review.googlesource.com/c/chromium/src/+/2250202 TBR=avi@chromium.org,fdoray@chromium.org Change-Id: I2ab86f1980fa5fb905c03349252c5a440abe3f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249930 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 7eab011b. Reason for revert: AmbientControllerTest failures https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg?limit=200 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19204?blamelist=1#blamelist-tab Original change's description: > ambient: container logic refactoring [part 1]. > > This CL is splitted from the original CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2199870 > with all files changed on ambient/. side. > > Bug: b/156531168 > Test: unittests. > Change-Id: I4f84277c74c95419ac96e6cfaaa48081c407b243 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248878 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779664} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org Change-Id: Ia9eaa3e0d856c7dabf2526c3566fa35cf415e17c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/156531168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250602Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 43de05d5. Reason for revert: caused failures of OmniboxViewViewsTest.HideOnInteractionAndRevealOnHoverWithAlwaysShowFullURLs https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests?limit=200 test is flaky and it didn't cause a failure in the first build. First failed build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/56117 Original change's description: > Hook up Always Show Full URLs option to omnibox path-hiding experiments > > This CL hooks up the Always Show Full URLs option via OmniboxEditModel > to the path-hiding omnibox UI experiments. Users will now be able to > opt out of reveal-on-hover and show-on-interaction to always show the > full URL without any elisions. > > Bug: 1094760 > Change-Id: I3d5f15e7fcb6863701f00042daee9867fcbcf0bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246863 > Commit-Queue: Emily Stark <estark@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779389} TBR=jdonnelly@chromium.org,estark@chromium.org Change-Id: I54f299cdeec20edb5ef6e278a17da40b33e60d42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250004Reviewed-by:
-
Anders Hartvoll Ruud authored
A subsequent CL needs to get the currently applying CSSProperty* from the CascadeResolver, and it's more efficient to get the pointer directly, rather than looking it up via the CSSPropertyName. This is a refactor: there is no behavior change in this CL. (Except one addition unit test is added). Bug: 1057072 Change-Id: I7532f2c23f9da915c132cb42abef7b804d3a5732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247821 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#779735}
-
Maxim Kolosovskiy authored
This reverts commit 7a647232. Reason for revert: caused failures of webcodecs/videoframe-imagebitmap.html Builder: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10 First failed build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/69062 TBR=sandersd@chromium.org Change-Id: Id880d1643e20216fabcae068952b7f886bbf1946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251618 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Keith Lee authored
This sends the Data to the TextInputClient, which is responsible for handling rendering. Bug: 1091088 Change-Id: I0c8669ff3d3b632e4fbc9eeeb3691f7929e069a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230404 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
-
Ewann authored
This CL links the cookies mediator to the NTP. The switch also updates his state according to the current cookies setting. Bug: 1063824 Change-Id: I072f14668d236bde6d4327156696619cb6090dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247029 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#779732}
-
Marina Ciocea authored
Reset the receiver before Bind(), in case it was already bound, to avoid running into Bind()'s internal DCHECK that expects the receiver to not be bound. Also add a test verifying that OnDeviceChanged() behaves as expected after rebind. Bug: 1093728 Change-Id: Ic964902d3f3af3e3c6963633c13b069ecb344d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250040Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#779731}
-
Dominik Röttsches authored
Break out underline thickness computation into its own function as preparation for computing underline thickness not only per current ComputedStyle but for each of the ComputedStyle AppliedTextDecorations. No functional change. Bug: 1096038 Change-Id: I1384ec2a23735b6c8b3541e0535ca6ba5712beee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249758Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#779730}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id7a5288974e74a27ca1f3eb6b94ab9a4d7568df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251466Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7a4685f44829..a84ab4815027 2020-06-17 rharrison@chromium.org Add support for different default branches in roll-shader-deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I30052a102d5d4eb7d967d5183e1c6d8a87c00252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251346Reviewed-by:
-
Jan Krcal authored
This CL makes THEMES data type a priority type. This gives the data type preference in intial sync (and thus is downloaded very fast, independent of how many regular sync entities the user has). This also gives THEMES preference in commits. Bug: 1084970 Change-Id: I53bf7c85c73694406ba96397da1fa8e083c8aee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220026 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
This is obsolete. Removing it fixes a problem where GPU process logs were not being captured by run_web_tests.py. Bug: 1092487 Change-Id: Ib138e0823be556bea7ae720e0ff6a02922a08937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250712Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#779726}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I0ff3ce30d29dd57837e3c156940d11247a46d661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248688 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#779725}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592452187-94708d6f0067ad9e590c4843569525b02efba040.profdata to chrome-win32-master-1592459911-c43358934a37f46ea56775cef711f664e7b25ffd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib1b3eed98272e484e8e7d047ac265b00b0ab0432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251464Reviewed-by:
-
Side Yilmaz authored
This CL replaces usages of |profile_key_util.cc#GetLastUsedProfileKey| with |profile_key_util.cc#GetLastUsedRegularProfileKey| in update_notification_service_bridge_android.cc. Since UpdateNotificationServiceFactory returns the same instance for both regular and incognito profile, it is correct to use always regular profile. However, this is not safe in case of future changes as TODO states. Note: This CL is only clean-up and does not change code behaviour. Bug: 1041781 Change-Id: I39e6003e9846f6f58a52e0fb291a30ac761bf5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246693 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779723}
-
Side Yilmaz authored
This CL replaces usages of |profile_key_util.cc#GetLastUsedProfileKey| with |profile_key_util.cc#GetLastUsedRegularProfileKey| in offline pages classes. Since offline pages only called in regular mode, it is safe to use regular profile always. Note: This CL is only clean-up and does not change code behaviour. Bug: 1041781 Change-Id: Ifa14e98f00ccc05ab48eafdc0a53366031692242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247724Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779722}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7898d65dedca..8d02a81b1877 2020-06-18 patrick.brosset@microsoft.com Grid: New grid overlay experiment setting to show negative lines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf267f55d69c12a6a1621583ce0d68f70853eb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251465Reviewed-by:
-
Mugdha Lakhani authored
These are deleted either because the useful test cases here are already covered by NoStatePrefetch browser tests: SSLCertRequestInfo and SSLSubresourceError. See this spreadsheet for more details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: If7531f6dfd7b5ff7cd1b78111597af71375dd8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250178Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#779720}
-
Mugdha Lakhani authored
These are deleted either because the use case they are testing does not apply to NoStatePrefetch, the use case is already tested in blink/ or content/, or an equivalent browser test exists for NoStatePrefetch. See this spreadsheet for more details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: Ic69a622e995672c0052e4833b54bea5a42bcaa21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247834Reviewed-by:
-
Haiyang Pan authored
Bug: 1095778 Change-Id: I8aa8b81d932fa9ff897ac2d0ff29a92442dd2550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248864 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#779718}
-
Giovanni Ortuño Urquidi authored
Passing both types of files, .ts and .m.ts, to the compiler at the same time caused them to pollute each others' namespaces. This meant that all interfaces and constants specified in .ts files would be available in .m.ts files without us having to actually import them. This fixes the issue by compiling .ts files separately from .m.ts. files. Bug: 1011609 Change-Id: Iee93d85ec4eec44d82823ab5ab4ba2828b72ae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245982Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#779717}
-
Marc Treib authored
Before this CL: With the feature EnablePasswordsAccountStorage enabled, calls to PasswordAutofillAgent::MaybeCheckSafeBrowsingReputation were always bypassed (as an unintended side effect of showing the autofill dropdown even if there are no password suggestions). This caused the following two tests to fail with the feature enabled: PasswordAutofillAgentTest.CheckSafeBrowsingReputationWhenUserStartsFillingUsernamePassword NavigationMetricsRecorderBrowserTest.PasswordEntry_EngagementLevel This CL rearranges the logic so that MaybeCheckSafeBrowsingReputation gets called again when appropriate. Bug: 1095984, 1093310 Change-Id: If51032f09463ec25bb239ffa410af822d13b4678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247795Reviewed-by:
-
Koji Ishii authored
This patch fixes hit-testing floating objects in a legacy root. With |NGPaintFragment|, floats are in children, and that regular traversal can cover this case. With |FragmentItem|, floats are either in |NGFragmentItems| if it has an inline formatting context, or in children otherwise. This difference requires additional branch to the legacy fallback when hit-testing floating objects. Bug: 1096259 Change-Id: I8565eb663781318233c21482270804cf254e0aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249249Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779715}
-
Javier Ernesto Flores Robles authored
Bug: 1081664 Change-Id: Ia96ee3dea8d05c177736c19371aeff723bee404d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250058Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#779714}
-
Koji Ishii authored
Following bot results are included. 2495 2496 2502 2508 2518 2519 2523 2526 2533 2534 22 lines were removed and 0 lines were deflaked by consecutive results since 2487. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I8829926775b32d00ba60754a5590e4324e600f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246122Reviewed-by:
-
Rakina Zata Amni authored
This CL adds the capability of doing proactive BrowsingInstance swap on same-site main-frame navigations when the "SameSite" level is set on the "ProactivelySwapBrowsingInstance" flag. With that, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL does not include: - Updates for tests that fails because they didn't expect a change of RenderFrameHosts, etc. on same-site main frame navigations. These are handled in other CLs. - Fix to ensure order of unload handlers on same-site cross-RFH navigations (will be fixed on a future CL) - Fix to ensure WebPreferences are carried over for cross-RFH same-site navigations (will be fixed on a future CL) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I455e598d1c422984cb707bb3a8b54fa926bb5911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121522 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Francois Beaufort authored
This CL makes sure PictureInPictureWindow is accessible from the leavepictureinpicture event so that users don't have to keep a reference to the PictureInPictureWindow object they got from the enterpictureinpicture event. Spec change: https://github.com/w3c/picture-in-picture/pull/189 Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gwaEnJjtfKw Change-Id: Ibb6972596cd6b766bc2ed35cc6e360b7907c594d Bug: 1096350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241537Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#779711}
-
