GitLab

BUG=633626

Review-Url: https://codereview.chromium.org/2436903002
Cr-Commit-Position: refs/heads/master@{#427108}

This is necessary to make braille output work in menus. If a text edit handler is active, output gets delegated through that handler, skipping the output o f the current range.

BUG=657036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2442583002
Cr-Commit-Position: refs/heads/master@{#427107}

We need to special-case setting selections when the focused node is itself editable.
- make no adjustments for the selected node; placing selection outside of the editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0 (placing selection at the beginning of the node); otherwise, use the character offset

TEST=move to a text field or content editable via ChromeVox commands; verify typing works to echo the keys. Furthermore, verify that in a content editable with headings, links, etc, jump commands move the selection. Finally, verify ChromeVox text movement commands (e.g. next character), moves selection in single line editables.
BUG=656349,658045
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2442503008
Cr-Commit-Position: refs/heads/master@{#427106}

BUG=654795

Review-Url: https://codereview.chromium.org/2440993003
Cr-Commit-Position: refs/heads/master@{#427105}

This is part of the mustash refactoring of ash.

Migrate to the existing SystemTrayClient mojo interface.

BUG=647412
TEST=show time settings via system tray at the login screen

Review-Url: https://codereview.chromium.org/2438023004
Cr-Commit-Position: refs/heads/master@{#427104}

If a widget has focus, but no view within that widget is focused, report
the root view as the view that's focused for the purposes of firing
focus change events.

BUG=656103
TESTED=Before this change, Alt+Shift+N results in no focus event sent to ChromeVox. After this change, ChromeVox gets a focus event on a node with role=dialog.

Review-Url: https://codereview.chromium.org/2416103003
Cr-Commit-Position: refs/heads/master@{#427103}

BUG=555865

Review-Url: https://codereview.chromium.org/2440443005
Cr-Commit-Position: refs/heads/master@{#427102}

https://pdfium.googlesource.com/pdfium.git/+log/3cad596c55cd..ad2441ef6758

$ git log 3cad596c5..ad2441ef6 --date=short --no-merges --format='%ad %ae %s'
2016-10-24 tsepez Rename IFX_ stream names
2016-10-24 npm Fix root dictionary leak in cpdf_document_unittest

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2443893003
Cr-Commit-Position: refs/heads/master@{#427101}

Previously, MostVisitedSites dumped all PopularSites information into
its own observer, then let Java ensure availability of icons. Popular
Sites on iOS needs these icons cached too, so the component should
handle icon availability itself.

MostVisitedSites::Observer::OnPopularURLsAvailable() is removed and
MostVisitedSites::Observer::OnIconMadeAvailable() is added in its place.

Note that FaviconHelper.ensureIconIsAvailable() hasn't been removed in
this CL, as it's still used to load favicons for snippets. Of course,
one day, iOS will need to do that too, so an eventual plan to share
IconCacher and broaden its interface makes sense (maybe coupled with a
move to the favicon component?).

BUG=631990

Review-Url: https://codereview.chromium.org/2388783004
Cr-Commit-Position: refs/heads/master@{#427100}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6962f5c0344a..4d43e1baaf06

$ git log 6962f5c03..4d43e1baa --date=short --no-merges --format='%ad %ae %s'
2016-10-24 jbudorick [devil]  Add support for run-as in DeviceUtils.RunShellCommand.
2016-10-24 jbudorick [devil] Work around occasionally fatal `adb forward --list` bug.

BUG=623989

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2444983002
Cr-Commit-Position: refs/heads/master@{#427099}

BUG=655341

Review-Url: https://codereview.chromium.org/2431193003
Cr-Commit-Position: refs/heads/master@{#427098}

This hook allows the Media Router component to properly record the cause of
event page wakeups that are caused by invoking the Media Route Provider API.

BUG=

Review-Url: https://codereview.chromium.org/2422773004
Cr-Commit-Position: refs/heads/master@{#427097}

Continuation of CL by ojars@ here:
https://codereview.chromium.org/2383933002/

Async hardware draw synchronously returns a frame future that is
fulfilled asynchronously on the IO thread. This allows the frame future
to be waited on either the UI thread or android's render thread without
deadlocks.

In content, make SynchronousCompositorObserver a true message
filter owned by RenderProcessHostImpl. Will rename this to SCFilter
in a later CL.

In android_webview, wait on the frame future in kModeDraw,
immediately before where the frame is needed, to maximize
parallelization.

Note that there is a hack in BVR to produce a synchronous frame
first to ensure that bindings are initialized before render thread runs
any code.

This makes a complete more or less working path. But there are still
lots of TODOs needs to be fixed before the async path is ready to
ship.

BUG=636164

Review-Url: https://codereview.chromium.org/2418383002
Cr-Commit-Position: refs/heads/master@{#427096}

Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ )

Reason for revert:
Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc.

Original issue's description:
> Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()
>
> To diagnose the cause of crashes on WebView.
>
> BUG=514141
>
> Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1
> Cr-Commit-Position: refs/heads/master@{#358295}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=514141

Review-Url: https://codereview.chromium.org/2444913002
Cr-Commit-Position: refs/heads/master@{#427095}

Review-Url: https://codereview.chromium.org/2446643002
Cr-Commit-Position: refs/heads/master@{#427094}

The latest version of Clang rejects direct relational
comparison between null pointer constants and pointers.

BUG=none
TBR=justinlin

Review-Url: https://codereview.chromium.org/2448533002
Cr-Commit-Position: refs/heads/master@{#427093}

We're seeing reasonable stability and performance numbers from the
current 10% enable rate on canary, so enable at the same rate on dev.

BUG=650869

Review-Url: https://codereview.chromium.org/2444573002
Cr-Commit-Position: refs/heads/master@{#427092}

Revert of Do not hide the old RenderWidgetHostView when commiting a navigation. (patchset #2 id:20001 of https://codereview.chromium.org/2415973002/ )

Reason for revert:
Caused a regression on Mac.

BUG=658688

Original issue's description:
> Do not hide the old RenderWidgetHostView when commiting a navigation.
>
> This fixes an issue where the old RenderView is reused by a new remote
> subframe. We shouldn't be leaking resources, because now we are already
> hiding the unused RenderView in the renderer, when the local main frame
> gets detached and the WebViewFrameWidget is closed.
>
> BUG=638375
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/7c3d7bbd510eda2bcfb971f6d166da26bcfe4222
> Cr-Commit-Position: refs/heads/master@{#426913}

TBR=creis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=638375

Review-Url: https://codereview.chromium.org/2448503002
Cr-Commit-Position: refs/heads/master@{#427091}

Adds a mocking method for Feature flags in SnippetsConfig

BUG=657319

Review-Url: https://codereview.chromium.org/2434263002
Cr-Commit-Position: refs/heads/master@{#427090}

TBR=xidachen@chromium.org

Review-Url: https://codereview.chromium.org/2448513002
Cr-Commit-Position: refs/heads/master@{#427089}

Revert of Use the serviceworker with mojo by default (patchset #2 id:20001 of https://codereview.chromium.org/2436223004/ )

Reason for revert:
I think this is causing InstallableManagerBrowserTest.CheckManifest404 to crash, see http://crbug.com/658702

Original issue's description:
> Use the serviceworker with mojo by default
>
> This patch changes --mojo-service-worker to --disable-mojo-service-worker.
> Let's try mojo for the service worker.
>
> BUG=629701
>
> Committed: https://crrev.com/391fa63bcefd25b35addf678356828dded5ae71e
> Cr-Commit-Position: refs/heads/master@{#427013}

TBR=horo@chromium.org,avi@chromium.org,shimazu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=629701

Review-Url: https://codereview.chromium.org/2443983002
Cr-Commit-Position: refs/heads/master@{#427088}

BUG=634418

Review-Url: https://codereview.chromium.org/2438403002
Cr-Commit-Position: refs/heads/master@{#427087}

Followup to https://codereview.chromium.org/2429523002

- Remove NTP_*_SIDE_SUGGESTION (replaced by LogMostVisitedImpression calls)
- Cleanup tests

BUG=656646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2435683003
Cr-Commit-Position: refs/heads/master@{#427086}

There are two main fixes:
-use the new NavigationHandle callbacks on WebContentsObserver which are compatible with PlzNavigate
-update the renderer side so that handles the new order of IPCs: while ReadyToCommitNavigation means the browser side can send its IPC before the internal content ones, with PlzNavigate one content IPC will fire both DidStartProvisionalLoad & DidCommitProvisionalLoad. So add extra logic to the renderer side to handle this.

This fixes
SubresourceFilterBrowserTest.MainFrameActivation
SubresourceFilterBrowserTest.MainFrameActivationOnStartup
SubresourceFilterBrowserTest.SubFrameActivation
with PlzNavigate.

BUG=504347, 653807

Review-Url: https://codereview.chromium.org/2446503002
Cr-Commit-Position: refs/heads/master@{#427085}

BUG=555865

Review-Url: https://codereview.chromium.org/2445513002
Cr-Commit-Position: refs/heads/master@{#427084}

iOS prompts the user to enable Bluetooth when the CBCentralManager object
is created. Setting the ShowPowerAlert option to NO suppresses the prompt.
This allows Chrome to check the Bluetooth enabled state without prompting
the user.

BUG=630769

Review-Url: https://codereview.chromium.org/2443733002
Cr-Commit-Position: refs/heads/master@{#427083}

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631

Review-Url: https://codereview.chromium.org/2437923002
Cr-Commit-Position: refs/heads/master@{#427082}

This method is called by the cross-platform autofill code resulting in
regular log spam. The calling sites don't expect a non-null return value
so there's no need to log this as an error.

BUG=658299

Review-Url: https://codereview.chromium.org/2435343002
Cr-Commit-Position: refs/heads/master@{#427081}

The following methods in SVGLengthContext:

 convertValueFromUserUnitsToCHS
 convertValueFromUserUnitsToEXS
 convertValueFromEXSToUserUnits

needs the same treatment as convertValueFromCHSToUserUnits got in
https://chromiumcodereview.appspot.com/2445463002.

R=pdr@chromium.org,eae@chromium.org
BUG=657438,658585,658613

Review-Url: https://codereview.chromium.org/2449433002
Cr-Commit-Position: refs/heads/master@{#427080}

BUG=654738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1914653002
Cr-Commit-Position: refs/heads/master@{#427079}

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri

Review-Url: https://codereview.chromium.org/2439673004
Cr-Commit-Position: refs/heads/master@{#427078}

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=

Review-Url: https://codereview.chromium.org/2406923002
Cr-Commit-Position: refs/heads/master@{#427077}

This test was flaky before.  It would just always "succeed" on the
second attempt.

Now it is still flaky.  It just sometimes succeeds outright and
sometimes fails on all attempts.

I'll disable for now until I can come up with a better fix for
these timing issues.

NOTRY=true
BUG=657839
TEST=none
TBR=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2448493002
Cr-Commit-Position: refs/heads/master@{#427076}

Switch the JNI generator sample code to use a JavaRef for java method
parameters instead of jobject.

BUG=506850

Review-Url: https://codereview.chromium.org/2418893003
Cr-Commit-Position: refs/heads/master@{#427075}

Because of crbug.com/657517 the original submit of the test for
NotificationImageLoader had a very loose timeout value. Now that the bug
was fixed (https://chromiumcodereview.appspot.com/2433323003), this CL
updates the timeout values to be tighter.

BUG=579137

Review-Url: https://codereview.chromium.org/2442323002
Cr-Commit-Position: refs/heads/master@{#427074}

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837

Review-Url: https://codereview.chromium.org/2427963004
Cr-Commit-Position: refs/heads/master@{#427073}

https://chromium.googlesource.com/chromium/src/+/dba76ba32

BUG=657839
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/2442323003 .

Cr-Commit-Position: refs/heads/master@{#427072}

BUG=655498

Review-Url: https://codereview.chromium.org/2437923004
Cr-Commit-Position: refs/heads/master@{#427071}

This is implemented by using Daydream Api. After a headset is detected by phone,
instead of launch Daydream Home app, ChromeVR is launched iff Chrome was the foreground
app. Follow up CLs will trigger auto presentation if VR aware content was showing.

BUG=641401

Review-Url: https://codereview.chromium.org/2428563003
Cr-Commit-Position: refs/heads/master@{#427070}

Using update-w3c-deps in Chromium 3524bd79.

This is for rtcpeerconnection-constructor.html

BUG=658423

Review-Url: https://codereview.chromium.org/2448433002
Cr-Commit-Position: refs/heads/master@{#427069}