- 22 Dec, 2017 40 commits
-
-
Christian Fremerey authored
This reverts commit 7b74ab48. Reason for revert: This CL caused test HangoutServicesBrowserTest.RunComponentExtensionTest to fail. See https://bugs.chromium.org/p/chromium/issues/detail?id=796601 Original change's description: > Autoplay: enable unified policy by default on trunk. > > Bug: 779087, 746554 > Change-Id: I22fea53534db6404da794c04320ef6b889dc5ac6 > Reviewed-on: https://chromium-review.googlesource.com/817739 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524987} TBR=mlamouri@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 779087, 746554, 796601 Change-Id: If27fa373985aaaa77ad4d7c87058d839c7ee332f Reviewed-on: https://chromium-review.googlesource.com/842225 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#526070}
-
Mustafa Emre Acer authored
Bug: 795820 Change-Id: I78202ba73a1c4e3d874a4faa973bb398fa2d30f8 TBR: estark@chromium.org Reviewed-on: https://chromium-review.googlesource.com/842855Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#526069}
-
Gauthier Ambard authored
This CL sets the incognito property of the OmniboxPopupViewController before the view is created when passed to the mediator as the property is used in viewDidLoad. Bug: 797239 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0db9d1754ea32d6d1a6c7cde5d2638f187da5fd3 Reviewed-on: https://chromium-review.googlesource.com/842723Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526068}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/2b7bbc282280..06f863774011 $ git log 2b7bbc282..06f863774 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 zmo Revert "Re-land "Vulkan: Roll loader/validation layers SDK. (2/2)"" Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I7c3b58bf692c0bbd20e1426b84dbbcf7e07c486a Reviewed-on: https://chromium-review.googlesource.com/843228 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526067}
-
Vadim Tryshev authored
It will never come back. This CL shaves off some layer, but I'm leaving more cleanups (around SpeechUIModel) for the next CL to keep it comprehensible. Bug: 781407 Change-Id: I86e0681794e1f84f3267e5b29cd3e5e55bdc385a Reviewed-on: https://chromium-review.googlesource.com/841744Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526066}
-
Jonathan Metzman authored
When chromium fuzzers are run with AFL, the process forks before calling LLVMFuzzerTestOneInput. This didn't work here because initialization needed for LLVMFuzzerTestOneInput to execute (specifically its call to run_loop.Run) needs to be done in the same thread running LLVMFuzzerTestOneInput. This CL moves the initialization to the same thread, by doing the initialization in the first execution of LLVMFuzzerTestOneInput. Bug: 797366 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic725d564490a3065df4a1ac3f0f079462fe093ed Reviewed-on: https://chromium-review.googlesource.com/843070 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#526065}
-
Marijn Kruisselbrink authored
Update test expectation for virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html TBR=rbyers@chromium.org Bug: 795250 Change-Id: If5f6df738c35c1ee7920f83f1ebc2771a4f06dac Reviewed-on: https://chromium-review.googlesource.com/843008Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526064}
-
Tom Finegan authored
Disable high bit depth to avoid a visual quality issue in AV1 playbacks. BUG=aomedia:1173 TBR=jzern,johannkoenig Change-Id: I95c54a5a63646f4ce3b305c36184f932bc8c5d3b Reviewed-on: https://chromium-review.googlesource.com/842851 Commit-Queue: Tom Finegan <tomfinegan@chromium.org> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526063}
-
Eric Lawrence authored
Add two custom domain entries to the HSTS preload list. Bug: 170913 Change-Id: Idce21cc1b8f6f7850d9a1f854ee835932b135044 TBR: palmer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/843125Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#526062}
-
Doug Turner authored
Bug: 796657 Change-Id: I49d2cd5fe8112fda7ec6ae6ae472ee13510d9394 Reviewed-on: https://chromium-review.googlesource.com/837730Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526061}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/891aaf63b349..05dcbc931eac $ git log 891aaf63b..05dcbc931 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 thestig Only set CPDF_ColorSpace component count on successful load. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I448f5d48dea567368d80aed5648f40c476fa7754 Reviewed-on: https://chromium-review.googlesource.com/843232 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526060}
-
danakj authored
Pass in the ContextProvider instead of each capability individually. And in the DirectRenderer classes, the FrameBuffer hint is always used so stop making it conditional (this is a leftover from ResourceProvider code this was based on) and just pass mipmap as a bool so that new bitflags can't be added without child classes knowing about it. Last, pass RenderPassRequirements consistently to both methods that receive them, instead of unpacking it for one of them, so that the relationship is more clear in the APIs. R=piman@chromium.org Bug: 738190 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie53c2041183207561efae7d10c0c32e42daf1bd2 Reviewed-on: https://chromium-review.googlesource.com/843162 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526059}
-
Michael Thiessen authored
There's a bug where if the control container is already hidden, we fail to pause VSync when entering WebVR. This happens when we enter WebVR from VR browsing. This CL fixes that hackily by just immediately pausing VSync if we're coming from VR browsing. This will be fixed properly with the fallback UI path. See crbug.com/793430 Bug: 797349 Change-Id: I8d35a0c38caa7aaf285c140bef368883aaa0765b Reviewed-on: https://chromium-review.googlesource.com/843237Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#526058}
-
Zhenyao Mo authored
https://chromium.googlesource.com/angle/angle.git/+log/2b7bbc2..06f8637 BUG=797253 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jmadill@chromium.org,thestig@chromium.org Change-Id: I85383d0eb6618c11b306d954d7c697a44a8a090d Reviewed-on: https://chromium-review.googlesource.com/843229Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526057}
-
Thomas Anderson authored
This reverts commit f93b585a. Reason for revert: Windows don't get shown Original change's description: > Remove ui::X11EventSource::BlockUntilWindowMapped > > This CL removes BlockUntilWindowMapped() and the 2 references to it. > > The first reference, in X11WholeScreenMoveLoop, waits until an offscreen window > is mapped. The window is override-redirect (so there's not WM that > asynchronously decides when to map the window), so any operations done on the > window should succeed after the window is mapped since the X server processes > events in sequence. > > The second reference is from X11WindowBase. A similar removal was done in > DesktopWindowTreeHostX11 in [1], so BlockUntilWindowMapped() shouldn't be needed > here either. > > [1] https://chromium.googlesource.com/chromium/src/+/662c24fc6debb33ee34a927d21dc26154b8973d6 > > R=sadrul@chromium.org > > Change-Id: I251e67839dd5216f5164a103a82ad8a906811a03 > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/823212 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525869} TBR=sadrul@chromium.org,thomasanderson@chromium.org Change-Id: I7bc83f409171941ce812ab09e0191b935127a38b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797358 Reviewed-on: https://chromium-review.googlesource.com/842685Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526056}
-
Andrew Grieve authored
See: https://developer.android.com/studio/projects/android-library.html webrtc and cronet have both expressed interest in this at one point or another. While this doesn't support all aar features, it's a good start (and wasn't that hard). Bug: 506230, 762967 Change-Id: I1a5144311c1e7a30ccd2a50f77183977d820ea78 Reviewed-on: https://chromium-review.googlesource.com/841862 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526055}
-
Bill Budge authored
Bug: chromium:756050 Change-Id: I13b8eaa26eb94dc1b1f4e37c678b82853246c423 Reviewed-on: https://chromium-review.googlesource.com/818449 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526054}
-
John Abd-El-Malek authored
Instead, use net::URLRequest::ReferrerPolicy. This is in preparation for moving the struct to services/network. In a follow-up, I'll switch content::Referrer to use the net enum as well. Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I622cba8d8c8f828f3961b9cb3a524b8cf487a3c1 Reviewed-on: https://chromium-review.googlesource.com/842249 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526053}
-
David Reveman authored
This enables motion-stills by default and adds a feature flag for turning it off. Bug: 769140 Test: chrome --disable-features=ChangePictureVideoMode Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia2eef2d627914572d95c91d08e876e5e37d282e6 Reviewed-on: https://chromium-review.googlesource.com/842703 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#526052}
-
Jiaquan He authored
This commit does miscellaneous work in preparation for breaking ChromeAppListItem from AppListItem to make future CL smaller, with the following change: - For ChromeAppListItem: - overriding AppListItem methods explicitly; - moving methods into proper scopes; - add test apis for non-public methods in tests. - For (Chrome)AppListModelUpdater: - adding more methods that will be used; - moving methods into proper scopes; - grouping and reordering methods by their behaviors; - add test apis for non-public methods in tests. Bug: 733662 Change-Id: I3e9661b83b8b5493afe4fa4847edef48d01951f7 Reviewed-on: https://chromium-review.googlesource.com/841755Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#526051}
-
Sahel Sharify authored
org.chromium.chrome.browser.vr_shell.VrShellControllerInputTest#testControllerScrolling failed after landing browserside touchpad fling. The resean for this regression is that with touchpad fling the proper event stream is WebMouseWheelEvents from which Gesture scroll events are generated and then a GFS event with touchpad source. However in VR while scrolling with touchpad Gesture scroll events are directly injected to RWHI rather than injecting WebMouseWheelEvents and then generating gesture scroll events from them. The proper fix is to make the VR event stream similar to the proper event stream for touchpad scrolling but meanwhile this cl fixes the issue by handling the VR case separately. The fix has three parts: 1- The ProgressFling is called in RWHV_Android to progress the fling. It used to get called only on Aura for touchpad flings on chromebook. 2- is_in_gesture_scroll_ DCHECK logic in RWHI is changed for Android VR: When a GFS with touchpad source gets handled by FlingController, the controller sends wheel events to progress the fling. In Android VR the is_in_gesture_scroll_ should get reset on GFS since the first wheel event sent by the FlingController will cause a GSB generation in MouseWheelEventQueue. This GSB generation happens since during scrolling with touchpad the WebContentsEventForwarder directly injects gesture scroll events to the RWHI rather than injecting wheel events. Once Motion events are used for VR event processing this DCHECK change must get back to what it was. 3- Input_handler_proxy used to assume that nonblocking wheel events have always had a blocking wheel event before them. This assumption is not valid anymore since as explained in number 2, in VR case the first wheel event that is send by the flingController is nonblocking and it doesn't have any wheel events prior to it since the scrolling is directly handled by gesture scroll event injection. TBR: dtapuska@chromium.org, tdresser@chromium.org Bug: 797322, 797299 Change-Id: I9ab4e8236c6fd274d84e3d571ef0fc2388ec17e1 Reviewed-on: https://chromium-review.googlesource.com/842707 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526050}
-
Hector Carmona authored
Bug: 791666 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I847476ac80c96d7df6e66ea4547d6fab32845b38 Reviewed-on: https://chromium-review.googlesource.com/835470 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526049}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/92c7fa6b009b..0482ced2cd10 $ git log 92c7fa6b0..0482ced2c --date=short --no-merges --format='%ad %ae %s' 2017-12-22 rmistry Revert "Update isolate binaries and update isolate recipe" 2017-12-22 csmartdalton CCPR: Initial semi-optimized vertex shader Impl Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I74d3ca0e2c67e3af79ce572928d269e715725691 Reviewed-on: https://chromium-review.googlesource.com/843054Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526048}
-
Kevin Marshall authored
The new SDK contains the Fuchsia package archival tool "far". Bug: 707030 Change-Id: I41ecbe9e946919734f487ee824a48be177953a13 Reviewed-on: https://chromium-review.googlesource.com/843049Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#526047}
-
Ian Vollick authored
With this CL, a layer may preclude squashing by subsequent layers in paint order. NB: it makes no attempt to handle cases where layers change sort order due to relative position in a 3D rendering context. I plan to add the test separately. It's in progress here: crrev.com/c/842946 Bug: 788807 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I817a7ddc6f446b7d65dde2c4b4d88a6ac8912549 Reviewed-on: https://chromium-review.googlesource.com/832668Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#526046}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/221b12666ff6..11556464a62e $ git log 221b12666..11556464a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtcBUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia75feb4ebfb112437d71febc05502595b3ff3da0 Reviewed-on: https://chromium-review.googlesource.com/843052Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526045}
-
Jonathan Metzman authored
Bug: Change-Id: I85fd75a9d8c70e2ed106a34e567bd2b95e8984ca Reviewed-on: https://chromium-review.googlesource.com/826709Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526044}
-
Dominic Mazzoni authored
Originally landed: crrev.com/c/833221 Reverted: crrev.com/c/837517 Moved the code that sets roles to ignored out of the code shared with Chrome OS and manually verified that the lock screen works now. Instead of only using NativeViewAccessibility on some platforms, rename the base class ViewAccessibility and make it a general-purpose class for view accessibility code. Potential benefits of doing it this way: * View subclasses like Slider wouldn't need to add a special method like SetAccessibleName. Instead any client could override the name or any other property directly: view->GetViewAccessible().SetName(...); * Creates a means to share more code with AXViewObjWrapper. * Creates a way to have a single consistent ID for all Views, making relations between views easier. As a next step, these could be moved from View to ViewAccessibility, further simplifying view.h: HandleAccessibleAction(const ui::AXActionData& action_data); gfx::NativeViewAccessible GetNativeViewAccessible(); void NotifyAccessibilityEvent(ui::AXEvent event_type); Bug: 796350 Change-Id: I61f88707a7f302bafdf1f5cb5fe4b2faa6a9095c Reviewed-on: https://chromium-review.googlesource.com/837901Reviewed-by:Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#526043}
-
Lei Zhang authored
Change-Id: Ic0c82bda4051f2e005354bf04e0352faf181122a Reviewed-on: https://chromium-review.googlesource.com/842251Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#526042}
-
Lukasz Anforowicz authored
After r512625, various ways of viewing page or frame source end up going through RenderFrameHost::ViewSource which depends on ability to present the view source WebContents to the user via WebContentsDelegate's AddNewContent method. This method was not overriden by ExtensionOptionsGuest, leading to https://crbug.com/796080. This CL fixes https://crbug.com/796080 by overriding ExtensionOptionsGuest::AddNewContent and making it forward the call to the embedder. This CL also adds a regression test for this scenario. Note that by default guest views cannot open new windows - this is blocked (unless the embedder explicitly allows this) and results in "<webview>: A new window was blocked." error message. This CL does not change this - window.open('<url>', '_blank') as well as <a target="_blank"...> in a guest view will continue to be blocked by default. I've tested this manually after temporarily overriding AddNewContent method higher in the class hierarchy - in GuestViewBase. See also https://crbug.com/796080#c7. A follow-up bug has been opened to investigate if AddNewContents method should instead be implemented in the base class of ExtensionOptionsGuest - in GuestViewBase: https://crbug.com/797340. Bug: 796080 Change-Id: I83ece7fc94bbf1005c5e2878159076949c48b076 Tbr: finnur@chromium.org or rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/841623 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526041}
-
Lei Zhang authored
Its functionality has been duplicated by PdfToEmfConverterClientImpl. Change-Id: If5f832b7d282b6da19ccaf6ebe85d9e4988e3e8e Reviewed-on: https://chromium-review.googlesource.com/842250Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#526040}
-
Anthony Zhang authored
Newly added observers are not currently notified of existing devices. If ScanDevices() is called before all observers are registered then some observers will miss device events. Bug: 70595920 Test: Observers receive OnDeviceEvent() correctly when registered Change-Id: Ia04b894773ac676409e2d6d12b31e3b3801eb140 Reviewed-on: https://chromium-review.googlesource.com/841424Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Anthony Zhang <antz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526039}
-
Katie Dektar authored
This reverts commit 15df088c. Reason for revert: Breaks PFQ trybots Bug:797339 Original change's description: > Use ChromeVox utils in Select-to-Speak to support future changes. > > Includes a closure_shim.js that allows Select-to-Speak to use these > files without closure. > > This is temporary, eventually ChromeVox and Select-to-Speak should > both pull these utility files from one shared location. > > Bug: 713303 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I0bb93e5989e2ea83d89a500b6d92134031e78f07 > Reviewed-on: https://chromium-review.googlesource.com/834206 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525820} TBR=dmazzoni@chromium.org,dtseng@chromium.org,katie@chromium.org Change-Id: I108428209aec17d0c88e0feee21837da7eb4d769 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797339 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/843206 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#526038}
-
Yuke Liao authored
This CL implements tracking build dependency files for targets, configs, toolchains and pools and write corresponding unit tests to verify the behaviors. Bug: 795913 Change-Id: I3f7a9302db0725ef8167160838448e7eb39c4eee Reviewed-on: https://chromium-review.googlesource.com/838220 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526037}
-
Weidong Guo authored
Changes: Remove |mirrored| in DisplayLayout and related code because mirror mode restoring no longer depends on DisplayLayout any more. Bug: 791881 Change-Id: I99c5d7d443e0ab511c0c6003190c4e09843f97d9 Reviewed-on: https://chromium-review.googlesource.com/835626Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526036}
-
Marijn Kruisselbrink authored
TBR=rdevlin.cronin@chromium.org Bug: 770305 Change-Id: Ia8f61e1bbc8aa9f2af1fe4f47bcb7a2d1050edaa Reviewed-on: https://chromium-review.googlesource.com/842223Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526035}
-
Sadrul Habib Chowdhury authored
Remove the version of FindViewAtLocation that takes a gfx::Point. All the callers can use the version that uses a gfx::PointF wihout having to do extra work. So update the code to do that. Also, make TargetData::delta a gfx::Vector2dF because blink event locations are floats. BUG=796649 Change-Id: Ib1f8d19671a642aed5f111b03a22a632521e33af Reviewed-on: https://chromium-review.googlesource.com/841724Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#526034}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1fa9c434fc0d..92c7fa6b009b $ git log 1fa9c434f..92c7fa6b0 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 ethannicholas fix usage of deprecated SkMatrix44 constructor 2017-12-22 kjlubick Quarantine android bots instead of shutting off device Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ia78c37ce90fe05647189d435d99c58f43764bc1e Reviewed-on: https://chromium-review.googlesource.com/843064 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526033}
-
Xiaocheng Hu authored
The tests has nothing to do with canonicalization, so this patch removes the usage of VisibleSelection to keep the test cases simple. Bug: 657237 Change-Id: Ib0d36734cface043d89118374e339c45938f945f Reviewed-on: https://chromium-review.googlesource.com/843046Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#526032}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/5626f3590eea..3b3f9e1e789d $ git log 5626f3590..3b3f9e1e7 --date=short --no-merges --format='%ad %ae %s' 2017-12-22 charliea Remove Benchmark.GetExpectations Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2736e53aca3945df1652af7f47170322e1acdfd4 Reviewed-on: https://chromium-review.googlesource.com/842109 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526031}
-