- 21 Apr, 2020 40 commits
-
-
Daniele Castagna authored
crrev.com/c/2069137 added support for visible_rect. Unfortunately it incorrectly computed the UV translation. It had two issues: - It was using right() and bottom() instead of width() and height() when scaling the UV translation part. - It was not scaling the translation part for the input UV. This produced incorrect UVs when a rect was not in the origin and/or the input UV were scaled. This patch fixes the computation using cc::MathUtil::ScaleRectProportional instead. in viz_unittests. Bug: 1059408, 1057953 Test: TextureDrawQuadTranslatedAndVisibleRectInsetTopLeftAndCustomUV Change-Id: Id852f3c43167364a001f33de07892905c7d3b768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149637 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#761038}
-
Deepti Gandluri authored
Extending flag expiration milestones for WebAssembly features that are still in use by a year. Status of features gated by flags: * code caching - Enabled by default, okay to expire. * baseline/tiering - Ongoing finch trial * lazy compilation - Lazy compilation is still experimental * threads - Enabled by default in chrome, waiting on other browsers for complete implementations, so still useful for testing * simd - Still experimental, used for prototyping and gathering performance data. Change-Id: I51ae98b3dd784b1d619cebf15f81252c697f62a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158037Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#761037}
-
Xing Liu authored
CacheStrategy enum is defined in cached_image_metadata.proto, this should not be used beyond ImageMetadataStoreLevelDB. This CL adds a cpp enum that maps to CacheStrategy protobuf enum. Bug: 1067049,1058534 Change-Id: If13ac706e3c1f0a8cd2376ce1d7e5d26c5b571c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158064Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761036}
-
Dave Tapuska authored
The header file is included in various spots in blink and pulls in more than it should. Change-Id: Icabd4a00d7a19daf2c78cec032ff9742b7d6f43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156606Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#761035}
-
Anders Hartvoll Ruud authored
CSS declarations that are !important have higher priority in the cascade than animation effects. Unfortunately the information about which declarations were and weren't important is lost once the StyleCascade disappears. Specifically, it's not stored on the ComputedStyle. This causes a problem (once again) for the base computed style optimization, since we can't naively add animation effects on top of the base anymore. We might be overwriting something in the base that was important. The previous attempt at fixing this (flag on ElementAnimations) doesn't work properly. For example, it fails to detect the case where an animation initially doesn't conflict with important declarations, but then suddenly does via setKeyframes. To solve this, this CL stores a bitset containing information about important declarations alongside the base ComputedStyle on ElementAnimations. When we're considering whether the base can be used or not, we then check if there's any animation matching the set of important declarations. Persisting that many bits is slightly uncomfortable, but the only viable alternative I see is disabling the optimization when *any* important declaration exists in the base, which is probably a worse option. Sidenote: Initially I tried to always use the base, even when there were conflicts with important declarations. The bitset of important declarations is effectively a set of animations to be skipped, so we should still be able to use the base if we just don't apply the properties present in the set. However, it unfortunately didn't work due to visited/unvisited colors being animated together (crbug.com/1062217). Bug: 552085 Change-Id: I39e2879af8a858ce1bd97eaa2ceb6e222591df79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152449 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761034}
-
Katie D authored
UX spec changed after discussion with PM. Also fixes bug causing the bubble to end up in the wrong place when the window shrinks extremely small in height and grows again, by keeping the ratios from being calculated when the bubble is not visible. Bug: 1055150 Change-Id: I6f344e22a44ce57615994508897a79b69c1bae8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157985 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#761033}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/367d64f84c3c1d01381c18c5a239b85eef47633c..78987bb7bb4764ca3a8b08b0a6f7bd14b53c3e4f Bug: none Change-Id: I223ef4fc5e902700b7a046f4a2558a153523a05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158969 Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#761032}
-
dpapad authored
Change Grit's default behavior to gzip compress all such files, unless compress="false" is explicitly specified. In other words, compress="gzip" is now the default behavior, and same as not specifying a |compress| attribute. out/<out_folder>/resources.pak sizes before/after (with optimize_webui=true) Linux: 7.1MB -> 5.9MB, -4.9% CrOS: 21.0MB -> 18.0MB, -14.3% Bug: 1068407 Change-Id: I3fa63a4db6087b2f3502cbb8b76a6ca3b576e7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612333 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#761031}
-
Piotr Pawliczek authored
This is a part of implementation of class Uri. This CL contains implementation of URI parser along with normalization and validation. The file with unit tests was also included. Other CLs: - https://crrev.com/c/2103143 - https://crrev.com/c/2118426 BUG=chromium:821497 TEST=on my workstation Change-Id: Ieb9f3c105d842d4cb2a8f2678d34130e3b94b374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123640 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#761030}
-
Andrew Shulaev authored
This patch adds support for typed arguments on async events (using Perfetto's Track argument for trace macros), which will enable Bug: 149824486 Change-Id: I2fa599dfa037528bf2c04e3e5ec8cdfaf0eac56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096756 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#761029}
-
Robert Ma authored
Bug: 1073100 Change-Id: I2cddb15ae7e5ed1d76323db11fdbb20f3da6292a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159414 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#761028}
-
haozhe authored
This is a follow-up patch of https://chromium-review.googlesource.com/c/chromium/src/+/2105754 This patch adds more reference rectangles to sticky ref-tests to catch when the main thread position is different from the sticky position. Bug: 1059272 Change-Id: Ib3101e58a95db134a427b2852bca4c4bd58f805e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137828Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e784d74686e7..d26075f0c381 git log e784d74686e7..d26075f0c381 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 janscheffler@chromium.org Fix Search in Folder regression Created with: gclient setdep -r src/third_party/devtools-frontend/src@d26075f0c381 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc4b6cb0aadd0fd6c186ef4ab41430148c602f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159138Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761026}
-
nancy authored
AppServiceAppWindowCrostiniTracker::OnAppLaunchRequested might be called when the window is not visible yet, so there is no shelf item yet in ash::ShelfModel items. model->ItemIndexByAppID(app_id) might return -1. So adding a checking for -1 (index < 0) to avoid system crash. BUG=1072870 Change-Id: I26aa2c2ba4fa7cf73af140792be94632a6953b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157438 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#761025}
-
Garrett Beaty authored
This reverts commit 068d6078. Reason for revert: Causes compile to hang for https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder Original change's description: > Structured Headers: Include all public tests > > This imports all of the tests from the public test repository at > https://github.com/httpwg/structured-header-tests, which have been > automatically converted from JSON to C++ unit tests. > > Tests which were already present in structured_headers_unittest.cc > have been removed from that file, to avoid needless redundancy. > > Bug: 1069790 > Change-Id: I05536c36cb66c7dda43aab2f6c5ae77961120a6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146237 > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759015} TBR=iclelland@chromium.org,asanka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1069790 Change-Id: I398e00aaa9903872475f8c5cb5f2513f99e38b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159370Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#761024}
-
Yuki Shiino authored
Bug: 1060971 Change-Id: I180e012501bf308c30b9dcae2998160e0eeb4192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159174Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#761023}
-
Dan Harrington authored
This should help mmke it clear that you can't pass null for keys_to_remove. Change-Id: I63a86d6253cdd3b0e609942edf306ccd88b47a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148058Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#761022}
-
Andrew Xu authored
One recent CL (https://crrev.com/c/2055982) adds the option to use layer transformation for bounds animation. However, it fails to handle RTL properly. Different from View::SetBounds which handles RTL, View::SetTransform does not do that. This CL mirrors the start bounds and target bounds of transform animation when RTL should be handled. Bug: 1067033 Change-Id: I1c5aceec54e4f167ac2a80d93fc0c156e0afa9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140774 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Mohsen Izadi authored
Currently, the test uses base::TimeTicks::Now() for timings which makes it hard to verify timing expectations. This CL changes the test to use a mock time that can be advanced on demand. This unblocks adding more tests. Bug: 1054009,1057193 Change-Id: I68448ac591d86d26246459cddd64f36d42bd82f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159413Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#761020}
-
Sujie Zhu authored
Add sub-histogram CreditCard.WithServerNickname.SelectionDuration to log suggestion selection duration between the first time suggestion was shown and the first card is selected when any server nickname is available to see whether having a server nickname available helps user reduce the time spent on selecting the card they want. Note that same as the selection rate, we would like to compare selection duration only for the same group of users who have server nicknames, which means for the Control group we will also log selection duration if the user has any masked server cards with a nickname, but we won’t display the nickname in the UI. For Enabled group, we will log and show nickname when nickname is available. Add a timestamp and boolean to credit_card_form_event_logger to record the first suggestion shown timestamp and to ensure the selection duration is only logged once per form. Metrics design (googlers only): https://docs.google.com/document/d/1SfrBduc3gJrouT4zLmQHWtUPtcE-9JbkBGLHYgFLTFc/edit?ts=5e50549a#heading=h.olagc6jelr42 Bug: 1059087 Change-Id: I0ac4eb8e758d693a8b8240144655d53c7560a259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151832 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#761019}
-
Clark DuVall authored
Now that TabSpecificContentSettings is componentized, it makes sense to share the logic in ContentSettingsManagerImpl. Bug: 1070825 Change-Id: I76cd324119640fd374b1ad2b474a665aa7fade7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157650Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#761018}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/062833f38761..b009c0643f55 git log 062833f38761..b009c0643f55 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 apolito@google.com revert git to 2.24.1 Created with: gclient setdep -r src/third_party/depot_tools@b009c0643f55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070694 Tbr: agable@chromium.org Change-Id: I543cd894f357b23eb45979ed0a28e85d75cfaf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159137Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e30b9d80933d..09aea59a8d8b git log e30b9d80933d..09aea59a8d8b --date=short --first-parent --format='%ad %ae %s' 2020-04-21 fmayer@google.com Clarify incident_report_config error. Created with: gclient setdep -r src/third_party/perfetto@09aea59a8d8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idb9a996beb3eb21a5ef33338c2cccc1c9bdd0cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159133Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f06c6ea..137ca431 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia72d89b25a244f8dbf690c0a9f9ca1a951cedd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159245Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761015}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I868fc7bc0294a4cbc6d6202293dc5a891a37f2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159169Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#761014}
-
Dominique Fauteux-Chapleau authored
The equivalent CL on the upload path is crrev.com/c/2134191 This is only a refactor to use Connectors manager instead of reading the deep scanning policies directly to facilitate the transition to new policies. Change-Id: I0b1253aaac9a90e8277d6f468fa33cfc6f5b74c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154739Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#761013}
-
Aaron Leventhal authored
An object cannot have both children and a child tree. When an object fails to load, its child fallback content loads. In that case, expose the fallback children instead of the broken <object> content. Bug: None Change-Id: If6ba1dfc27ac19665a2e80c3d54750b3dc99bfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153887 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#761012}
-
Henrique Nakashima authored
- chrome/browser/flags/android - chrome/browser/preferences/android - chrome/browser/util/android These can be depended on by any code in chrome/android and chrome/browser. Remove scattered DEPS entries to these modules that are not needed anymore, since a parent directory already allows them. Change-Id: Idd1b5a6da6f4b0552150d640637eedd2a55180c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150975Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#761011}
-
rbpotter authored
Leave fonts_browser_proxy autogenerated since it is used by OS settings. Bug: 1069258 Change-Id: I7bd27c81477499b4171e27b7da32c9817724b5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155435 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#761010}
-
Ted Choc authored
BUG=1036923 Change-Id: I7777cc7cbdfc8b6703b22cacb49d256931ef57ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158828Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#761009}
-
Matthias Körber authored
The requirements for storing new profiles address in Egypt enforce both a ZIP code and a state entry. Both are commonly not present in address forms from Egypt. This prevents Egyptian users from using autofill as intended. This change simply relaxes the requirements to enable Egypt users to use autofill. Change-Id: I3511941ef5195e8f16c53d6dd535b9eef0cc52a7 Bug: 1073078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159434 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#761008}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a653d8a2. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" daae887f "CookieStore: Add validation behavior for __Host- prefixed cookies" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia6042d948f99339dcec814e7860f2f1b861d0c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159247Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761007}
-
Li Lin authored
Stop means to stop playback and reset the session with no intention to resume it. To allow resume after stopping, use the suspend API instead. Bug: b/140945356 Test: Manual test Change-Id: Ib4b76aa64d7ed1d805c0c4761375faf2c6c447b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158046 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#761006}
-
Yuki Shiino authored
Bug: 1060971 Change-Id: I3deb3787a431c6d195eb948cd3c966588a9e3ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158197Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/146137adeebe..811efc06df3d git log 146137adeebe..811efc06df3d --date=short --first-parent --format='%ad %ae %s' 2020-04-21 mbonadei@webrtc.org Trigger bots. Created with: gclient setdep -r src/third_party/webrtc@811efc06df3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I787933ffc0fea40c246c87672248ab0353c211d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159136Reviewed-by:
-
Andrew Grieve authored
Turns out it uses a different setting for disabling hidden API access from Q. hidden_api_policy_p_apps vs hidden_api_policy. Bug: None Change-Id: I25d603664da762f24d44f66bafb20fe641a2b935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159408 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#761003}
-
Haiyang Pan authored
K is deprecated after m81 so it is not needed any more. android-cronet-kitkat-arm-rel is kept due to https://crbug.com/1032336#c25 Bug: 1032336 Change-Id: I4e93516375f79faf2b21ef5d7a9c5073b8df9908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157974Reviewed-by:
-
Sergio Collazos authored
This reverts commit 3e1566b9. Reason for revert: Landed by error Original change's description: > Reland "Enables kInfobarUIRebootOnlyiOS13 by default" > > This reverts commit 920d8f93. > > Reason for revert: Initial Patchset to Reland this change. > Original change's description: > > Revert "Enables kInfobarUIRebootOnlyiOS13 by default" > > > > This reverts commit b7db0ccb. > > > > Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed. > > > > Original change's description: > > > Enables kInfobarUIRebootOnlyiOS13 by default > > > > > > This is now needed in order to enable this locally and not via a finch > > > config which might not land before the re-sping gets to users. > > > > > > Bug: 1071853 > > > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505 > > > Commit-Queue: Sergio Collazos <sczs@chromium.org> > > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#760756} > > > > TBR=eugenebut@chromium.org,sczs@chromium.org > > > > Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1071853, 1073091 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469 > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#760984} > > TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org > > Change-Id: I2d3fc20cf74f8082b928c1bbef7a1fd51f86704d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1071853, 1073091 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159249 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760999} TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org Change-Id: Id605aba1c85df624862ef46ce9776dedffdb8e37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071853, 1073091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159250Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#761001}
-
Julian Pastarmov authored
Only trust the URLWhitelist policy for external protocol handlers if the computer is part of an AD or AAD domain. BUG=1052093 Change-Id: Ie0d3ecb24ae6117248ff4e00e875a9104255ef41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152585Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#761000}
-
Sergio Collazos authored
This reverts commit 920d8f93. Reason for revert: Initial Patchset to Reland this change. Original change's description: > Revert "Enables kInfobarUIRebootOnlyiOS13 by default" > > This reverts commit b7db0ccb. > > Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed. > > Original change's description: > > Enables kInfobarUIRebootOnlyiOS13 by default > > > > This is now needed in order to enable this locally and not via a finch > > config which might not land before the re-sping gets to users. > > > > Bug: 1071853 > > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505 > > Commit-Queue: Sergio Collazos <sczs@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#760756} > > TBR=eugenebut@chromium.org,sczs@chromium.org > > Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1071853, 1073091 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760984} TBR=sdefresne@chromium.org,eugenebut@chromium.org,sczs@chromium.org Change-Id: I2d3fc20cf74f8082b928c1bbef7a1fd51f86704d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071853, 1073091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159249Reviewed-by:
-
