- 20 Jun, 2018 26 commits
-
-
Nigel Tao authored
This is a reland of 82a1baac Compared to the original: No changes, other than https://chromium-review.googlesource.com/c/chromium/src/+/1100661 "Delete spurious js_type_check BUILD.gn target" landed. Original change's description: > Centralize externs_list BUILD.gn declarations > > The externs_list is used by the Closure compiler, to type check imported > terms like 'chrome.fileManagerPrivate.foo', and to ensure that when > minimizing JS code from 'foo.bar.baz()' to 'a.b.c()', well known names > like 'chrome' aren't minimized. > > However, the files_manager app does not ship Closure-compiled code in > production. It ships uncompiled code - the .js files as written by the > programmer. Instead, the externs_list is used indirectly by the > js_type_check("closure_compile") rules as a lint-style check. > > Prior to this CL, maintaining the externs_list was therefore ad hoc and > indirect. For example, the hand-written and hand-maintained BUILD.gn > files would contain rules like: > > js_library("foo") { > deps = [ > "../../common/js:elephant", > "../../common/js:giraffe", > ] > externs_list = [ > "../../../externs/apple.js", > "../../../externs/banana.js", > ] > } > > where foo.js might not refer to externs/apple.js any longer, and it > might actually depend on externs/pear.js that is only coincidentally > satisfied because common/js/giraffe.js happens to list externs/pear.js > on its externs_list. This might be true at any particular point in time, > but as new code is added, and as existing code is refactored, the > externs_list entries become stale. > > After this CL, each js_type_check("closure_compile") target has an > associated js_library("closure_compile_externs") BUILD.gn target. This > gives exactly one place to list all the external dependencies of every > Closure compilation target. > > Future commits may re-organize the very fine grained (only 1 .js file > per js_library BUILD.gn target) js_library targets into larger units, > and in doing so, push duplicated externs_list entries from the leaves of > the BUILD.gn dependency tree towards the root. This could arguably help > us move towards shipping Closure compiled JS instead of hand-written JS. > But the first step is to get a handle on the dependencies (i.e. > externs_list entries) in the first place. > > Test: "ninja ui/file_manager:closure_compile" runs without error > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I1a3b029b5223db12abd38077d56914ad9d28a396 > Reviewed-on: https://chromium-review.googlesource.com/1092399 > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Sasha Morrissey <sashab@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567072} Change-Id: I3a89e0c722840535f40c35bfbdfc69236139e0ec Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1100615 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#568677}
-
Ben Smith authored
WebAssembly threads implicitly enables SharedArrayBuffer (--enable-shared-array-buffer) and structured cloning WebAssembly.Module (--enable-webassembly). Bug: 852756 Change-Id: I89d04cf08f1ff8cb777cf67f794d0f88049b6443 Reviewed-on: https://chromium-review.googlesource.com/1105558 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568676}
-
Thomas Anderson authored
This reverts commit 43a48785. Reason for revert: This CL made the assumption that we didn't ship in any configurations that are instrumented or that are component builds. However bug 853266 points out that CrOs ships in an asan configuration, so the rpath removal will still be necessary until the change in [1] is made. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=850682#c14 Original change's description: > Stop removing rpath_for_built_shared_libraries from chrome_sandbox > > For instrumented builds like tsan, this causes chrome_sandbox to reference the > wrong libc++.so due to a missing RPATH. > > Since all configurations we ship don't set RPATH, we don't have to worry about > security vulnerabilities introduced by RPATH=$ORIGIN. There's also a check to > enforce this in chrome/installer/linux/common/installer.include. > > BUG=850682 > > Change-Id: I25307bd9de388009acffdbb8de6717210873655b > Reviewed-on: https://chromium-review.googlesource.com/1092077 > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566099} TBR=jorgelo@chromium.org,palmer@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 850682,853266 Change-Id: I4b094a512b29b76e12659cba905536118a49208c Reviewed-on: https://chromium-review.googlesource.com/1107137 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568675}
-
Giovanni Ortuño Urquidi authored
This is the first patch to implement a policy to allow admins to remotely install Web Apps. Bug: 844278 Change-Id: Ib8ace57ddfbb004db7b612ec0c8501f162ea56ff Reviewed-on: https://chromium-review.googlesource.com/1075872Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#568674}
-
Aaron Leventhal authored
Bug: 848617 Change-Id: I42b5b23a8497912128462ce83dacfd8009ef8797 Reviewed-on: https://chromium-review.googlesource.com/1105069 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#568673}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/179059f63e9e..1cabdc464313 git log 179059f63e9e..1cabdc464313 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1cabdc464313 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I30ba4bb877d68123bd4265988dfdd78a3f0eb920 Reviewed-on: https://chromium-review.googlesource.com/1107217Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568672}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/780cdfed4eb2..bc383e76d631 $ git log 780cdfed4..bc383e76d --date=short --no-merges --format='%ad %ae %s' 2018-06-15 thomasanderson Update DEPS necessary to green-up CQ bots Created with: roll-dep src/third_party/libyuv Bug: chromium:845700,libyuv:799 Change-Id: I6f5b0d56dd9c057e3a341a069e121e7b7d09b4dc Reviewed-on: https://chromium-review.googlesource.com/1106968Reviewed-by:
-
Jinsuk Kim authored
The reported bug is a corner case where the WebContents at the front when Chrome is put background, is not at the front when Chrome is back to foreground. When coming to foreground in normal flow, |OnAttachedToWindow| callback reestablishes the front WebContents' ActivityStateObserver(ViewEventSinkImpl) first, which then reacts to |onActivityResumed| callback to update the state to 'resumed' as expected. The bug happens because the WebContents, not being in the front anymore, loses the chance to receive |onActivityResumed| when Chrome gets foreground, since it is still in the state where the observer is not registered. The observer is added later when the tab is moved to the front, upon receiving |onAttachedToWindow| callback. The observer will still remain in paused state that causes inconsistency leading the the bug. This CL fixes the bug by checking activity state when registring the activity state observer, which is done when attached to window. If it is already in the 'resumed' state, it invokes |onActivityResumed| to put WebContents in the right state. In a normal flow this will make |onActivityResumed| invoked twice but it is ok - the second one will be no-op. Bug: 852336 Change-Id: I24aae020908b6a537b258c44b26e63fe5b314474 Reviewed-on: https://chromium-review.googlesource.com/1105344 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568670}
-
Philip Rogers authored
This patch runs DocumentAnimations::UpdateAnimations for svg images, matching the SPV2 codepath. The corresponding non-svg-image UpdateAnimations call is behind a SPV2 || BGPT conditional in local_frame_view.cc. Bug: 854198 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If5132139cb7dcf0add0227c189f73809933a20c3 Reviewed-on: https://chromium-review.googlesource.com/1107098Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568669}
-
Reid Kleckner authored
Windows ASan reports a use-after-free on an ExtensionInstalledBubble object. While these tests don't fail on other bots, it's likely that they are flaky elsewhere, so we should disable them until the issue is resolved. R=rdevlin.cronin@chromium.org BUG=854355,844398 Change-Id: I19f5d646022847ab20a9fef54c5917a13153805c Reviewed-on: https://chromium-review.googlesource.com/1107001Reviewed-by:
-
Nigel Tao authored
Also fix a "missing semicolon" JS presubmit failure. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib607e0e25c74ff85cc9d5ba2f23c596e0f509723 Reviewed-on: https://chromium-review.googlesource.com/1100660 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Nate Chapin authored
Bug: 31666 Change-Id: Ib4e935437d0bf08fabc6c83103e6979e1c7ac8c8 Reviewed-on: https://chromium-review.googlesource.com/1104953 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568666}
-
Rintaro Kuroiwa authored
- Crypto session key exchange method should be HW key exchange. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iad92618778da0b83860cd6a4de19e829b03a667a Reviewed-on: https://chromium-review.googlesource.com/1087318 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568665}
-
Tom Anderson authored
When the --backwards-compatible option is given, all packages that have been removed from this script in the past 3 years will be included. R=dpranke CC=inferno BUG=None Change-Id: I396314c2204c45cfe2a78881e8cfc6838a68c2f5 Reviewed-on: https://chromium-review.googlesource.com/1106648 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Thomas Guilbert authored
When making multiple GMS RemoteMediaPlayer API calls, a "Results have already been set" IllegalStateException is often thrown. This is because the results of the earlier API calls have not been consumed in time, before the new PendingResults are set. In the past, similar issues in GMS RemoteMediaPlayer code were fixed by simply catching the exception and noop-ing it. This CL fixes the issue in the same way. Bug: 853923 Change-Id: I669c9e7ca0628d89dd24fc227349345f10c0f8a0 Reviewed-on: https://chromium-review.googlesource.com/1106610Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#568663}
-
Robbie McElrath authored
Currently the async flag in base::File isn't serialized when passing Files between processes. There are assertions and checks on the value of this flag in several places, so it needs to be preserved during serialization/deserialization. On Windows we can't check whether an existing file handle is async or not, so we have to explicitly pass the flag around. Bug: 845612 Change-Id: I8847ecd9451c13f7419e96db465caa417f4c543d Reviewed-on: https://chromium-review.googlesource.com/1096480 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#568662}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80452bee11eb..846bb413e161 git log 80452bee11eb..846bb413e161 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 reed@google.com iwyu 2018-06-19 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 1be9889efd32..eb7de4255855 (1 commits) 2018-06-19 bsalomon@google.com Move GrSwizzle.h from include/private to src/gpu. 2018-06-19 bsalomon@google.com Move GrGLSL.h from include/private to src/gpu/glsl. 2018-06-19 mtklein@chromium.org update software DM/nanobench configs for color testing 2018-06-19 brianosman@google.com added NIMA sample to showcase animations 2018-06-19 csmartdalton@google.com ccpr: Don't consider sub-pixel translation for caching on Android 2018-06-19 reed@google.com move imagefilters into separate dir and flag for build.gn 2018-06-19 rmistry@google.com Make infra failure message in Android compile bot more descriptive 2018-06-19 halcanary@google.com SkUtils: safe SkUTF16_NextUnichar 2018-06-19 fmalita@chromium.org Use SkJSONWriter for get_images_from_skps stats reporting 2018-06-19 brucewang@google.com Implement SkTypeface_FreeType::onMakeClone which overrides SkTypeface::onMakeClone. 2018-06-19 bsalomon@google.com Revert "Revert "Change how vertex/instance attributes are handled in geometry processors."" 2018-06-19 fmalita@chromium.org [skottie] Simplify Parse<SkPoint> 2018-06-19 herb@google.com Use SkGlyphRun instead of builder 2018-06-19 timliang@google.com Reland "Reland "added 565 to 8888 conversion for gpu LCD text rendering for macOS"" 2018-06-19 robertphillips@google.com Move op memory storage to GrContext (take 2) 2018-06-19 caryclark@skia.org simplify confusing examples 2018-06-19 jvanverth@google.com Limit iterations when computing convex inset. 2018-06-19 jvanverth@google.com Clamp ambient blur radius 2018-06-19 ziadb@google.com SkAR: drawing text, shapes, rotation modes enabled, translating objects Created with: gclient setdep -r src/third_party/skia@846bb413e161 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ibd6c34200198a6d902e00f5a0a7dc988b91657d1 Reviewed-on: https://chromium-review.googlesource.com/1107116Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568661}
-
François Beaufort authored
This makes sures Picture-in-Picture browser_tests run on Linux but not on Chrome OS yet. Bug: 845747 Change-Id: Ie22f3b5a3d3cebe9f2298b70882aae5e3679897b Reviewed-on: https://chromium-review.googlesource.com/1105048 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Maggie Chen authored
The current DCLayerOverlayProcessor only allows one overlay in the root render pass. Also no underlay is allowed. In order to support protected video, overlays and underlays (swapchains) are supported if PROTECTED_VIDEO and REQUIRE_OVERLAY are set. BUG=843814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iab1aa4adeb27f9ebed2fcc30727f17e73cea1d6f Reviewed-on: https://chromium-review.googlesource.com/1093986 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#568659}
-
Cathy Li authored
This will allow the "more" button to work on the NTP. Bug: 852075 Change-Id: I1a09ddc4f5b4faa484777650bde1eaedce5ec8cd Reviewed-on: https://chromium-review.googlesource.com/1107050Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#568658}
-
Peter Boström authored
Fixes theme regression in newer material UIs as the toolbar icons were not respecting themes' button tints. Also modifies the default incognito tint shift to be close to a no-op when the browser window is unthemed. Bug: chromium:820495 Change-Id: Ie820f373ba73a2fe3eb56959d0fe3618cc84f179 Reviewed-on: https://chromium-review.googlesource.com/1107108Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#568657}
-
Jennifer Apacible authored
Currently, tapping the controls will not show any of the controls. However, tapping the window where a control (e.g. play/pause, close) will activate it. With this change, the first tap on the window will show controls, and subsequent taps will be able to interact with the controls if they are visible. Bug: 854373 Change-Id: Ibceea8ac868071c675fa50b5e031ad0abd0e02cc Reviewed-on: https://chromium-review.googlesource.com/1107109Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#568656}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c9229d20..4e454ce4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie8416cf562eaf375b0a7a48a58858414a10ce234 Reviewed-on: https://chromium-review.googlesource.com/1106540Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568655}
-
codeimpl authored
XRFrame is a more generric name because with the addition of the input API we're using frames in places where there's no expectation of rendering or presentation involved[1]. [1] https://github.com/immersive-web/webxr/issues/364 Bug: 852528 Change-Id: Ie9a325cd626912b09bb2b77fe1b46d29baaef0b8 Reviewed-on: https://chromium-review.googlesource.com/1103426 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568654}
-
Katie D authored
The unused link was to install text-to-speech engines. We hope to use this in the future but don't have a place for it in M69. Removing before feature freeze. Bug: 850748 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie4c4d92bf285f3371bd5f51e8e485cfca3a0f18e Reviewed-on: https://chromium-review.googlesource.com/1106556Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#568653}
-
David Grogan authored
Also pass content size to the flex algorithm in a few places where border-box size had been getting passed. 33 new passes Bug: 845235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3d6556bed482a6aed7b5089390f874654a87ed60 Reviewed-on: https://chromium-review.googlesource.com/1096451 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#568652}
-
- 19 Jun, 2018 14 commits
-
-
Steven Holte authored
TBR=mlamouri NOTRY=true Bug: 854349 Change-Id: I97e80d2798a902bcdece04cf74deb7138a20f2af Reviewed-on: https://chromium-review.googlesource.com/1107173Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568651}
-
Devlin Cronin authored
As a workaround for flakiness in https://crbug.com/177163, crrev.com/9b393cf4 made all extension api subtests exit immediately for windows debug builds. However, this can lead to a number of issues: - Unnecessarily disabling tests that use RunExtensionSubtest that *aren't* flaky - Requiring tests that rely on RunExtensionSubtest() as only a portion of their validation to also be disabled. - Masking flakiness by having the test return true (instead of show up as disabled for a platform). Instead of doing this, we should find and disable specific flaky tests on specific platforms. This CL removes the logic to suppress extension api subtests. Sheriffs note: Since this has passed the CQ, this CL does not directly disable any tests. Any tests found to be flaky on Windows Dbg as a result of this CL should be disabled on Windows Dbg directly, rather than reverting this CL. (They were flaky before, and simply not run.) Bug: 177163 Change-Id: Id44a3b9ffd1882e15c1251a9665ffdf99a259373 Reviewed-on: https://chromium-review.googlesource.com/1106284Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568650}
-
Ned Nguyen authored
NOTRY=true # no tests on CQ cover this TBR=eyaich@chromium.org Bug: 713357 Change-Id: I252064713b2c8e5584f9db2fec35e58c0bf8a5f3 Reviewed-on: https://chromium-review.googlesource.com/1107213Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568649}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/efd58885b78d..9cccc5ce4fb9 git log efd58885b78d..9cccc5ce4fb9 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 ayatane@chromium.org sysmon: Ignore chromeos3-* devservers 2018-06-19 dgarrett@google.com gclient: Stop using implicit git_cache_dir. 2018-06-19 lhchavez@google.com Add 'signed' image type examples / docs to cros flash 2018-06-19 dgarrett@google.com chromeos_config: Move toolchain builders to swarming. 2018-06-19 dgarrett@google.com build_status: Remove config_lib.UseBuildbucketScheduler. 2018-06-19 yunlian@google.com cros_gdb: set debug-file-directory for simple chrome. 2018-06-19 vapier@chromium.org pylintrc: convert warnings list into readable ids Created with: gclient setdep -r src/third_party/chromite@9cccc5ce4fb9 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853866,chromium:853391,chromium:852017,chromium:853969,chromium:853025,chromium:843275,chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I38b6b86c7271b9ca0ec2148faa144816e012ac81 Reviewed-on: https://chromium-review.googlesource.com/1107006Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568648}
-
Sylvain Defresne authored
ProfileSyncService DCHECK in Shutdown that all observer have been unregistered, so refactor DesktopPromotionSyncService to unregister its observer in Shutdown. The refactor consist in removal of the helper observer class DesktopPromotionSyncObserver that is folded in the service as it makes it easier to track whether the observer is still registered (the alternative is to introduce a delegate class that is implemented by the service and invoked by the observer when it needs to unregister). As the class had no behaviour at this point, merging it with the observer is simpler. Also fix the fact that desktop_metrics_logger_initiated_ was not initialized in DesktopPromotionSyncObserver constructor, so the check in OnStateChange was undefined behaviour (most likely the result would have been that the variable was read to be non-false). Mark some local variable as const and avoid reading prefs that are not used. Bug: 854118 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8d5d2bcb09da0430d3a08d79058bdecd047f3f28 Reviewed-on: https://chromium-review.googlesource.com/1105978 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568647}
-
Ned Nguyen authored
Bug:713357 NOTRY=true # changes not affecting CQ TBR=eyaich@chromium.org Change-Id: Ife9474655e1a92e2cca1d4b6c0f2b38a134aff75 Reviewed-on: https://chromium-review.googlesource.com/1107205Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41b453a48844..4004ae0e033a git log 41b453a48844..4004ae0e033a --date=short --no-merges --format='%ad %ae %s' 2018-06-19 lfy@google.com GLES1: Point rasterization (partial implementation) 2018-06-19 jmadill@chromium.org D3D11: Suppress basic line XFB dEQP tests. Created with: gclient setdep -r src/third_party/angle@4004ae0e033a The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I3d89829abc3658ad68da07daea1057bb31ab521c Reviewed-on: https://chromium-review.googlesource.com/1107097Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568645}
-
Tommy Steimel authored
This CL adds CSS to make the overlay enclosure the size of the video to prevent it from defaulting to 0x0. This fixes a bug where once the overlay cast button disappeared (due to the hide timer), the user was unable to bring it back by tapping on the overlay enclosure (since there was nothing to tap on). Bug: 853855 Change-Id: If4504b84c023cf7f52620ce7d58a71a5522be587 Reviewed-on: https://chromium-review.googlesource.com/1105516 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#568644}
-
Andrey Lushnikov authored
R=dgozman Change-Id: Ie10da2525c9192d652735c3331ed1bb28670c582 Reviewed-on: https://chromium-review.googlesource.com/1105597Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568643}
-
Varun Khaneja authored
Partly, this undoes the change made in CL crrev.com/c/1095569 It turns out that there's no need to send the status code from Java to native -- it can be logged from Java-land. This CL also changes the type of histogram "SB2.RemoteCall.InternalErrorStatusCode" but that's acceptable since it only logged '0' values so far which were neither interesting in the past and nor will be interesting in the future. Bug: 851587 Change-Id: I959f5a1a557b09f7691cdc200625d14b8adbde41 Reviewed-on: https://chromium-review.googlesource.com/1105310 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Mei Liang authored
This CL adds logging for the following UMA histogram on cold start: 1. Tabs.Tasks.AverageTabGroupSize 2. Tabs.Tasks.TabGroupCount 3. Tabs.Tasks.TabGroupDensity 4. Tabs.Tasks.TabsInGroupCount 5. Tabs.Tasks.TabsInGroupRatio All of these histograms will help us understand how users use tabs. Bug: 848150 Change-Id: Ieb290911a6f8f6dccd7133cce2e7cc72362f56bf Reviewed-on: https://chromium-review.googlesource.com/1085629Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568641}
-
Scott Chen authored
This CL removes all changes from media_router, which were causing flakey tests. The intention is to reland those separately as a follow-up CL. Bug: 832177 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I68c653f4e492807988cdb09c2387e42111bd8db7 Reviewed-on: https://chromium-review.googlesource.com/1106419 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568640}
-
Bo Liu authored
Move java_peer_avaiable_on_client_thread_ to an early return. Call ApplicationStatusListener::GetState only once. Have java side call back to native to set TerminationInfo, so that it's easier to add more arguments in the future. No behavior change intended. Change-Id: I6b9ef14719414513fb307944e126eac9f51bf28f Reviewed-on: https://chromium-review.googlesource.com/1105461Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568639}
-
Stuart Langley authored
ThreadChecker has a set of boilerplate macros that should be used so that it is compiled out correctly on non DCHECK enabled builds. No Logic Changed, No New Tests. Bug: 841659 Change-Id: I93369ee67285ace07b630cd05b11b9e1d1cc9cfc Reviewed-on: https://chromium-review.googlesource.com/1107017Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#568638}
-
