- 24 Mar, 2018 18 commits
-
-
David Bokan authored
ScrollIntoView is a virtual method on ScrollableArea. In ScrollableArea, the param implies the rect param is in content coordinates. However, implementations varied. RootFrameViewport required content/document coordinates but PLSA assumed it was in absolute coordinates. This CL ensures the interface and all implementations take the param in absolute coordinates and cleans up the callsites in LayoutBox's ScrollRectToVisibleRecursive. I've also cleaned up some variable names where I found ambiguity. There's also a change in LayoutBox::Autoscroll to change RootFrameToContents to RootFrameToAbsolute. This is a bit misleading since RootFrameToContents uses the term "contents" to mean "frame" when root-layer-scrolling is turned on. This means the code is correct but looks strange. Changing it to RootFrameToAbsolute has no functional difference (the code is the same) but fits better with the naming scheme (and we'll likely remove RootFrameToContents once root-layer-scrolling is fully shipped). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2d9ab7e851d63c0e5d9e5d2e2025b1f8bbf460c1 Reviewed-on: https://chromium-review.googlesource.com/972430 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545654}
-
Jun Mukai authored
It seems this causes repositions of the toggle buttons when subtitles are set / cleared. Bug: 823656 Change-Id: Id987bd7f6291d4debdfb17d7fac34daedbe21117 Reviewed-on: https://chromium-review.googlesource.com/978889Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545653}
-
Candice Sy authored
Bug: 824602 Change-Id: I1aa2c7c43ec1e6afc343a239c30846258a231644 Reviewed-on: https://chromium-review.googlesource.com/978545 Commit-Queue: Candice Sy <cmsy@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#545652}
-
Chris Palmer authored
We were in a maze of twisty #ifdefs, all alike. We are now somewhat less likely to be eaten by a grue. TBR=dcheng Bug: 766882 Change-Id: Ib72010a76cdf76fc1ec821b618cc0ad967d687ab Reviewed-on: https://chromium-review.googlesource.com/978860 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545651}
-
Scott Violet authored
This updates mojo, net and pdf. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build Change-Id: I279223aa2bdfc375288eee485a77bfad9b6db3d4 Reviewed-on: https://chromium-review.googlesource.com/978372 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545650}
-
Lukasz Anforowicz authored
The move helps ensure that --site-per-process stays turned off by default in the //content layer (this is needed to avoid opting into --site-per-process all //content embedders like ChromeCast). The move enables selectively enabling --site-per-process at the //chrome layer. Bug: 824966 Change-Id: Icc3354dfeb2ff20c6027267890596b929331c1ed Reviewed-on: https://chromium-review.googlesource.com/976880 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545649}
-
Miguel Casas-Sanchez authored
This CL corrects the usage of |fast_mode| (which is reversed on ToT), adds a note about CIDetectorMaxFeatureCount and improves unit tests. Anecdotically, Spec issue [1] primed me to wire the max-detected-faces option that was apparently available on 10.12; on a closer reading of the header files (not of the online docs), the setting is only actually available for rectangle detection. [1] https://github.com/WICG/shape-detection-api/issues/39 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I6d66b477d0a408c4950d8956d1e020c81e558269 Reviewed-on: https://chromium-review.googlesource.com/978511Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#545648}
-
Christopher Grant authored
BUG=824969 R=mthiesse Change-Id: Ifeb8f82e41ade9bdb10c7649cb7d2a4f1e06851c Reviewed-on: https://chromium-review.googlesource.com/978659Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#545647}
-
John Budorick authored
Bug: 755920 Change-Id: Idb7367fcd6e425d3a2a2e5c05599abc3fa5954ef Reviewed-on: https://chromium-review.googlesource.com/930178Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545646}
-
Christopher Grant authored
Have the button class itself assign default sounds. This ensures they all sound the same, in both enabled and disabled states. BUG=823413 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id254c67f702d7cd7ccd169b55f68f9b79cf4eb49 Reviewed-on: https://chromium-review.googlesource.com/978631 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545645}
-
Qiang Xu authored
Bug: none Test: covered by tests Change-Id: If2c3601446dd48391aed141e28bf8c3ee2e11c9e Reviewed-on: https://chromium-review.googlesource.com/978934 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545644}
-
Mike Wasserman authored
Avoid overriding the OzonePlatform instance with a test subclass. Instead, have PlatformDisplayDefault make StubWindows for invalid ids. Bug: 732987 Test: Automated Change-Id: I981e844861fbd045eee5436aede91a35c7f8f682 Reviewed-on: https://chromium-review.googlesource.com/978375Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#545643}
-
Steven Holte authored
Bug: 761524 Change-Id: Ia9f024dc01732814a8b8eaf7a5284f99e899e418 Reviewed-on: https://chromium-review.googlesource.com/976948 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#545642}
-
Raymond Toy authored
Change-Id: Ibfefd9929b5f60b7c0de954ceee75142fdb6a838 Reviewed-on: https://chromium-review.googlesource.com/979016Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545641}
-
Lukasz Anforowicz authored
Bug: 825325 Change-Id: I17d46070a5fc5a060b0881a2ba58f52ffce07f1d Reviewed-on: https://chromium-review.googlesource.com/978674 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
The WindowAndroid object for WebContents(or ContentViewCore) can be obtained through WebContents.getTopLevelNativeWindow. This CL removes the API in ContentViewCore that returns the same object. Internally, ContentViewCore uses the cached value updated via |updateWindowAndroid| instead. Bug: 598880 Change-Id: I19707db25ba9e7e55e85c1275e27d1c63e5167b4 Reviewed-on: https://chromium-review.googlesource.com/977101Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#545639}
-
Evangelos Foutras authored
Ensure ICU symbols have public visibility and are thus excluded from CFI checks and whole-program optimization. The former caused a startup crash and the latter has the potential to break virtual calls in weird ways. BUG=822820 Change-Id: Ia809eefcb9e93b3c612f2381d394db83bbc67120 Reviewed-on: https://chromium-review.googlesource.com/978008Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545638}
-
Jialiu Lin authored
Bug: 825268 Change-Id: I575c9600b2989fbedc78bfa38f4888b8aec8965d Reviewed-on: https://chromium-review.googlesource.com/978505 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545637}
-
- 23 Mar, 2018 22 commits
-
-
wutao authored
KeycodeConverter::DomKeyToKeyString cannot show correct string if the dom_key has no mapping. This cl handles this corner case to display alternative string in Keyboard Shortcut Helper (KSV). Bug: 824495 Test: On device with Swedish keyboard layout. Change-Id: I3c54941b89ce34244c8b69d4a905cb1ddbdffb11 Reviewed-on: https://chromium-review.googlesource.com/974474 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#545636}
-
Sammie Quon authored
Test: manual Bug: 824868 Change-Id: I9d008311447215bce541a7c294b451470a0c5aac Reviewed-on: https://chromium-review.googlesource.com/978451Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#545635}
-
Daniel Cheng authored
Update the IPC owners checks to skip files that don't parse. This is OK since invalid JSON already triggers a separate presubmit error. Once the error is fixed, subsequent presubmit runs will verify that IPC owners are correctly set. Bug: 825053 Change-Id: I2295901bf706c1a62ebee3710c5d87e415bd011a Reviewed-on: https://chromium-review.googlesource.com/978611Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545634}
-
Ahmed Fakhry authored
The header of a browser window snapped in SplitView mode should use the same height as that of a maximized browser window header. This is true for both touchable and non-touchable chrome. This bug became more obvious with touchable chrome since the header height is much bigger. BUG=823371 TEST=Added test that would fail without the fix Change-Id: Ica52701338b4fdf94582392bbebbbdfc96328433 Reviewed-on: https://chromium-review.googlesource.com/969585 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#545633}
-
Tommy Steimel authored
This CL adds a check in the overlay play button double-click code to make sure the user should be able to toggle fullscreen before actually toggling. Bug: 823476 Change-Id: I8d61292516ed4b385f732f9259ed262b4685a314 Reviewed-on: https://chromium-review.googlesource.com/972347 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#545632}
-
Matt Mueller authored
Change-Id: If6d42457b8d40040ef09695eaf8197b06fd99575 Reviewed-on: https://chromium-review.googlesource.com/967322 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#545631}
-
Peter Boström authored
This separator isn't called for in either the touchable spec or MD refresh. Bug: None Change-Id: I99a1c3ddd1d478aec6258426f4c6a9865cd7eadf Reviewed-on: https://chromium-review.googlesource.com/978879 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545630}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/31a3eb064ea3..a03592f3d2e2 $ git log 31a3eb064..a03592f3d --date=short --no-merges --format='%ad %ae %s' 2018-03-21 jrbarnette Add a 'kevin-full' builder. Created with: roll-dep src/third_party/chromite BUG=chromium:817547 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0b7823460c8221ea9655914f3f6aeb11fbe6e8c3 Reviewed-on: https://chromium-review.googlesource.com/978880Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545629}
-
https://chromium.googlesource.com/angle/angle.git/+log/49cef9a52181..ad4f9642a655 $ git log 49cef9a52..ad4f9642a --date=short --no-merges --format='%ad %ae %s' 2018-02-08 ynovikov Allow ANGLE libs to have arbitrary suffix. 2018-03-22 lucferron Vulkan: Depth / stencil attachments bug fixes 2018-03-23 oetuaho Increment ANGLE_SH_VERSION Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I14c42f835b942abbdea348eb66cea440d34a6098 Reviewed-on: https://chromium-review.googlesource.com/978885 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545628}
-
Devlin Cronin authored
Manifest v1 had an "inIncognitoTab" on the chrome.extension API object property instead of the new "inIncognitoContext". Remove support for this fully (and update a stale reference). Bug: 816677 Change-Id: I4cefe0359ff3c4cae0df06b467c5628f6cd27fc6 Reviewed-on: https://chromium-review.googlesource.com/973542Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545627}
-
Conley Owens authored
This change adds a boolean `was_cached` to the SubresourceLoadInfo struct. This lets consumers know whether or not the response was fetched from the network cache. Notably, this is important for recording page load metrics when the Network Service is enabled. This reverts commit 0b2b1a92. Issues in the previous commit are fixed by retaining the exists_in_cache field. In a many cases when NavigationURLLoaderDelegate::OnRequestFailed() is called, NavigationURLLoaderNetworkService::OnResponseStarted() has not been called. In these cases, we cannot rely on using a stored was_cached value, since it may not be properly updated. BUG=816684,822237 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0beb72b825ae0a12122170cec2e4f4358dda58af Reviewed-on: https://chromium-review.googlesource.com/966792Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
-
Yuly Novikov authored
conformance/extensions/oes-texture-float-with-video.html on Win Intel TBR=kbr@chromium.org BUG=825338 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2b3116e48264c503b034d1230f24555a639858db Reviewed-on: https://chromium-review.googlesource.com/978038 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#545625}
-
Kevin Bailey authored
Primarily adds 2 fields to the Omnibox event proto, but also makes tiny changes to other protos to bring them up to date with the master copies. About the 2 new fields: The first indicates whether the autocomplete match also advertised that a tab switch suggestion was present. i.e. whether the URL was already open in another tab. The second indicates whether the user selected the tab switch option (or whether they chose to navigate). Tab switch suggestion is orthogonal from the suggestion type because most any suggestion can have its URL be present in another tab. Additionally we wish to know the original type in order to give credit to that provider. We wish to know whether the user selected the tab switch option to gauge whether the indication for the tab switch option was obvious enough, and clear enough (if it was noticed). Bug: 780835 Change-Id: Ib4e8af9275283fe0eac3c7734e1647a4b2c0a133 Reviewed-on: https://chromium-review.googlesource.com/977047 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545624}
-
Istiaque Ahmed authored
This will allow ContentHash caching to be (trivially) implemented in the future in ContentVerifier::GetContentHash(). This CL also makes extension load at startup to queue all inflight requests to load verified_contents and computed_hashes reading from disk. This is because inflight requests will be served by single file read. Summary of changes: The primary method is ContentVerifier::GetContentHash(). This method is responsible for retrieving ContentHash on IO thread. It uses ContentVerifier::HashHelper to manage thread hops and such. HashHelper is not thread safe and it uses static method + weak pointers to safely call ContentHash methods on blocking thread. ContentHash class is responsible for fetching verified_contents.json from network, using ContentHashFetcher. ContentHashFetcher manages its own lifetime and is no longer ref-counted. Also, ContentHashFetcherJob is no longer required. ContentHashFetcher is currently an implementation detail of ContentHash, and can be further restricted so that it cannot be instantiated outside of ContentHash. Because of async nature requirement of net fetch, ContentHash::Create is now async. Since ContentHash instance can travel between sequences, they are RefCountedThreadSafe now. ContentVerifier::VerifyFailed used to be (also) called when we fail to retrieve hashes on disk and it would fall back to ContentHashFetcher for fetching the hashes. As GetContentHash currently takes care of this through ContentHash::Create, ContentVerifier is only made aware of failures on when hash mismatch occurs, simplifying things further. Bug: 796395 Change-Id: I7eb6bf93daba908258ae604a8cd45ea643b4e00d Reviewed-on: https://chromium-review.googlesource.com/933863 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545623}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/728244f70a8b..0d9ecc925d38 $ git log 728244f70..0d9ecc925 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 ehmaldonado Reland "gclient eval: Expand vars while parsing DEPS files" 2018-03-23 sergiyb Correct documentation for the --no-referenced-issues argument 2018-03-23 iannucci Clear $VPYTHON_CLEAR_PYTHONPATH when setting $PYTHONPATH. Created with: roll-dep src/third_party/depot_tools BUG=chromium:821199,chromium:825290,chromium:825174 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I58cbb0ca469176bb99a5a86d7504c986fa9b162b Reviewed-on: https://chromium-review.googlesource.com/978865 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545622}
-
Tao Bai authored
Bug: 825248 Change-Id: I5bb5bbe2b7dd0e147d409ce6074ae6adab2dd14d Reviewed-on: https://chromium-review.googlesource.com/978883Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545621}
-
Reilly Grant authored
This change wraps strong references to libusb_device objects in a ScopedLibusbDevice class (specializing ScopedGeneric) in order to better document when these references are expected to be dropped. Bug: 819356 Change-Id: I9671d340f0d5353637405ddd72846456e23a5f1f Reviewed-on: https://chromium-review.googlesource.com/972623Reviewed-by:
-
Qiang Xu authored
changes: - Fix regression from crrev.com/1972033002. - Rename multi_user_window_manager_test.h to multi_user_window_manager_test.h. Bug: 766834 Test: manual test and added test coverage Change-Id: I08d9beca388bf71eecb19f9c7b6412c6f8157365 Reviewed-on: https://chromium-review.googlesource.com/977040 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
-
Carlos Knippschild authored
With this change version checking will also ignore the line from the version string that presents the local installation path for adb. Change-Id: Ie7a3b26965b1d94d6d269f1b4b0919468d8eea2c Reviewed-on: https://chromium-review.googlesource.com/978775Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#545618}
-
Scott Chen authored
After this CL, when the unified-consent feature is enabled, user will see a "sync and personalization" row instead of a "sync" row with status icon. This "sync and personalization" row will be present even when the user's not signed in yet, and will open the /syncSetup subpage even when the user is not signed in. This change DOES apply to CrOS if the unified-consent feature is enabled. if the unified-consent feature is not enabled, there should be no user-perceivable changes. ** The content of the sync subpage while non-signed-in is still WIP so it will be a bit wonky (there will be follow-up CLs to complete this work before unified-consent launches). Screenshots + captions: https://imgur.com/a/Usx6z Bug: 800972 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3bbbf4e5b55eb25116d19d0f959a549116dce3d2 Reviewed-on: https://chromium-review.googlesource.com/974476Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545617}
-
Matt Menke authored
ResourceDispatcherHost pushes pending load state of all frames to the UI thread once every 250 milliseconds when there's a pending load. This happens even when the UI thread is blocked. Apparently it's causing an OOM when the UI thread is blocked. Whatever is blocking the UI thread is another issue entirely, but we shouldn't use unbounded memory in the browser process. This CL prevents load state updates from being sent until the previous set was ACKed by the UI thread. Bug: 824869 TBR: jam@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3b68522c5281d477d3a621ac02e5df1f75153d99 Reviewed-on: https://chromium-review.googlesource.com/978383 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
wutao authored
This cl puts the focus on the search box when Keyboard Shortcut Viewer (KSV): 1. The first time the window is created. 2. Every time it exits search mode by Esc or back arrow. Bug: 822333 Test: manual test. Change-Id: Ia0fdeb744e3090d246769aee58c9ee42d58e14e5 Reviewed-on: https://chromium-review.googlesource.com/978784Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545615}
-
