- 31 Oct, 2018 40 commits
-
-
BUG=762641, 897540 TBR=oshima@chromium.org Change-Id: I497be0962d522a8e3ce19ff5e09754a8c91f6a3a Reviewed-on: https://chromium-review.googlesource.com/c/1303654 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#604123}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a92cd7312ca..b3f887b82310 git log 1a92cd7312ca..b3f887b82310 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 benwright@webrtc.org Expose key derivation through a simple interface for use in WebRTC. Created with: gclient setdep -r src/third_party/webrtc@b3f887b82310 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie616f3ecf9b9811cc8d393cc0d8701fff0766b52 Reviewed-on: https://chromium-review.googlesource.com/c/1308702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604122}
-
Zhuoyu Qian authored
LogoDelegate was used as a mechanism for decoding untrusted logo images. Now, all platforms use the same LogoDelegateImpl, based on image_fetcher::ImageDecoder. LogoDelegateImpl should be removed, in favor of using an image_fetcher::ImageDecoder directly. Bug: 761828 Change-Id: If5734629a0c16a0a8867421c783b6d49fad2545c Reviewed-on: https://chromium-review.googlesource.com/c/1290583 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#604121}
-
Ian Kilpatrick authored
This lambda-izes AllLayoutOpportunities, so that FindLayoutOpportunity doesn't need to iterate over a Vector to find something that fits. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0cf9d5ce16608032850e326173a9fb4d501a9181 Reviewed-on: https://chromium-review.googlesource.com/c/1193942 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604120}
-
Tetsui Ohkubo authored
This CL ports following tests from browser to ash: * TrayAccessibilityTest.ClickDetailMenu * TrayAccessibilityTest.CheckMarksOnDetailMenu Other TrayAccessibilityTest browser_tests will be refactored to use SystemTrayTestApi mojo interface and kept on the browser side, because these tests are hard to do in ash unit tests. This CL also removes following tests: * TrayAccessibilityTest.ShowTrayIcon (browser_tests) * TrayAccessibilityTest.VisibilityFromMenu (ash_unittests) * TrayAccessibilityTest.VisibilityFromSettings (ash_unittests) * TrayAccessibilityLoginScreenTest.LoginStatus (ash_unittests) They either have the replacement in AccessibilityFeaturePodControllerTest, or simply the feature is removed. TEST=ash_unittests, browser_tests BUG=850014 Change-Id: I4d7c8d99cb6ce5df9de4115d874fc56d7a0c276a Reviewed-on: https://chromium-review.googlesource.com/c/1306937 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604119}
-
Ryan Hamilton authored
Change QUIC ConnectionCloseError histograms to break out errors for Google hosts in an attempt to diagnose some unexpected errors. Change-Id: I56a795474abda715025b7fbf015d4880537c8748 Reviewed-on: https://chromium-review.googlesource.com/c/1303045Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604118}
-
Christian Biesinger authored
No need to call IsLayoutBlock/IsLayoutNGMixin twice R=eae@chromium.org, mstensho@chromium.org Change-Id: Id63f3833040d4eb58dd67dcb204a139522e08a9b Reviewed-on: https://chromium-review.googlesource.com/c/1308653 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Before crrev.com/c/1277654 when we created text results for ref tests most of which don't need text baselines, we let reftest's text baseline be optional, so that most reftests can ignore the text results, while a few of them for which the text result is significant can still check the text results. After crrev.com/1277654, reftests no longer produce text results thus don't need text baseline, unless a test explicitly produces text result. In this case, we can just let the test determine if the text baseline is needed, instead of run_web_tests.py checking existance of the text baselines. About existing reftests producing text results but without text baselines: 1. for tests that don't actually need text results, modify them so that they no longer produce text results. This includes some tests previously calling testRunner.dumpAsTextWithPixelResults() just to dump pixel results. 2. for tests that produce meaningful text results, create text baselines. 3. for tests that don't produce text results intentionally, but the text results are created because of some console messages, etc. also create text baselines. There are several cases: a) the message shows the purpose of the test, e.g. intentionally testing with some invalid values. New text baselines are created in this CL. b) the message shows some problem of the test that doesn't need to fix for now, e.g. the test is using some deprecating API. New baselines are created in this CL. c) the message indicates some fatal bug in the test, e.g. using undefined variable, invalid JavaScript grammar, etc. The bugs are fixed in this CL. Bug: 703899 Change-Id: I82a6b25c61d1fb794840fdaa0da248909a690592 Reviewed-on: https://chromium-review.googlesource.com/c/1298120 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#604116}
-
John Z Wu authored
Change-Id: I53fc40fe8efebf71c0fe4831cfbd8bcb8deab138 Reviewed-on: https://chromium-review.googlesource.com/c/1289438 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#604115}
-
Yutaka Hirano authored
Looks like they are due to infra flakiness. Bug: 626703, 898687, 898153 Change-Id: I424c2d7cd0eaaec37605bc78d0d25865ed0b778a Reviewed-on: https://chromium-review.googlesource.com/c/1304037 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#604114}
-
Maks Orlovich authored
This CL's contents are entirely: cp chrome_async_socket.cc network_service_async_socket.cc cp chrome_async_socket.h network_service_async_socket.h cp chrome_async_socket_unittest.cc network_service_async_socket_unittest.cc ... done as a separate change so that the CL making the actual porting changes gets a usable diff between net and NetworkService versions of code. The "new" files are not included in compilation and this is meant to be landed together with https://chromium-review.googlesource.com/c/chromium/src/+/1232034 Bug: 875032 Change-Id: Idcdc85125c910662e642258adb71d58406752a64 Reviewed-on: https://chromium-review.googlesource.com/c/1237214Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604113}
-
Sunny Sachanandani authored
NV12 uses 4:2:0 subsampling which means there's one U and V sample per 2x2 block of Y samples. This means to have an integral number of U and V samples, both width and height of the surface (or Y plane) must be even. Scrolling on a page with video causes swap chain to be resized when the video's visible rect changes. Without forcing even width and height for NV12 swap chains, creating the swap chain often fails with fallback to BGRA swap chain. With this fix, creating the swap chain never fails. Includes a unit test for testing that swap chain is created with even dimensions after rounding, if necessary, and that the format of the swap chain is indeed NV12. Also, includes some minor cosmetic changes to logging to make clear that the errors codes are hexadecimal. Bug: 869677 Change-Id: Ief5999149d438e4883fc9c2bb397ab8a7d2b294e Reviewed-on: https://chromium-review.googlesource.com/c/1308906Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#604112}
-
Leonard Grey authored
Bug: 898278 Change-Id: I24ae7ef4e8accd54244dfd09721fa376dadfba34 Reviewed-on: https://chromium-review.googlesource.com/c/1305498Reviewed-by:
-
Alan Cutter authored
This CL makes OpaqueBrowserFrameView test for whether the user is using the system theme for the browser before using the hosted app theme color algorithm. This CL also updates the foreground color algorithm to always use the actual frame color to avoid readability bugs like this in general. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=365224&signed_aid=05pRAK75RpeItQNbJQ32zA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=365225&signed_aid=5PQmY9poCGVOGL8cIt7X3g==&inline=1 Change-Id: Id428054a636b408f59f88c49a0911f6a5052ccc5 Reviewed-on: https://chromium-review.googlesource.com/c/1307032Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604110}
-
Peter Boström authored
r598108 made GG900 primary text color in GetAuraColor / common_theme.cc which made the ShouldIgnoreHarmonySpec check (kColorId_LabelEnabledColor == SK_ColorBLACK) fail. This caused the Harmony colors to be ignored for OSes outside Windows that use the default aura colors. This change meant that GetHarmonyTextColorForNonStandardNativeTheme was pretty much always used for colors, instead of using the Harmony colors. Bug: chromium:896891 Change-Id: I394e25d2eda5da5c0bb0532056d6eebff2a855c2 Reviewed-on: https://chromium-review.googlesource.com/c/1308901Reviewed-by:
-
Antoine Labour authored
All callers set it to something consistent with the BufferFormat (i.e. the value of gpu::InternalFormatForGpuMemoryBufferFormat), and so is redundant. For GetInternalFormat, we can directly extract it from the BufferFormat. Bug: 900044 Change-Id: I5e135d60dedf3854fbc28a29abcc26054dd663f7 Reviewed-on: https://chromium-review.googlesource.com/c/1306993 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 870439 Change-Id: I6b08c368f23b18e533548ad02fd250876f911ccd Reviewed-on: https://chromium-review.googlesource.com/c/1308597Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#604107}
-
Clark DuVall authored
When running tests with network service enabled, we need to initialize NetworkServiceTestHelper to register test certs and perform other setup in the network process. This does the necessary setup for Android, similar to what is alredy being done for desktop here: https://cs.chromium.org/chromium/src/chrome/test/base/chrome_test_launcher.cc?l=167&rcl=024b72104d153da4c609c19d09facb8bd48632b6 Bug: 888020 Change-Id: I7016c42ff59169eb4f32b8531a83266b120a65fe Reviewed-on: https://chromium-review.googlesource.com/c/1306665Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#604106}
-
Zhuoyu Qian authored
This patch clears a call site of CreateVisiblePosition() in VisiblePositionOfHitTestResult(), since canonicalization on hit test result is unnecessary. Rename VisiblePositionOfHitTestResult() to PositionWithAffinityOfHitTestResult(). Bug: 657237 Change-Id: I2e88ac02e7b8c3afb307c4fe1033cc21d9f20161 Reviewed-on: https://chromium-review.googlesource.com/c/1297227Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#604105}
-
Wan-Teh Chang authored
Passing the address of a timestamp local variable as the user_priv argument to vpx_codec_decode() merely verifies that vpx_codec_get_frame() copies that value to the user_priv field of vpx_image_t correctly. No other clients of libvpx that I've inspected do this, including vpxdec.c, the sample decoder program. BUG=chromium:899916 Change-Id: I65dfd479fa3634429c4b76285c257aa54d860d81 Reviewed-on: https://chromium-review.googlesource.com/c/1306413 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604104}
-
Erik Luo authored
When editing a breakpoint (disable, edit condition), we trigger BreakpointRemoved, BreakpointAdded by resetting live UILocations. Un-evaluated Snippets and Filesystem scripts may have a 'defaultUILocation' but no live UILocation, so edits will not update the decoration. This CL resets the defaultUILocation to trigger decoration update. Bug: 899369 Change-Id: I4474d39c5fd25f14588e0488ce9b284aa453988e Reviewed-on: https://chromium-review.googlesource.com/c/1303096 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604103}
-
Sergey Ulanov authored
Previously scenic platform was using FIDL Scenic interfaces directly. SDK now includes scenic_cpp wrappers for Scenic interfaces. This CL updates Scenic Ozone platform to use scenic_cpp, which makes the code more readable and less error-prone. Bug: 899348 Change-Id: Id5fac3485b6a8cfac1aaefe1a921555090ec8138 Reviewed-on: https://chromium-review.googlesource.com/c/1308987 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604102}
-
Luciano Pacheco authored
This change is part of allowing folders/files inside My files, My files will be VolumeEntry instead of EntryList. Change VolumeEntry.createReader to use CombinedReaders, to combine volume's root reader with a StaticReader which returns any entries that have been added to VolumeEntry, this is what combine volume's own entries with Linux and Play files. Copy the following methods from EntryList to VolumeEntry type: - addEntry: To be able to append Linux and Play files inside My files when it is an actual volume. - findIndexByVolumeInfo: To be able to check if Linux and Play files is already appended. - removeByVolumeType: To be able to remove Linux and Play files when they aren't available anymore. - removeByVolumeType: To be able to remove Linux files fake entry, which is used before mounting the real Linux files. Remove EntryList method removeEntry, this method wasn't in use. Test: --gtest_filter="FileManagerJsTest.FilesAppEntryTypes" Bug: 873539 Change-Id: Ic9a659aed1e7c3b40fecd678240be99915121a90 Reviewed-on: https://chromium-review.googlesource.com/c/1304186Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604101}
-
Bailey Berro authored
This change is part of an ongoing series of changes to pull the add-smb-share dialog out of settings. - Creates smb_shares_localized_strings_provider - Switches the settings localized strings provider to using the smb_shares_localized_strings_provider Bug: chromium:887135 Change-Id: If061c2175497188772cfaa06cccb4727e438e962 Reviewed-on: https://chromium-review.googlesource.com/c/1287037 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604100}
-
Shu Chen authored
Also add the transform rules for the deva_phone (Devanagari Phonetic) keyboard. Bug: 859432 Change-Id: If76c01252606601f645fc01a17783f1089e9bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/1297223Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL is pure non-op refactoring, it simplies the structure of existing compiler wrappers and makes it easier to add new wrappers. Specifically, this CL maintains the following behaviors: 1. When goma is off and static_analyzer is off: cxx command: clang++ <flags> asm command: clang <flags> 2. When goma is on and static_analyzer is off: cxx command: gomacc clang++ <flags> asm command: gomacc clang <flags> 3. When goma is off and static_analyzer is on: cxx command: analyzer_wrapper.py clang++ <flags> asm command: clang <flags> 4. When goma is on and static_analyzer is on: cxx command: analyzer_wrapper.py gomacc clang++ <flags> asm command: gomacc clang <flags> Basically, goma wapper applies to both cxx and asm while static_analyzer only applies to cxx. Bug: 898695 Change-Id: I12ed474d1286daa9fdc2f7ab5611745e99dd66a3 Reviewed-on: https://chromium-review.googlesource.com/c/1307847Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604098}
-
Joe Downing authored
We had a few places in strings and code which referenced older MacOs versions as the minimum version, I've updated these so they should be inline with reality. Change-Id: I6f004754d25dd76a6b3d185f560b1e01a6f98eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1300683Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#604097}
-
Ben Pastene authored
Needed to pack up the bios-256k.bin file in the test isolates. The latest lkgm bumps fail w/o it: https://chromium-swarm.appspot.com/task?id=40e0280b72f15510 NOTRY=true Bug: 897540 Change-Id: If731c73a677cff02523b17599a1a50629b6ff430 Reviewed-on: https://chromium-review.googlesource.com/c/1308716 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604096}
-
Chris Morin authored
Factor out common code in UpstartClient, and allow UpstartClient to start arbitrary jobs instead of a fixed set of them. BUG=b:115779632 TEST=./out/Debug/unit_tests TEST=./out/Debug/component_unittests TEST=Ensure dummy job can be started with UpstartClient Change-Id: I362ad288b93615753cd778e823173d24a9ac16df Reviewed-on: https://chromium-review.googlesource.com/c/1307238Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
wutao authored
Decoder could read media data when the data source is deleted. This cl fixes this by allowing decoder to clean up defore deletion. Bug: b/118403995 Test: manual. Change-Id: I1c7336e417f8a8b5d57880d49e126fbc8873a6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1304066 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604094}
-
Khushal authored
The metadata decoder is never used for decoding anything other than the header, so it should never have any pixel data to evict. Its unnecessary to evict it from BitmapImage. R=chrishtr@chromium.org Bug: 899666 Change-Id: I93a5baa48d95e6c94f7081e9c9c02196a584b9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1305973Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#604093}
-
Oliver Chang authored
R=eugenis@chromium.org Bug: 899943 Change-Id: Ia8b67dd16a924d24c40aebfd713096bbbaeab5d7 Reviewed-on: https://chromium-review.googlesource.com/c/1306933 Commit-Queue: Oliver Chang <ochang@chromium.org> Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604092}
-
Ryan authored
Avoid risky casts between void* and object pointers by using the wincx method on the CryptoModuleBlockingPasswordDelegate. While safety was assured by virtue of being passed as a scoped_refptr<> to the appropriate base class, consistently use the wincx() method of the password delegate so that safety can be reasoned about from the callsite, rather than inferred from the type. BUG=none Change-Id: I120584dd5a62d1533689871f4a207f7205c6ada7 Reviewed-on: https://chromium-review.googlesource.com/c/1309097Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604091}
-
Nico Weber authored
See https://chromium-review.googlesource.com/c/1307937 for why. Bug: 899437 Change-Id: I996feae20627688fefd09419dedc78f015347cf4 Reviewed-on: https://chromium-review.googlesource.com/c/1308494Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604090}
-
Tarun Bansal authored
Change-Id: Ibac0faa988dfa05b727967251d0f51cfe0b474d1 Bug: 900432 No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: dgozman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1309322 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/98bc0ce5c15f..295328449111 git log 98bc0ce5c15f..295328449111 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 tsepez@chromium.org Better test for AFSpecial_KeystrokeEx. Created with: gclient setdep -r src/third_party/pdfium@295328449111 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8343df1024a3141f97eaaf3d31fbc1e6160ac9c3 Reviewed-on: https://chromium-review.googlesource.com/c/1308513Reviewed-by:
-
Aleks Totic authored
80+ unexpected passes makes testing new code hard, you can't tell what passes belong to your patch. This patch updates ~50 tests that unexpectedly passed in Linux/Win/Mac recently. There is some turbulence in test suites because of "--enable-display-compositor-pixel-dump" test running flag. Tests that were marked as failing because of this flag got a [ Failure Pass ] expectation. For the rest of the passing tests I just removed the failure line. https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/219487/site_per_process_webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/win7_chromium_rel_ng/117191/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/mac_chromium_rel_ng/172497/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html Bug: 726520 Change-Id: I109e731dd318782d3e492227455ba264a435d1c2 Reviewed-on: https://chromium-review.googlesource.com/c/1303339 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
The added code is mostly the ones deleted in https://chromium-review.googlesource.com/c/chromium/src/+/1297308 as part of "old-wallpaper-picker only" code path. Bug: 899872 Change-Id: I7dbad13c00d50841091b9f51656428025efae096 Reviewed-on: https://chromium-review.googlesource.com/c/1308936Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#604086}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f5973509ec68..9877e8407b5c git log f5973509ec68..9877e8407b5c --date=short --no-merges --format='%ad %ae %s' 2018-10-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-30 bsalomon@google.com Remove unused GrOpList::numOps() 2018-10-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-30 mtklein@google.com some SkDraw_text cleanup 2018-10-30 brianosman@google.com Switch GrColor4h to use float storage 2018-10-30 reed@google.com hide the SkPaint::Align enum entirely Created with: gclient setdep -r src/third_party/skia@9877e8407b5c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I5f6bf281e31fc3d01e0ee38cdd3f8bc391e66873 Reviewed-on: https://chromium-review.googlesource.com/c/1308693Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1b114f20625d..76eeb8565846 git log 1b114f20625d..76eeb8565846 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 rsavitski@google.com Merge "Kokoro: add a new dependency to container image & small tweaks." 2018-10-30 lalitm@google.com Merge "trace_processor: fix build on Google3" Created with: gclient setdep -r src/third_party/perfetto@76eeb8565846 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ieddd43852314f932a7248a1da39a8eed36844e1c Reviewed-on: https://chromium-review.googlesource.com/c/1308699Reviewed-by:
-
