- 16 Jun, 2020 40 commits
-
-
Yutaka Hirano authored
Define the property behind a runtime enabled flag. Currently it always return false. I'll modify the implementation later. Bug: 1018680 Change-Id: I9971668254a6faa71c4ffb1a26e839d55760a10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245949Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#778633}
-
Hidehiko Abe authored
Currently LacrosLoader had two responsibilities: - Loading Lacros via ComponentUpdater. - Launching Lacros executable. This CL splits the responsibility. The latter one is now LacrosManager's responsibility, and it delegates the loading to LacrosLoader. Flipped the flag, and made sure loading works. Bug: 1094106 Test: Ran lacros-chrome locally. Change-Id: Ic18dc38641d1a28149fda3fce8619aefd87bc406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241203 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#778632}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ic00b9b4418f9e88b407818a65b28446016d7b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247343Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778631}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iccf1bfed90eaa7235544fb8a0cd4f96a2f1bc0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778630}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c3c2c9b6b09c..cf1fdf413cba 2020-06-15 enga@chromium.org Handle OOM buffer allocations better If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1014740 Tbr: cwallez@google.com Change-Id: I9d2aecb5a3ad685dcc99cf6223cae8f315bb8851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247129Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c2ac70797a38..f1e7813be659 2020-06-16 rharrison@google.com Rolling 5 dependencies (#1085) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I75aac10124b8cf7a5a81ef37589d1caf4ca0bf3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247131Reviewed-by:
-
Meredith Lane authored
Part of the ongoing effort to consolidate AXNodeObject and AXLayoutObject, with the eventual goal to remove AXLayoutObject entirely. This patch migrates the following methods to AXNodeObject: - AccessKey - ImageDataURL - TextLength The methods in this patch are not thematically related or dependant in any way, but were identified as being trivially easy to move across. This patch should have no functional impact - it is purely a refactor. Written with aboxhall and chrishall AX-Relnotes: N/A Bug: 1093651 Change-Id: Iebd7e71dbb10727e62f21e1c13abcad1f3f02e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237450Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#778627}
-
Tom Anderson authored
This is a reland of 9b8d92b3 Original change's description: > [XProto] Implement event reading > > This CL implements a parser from wire events to XProto events. Nothing > is currently done with the events; this will be done in followups. > > BUG=1066670 > R=nickdiego,sky > CC=msisov > > Change-Id: Ica0982298bf84e6a3ddbed77a5a6f6a3288bcaf7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233610 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778344} R=nickdiego TBR=sky CC=msisov Bug: 1066670 Change-Id: Iac8f919b0324762a33748262c94e49635f3ab71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246829Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#778626}
-
Hiroki Sato authored
CL:2222068 improved focusability computation in ARC++, which introduced a focusability computation similar to what TalkBack does. We no longer need to see a clickable node as a leaf. This change removes most of changes that was done in CL:1243670, CL:1316095, and CL:1849548. AX-Relnotes: n/a. Bug: b:152930082 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: browser_tests --gtest_filter="ChromeVox*.*" Change-Id: I7b70116e534d555ab6f8c5c66d5af1cbbb37be9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241393 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#778625}
-
Rachel Wong authored
This change also removes the unimplemented interface local_search_service.mojom for now. Bug: 1092767 Change-Id: I9bf0a7174115e591281ffbeae85d2b512cf1097c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246003 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#778624}
-
Trevor Perrier authored
This CL updates enums.xml to include the five new languages added to Google Translate earlier this year. Bug: 1093056 Change-Id: I35c894a3a46abebf11b1d4796a8b3f06487ab94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247152Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#778623}
-
danielng authored
It appears that the test is failing in between tests, which implies that there may be errors in the setup/teardown. Adding extra logging to see if the teardown completes successfully and also adding some extra functionality to reject any unresolved promises at the end of each test, as the unresolved tests may be causing mocha to hang. Also added some extra logging to the js code itself, to help identify which promises are being unresolved. Bug: 1082027 Change-Id: I4eaefe54aaffd8a513bd158f713e4d1fa963f4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245574 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#778622}
-
Nate Chapin authored
Bug: 1094587 Test: html/obsolete/requirements-for-implementations/the-marquee-element-0/marquee-adopt-to-inactive-document-crash.html Change-Id: Ib7587615d948d7c9e21ceaa83adbc00c5576f1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246715 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/85169498..3337005f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8a55e9b7fd9526a22cfd5cb3d8f27f18b81a028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245239Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778620}
-
Alan Cutter authored
It's possible for web apps to have no size specified for their icon via <link rel="icon" ...> tags in the HTML document. Originally these were being recorded as size 0. This CL refactors WebApplicationInfo to explicitly store no size as nullopt instead to avoid accidental use of 0 (see bug). Bug: 1062921 Change-Id: Ib203f14216fca071a52f5d1495cd13aa78d269d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115869Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#778619}
-
Vincent Boisselle authored
Bug: 1095106 Change-Id: Iffd8a1645e60ee2f02a69f8c5ac2b823aaf57fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246848Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#778618}
-
danielng authored
Adding checks to see if port forwarding is enabled for users based on the user policy and chromeos feature relating to port forwarding. Hides the port forwarding UI and disables certain port forwarding clean-up tasks when the policy or/and feature is disabled. Test: Added unit_tests, ran browser tests and tested manually. Cq-Depend: chromium:2228595 Bug: 848127 Change-Id: I42dfb5835393c32f868bfadb58a4914441a498ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239686 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#778617}
-
Dan Sanders authored
Bug: 897297 Change-Id: I7bc070913b53a88a9588836c424cb9f5b6fe8283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231593 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#778616}
-
Adam Langley authored
Records always have strings as keys, but dictionaries containing records didn't trigger an include of wtf_string.h automatically. Hasn't been a problem so far because all such dictionaries have includes other members that triggered the needed #include. Change-Id: I882bba80be0d515493261e7fa36759847a211835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245759 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#778615}
-
Victor Vasiliev authored
This adds support for QUIC draft29 into QuicTransport, and the machinery required to use more than one version at a time. Bug: 1011392 Change-Id: I99e4906a5e0ddd2ef04f7eb238b634e993075845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246071 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#778614}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b2caf7dfc87..47111d18f48d 2020-06-15 egdaniel@google.com Fix d3d clear op rect. 2020-06-15 egdaniel@google.com Add support for stencil in d3d. 2020-06-15 johnstiles@google.com Update GrConvexPolyEffect to support an input FP. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I29e292d91bc5c42aae7182720ef51bcaebddd8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247258Reviewed-by:
-
Matt Falkenhagen authored
- Add a link to the code comment. - Remove inaccuracy: in-process doesn't always run on the IO thread Change-Id: I827b8646ce448a86d3383a954e8835c20676d547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223708Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#778612}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592243886-ad52ae0aa339f20916a97252558a85905433e432.profdata to chrome-mac-master-1592265550-99f6241b57521e15eb2ed925c44009a393f1ea3e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia4afa58e185a256c65a33248682957fd91ab0d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247127Reviewed-by:
-
Lei Zhang authored
Change-Id: I5c46d13dc38cbb93e28569644b4d22460fd9e551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242230Reviewed-by:
-
Nigel Tao authored
Bug: 1086733 Change-Id: I972e15e0c8dfa6e45b1deba1107b54126e54aa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235137Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#778609}
-
Hitoshi Yoshida authored
Bindings team is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes such potential crash issues in NDEFRecord. Bug: 839389 Change-Id: Ie6b8b75764653bf6d21fdcc354437d19bdee7df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241311 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#778608}
-
Nigel Tao authored
The base::JSONReader::ReadEtc method is a static method. Bug: 1070409 Change-Id: Id71d9e44f6f65a7ef62bb6475d293981273c1077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244751Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#778607}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e3864d7cbd1..0b2bcebb8a7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sergeyu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025990,chromium:1085525 Tbr: sergeyu@google.com Change-Id: I6f9257b4266fadd8cc80bca85bbf208f7aca93cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247259Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778606}
-
Nico Weber authored
Going for the smallest fix to heal the bots; lizeb can fix better (if necessary) tomorrow. TBR=lizeb@chromium.org Bug: 1094908 Change-Id: I45f4afd916f02a87015aa967e7c5ea449fe0df8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246933Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#778605}
-
Brandon Wylie authored
Bug: 1091135 Change-Id: I6568f6fe1a98c3a91bd3887c452d5eb2de0ecbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240353Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#778604}
-
chrome://flags/#force-empty-CORB-and-CORS-allowlistLukasz Anforowicz authored
This CL adds a new chrome://flag as an easy alternative to manually ensuring that there are no Chrome processes and then launching Chrome with --force-empty-corb-allowlist cmdline flag. The new flag is: chrome://flags/#force-empty-CORB-and-CORS-allowlist Additionally the CL slightly tweaks the text and metadata for the already existing chrome://flag that can be used to opt into or out of the CORS-for-content-scripts changes that are planned to ship in Chrome 85. This existing flag is: chrome://flags/#cors-for-content-scripts Screenshot of the flags can be found here: https://drive.google.com/file/d/1xPpHGMmjgMOYDEZH1U02XvAxDHDPMwoc/view Bug: 920638 Change-Id: I0d2b44dbf58db7dacb3addc67e4be977cd9437de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243717Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#778603}
-
Lijin Shen authored
2nd experiment for default browser promo on Q+: skip the primer/dialog and show role manager dialog directly. Bug: 1090103 Change-Id: I94fc85782deca73702720f909edad3be5e9a27c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244032 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#778602}
-
Nate Fischer authored
No change to logic. This changes kPersistentPrefsWhitelist to kPersistentPrefsAllowlist. This follows the guidance at https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md#racially-neutral Bug: 842296 Test: verify it still compiles Change-Id: I13327d0b6bc416de620990e12f610235d3ce7bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247149 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#778601}
-
Xianzhu Wang authored
This reverts commit af3d6f16. Reason for revert: crbug.com/1094807 (DCHECK failure in cc::PictureLayerImpl::SetUseTransformedRasterization). Original change's description: > Fix relationship among transformed rasterization, lcd text and contents opaque > > - Turned out that we can't enable LCD text with transformed > rasterization because the latter will cause translucent pixels along the > edges of the layer on which text may draw. This CL partly reverts > crrev.com/c/2229243 which enabled LCD text with transformed > rasterization. > > - When enabling transformed rasterization, we need to not only set > contents_opaque to false, but also need to let RasterSource clear canvas > before drawing because of the translucent pixels at edges. > > - Refactor to make contents_opaque() consistent in the main-thread and > impl-side. > > Bug: 1077071 > Change-Id: Ie08d8d7bdeb46fa6dcc16560369cfd3dfedd14a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238519 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777523} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1077071 Change-Id: I4f8e71bea811a5920f4bfbdff5840bc13b73e81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247147Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778600}
-
Jimmy Gong authored
- Ongoing print jobs are dynamically updates. - The app updates as soon as a print job is complete. - Includes browsertests for this new capability. Bug: 1053704 Test: browser_tests Change-Id: Ia24ea6298b1907acdc0df687e3f9fcdc6824a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224346 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#778599}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bde6ff28cf3d..1f3176b05891 2020-06-15 joselea@microsoft.com Devtools: Open a closed tab via quary param 2020-06-15 jalyn@microsoft.com Add browser test for forwarded key whitelist changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1094648,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I638fcd5b0678bab5aa286e5a2f67fb7a0493f636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245194Reviewed-by:
-
Fabrice de Gans-Riberi authored
A channel for chromium.cast.ApplicationContext was created in both PendingCastComponent and CastComponent. This sometimes caused issues in agents that make use of ScopedServiceBinding to handle the server-end of this channel. These agents could get into a state where they never got a signal on the second client disconnect. Bug: 1095217, b/158684780 Change-Id: I06e8e1dd35516bb88ea4929e9f43fb4cd862cd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246794 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#778597}
-
Kuo Jen Wei authored
Shorten the distance from center of video shutter button to center of video snapshot and pause button from 100px to 84px. Bug: 1054314 Test: None Change-Id: Ic772a79146ad97e8c6ce8efadef23729d06d9407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246358Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#778596}
-
Hiroki Sato authored
This CL tries to make linear navigation order of ChromeVox on ARC++ similar to TalkBack. For example, imagine a11y tree in Android is like this: ++ nodeA container (focusable clickable) (name is empty) ++++ nodeB static text (not focusable, not clickable) (name X) ++++ nodeC button (focusable clickable) (name Y) TalkBack's navigation order is as below: 1. nodeA, announce a name of nodeB. 2. nodeC, announce a name of nodeC. Currently ChromeVox skips nodeA. With this CL, ChromeVox firstly focus on nodeA and nodeB is skipped because it's ignored. This CL introcues 'screen reader mode' in ARC accessibility, which is enabled when SwitchAccess or ChromeVox is enabled. The focusability change added in this CL is applied only when the screen reader mode is enabled so that we don't break text location API for Select-to-Speak. Note that this change adds a few TODOs, which will be resolved in follow up CLs. AX-Relnotes: n/a. Bug: b:157441336 Bug: b:150344900 Bug: b:150344310 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually confirmed with PlayStore and Android Settings. Change-Id: I700cbbd348c9eb7bf71a7995994c926b1c839979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222068 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
-
Antoine Desbois authored
This prevent a user from adding a callback and discarding the return value which in turns causes the callback not to be called later on. Merge-With: eureka-internal/407264 Change-Id: I4b1fb4570c6709297f783d488f5505b4102573ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240294Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Antoine Desbois <antoinedesbois@google.com> Cr-Commit-Position: refs/heads/master@{#778594}
-
