- 22 Sep, 2020 40 commits
-
-
Adithya Srinivasan authored
Found while doing an audit of WebContents::GetMainFrame(). web_contents->GetMainFrame()->GetParent() will always return null. Change-Id: Idc5d2ed719a400a300198b9c36ab4e3307934556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422440 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#809320}
-
Jonathan Ross authored
Currently content/renderer/android/OWNERS lists a dependency on content/renderer/input which was removed. That owner file is being temporarily re-added[1]. As without it all changes to content/renderer/android fail, including updating the owners file. This change removes the dependency, and places dtapuska@ as an OWNER. This will be followed by a revert of the temporary re-add of content/renderer/input/OWNERS [1] https://chromium-review.googlesource.com/c/chromium/src/+/2422141/ Bug: 1097816 Change-Id: I06a554dc52dfd9820048eb14af79163db97e40ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422181Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#809319}
-
Sky Malice authored
Adding skym@ and wenyufu@, who have recently made feature modifications to the firstrun. Removing yusufo@ who is not currently making changes in this space and is also an OWNER in a parent folder anyways. Change-Id: I9343df6eb96a52fa3e381b9859ec8c2198485a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417300Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#809318}
-
Boris Sazonov authored
Fixes two separate issues with the unconsented primary account sign-out flow within PrimaryAccountMutator and PrimaryAccountManager: 1. Check HasUnconsentedPrimaryAccount in PrimaryAccountMutator so that the PrimaryAccountManager::SignOutXYZ is actually invoked even if there's no sync consent. 2. Make sure PrimaryAccountMutator calls GoogleSignedOut using a correct account info - before this change, it would be invoked with an empty account info if there's no sync consent. Bug: 1130526 Change-Id: I9019faeb602a32a499ae7fd3cab09f5634fc69ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421739 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809317}
-
Joshua Pawlicki authored
This data is already sent in the <app> element, but sending it in <request> ties it to the updater and enables Omaha's cross-product monitoring and logging to be more aware of this updater. Bug: 1110339 Change-Id: Ib4ec718a281664e3732f6ca060be7300902fa1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418474 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#809316}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/566821cb0e58..44623aeccd06 2020-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 60ce96e2ff10 to 125b64241909 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I76a9dd1465dd6a584a565dc6764b8859affb0d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809315}
-
Vladimir Levin authored
This patch ensures that we don't try and update assignments if the layout view is locked in its parent frame. If the view is locked, it means that we skipped processing prepaint for it, which means that the contents here might not have the LocalBorderBoxProperties (created during prepaint). However, the assignment needs the properties to do its work. Since the frame walk here is unconditional, there is no need to keep track of the dirty bit flags, as long as we don't clear the flags on the compositor itself. This is similar to how the throttling logic behaves. R=chrishtr@chromium.org Bug: 1128790 Change-Id: Ic325b618161c68d5886d0a5c0926cbd29e81d38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422265 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809314}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600754349-bb0b36845adda8f601cf43d9095b0eb5c5334e61.profdata to chrome-linux-master-1600775907-52df3750a6dec0d6a74672a50b3faa88175a1e9e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ibbad7da619409ff8fc0365cfdab25f45ac3291de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423968Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I73e93914aedf3fcce9a61766c21f91973e709358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423406Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809312}
-
Aaron Leventhal authored
Do not create or initialize accessibility objects at the wrong time. Bug: 1125186 Change-Id: I14110615efb4e18a22ebccf2e67b64ce6f258e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399317Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#809311}
-
Antonio Gomes authored
This header is included by pepper and chromecast code, and won't move out of the Blink API any soon. BUG=787252 R=guidou@chromium.org, haraken@chromium.org TBR=spang@chromium.org Change-Id: I7bc274541ef242cf6146b9988b7c29cf10869145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418798 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#809310}
-
Aaron Krajeski authored
Merging this CL with TODOs to keep this CL small. TODOs: - Single radius version of function called without an array - Accept generic dictionaries with "x" and "y" values as arguments - Add WPT tests Bug: 1123971 Change-Id: I41816beca0678b7df873310d16f826f2f3ed5e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388151Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809309}
-
Olga Sharonova authored
(Behind a flag) * Configures renderer-side RT audio threads based on the audio buffer duration, the same way CoreAudio does for audio device threads. * This CL covers only audio playback and capture which use base::PlatformThread directly (this is most of the audio paths). * WebAudio worklet and audio loopback could probably also benefit from such changes, but it requires a separate effort of exposing API in blink::Thread/SimpleThread (WebAudio) and base::Thread (loopback). * The change is disabled by default. We'll run a finch experiment to evaluate it. *If we do decide to keep it, as part of cleaning up the experiment, we will remove the new virtual from PlatformThread::Delegate and move it to be passed along with the ThreadPriority (presumably in some sort of struct, but TBD). Doc: https://docs.google.com/document/d/12grOIZ4ootmJb5RYoe3GuJDCzYTjtNiuGIG6PvCz-78/edit?usp=sharing ------ API discussion: V3 of API (PS10) * Removed a data member from Delegate V2 of API (PS8) * Looks a bit better V1 of API (PS7) * I'm not a fan of having |audio_buffer_duration| in the thread API, but left it for now, to make it clear what exactly is going on. Bug: 1112952 Change-Id: I43c0b92d60622c74b9eede4e9feba9142cbca9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398661 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809308}
-
Jonathan Ross authored
When content/renderer/input was moved[1] it removed the OWNERS file. However content/renderer/android/OWNERS lists it as a dependency. This leads to any changes to content/renderer/android to fail presubmit, due to the missing file. This includes changes to remove that dependency in the OWNERS. This change temporarily re-adds the file so that the dependency can be removed. Removing the dependency will be done in a follow-up[2]. After which this change will be reverted. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2411941 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2422181/ Bug: 1097816 Change-Id: Ic318ebdd5c9e845afb6047776a2b9ebb0b5d746a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422141Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#809307}
-
Jan Wilken Dörrie authored
This change modifies the WellKnownChangePasswordNavigationThrottle to use the URL used in the beginning of the navigation for the fallback logic in case the server does not support .well-known/change-password URLs. So far it has been using `navigation_handle()->GetURL()`, which could change in the presence of server-side redirects and thus could point to a different origin, for which the fallback logic would be wrong. Fixed: 1130519 Change-Id: I8177f7a8f794de91d2cf81d92aab11179280f73c Bug: 1130519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421512Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#809306}
-
Roman Aleksandrov authored
Add TPM locked bubble which shows information on how long user should wait. Bug: 1126908 Change-Id: I45e4738eca22fa172298111b97218689d945a912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410120 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#809305}
-
Maksim Sisov authored
This happens because mojo::core::Init() is being called multiple times. Move that into the Environment setup. Bug: 1124902 Change-Id: I98a05ff1c813c32ae8f3223907c8cf22b2f078ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424164 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#809304}
-
Alan Cutter authored
This CL adds three metrics for preinstalled web apps: - WebApp.Preinstalled.ConfigErrorCount - WebApp.Preinstalled.EnabledCount - WebApp.Preinstalled.DisabledCount This helps track whether we see the expected number of preinstalled apps configured on devices and whether there are bad config files. Bug: 1128801 Change-Id: I2a33d9d5812ff29d0218f345ba68c8727542218c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418756 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#809303}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d53ca9807f41..dcc28c9f5a3d 2020-09-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-22 tvanderlippe@chromium.org Remove scripts support from module.json 2020-09-22 wolfi@chromium.org Add css variable for link-color If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1122511 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6cee085115b483d29241f9c6ca816f435f6c2868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423964Reviewed-by:
-
Nick Diego Yamane authored
Recent refactors in surface code caused a regression in tab dragging. More specifically, when running on Wayland compositors that drop the DND session when the DND origin window gets destroyed (see [1] for further explanation). The crash happens due to a use-after-free issue in WaylandSurface event handlers, when the wl_surface::leave event comes in after its root window destruction (eg: a single-tab window being snapped into tab strip). To fix it, this CL unsets WaylandSurace's root_window when surface ownership transferring to WindowDragController is done. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2267637 R=msisov@igalia.com them containing 1 tab, then drag the tab from window 1 to window 2. Once it gets snapped into window 2 the drag session must keep responding to drag events, etc. Test: On a Gnome Shell Wayland session, open 2 Chromium windows, each of Bug: 896640 Change-Id: Ie31948099968ec9a932c44efde2985e6c4d7dea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422273 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#809301}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/540c58aa5949..6a7c1f2e304e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rsorokin@google.com Change-Id: Ie8ba2c5a9d91660233010699197d7e1572b4705d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423963Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809300}
-
Rushan Suleymanov authored
Bug: 1127959 Change-Id: Icb7990bdc7ac2071ae6c13cc80a625c47c4a8d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423845 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Matthias Körber authored
Change-Id: I7cdeead924974d382c09c9e2072473186200e98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421666 Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#809298}
-
Gyuyoung Kim authored
As content::ViewportStyle enum type was moved to Blink, it would be good if we can use it in the whole area without converting. So, this CL replaces the existing enum type and all uses with web_pref::WebViewportStyle after moving web_viewport_style.h from public/platform/web_viewport_style.h to public/common/web_preferences. Bug: 919392 Change-Id: I7443ea5642c36e609086ca52af87c5e66630bca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418597Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#809297}
-
Nela Kaczmarek authored
This CL removes the scoped logic from FakeAffiliationAPI and makes usage of AffiliationFetcherFactory in AffiliationBackend, where it's called to create an instance of AffiliationFetcherInterface. Bug: 1117447 Change-Id: Id0efc2da4fb88e96c84adcffbb7730edec0e485d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410863 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#809296}
-
Reda Tawfik authored
This CL sends the app name from native to java to use in the AllPasswordsBottomSheet in case if the credential is android credential. Remove unused properties (isAffiliationBasedMatch and isPublicSuffixMatch). Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1130572#c1 Bug: 1130572, 1104132 Change-Id: I872ed3f9df57d9e2e70ea91de4bab68fc907a7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414176Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#809295}
-
Sebastien Lalancette authored
Added the fieldtrial testing config change for this feature. Bug: 1110944 Change-Id: I435c42d7116cf38a760939f63ac7e70c4c10b0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421631Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#809294}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b653fdea2f19..9cf7a56afbcf 2020-09-22 hjd@google.com Merge "ui: Improve error message for invalid permalink" 2020-09-22 hjd@google.com Merge "Support loading traces from the Android Bug Tool" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I89150ea04ca95702fba33ddc313bf86ce1b7c50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423536Reviewed-by:
-
Nick Diego Yamane authored
Modifies WaylandKeyboard::Delegate::OnKeyboardKeyEvent such that both wl_keyboard and zwp_text_input (IME) decode key codes the same way (by using Ozone's KeyboardLayoutEngine, xkbcommon, etc). Furthermore, this simplifies its function signature, making it easier to use to inject key events, such as in follow-up CL https://crrev.com/c/2417065. No functional changes are expected. R=msisov@igalia.com Bug: None Change-Id: Ia3610c5fbf9bb326c7f7ce4f1e4486083a348464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422429 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
Josh Nohle authored
(1) Simplify default device name creation now that we do not need to support non-ChromeOS platforms. (2) Use the given name (e.g., "Josh") instead of display name (e.g., "Josh Nohle") when creating the default device name (e.g., "Josh's Chromebook"). (3) Localize the default device name. (4) Now that default device name creations is synchronous, pass the default device name to the local device data manager. The Nearby Share service no longer needs to handle setting the default device name. (5) Set the default device name in the local-device-data manager constructor if the pref is empty. Fixed: b/168843120, 1127017 Change-Id: Ic023d1f696f1fd396277ffd9c8cc601f9b5cdcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423008Reviewed-by:James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#809291}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/52a588f3c9ba..aeda49ba5046 2020-09-22 cwallez@chromium.org Reuse BGL validation in default layout computations. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If9611aeb55c5b5e75683185288387ccb04aa77f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423541Reviewed-by:
-
Alice Wang authored
This CL refactors ProfileDataCache for monogram change in future. There is no behavior change in this CL. Bug: 1127886 Change-Id: Ib3349813730c8b9b065aa6ae9d559aa09c0efeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422948Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809289}
-
Boris Sazonov authored
Revise primary account check in AccountManagementFragment's sign-out flow. Since sign-out doesn't depend on sync consent - primary account should be queried using ConsentLevel.NOT_REQUIRED. Bug: 1130526 Change-Id: I411dc2d9312793ed0e80e7b63dce584a5cc026b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421897Reviewed-by:
-
Roman Sorokin authored
TBR=jomag@chromium.org,martiniss@chromium.org Fixed: 1130984 Bug: 1094203 Change-Id: Ib109934adddbe514f4141ab78988c31ccc200aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423715 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809287}
-
Anastasiia N authored
Screenshots: http://screen/3FWvACiYWV5ExsA, http://screen/8owuVEadT7uVtp4, http://screen/98f28fUHmSipZfp Fixed: 1099332 Change-Id: I05b13badbc391e677a809e5022dcf4fd480a7b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416460 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809286}
-
Matthias Körber authored
This CL adds support for settings and retrieving all structured address tokens and their corresponding statuses from the AutofillProfileSpecifics. Change-Id: I1b8a876fe565339fe4bfe1e2590819dde18d7cc0 Bug: 1128367, 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410038 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#809285}
-
Nikita Podguzov authored
This CL: * Changes the dialog modal type if it's anchored. * Removes the extension name from dialog header getter call, as corresponding string doesn't require it anymore. * Adds the ability to skip confirmation dialog, as it's complicated to interact with the dialog from the browser tests. Bug: 1128197 Change-Id: Ie830049dde68398f605fd59025c7f4c985e3434b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421673Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809284}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a485b3ae. With Chromium commits locally applied on WPT: 434c646e "[mathml] Make math display values on pseudo elements compute to flow" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ia8f9cd352694fae14e2fe8b25925103f935d22b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422586Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809283}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a8aa0a8f5d26..d53ca9807f41 2020-09-22 sadym@chromium.org Respect additional arguments in npm targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130513 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9a6b225ce5e201934f665f9be9d523ec5adc68a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423540Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d0f8b8c9cc7..540c58aa5949 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rsorokin@google.com Change-Id: Iafcf76c715c24c0e5f69a107c60c8ee011180115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423534Reviewed-by:
-
