- 17 May, 2019 13 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aefbea29626b..06de90c66c18 git log aefbea29626b..06de90c66c18 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 syoussefi@chromium.org Vulkan: Re-enable a handful of suppressed ES3 tests 2019-05-16 jmadill@chromium.org Break debugger on assertion failure. Created with: gclient setdep -r src/third_party/angle@06de90c66c18 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I0e8cec0f1c0b0bd233bff94a2af3ab1d258799da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616201Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660673}
-
Caleb Rouleau authored
This changelist https://chromium-review.googlesource.com/c/chromium/src/+/1611313 has a bug in it where bot_platforms.py's configuration says not to schedule blink_perf.display_locking on Nexus 5X Perf, but the shard map for Nexus 5X Perf does contain blink_perf.display_locking. This changelist fixes that bug by adding the configuration to bot_platforms.py and it adds a presubmit test to cover that. That presubmit is really just a more specific presubmit than what is in perf_data_generator.py, so I also deleted the existing check from there. (The difference is that the new check is per-platform. I think that the check should be in generate_perf_sharding because that is where we configure shard maps, versus perf_data_generator is for generating buildbot json files, which should become decoupled in the future. I also deleted the Telemetry-specific test cases from perf_data_generator_unittest.py. I'm thinking these tests are no longer necessary since we now verify consistency in PRESUBMIT. Change-Id: I31afa1fd8782951f750e5f5c5c8b7fb959f5a049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614358Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#660672}
-
Collin Baker authored
This reverts commit b85dc559. Reason for revert: build failure on https://ci.chromium.org/p/chromium/builders/ci/win-archive-dbg/4 Error is "../../net/third_party/quiche/src/quic/tools/quic_toy_client.cc(45,10): fatal error: 'netdb.h' file not found" Original change's description: > Roll src/net/third_party/quiche/src/ 63d0bc4ae..8474fd7a2 (17 commits) > > https://quiche.googlesource.com/quiche.git/+log/63d0bc4ae8dc..8474fd7a2f24 > > $ git log 63d0bc4ae..8474fd7a2 --date=short --no-merges --format='%ad %ae %s' > 2019-05-16 rch gfe-relnote: n/a - Remove overly broad include from quic_toy_client.h > 2019-05-16 fayang Add logging only ack_frame accessor. > 2019-05-15 rch gfe-relnote: n/a - Add missing include for quic_flag_utils.h in quic_packet.cc > 2019-05-15 nharper Add QUIC_BUG_IF to QuicUtils::GetCryptoStreamId > 2019-05-15 rch Move virtually all the toy client logic out of quic_client_bin.cc and into a new QuicToyClient class which can be used in chromium. > 2019-05-15 wub gfe-relnote: (n/a) Delete use_stateless_rejects_if_peer_supported from QuicCryptoServerStream's constructor. No behavior change, not protected. > 2019-05-15 dschinazi Replace a DCHECK with a parse failure in connection ID parsing > 2019-05-15 rch Move drop_response_body from QuicClient to QuicSpdyClientBase to share with chromium > 2019-05-15 rch Extract the FakeProofVerifier from quic_client_bin.cc to facilitate sharing with Chromium. > 2019-05-15 dschinazi Add QuicFramer Probe methods > 2019-05-15 vasilvv Remove .impl() method from QuicSocketAddress and QuicIpAddress. > 2019-05-15 quiche-dev Change QuartcClientEndpoint to handle client-side version negotiation. > 2019-05-15 wub In quic_client_bin.cc, print the "Request (succeeded|failed)" messages in stdout instead of stderr. > 2019-05-15 fkastenholz Have separate uni- and bi-directional stream limits for IETF QUIC > 2019-05-15 wub Fix a use-after-free in quic_client. > 2019-05-14 quiche-dev Project import generated by Copybara. > 2019-05-14 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_termination_packets. > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > Change-Id: I43e3ac80816bade7d80e2ca8ae9f92bb3f457d95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614938 > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Reviewed-by: Steve Anton <steveanton@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Auto-Submit: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660666} TBR=rch@chromium.org,zhongyi@chromium.org,steveanton@chromium.org Change-Id: I7d74bb2f140d840ec93a9e55883a6694a19cc157 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616423Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660671}
-
dpapad authored
Bug: None Change-Id: I5c3c5eaba63041bbad30d53b2590382eafba45a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613747Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660670}
-
Collin Baker authored
This reverts commit 84c7124e. Reason for revert: It looks like this caused flakiness in OutOfProcessPPAPITest.FlashFullscreen. See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests https://findit-for-me.appspot.com/p/chromium/flake-portal/analysis/analyze?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJyY2hyb21pdW0ubWVtb3J5L0xpbnV4IEFTYW4gTFNhbiBUZXN0cyAoMSkvNjA5NTgvYnJvd3Nlcl90ZXN0cy9UM1YwVDJaUWNtOWpaWE56VUZCQlVFbFVaWE4wTGtac1lYTm9SblZzYkhOamNtVmxiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw https://findit-for-me.appspot.com/p/chromium/flake-portal/analysis/analyze?key=ag9zfmZpbmRpdC1mb3ItbWVyqQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJzY2hyb21pdW0ubGludXgvTGludXggVGVzdHMvNzc4NjgvYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVDNWMFQyWlFjbTlqWlhOelVGQkJVRWxVWlhOMExrWnNZWE5vUm5Wc2JITmpjbVZsYmc9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Original change's description: > Fix weird artifacts during resizing browser window on Linux > > This CL uses _NET_WM_SYNC_REQUEST to synchronize with desktop > compositor during resize. > Without this CL, resize steps are: > 1. Desktop compositor(WM) resizes chrome browser window. > 2. Desktop compositor draws a new frame with the current browser window > without waiting chrome to complete handle the ConfigureNotify event. > For SW rendering, compositor uses the content before resizing. It will > out of synced size between compositor and chrome. > For GPU rendering, compositor uses the framebuffer before resizing, the > behavior is undefined. It cause weird artifacts. > 4. Desktop compositor go to step 1, to issue a new resize. > 5. Chrome finished handle the ConfigureNotify and rendered a new frame. > 6. Desktop compositor draws a new frame again with right size. > > With this CL, resize steps are: > 1. Desktop compositor sends client message _NET_WM_SYNC_REQUEST to notify > about the incoming resize > 2. Desktop compositor WM resizes chrome browser window. > 3. Desktop compositor waits on an alert on value change of a XSYNC counter > on chrome window. > 4. Chrome handles the ConfigureNotify event, and renders a new frame. > 5. Chrome increases the XSYNC counter on chrome window. > 6. Desktop compositor gets the alert of counter change, and draws a new > frame with new content from chrome. > 7. Desktop compositor responses user mouse move events, and starts a new > resize process, go to step 1. > > > Change-Id: I51aafe03b8aac73ce6570976bbe36c6f4d86531a > Bug: 961858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602285 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660532} TBR=penghuang@chromium.org,sky@chromium.org,kenrb@chromium.org,kylechar@chromium.org,piman@chromium.org,thomasanderson@chromium.org Change-Id: I863ea3a4bb6b39fd3c65c4ea1dbbb56072988a26 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616384Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660669}
-
Sunny Sachanandani authored
TBR=piman@chromium.org Bug: None Change-Id: I7097c8dd3ebbd7690228fcfcd79dec746a913de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616018Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#660668}
-
Taylor Bergquist authored
Bug: 960915 Change-Id: I3e39cc3ba6e4e98ad9a01ac2ab9028fa1a1f76d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614433 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#660667}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/63d0bc4ae8dc..8474fd7a2f24 $ git log 63d0bc4ae..8474fd7a2 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 rch gfe-relnote: n/a - Remove overly broad include from quic_toy_client.h 2019-05-16 fayang Add logging only ack_frame accessor. 2019-05-15 rch gfe-relnote: n/a - Add missing include for quic_flag_utils.h in quic_packet.cc 2019-05-15 nharper Add QUIC_BUG_IF to QuicUtils::GetCryptoStreamId 2019-05-15 rch Move virtually all the toy client logic out of quic_client_bin.cc and into a new QuicToyClient class which can be used in chromium. 2019-05-15 wub gfe-relnote: (n/a) Delete use_stateless_rejects_if_peer_supported from QuicCryptoServerStream's constructor. No behavior change, not protected. 2019-05-15 dschinazi Replace a DCHECK with a parse failure in connection ID parsing 2019-05-15 rch Move drop_response_body from QuicClient to QuicSpdyClientBase to share with chromium 2019-05-15 rch Extract the FakeProofVerifier from quic_client_bin.cc to facilitate sharing with Chromium. 2019-05-15 dschinazi Add QuicFramer Probe methods 2019-05-15 vasilvv Remove .impl() method from QuicSocketAddress and QuicIpAddress. 2019-05-15 quiche-dev Change QuartcClientEndpoint to handle client-side version negotiation. 2019-05-15 wub In quic_client_bin.cc, print the "Request (succeeded|failed)" messages in stdout instead of stderr. 2019-05-15 fkastenholz Have separate uni- and bi-directional stream limits for IETF QUIC 2019-05-15 wub Fix a use-after-free in quic_client. 2019-05-14 quiche-dev Project import generated by Copybara. 2019-05-14 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_termination_packets. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I43e3ac80816bade7d80e2ca8ae9f92bb3f457d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614938 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#660666}
-
Oksana Zhuravlova authored
Bug: 621383 Change-Id: Ie2da4387a8352073c6d2221274b39034c8ee285c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616148 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#660665}
-
Scott Violet authored
This is not everything, but parts of ui/aura/mus are still used by services/ws, so I can't remove them without breaking services/ws. BUG=958245 TEST=covered by tests TBR=emaxx@chromium.org Change-Id: I97b4fabb1ac23802d1b59ffd9250c104fba8ac96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612849Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#660664}
-
Maksym Onufriienko authored
This reverts commit cb003fac. Reason for revert: this change broke chromium-autoroller, https://luci-milo.appspot.com/buildbot/internal.bling.main/chromium-autoroller/18288 Original change's description: > Moved test/app/web_view_interaction_test_util.h calls to chrome_earl_grey. > > Also removed unused imports for both > #import "ios/chrome/test/app/web_view_interaction_test_util.h" > #import "ios/web/public/test/web_view_interaction_test_util.h" > > This is part of EG1 to EG2 migration, which involves moving EarlGrey code from > app-side helpers into test code. For GREYAsserts, the policy is to take assert- > containing-helpers, modify them to return NSError* with localizedDescription > containing the assert failure (in the event of a failure), and then assert > on the result of the helper on the test side. > > Also cleaned code in internal_os repository(submit only after this cl) > https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1284395 > > Bug: 922813 > Change-Id: I8c1dcc1abf61a7b3886dd6886174ea6eca1b6413 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604428 > Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660563} TBR=rohitrao@chromium.org,eugenebut@chromium.org,yzjr@google.com,monufriienko@chromium.org Change-Id: Idea9658c8fad0da108d4cb153351ee4b6fbab2cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616281Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#660663}
-
Daniel Rubery authored
To limit regression in the total analysis time from Safe Browsing, cutoff RAR analysis at 10 seocnds. Bug: 948277 Change-Id: I3838b46b362ee88dd7752266cc0d0d5a881b1c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616149 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660662}
-
Daniel Libby authored
This reverts commit 287cb744. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add popup client support for injected scroll gestures. > > I missed adding support for injecting scroll gestures to > PagePopupChromeClient and scrollbar presses broke for select popups > that had scrollbars. Add an override that forwards to the > WebWidgetClient and add a test that validates that this works correctly. > > R=bokan@chromium.org > > Bug: 960747 > Change-Id: I7a5164bb3d8c7b15252d0a9a806e932f7cc269a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600444 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#658137} TBR=bokan@chromium.org,dlibby@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960747 Change-Id: Ib4ee6e5ef03910ef9b6253e03381cd1dcc780431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613756Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660661}
-
- 16 May, 2019 27 commits
-
-
David Dorwin authored
Bug: 956149 Change-Id: I3ceb266f8975dc094dce48d2988d16b16a993127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611655Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660660}
-
pliard authored
In the attached bug launching some Android applications such as Adobe Acrobat results in a flash where shadow bounds are twice larger than they should be. This is due to the shadow bounds being computed before the first commit even though the pending scale is correctly set which results in the default hard-coded scale (=1.0) being used. The pending scale set via SetScale() only becomes effective after a commit. Rather than implicitly relying on this commit for the scale to be effective exo::Display now commits it explicitly right after setting it. Bug: b/118827262 Change-Id: I4bd6cf395ba186be2dfd4f4e3b42e6591bd5382d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612937Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Philippe Liard <pliard@google.com> Auto-Submit: Philippe Liard <pliard@google.com> Cr-Commit-Position: refs/heads/master@{#660659}
-
John Rummell authored
There is no need to pass the previous frame when only a few values are needed. This will free space by allowing the previous frame to be freed earlier. BUG=946265 TEST=WebMediaPlayerMSTest content_unittests pass Change-Id: I799a7d105c119760e440ca76c0b7b7cd82e4c524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601827 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#660658}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia3cc8a2067df50488bce4c6d431fc733c2372dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660657}
-
Toni Barzic authored
This is a reland of 144e9e93 Making user session manager open a browser on startup fixed this for me locally (without it, chrome shutdown would start just after login screen UI goes away). To be safe added a waiter to make sure the accept button is there when the test attempts clicking it. TBR=alemate@chromium.org Original change's description: > Test oobe screens for public session login > > Tests that the terms of service screen (if required by policy) is the > only screen shown to public session user during login. > > To make environment setup for different configurations eaiser, separate > end to end test setup steps from OobeInteractiveUiTest into a separate > mixin. > > BUG=none > > Change-Id: Ib6580e2b4f63f59c7b262fb0f79982197251724c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607103 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660269} Bug: none Change-Id: Ib3e9a7adf3486122ae3ddb5c8c2cd4a8e87915ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614151Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#660656}
-
Maksim Ivanov authored
Delete the signin::GetLandingURL() function. This function isn't used anymore since crrev.com/c/1604274. Bug: 470893 Test: existing unit tests Change-Id: Ida6432f052d0b1980946366de567f4f5e56f00f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606160 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#660655}
-
Stephen Martinis authored
Bug: 888810 Change-Id: I0050f7f6e944004848a8c4bf1d74720e782e17ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615598Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#660654}
-
Vlad Tsyrklevich authored
Previously the GWP-ASan crash handler reported crash analysis results via a single UMA histogram. With support for a second allocator, refactor the histogram reporting so that there are separate histograms per allocator. Bug: 960051, 960532 Change-Id: I1c1c5c2802cee47a533f3f865c9933d7a9d3ef66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610878 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#660653}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a2e4f03e8e6a..fd64d5d2d4a7 git log a2e4f03e8e6a..fd64d5d2d4a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 sadrul@chromium.org rendering: Fix running the metric on non-renderer stories. 2019-05-16 crouleau@chromium.org [Telemetry] Return -1 if no tests were run. Created with: gclient setdep -r src/third_party/catapult@fd64d5d2d4a7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:945709,chromium:944909 TBR=simonhatch@google.com Change-Id: I5f334e908e997463205fb9eaba0cfa88d9cff446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660652}
-
Eric Stevenson authored
Previously, moving Java files used by JNI to new locations could cause build failures. This CL addressed stale generated files by deleting stale files from the output directory before creating new ones. Also merge the two generate_jni() templates since they're pretty much the same. Bug: 951701 Change-Id: Id066d8e74a52ed0c4c6fd29e92108c2e0bbfe96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610749 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#660651}
-
Jacob DeWitt authored
OpenVR does not expose USB vendor + product ID, but it does expose some string properties for model and manufacturer name that can be queried for controllers to determine if they are the HTC Vive. Bug: 961862 Change-Id: I8a14cedc0ad11885d83c86a439b28e2c9be2086a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615646 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660650}
-
Harry Cutts authored
This will be used by a D-Bus service to allow developers to tweak gesture properties at run-time. See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the full design. Some of this code is based on Jacek Fedoryński's https://crrev.com/c/1350982. Bug: 952054 Test: As part of a series, tested that the D-Bus service can get and set properties. Alone, checked that Chromium and unit tests build. Change-Id: Ic1aaee76994231f439c1aa78e5bd7b4d4b3f9a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589444Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#660649}
-
Mason Freed authored
Previous to this CL, the backdrop filter bounds clip rect was not being applied to the filtered backdrop image. The clip is now applied. This CL also moves a few functions from gl_renderer into viz_utils so that they can be shared. Bug: 916318 Change-Id: Ie8f2d394cef648bbec47f1b088b7b6a78988a947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614753 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#660648}
-
Kevin Marshall authored
Refactors the FIDL/MessagePort adapter classes and adds support for adapting InterfaceHandle<MessagePort> to Mojo MessagePipes. Bug: 953958 Change-Id: I9c208cf21bc0956c8f3856e23dbd4302e981abd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612351 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#660647}
-
Xiyuan Xia authored
Extension/app custom menu range should be [IDC_EXTENSIONS_CONTEXT_CUSTOM_FIRST, IDC_EXTENSIONS_CONTEXT_CUSTOM_LAST). Bug: 837290 Test: Bring up context menu of "Files" and select "New Window". Change-Id: Ifac2c6b23cde52618fcd0df27ccf11d5e4897547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615385 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#660646}
-
yilkal authored
This is a reland of 6ec894bb Original change's description: > Hide App Icons in KioskNextShell. > > Bug: 951212 > Change-Id: Ie69a2cd77aaa9d169d102cd3582a6d1902306001 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610501 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660091} Bug: 951212 Change-Id: Ib89e0e6e2643fd3ed4ad585ab92b028ce3ecba08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614625Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#660645}
-
Robert Sesek authored
Previously chrome::GetFrameworkBundlePath() returned the top-level frameworks directory. But if an update is staged, any resource accesses that go through the Current symlink would access resources for the new version rather than the currently running one. By returning the path to the versioned subdirectory, resources will always be accessed for the correct version. Bug: 963896, 958976 Change-Id: I51b658ab60ff6c970e357dcf53f67557ec2cbdd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614747 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#660644}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0391cd9d0f6b..57f13dec7309 git log 0391cd9d0f6b..57f13dec7309 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 derat@chromium.org chromeos_config: Run Tast on moblab-generic-vm builders. 2019-05-16 mikenichols@chromium.org chromeos_config: Increase Informational timeout 2019-05-16 jclinton@chromium.org Revert "chromeos_config: Mark some CQs experimental." Created with: gclient setdep -r src/third_party/chromite@57f13dec7309 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I0e2e0c1fdff620bd71de37186dec2f9b44d07a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660643}
-
François Degros authored
Bug: 778674 Change-Id: I9e78661b34f5726855a933db61c6434adc2df2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614726 Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#660642}
-
Gyuyoung Kim authored
As the first step to deprecate WTF::CString, the bug has suggested replacing EXPECT_STREQ with EXPECT_EQ. This CL replaces EXPECTED_STREQ with EXPECT_EQ in the cases of both converting WTF::String to const char* to use EXPECTE_STREQ and the expected string is ASCII. Bug: 950077 Change-Id: I9724b09dffb160c787af3085afcba0c1b6724de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614827Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#660641}
-
tby authored
The hashed logging launch recorder uses an enum to describe which UI component a launch happened from. This is duplicated between AppListLaunchRecorder and the new ChromeOSAppListLaunchEvent proto. This CL deletes the enum in AppListLaunchRecorder and uses the one in ChromeOSAppListLaunchEvent instead. Bug: 951287 Change-Id: Ia156370360ae44d66c7ab22314374e71c4213dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614639Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#660640}
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: Iff7b729900f06d7d8931daea3bfec1bdc85cc2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614638Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660639}
-
Scott Violet authored
The first attempt was reverted as the test was flaky. After talking with Oshima I decided to take the simpler route of removing all the code, hence no test. You can diff between patchset 1 and 4 to see the difference, but given I'm now removing it all, that may not be as interesting. BUG=958213 TEST=covered by tests TBR=tsepez@chromium.org Change-Id: Id3f88c9b4b76762dd31f2d402b57bd3c9757f750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615379 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#660638}
-
John Budorick authored
Deterministic Linux (dbg) is trying to share machines with the 32-core chromium.clang builders by setting auto_builder_dimension:NO. Unfortunately, this means it can steal *any* arbitrary 32-core ubuntu-14.04 machine in pool:luci.chromium.ci, not just the chromium.clang ones -- see e.g. https://chromium-swarm.appspot.com/task?id=44d11ba4bdc5cf10, where it stole Linux Builder (dbg)(32)'s single machine. This CL switches all users of luci-chromium-ci-trusty-32 bots to the builderless configuration, which will allow them to share without stealing from builders with dedicated machines. It also switches the other chromium.clang bots and Deterministic Linux to builderless for consistency. crrev.com/i/1304878 handles the infra-side change. Bug: 963224 Change-Id: Ied19c52042a1a757153e144e3fccfc81486cb7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612855 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#660637}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d2a2433c7a57..908d73f65ad9 git log d2a2433c7a57..908d73f65ad9 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 thestig@chromium.org Temporarily disable EOL policy for .in files. 2019-05-16 tsepez@chromium.org Tidy static/global usage in BC_ReedSolomonGF256.cpp Created with: gclient setdep -r src/third_party/pdfium@908d73f65ad9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I0345bb03e8c0090b4edb26fe6e74a4dfa38841db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660636}
-
Jun Mukai authored
TBR=sky@chromium.org, afakhry@chromium.org Bug: 958197 Test: build Change-Id: Ie871518604b9ed74f7cb8a3f1a6bd34d2b7aefc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615597Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660635}
-
Luciano Pacheco authored
|cr.define| used for this element doesn't support inheritance properly [1], so to make the inheritance work with |cr.define| parent element |cr.ui.MenuButton| added a static |decorate| method which is called by the rest of |cr| framework and in this method inject back the prototype in the same way it happens in the |cr.ui.define| [2]. [1] - https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr.js?l=269-281 [2] - https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui.js?l=97-100 Test: Manually checked that the component is working in addition to normal integration tests Bug: 778674 Change-Id: I9531c517c6a31b01e23fb42c3d8aec70081b8712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614725 Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#660634}
-