Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Oct, 2014 1 commit
    • pkotwicz's avatar
      Revert of Support modal windows (patchset #4 id:80001 of... · d075289e
      pkotwicz authored 
      Revert of Support modal windows (patchset #4 id:80001 of https://codereview.chromium.org/662763002/)

Reason for revert:
Reverting because this CL because WithOrWithoutTargeter.* introduced a memory leak and made all of the Athena Asan tests fail http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)

Based on tools/lsan/suppressions.txt reverting is now preferred over adding a suppression

Original issue's description:
> Support modal windows
>
> * New ContainerParams
>  -  default_parent to specify the default parent when no
>     transient parent is specified.
>  - modal_container_priority now controls the modal container
>    used for a modal window created for the given container.
>  - if not specified, it will fallback downwards to find one.
>  - if window is specified as always_on_top, it will use top
>    most modal container.
>
> * Changed network selector/shutdown dialog to use the new API.
>
> * Other change:
>  Separated test windows to athena/test/base/test_windows.h
>
> BUG=410499
> TBR=sky@chromium.org,reed@chromium.org
> TEST=coverd by unit tests
>
> Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
> Cr-Commit-Position: refs/heads/master@{#300192}

TBR=mukai@chromium.org,sky@chromium.org,reed@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410499

Review URL: https://codereview.chromium.org/665803003

Cr-Commit-Position: refs/heads/master@{#300226}
      d075289e
  3. 19 Oct, 2014 2 commits
    • kbr's avatar
      Revert of Revert of [Telemetry] Set the number of attempts to retry a test if... · 89b463dd
      kbr authored 
      Revert of Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #1 id:1 of https://codereview.chromium.org/661303002/)

Reason for revert:
The removal of Telemetry's retry logic wasn't the cause of the intermittent crashes on the GPU bots.

Original issue's description:
> Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)
>
> Reason for revert:
> Possible cause of gpu telemetry bot flake
>
> Original issue's description:
> > [Telemetry] Set the number of attempts to retry a test to 1
> >
> > **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
> >
> > BUG=422339
> >
> > Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> > Cr-Commit-Position: refs/heads/master@{#299716}
>
> TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=422339
>
> Committed: https://crrev.com/1c141bedc45cdef1ac7b7264ea1288c33e33d106
> Cr-Commit-Position: refs/heads/master@{#300218}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com,hendrikw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/662963002

Cr-Commit-Position: refs/heads/master@{#300225}
      89b463dd
    • kareng's avatar
      Revert of [ServiceWorkerCache] Implement storage::QuotaClient (patchset #12... · 1be6b8a3
      kareng authored 
      Revert of [ServiceWorkerCache] Implement storage::QuotaClient (patchset #12 id:320001 of https://codereview.chromium.org/651983002/)

Reason for revert:
bug 424923, top crash in canary.

Original issue's description:
> [ServiceWorkerCache] Implement storage::QuotaClient
>
> Adds a QuotaClient for the ServiceWorkerCache system.
>
> * Calls to the QuotaManagerProxy like (NotifyStorageAccessed/StorageModified/OriginInUse/etc..) will be in an upcoming CL.
>
> * The ServiceWorkerCacheQuotaClient is registered by the ServiceWorkerCacheStorageManager.  The QuotaClient holds a WeakPtr to the ServiceWorkerCacheStorageManager since the manager is destroyed before the QuotaClient.
>
> * Added a number of unittests.  They fit better into the StorageManager tests file than in their own file as they rely on a lot of the StorageManager infrastructure.
>
> * In order to support QuotaClient the ServiceWorkerCacheStorageManager needs to be able to list the origins it supports. This data is not currently stored so an "origin" member has been added to the CacheStorage index protobuf.  We won't report the origins of existing caches (if any even exist at this point) until their index is next written.
>
> BUG=420159
>
> Committed: https://crrev.com/22fcbd3c898136dfe839de3ca5cb0633c17bb163
> Cr-Commit-Position: refs/heads/master@{#300187}

TBR=michaeln@chromium.org,falken@chromium.org,jkarlin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420159

Review URL: https://codereview.chromium.org/651433005

Cr-Commit-Position: refs/heads/master@{#300224}
      1be6b8a3
  5. 18 Oct, 2014 35 commits
  7. 17 Oct, 2014 2 commits
    • skia-deps-roller's avatar
      Roll src/third_party/skia 7839915:d12af70 · d946c920
      skia-deps-roller authored 
      Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7839915..d12af70

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/666633002

Cr-Commit-Position: refs/heads/master@{#300188}
      d946c920
    • jkarlin's avatar
      [ServiceWorkerCache] Implement storage::QuotaClient · 22fcbd3c
      jkarlin authored 
      Adds a QuotaClient for the ServiceWorkerCache system.

* Calls to the QuotaManagerProxy like (NotifyStorageAccessed/StorageModified/OriginInUse/etc..) will be in an upcoming CL.

* The ServiceWorkerCacheQuotaClient is registered by the ServiceWorkerCacheStorageManager.  The QuotaClient holds a WeakPtr to the ServiceWorkerCacheStorageManager since the manager is destroyed before the QuotaClient.

* Added a number of unittests.  They fit better into the StorageManager tests file than in their own file as they rely on a lot of the StorageManager infrastructure.

* In order to support QuotaClient the ServiceWorkerCacheStorageManager needs to be able to list the origins it supports. This data is not currently stored so an "origin" member has been added to the CacheStorage index protobuf.  We won't report the origins of existing caches (if any even exist at this point) until their index is next written.

BUG=420159

Review URL: https://codereview.chromium.org/651983002

Cr-Commit-Position: refs/heads/master@{#300187}
      22fcbd3c