- 09 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3d75d778f466..597193051bfc git log 3d75d778f466..597193051bfc --date=short --first-parent --format='%ad %ae %s' 2020-04-09 tvanderlippe@chromium.org Use karma-coverage in favor of community-maintained packages 2020-04-09 wolfi@chromium.org Increase width of device dropdown in device emulation 2020-04-09 alexrudenko@chromium.org Use var --focus-bg-color for expandable view in sources 2020-04-09 tvanderlippe@chromium.org Handle old versions of DevTools localStorage corruption 2020-04-09 mathias@chromium.org Remove `preinstall` hook from package.json Created with: gclient setdep -r src/third_party/devtools-frontend/src@597193051bfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066415,chromium:1068145 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia61b8700176153c79a2d341f938362753c68ed34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757808}
-
Victor Hugo Vianna Silva authored
Previous to this CL, the method was misleading because it could show a different UI (autofill dropdown) if the generation was automatic, i.e. not directly triggered by the user). The different UI call is now moved to AutomaticGenerationAvailable, the only caller of this method passing true for |is_manually_triggered|. The bool parameter can't be entirely removed because it is still used in other parts of the method. Bug: 1060131 Change-Id: I82f769129fe601f55008607ce867d4bf04415241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144151Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#757807}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d536d03..61094cb6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If4d105643a408b30da8a062c2e12b47e3c459a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757806}
-
Colin Blundell authored
I inadvertently landed a change that set this member to true rather than false :P. This landed in https://chromium-review.googlesource.com/c/chromium/src/+/2132385. Fortunately the above CL first landed in 84: https://storage.googleapis.com/chromium-find-releases-static/955.html#955b7118ab87d23cbb053608efa451ae9bd80d20 Hence there doesn't need to be any question of whether this change would be worth merging to 83 or not. Bug: 1031465 Change-Id: I49e0c780f512c8786770851fa56cdcbc03d66608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144051Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#757805}
-
Mathias Bynens authored
A V8 CL [1] improves the terminology that’s used for internal promise state. Per the spec [2], a resolved promise may be “pending, fulfilled, or rejected”, but previously V8 incorrectly used the term “resolved” instead of “fulfilled”. This change is user-observable through the `d8` REPL and the DevTools Console, and so this patch updates the affected test’s expectations and temporarily disables it. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/2144011 [2]: https://tc39.es/ecma262/#sec-properties-of-promise-instances Bug: v8:6751, v8:5416 Change-Id: I359560afab9155511aed762c864e80f33ac57262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144095 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#757804}
-
Yutaka Hirano authored
At https://crrev.com/c/2098190 I introduced a COEP parsing logic to content/common but it was problematic - parsing an untrusted data in the browser process is forbidden. This CL moves the parsing logic from the browser process to the renderer process. Bug: 887967 Change-Id: I3bf4bd0f6d727573406e2f866df6c1ffdc7f59e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132902Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#757803}
-
Antonio Gomes authored
CL adds <title>, <link>s and <meta name=assert> entries to the original test, and moves it to external/wpt/css/filter-effects/. Target location/name: external/wpt/css/filter-effects/effect-reference-feimage-003.html Associated TestExpectations entries are also updated. BUG=968791,1063749 R=pdr@chromium.org Change-Id: Ie2a49760e32642613757272db97745fb3994dd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141350 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#757802}
-
Jose Lopes authored
The function splitlines consumes the trailing newlines so the resulting diff lines are printed in a single line and the diff is not readable. This CL implements the recommendation from the difflib library, which is to use readlines and writelines for a correct diff output: * https://docs.python.org/3/library/difflib.html#difflib.unified_diff Change-Id: I88b9bf1a1ff8f4c1f75c9cb1aca82e209f72abdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139699 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757801}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10401829730c..3d75d778f466 git log 10401829730c..3d75d778f466 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 alexrudenko@chromium.org Empty Navgiator tree should not get focus via keyboard Created with: gclient setdep -r src/third_party/devtools-frontend/src@3d75d778f466 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96896ac50402313d74b664aed3237291d989bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143954Reviewed-by:
-
Jérôme Lebel authored
Adding image inset for "More" button in sign-in, to get more space between the arrow and the title. Before: https://drive.google.com/open?id=1zyn8Lon_4Nb6_N0M4tRWxGCNfaYnEaCb After: https://drive.google.com/open?id=1Cn2BURPpstvEgssk8hCtN_yy5RyfLOXm Bug: 971989 Change-Id: I6dc46a21b81a048ccf34d397ffb835c4a46f411a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142253 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#757799}
-
Fergal Daly authored
This is mostly a no-op. It reduces redundancy and hopefully makes it simpler and clearer. It also skips calling SetEmbeddingToken if it's already set. There's a question as to whether this is OK to land during our stability freeze. In terms of stability, this should be a no-op and fairly easy to verify. In terms of cherry-picks, this is a very local refactor, if something has a merge conflict with it, we could just CP this too. Change-Id: Icb575f5fe3ff7a9bbea3d24cd7dec9c5ad884794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138935 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#757798}
-
Anatoliy Potapchuk authored
This cl is a policy-part of native a11y project for kiosk mode. it adds a policy which will control the visibility of the floating menu. Bug: 1061068 Change-Id: I1bbcf39790f81e797e46d96c148d46756923da42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139754 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#757797}
-
Mikhail Khokhlov authored
For consistency with other generated scripts and also to work around an issue with test_env.py failing to run a script from the current directory. Bug: 1050517 Change-Id: I83c0608add7450dc7d7996cc722ca7a809e39581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141987Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#757796}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/00e6685b05e8..f3ae9d6b5d40 git log 00e6685b05e8..f3ae9d6b5d40 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 primiano@google.com Merge "service: allow to specify a file path with write_into_file" 2020-04-09 treehugger-gerrit@google.com Merge "TraceProcessor: ingest TracingServiceEvent.all_data_sources_started" 2020-04-08 rsavitski@google.com fix typo in get.perfetto.dev 2020-04-08 primiano@google.com Merge "GN: enable PIE on Linux" 2020-04-08 primiano@google.com Docs: improve comments on builtin data sources 2020-04-08 treehugger-gerrit@google.com Merge "CPU frequency indexing function" 2020-04-08 fmayer@google.com Add new table for heap_graph_class. 2020-04-08 lalitm@google.com Merge "tp: add proto for hsc startup metrics" 2020-04-08 fmayer@google.com Merge "Create proper table for packages list." Created with: gclient setdep -r src/third_party/perfetto@f3ae9d6b5d40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:150546312 Tbr: perfetto-bugs@google.com Change-Id: I9470c305a131f16e41a0d7f19c37708bbd7f0b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143951Reviewed-by:
-
Aya ElAttar authored
Bug: 1068206 Change-Id: Iab84006d32e3cefbea3856cc94461c1343aa32d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137329 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Miyoung Shin authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to effect-reference-source-alpha-002.html. Bug: 1063749 Change-Id: I938d13f151aeb24d4a176b5841f675c3fa5c8084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141557Reviewed-by:
-
Miyoung Shin authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to effect-reference-source-alpha-001.html. Bug: 1063749 Change-Id: I43f149c9eb45cd83f739e50d2b8601446b0ec714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141555Reviewed-by:
-
Alex Ilin authored
ChromeOS can now support multiple accounts in the extension consent flow. This change should be compatible with the old consent flow as well. Bug: 1026237 Change-Id: I915a6697dc0301bb67f297983c32f98a1a2e5fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141102 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#757791}
-
Roman Sorokin authored
Sometimes LoginHost creation postponed (e.g. due to language switch) and DeviceDisablingManager might try to show the screen before the creation. Which leads to crash. Fixed: 1065569 Change-Id: I369d16e1022be98c6fdb42d25c25b4c108d95276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141972Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757790}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2caf7ffda74f..dcee8f94a9f8 git log 2caf7ffda74f..dcee8f94a9f8 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 9c3204a1fde0..75de196cecab (1 commits) Created with: gclient setdep -r src/third_party/angle@dcee8f94a9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I63fd1a723270b888e36b46c3b00d0f45090adf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143568Reviewed-by:
-
Peter Kasting authored
Commit d69d3bec added a call to ui::GetScaleFactorForNativeView() but not an #include of ui/base/layout.h, which declares it. This happens to work right now via transitive #includes but broke an in-progress CL of mine. Bug: none Change-Id: Id0d5f390052e6468b323958f2e2b713aef53ee16 Tbr: nektar Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143519Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#757788}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4e55491a936..10401829730c git log c4e55491a936..10401829730c --date=short --first-parent --format='%ad %ae %s' 2020-04-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@10401829730c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b7f87bbf13b5c0f280a6aab9193b6a39eb2421c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143555Reviewed-by:
-
Jérôme Lebel authored
Adding consent insets for buttons. Adding max constraints for the user consent view (600x600px). Centering the user consent on iPad. Changing the button size between iPad and iPhone. Attaching the gradient view to the bottom of user consent view. Screenshots: https://drive.google.com/open?id=17Eh7k968on1pifk0nJSRCArmgs9Csb98 (blue and yellow colors are just for debug reasons). Bug: 971989 Change-Id: I3c767d717538a1d5de53eb66f33cf20db4336261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139723 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
I noticed that we treat all displays the same type in unit tests, which is not true in all chromebooks. This should make our display test more realistic. Bug: None Test: Updated the test and all test should still pass. Change-Id: Ia407a308da47ebdf9680d774fbbbcb001bc5e8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114578 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#757785}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 83-4085.6-1585564150-benchmark-83.0.4099.3-r1 to 83-4091.0-1586169176-benchmark-83.0.4103.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I62362c53762d94410eb04663c1f9d664b694d5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143953Reviewed-by:
-
Tim van der Lippe authored
The location for CDP-related bugs is https://bugs.chromium.org/p/chromium/issues/list?q=component%3APlatform%3EDevTools%3EPlatform&can=2 Moving these bugs from Platform>DevTools to Platform>DevTools>Platform allows us to separate issues regarding the frontend from issues regarding the protocol. This also allows us to move issues on other repositories (like https://github.com/ChromeDevTools/debugger-protocol-viewer/issues into the Monorail component) Change-Id: I845c2a6ed0eb28925ee7bd15b959b3e75a9a1c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139811Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#757783}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4091.0-1585565910-benchmark-83.0.4099.3-r1 to 83-4099.3-1586165807-benchmark-83.0.4103.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I118f485ba9c54ed213401bef5b375c513c7997e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143952Reviewed-by:
-
arthursonzogni authored
Follow up for: https://chromium-review.googlesource.com/c/chromium/src/+/2134246 The CSP parser implemented by: services/network/public/content_security_policy/ is already tested and fuzzed. Blink reuses it for parsing responses built from a service worker. This patch tests it. The parser is already tested, so we just need to check the conversion from/to blink types is not missing any attributes. Of course, this doesn't prevent future attributes from being missed. An attempt to have something 'future-proof' has been made here: https://chromium-review.googlesource.com/c/chromium/src/+/2126933 but it has been withdrawned. Bug: 1063832 Change-Id: Id4da82e0dc34ce3b7062a74668c8a5c8215893bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139718Reviewed-by:
-
Mario Sanchez Prada authored
Partially migrate the contents of this test into the WPT-specific directory, including only the checks that can be upstreamed and leaving the parts that are Chromium-specific in the original test. In addition, this CL also adapts the description of the original Chromium-specific test to reflect what it actually does now after having removed some parts. In the newly-added test, we also add the relevant meta information i.e links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I57df80bf8a3c48dd94c70315a07d31715477a28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129537 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#757780}
-
chrome://settingsAlex Ilin authored
Polymer 3 uses JavaScript ES6 modules that don't leak variables to the global context. Signin live tests depended on one of this variables to perform sync-related operations on the settings page. Fixed: 1069089 Change-Id: Ia705f9da4a4c3a356a13bd8c7d6cc5f5d61c3997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142274Reviewed-by:
-
Greg Thompson authored
The multi-install support was deactivated in 2017 but there were still many remnants remaining in the Chromium code base. These remnants have been a source of friction for changes being made in the install and update infrastructure. Some additional house-keeping is included by reviewer request. TBR=rsesek@chromium.org,jxiang@google.com NOTRY=true Bug: 1067489 Change-Id: I132f3146db2f465226d1b793c8fd2f8c4e66d9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143811 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#757778}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2fb0b345. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 239eeaa8 "[css-filters] Migrate effect-reference-image.html to WPT" 29baa8ce "[css-filters] Migrate effect-reference-image-hw.html to WPT" e7582c3e "[css-filters] Migrate effect-reference-displacement-negative-scale to WPT" 7bcf733d "[css-filters] Migrate effect-reference-external-stylesheet to WPT" dc790030 "[css-filters] Migrate effect-reference-local-url-with-base to WPT" 2fb0b345 "[css-masking] Migrate clip-path-reference-local-url-with-base to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib64a5f3747eb1e92003032c58cfdd0524ef3d4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757777}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/61e170b3c5f6..d56b69f115e2 git log 61e170b3c5f6..d56b69f115e2 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 cwallez@chromium.org Skip Float16 TextureFormatTests on Swiftshader Created with: gclient setdep -r src/third_party/dawn@d56b69f115e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1823b44f72eb1e0a30d5d6c5647b1bb4583d4c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143567Reviewed-by:
-
Matt Falkenhagen authored
The test is evidently slow. Add long timeout. Bug: 1068289 Change-Id: I8fb1ec3d749bd2ff07153ec9ee178b8d1f8f55b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142874 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL augments WebLayer's external intent launching to use the RedirectHandler implementation that is used by Chrome. This takes another step in bringing WebLayer's external intent launching logic up to par with Chrome's; in particular, see the tests modified in this CL, which highlight areas that had previously been deficient in WebLayer. There is one subtlety in this bringup: RedirectHandlerImpl wants to know the last time that the user interacted with the app as a heuristic to help determine if a navigation was started by the user. In Chrome this is determined by the Activity subclass listening for user interaction. However in WebLayer this information is not available, as WebLayer's Activity is provided by the client and thus opaque. Instead, this CL uses a replacement heuristic wherein we pass a user interaction time to RedirectHandlerImpl that is updated on navigations that are either from user typing or have a user gesture associated with them. To date, we have not seen any differences that would result from the usage of these different heuristics. Bug: 1031465, 1066291 Change-Id: Ia9b2c94433db61eb743bfdd50caa9f99fc699c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130790 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#757774}
-
Hajime Hoshi authored
Thic CL adds PageLoadTracker::OnRestoreFromBackForwardCache, which is triggered when the page is restored from the back-forward cache. Now there are no use cases to call OnRestoreFromBackForwardCache since OnEnterBackForwardCache returns STOP_OBSERVING. This CL is a preparation to treat metrics in CorePageLoadMetricsObserver. Bug: 1014174 Change-Id: If5e2316c922fbad43ed68c32a307ba02a95f6b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132560 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#757773}
-
Alan Cutter authored
This CL fixes the unit_tests warning: The following parameterized test case is not instantiated: UninstantiatedTypeParamaterizedTestSuite<PasswordStoreOriginTest> Bug: 1045846 Change-Id: Iae85d808ae25b83c9473225bcbb671d977573a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143098 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Update FontMetrics implementation to return Optional<int> for underline offset and thickness metrics to represent unretrievable values. Update underline thickness painting implementation to only perform what the `auto` keyword would do, as UnderlineThickness() was never initialised on the FontMetrics object. Update TextDecorationOffsetBase implementation support auto and from-font modes. Bug: 1067242 Change-Id: Ica8c7bf3ea8812fae9cd8e285f71d3eba1a9c983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134018 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#757771}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4091.0-1585562740-benchmark-83.0.4099.3-r1 to 83-4099.3-1586168020-benchmark-83.0.4103.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I886fb0d20284cd863850c52495b636831d3f17ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143569Reviewed-by:
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c98edc42336f..00e6685b05e8 git log c98edc42336f..00e6685b05e8 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 treehugger-gerrit@google.com Merge "perfetto-ui: Fix rounding of merged slice percents" 2020-04-08 lalitm@google.com Merge "tp: add documentation for trace analysis feature" 2020-04-08 treehugger-gerrit@google.com Merge "base: round two of trying to fix vs2019" 2020-04-08 treehugger-gerrit@google.com Merge "TrackEvent: Fix compatibility issues with Clang 11 on macOS" 2020-04-08 lalitm@google.com Merge "tp: fix inconsistency of base::optional<StringId> column API" 2020-04-08 primiano@google.com service: Emit a marker when all data source started Created with: gclient setdep -r src/third_party/perfetto@00e6685b05e8 Bug: chromium:150960749 Change-Id: Ieaac915d9c4d2c0325abaac326346cdb5e998065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142034 Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
