GitLab

This is a follow-up to https://crrev.com/c/1500255.

Bug: 938511
Change-Id: If3a4f8a3488557808551da8180ff858522f23052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506872
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638337}

Also removed the EnableAutofillCreditCardLocalCardMigrationExperiment()
in unittests since as we add more experiment flags, this function does
not help.

Set a helper function in TestPersonalDataManager to change the sync
state, which can help us in case of such need in the future.

Bug: 897998
Change-Id: Id212077092d80738b8495f4b50bd7034e9f1ead6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501754
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638336}

- unsigned long long -> uint64_t
- No logic change.
- Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types

Bug: 929980
Change-Id: I6eaddcae79f2b22cde719df027f9fce95664db6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504485Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638335}

This reverts commit c8bd0362.

Reason for revert: The crashes have stopped, so these debugging CLs
are being reverted.

Original change's description:
> [DOMStorageS13N] Making bind calls sync and adding crash info
> 
> There are renderer hangs on the GetAll call, and it is unclear why. This
> change adds crash metadata to know what kind of dom storage is hanging,
> and make the 'bind' calls also sync. This will help narrow down what
> exactly is hanging (or being dropped) so that the GetAll call never
> completes.
> 
> This change is meant to be reverted after the culprit is found.
> 
> TBR: jam@chromium.org
> Bug: 927534
> Change-Id: I3c9727f007cddae93b7b274a72f0a6313343ae29
> Reviewed-on: https://chromium-review.googlesource.com/c/1449160
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629630}

TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 927534
Change-Id: I1d864a6a085c8cd8546bd575f06a4be2d12145d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506533Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638334}

Moves the EG tests related to the legacy translate infobar to a new target
as the new infobar EG tests rely on the CompactTranslateInfobarIOS feature
to be enabled via command line which will break the legacy infobar tests.

- This CL does not make any changes to the tests logic.
- The new target is the previous translate_egtest target which runs on
  downstream bots.

Bug: 910994
Change-Id: I9ea34207e20a5fb72e257ec5f0c8d9a43f05a440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506571
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638333}

This does not change the behavior of any existing extension or focus
ring. It only changes the interface by which the extensions set the
focus rings, and adds additional parameters to allow for multiple focus
rings with different visual styles from a single extension.

No new parameters have been plumbed through to the
accessibility_focus_ring_controller at this time, that will happen in a
follow-up change. This change does support multiple focus rings from
the same extension simultaneously.

There are no whitelisted extensions using
accessibilityPrivate.setFocusRing (ChromeVox classic is not supported
on Chrome OS, and this function is only supported on Chrome OS).

All existing calls to setFocusRing within Chrome have been updated.


Bug: 925103
Change-Id: Ic85abef978ce969ff76db38308a1c234fe746a4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489972Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#638332}

Bug: 936944
Change-Id: I3eed83b7c69b804f577ba6ea9097a6be205fc898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506758
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638331}

According to the plan to replace |const LocalFrame*| arguement with |const Document&|,
|ExecutionContext*|, or |DocumentLoader*| in UseCounter::Count(), this CL
replaces all uses of UseCounter::Count(const LocalFrame*) with
other UseCounter::Count(...) in frame directory.

Finally, this CL removes UseCounter::Count(const LocalFrame*, WebFeature) in Blink.

Bug: 936187
Change-Id: I8beff53c6a3899737de7dbc37c2f6fbe6602e977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498794Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638330}

This CL adds tests to verify that a decision to bypass the lookalike
interstitial made in the main profile does not affect incognito and vice
versa.

Bug: 927924
Change-Id: I238e2e263db42c1434b9190de007aa775129417e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506458
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638329}

If a request was blocked by Chrome, a reload is unlikely to help and
auto reloads cause issues with some types of errors (e.g. Safe Browsing
committed interstitials).

Bug: 910794
Change-Id: I94e6d040216cee92b9dd1ad4ee89f1cd25a52e2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504033
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638328}

In CyptAuth v2 Enrollment, the user key pair--also known as
CryptAuthKeyBundle::Name::kUserKeyPair or "PublicKey"--has special
standing in order to 1) accommodate any existing key from v1 Enrollment
and 2) enforce that the key is not rotated. Only one user key pair
should exist in its key bundle, and it should be an active, P-256 key
with handle "device_key".

It is possible that CryptAuth could request the creation of a new user
key pair even if the client sends information about an existing key in
the SyncKeysRequest. If this happens, the client should re-use the
existing user key pair key material when creating a new key. At the end
of the enrollment flow, the existing key will be replaced with this new
key that has the same public/private keys, but possibly with a new key
directive.

It might seem more efficient to simply ignore the key-creation request,
but the method outlined above natually fits into the enrollment flow,
the key directive will be updated, and the client will be able to
provide CryptAuth with an EnrollKeys request, which it might be
expected.

Bug: 899080
Change-Id: I3a4a63aa902090698ecb619bc7af78ff1e790c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504121
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638327}

Bug: 938717
Change-Id: Ied6a40e873849bdd91d499fe1a9093752d144763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504500
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638326}

Previously, the animated voice input toggle was slightly off center:
https://screenshot.googleplex.com/tODAXyEw64F

Bug: 924624
Change-Id: I30b230a22afa152a4081aa9f25347a696a002179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506381
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638325}

Updates the resource manager to not require a mime type when loading
a bundled resource. This is the same as the behavior in [1].

[1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340

Bug: 902646
Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194
Commit-Queue: dstockwell <dstockwell@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638324}

Bug: 902646,938857
Change-Id: I8a6165fc0de258b634733b77ac166c184882318a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505733Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638323}

https://chromium.googlesource.com/webm/libvpx.git/+log/503cb8e63a06..d64e328624e0

$ git log 503cb8e63..d64e32862 --date=short --no-merges --format='%ad %ae %s'
2019-03-05 jianj vp9 svc example: use CONFIG_VP9_DECODER guarding decoding.
2019-02-12 angiebird Add rd_diff_arr to store future blocks' rd diff
2019-03-04 angiebird Fix compile error when DUMP_TPL_STATS is 1
2019-03-04 marpan vp9-rtc: Speed feature changes to speed 9
2019-03-01 marpan vp9-rtc: Adjust force split logic for screen mode
2019-03-01 marpan vp9-rtc: Fix for scroll motion for rtc
2018-12-07 paulwilkins Strengthened film grain setting.
2019-02-26 paulwilkins Fix RD multiplier bug impacting AQ1.

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I8619ec2af03d0f24d3e243fd9c647c4db39c3ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506459
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#638322}

Previously the wrapper script would only be used for coverage builds
that required selective instrumentation of specific files. Now it
will also be used for any coverage builds.

Since the script's job is to remove flags from files that shouldn't
have them the default_coverage config now adds to cflags even in a
CQ build.

Bug: 918215
Change-Id: I012c5732d46bf5cff9eaf8f50615739bb781cc29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496002
Commit-Queue: Sajjad Mirza <sajjadm@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638321}

Bug: 923475
Change-Id: I83a67e5053bf50ce6299523eb0cadff68b8169d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506656Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638320}

The feature toggles are on track to be launched in M73 via server-side
variations, so let's enable them all by default for M74.

Bug: 902704
Change-Id: I0763b2ecb8a572d975cd6da56892e74e3da59a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503572
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638319}

The class has no superclasses or subclasses, so it is confusing for the
reader to see the virtual qualifier here. This change clarifies for the
readers how this class is used.

Change-Id: I22fc58f88a0dd7091c530ce55357ed783d4b46c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506377
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638318}

This reverts commit 3194759c.

Reason for revert: Caused https://crbug.com/938839. Seems that the 
workaround is still needed even without animations.

Original change's description:
> Settings cleanup: Remove obsolete setTimeout() work-around.
> 
> This workaround refers to 859794 which is obsolete after removal of
> page/subpage animations.
> 
> Bug: 859794
> Change-Id: I688ec714117f90a797db1b1baacc6eb9d2138751
> Reviewed-on: https://chromium-review.googlesource.com/c/1490436
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: calamity <calamity@chromium.org>
> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636347}

TBR=calamity@chromium.org,dpapad@chromium.org,hcarmona@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 859794,938839
Change-Id: Id83ed5c68320815b75c49acb06b21afbb7ed9007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506464Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638317}

This change:
1) Adds 4 new properties to CaptionStyle.
2) Adds caption_style_win.cc that contains a Windows implementation for
   CaptionStyle::FromSystemSettings().
3) Adds a new feature flag to enable Windows system styling.
4) Follows the same pattern as the earlier change here:
   https://chromium-review.googlesource.com/c/chromium/src/+/1418399

Next steps:
Add support for background opacity, window opacity, and window color

Bug: 897730

Change-Id: Iefb0092c32b4fdb3d4d6412a2e21b9bdf018887f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482140Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#638316}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0668403dfdd6..61a1b5f31059


git log 0668403dfdd6..61a1b5f31059 --date=short --no-merges --format='%ad %ae %s'
2019-03-06 spang@chromium.org Avoid unnecessary invocations of "git fetch"


Created with:
  gclient setdep -r src/third_party/depot_tools@61a1b5f31059

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:938627
TBR=agable@chromium.org

Change-Id: I06964df9cebf7fa67eb148d0477220f3fe9259ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506475Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638315}

This CL adds support to send ExtensionHostMsg_PostMessage IPC from
worker threads. This allows reply to work targeting a Service
Worker.

Bug: 925927
Test: chrome.runtime.sendMessage can use reply callback.
Change-Id: I2c64992847f0f8746a455941a58841e5f1fea8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506009
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638314}

R=benmason@chromium.org

Change-Id: Ie53cce111fb1cbc2024050efd70bf3874ccef459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506471Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638313}

This prevents a bug which can occurr for URLs that redirect. The bug is a bit
subtle, so see the crbug.com/937581 for more details.

We're almost guaranteed that Chrome hasn't seen a redirect for the final URL,
so this will fix the problem of redirecting before hitting the offline url
loader request interceptor. We will intercept requests for either the original
URL or the final URL.

Note that because we're using a different URL in the intent, when a URL is a
redirect, we will always open the page in a new tab. This is not ideal, but
is preferable to failing to open the page.

Bug: 937581
Change-Id: I04f02556e93eba1ca0b2380313f1052c7f8f7cd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505895
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638312}

Bug: 925949
Change-Id: I55a9d8280be7cbe435f7c84629b79e919fdff016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499955
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638311}

We introduced two new accessibility attributes for image
annotations. When these attributes change, it's exposed to
assistive technology as part of the accessible name,
so we need to fire name changed events to guarantee that
AT is updated.

Bug: 905419

Change-Id: I63d64b895ccbfc3265f037de3227be3da4dc41dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504705
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638310}

Tbr: eae@chromium.org
NoTry: True
Change-Id: I8811ef4a85c350663e280543f76a950abae858a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505901Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638309}

There can be a race between the browser receiving window bounds updates
and the IME ensuring the text caret is visible.

* Repeat the text caret visibility request after virtual keyboard
  occluded bounds update. This is a no-op if the caret is already
  visible.
* Fix double-conversion of local bounds to screen bounds in chrome's
  receipt of occluded bounds from ash.
* Clarify variable names with coordinate system.

Bug: 937722

Change-Id: I0f49413ca63582469cf0a4b61cde69733c1841ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504150Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638308}

BUG=937880

Change-Id: Ib222ad6cddf23b0f28863e75f1bc729e638c6ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504460
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638307}

MediaStreamSourceNode and related nodes should report they have
activity whenever the context is running, because they actually do.
This prevents the nodes from getting prematurely collected.
Unfortunately, this also means nodes will not be collected until the
context is suspended or stopped.



Bug: 937231
Change-Id: I4cd93fe757d8f34fbbc0c68aeaace4727c77be14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496541Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638306}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/767948b07604..c3ec692344cb


git log 767948b07604..c3ec692344cb --date=short --no-merges --format='%ad %ae %s'
2019-03-06 dgarrett@google.com workspace_stages: Add SyncChrome timeout.


Created with:
  gclient setdep -r src/third_party/chromite@c3ec692344cb

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I58f7b56c9a2251c891eda19d3884929a6987e9ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506477Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638305}

This also moves the ignore blacklist flag one call level higher for use
in browser tests, instead of having to load hints for every test.

Bug: 938621
Change-Id: Ie13f87463dccb9e2a3d57a0cda9b89a80fdb9f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504256Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638304}

Bug: 933515

Change-Id: I2c4f239144d3ed060d5bace974b5646b086ca9db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479422
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638303}

Updating +[ChromeMatchers googleServicesSettingsButton], to find the
"Sync and Google services" cell. This cell cannot be found with its
accessibility text since the sync status (detail text of the cell)
can vary.

The issue was created with:
crrev.com/c/1497003

Bug: 937855
Change-Id: Ia8ab1f90a3c8476f2710b48cdcacb1278aa292e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503414Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638302}

There are missing clang runtime libraries that are needed to
successfully link libmojo in a coverage configuration. This
workaround lets us get coverage data for the rest of Chrome on
Chrome OS.

This patch was authored by Noel Gordon, who initially reported this
issue.

Bug: 865376
Change-Id: I88b309760836639b80dfa0f7b67e4bb5c2b55d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493471
Commit-Queue: Sajjad Mirza <sajjadm@google.com>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638301}

According to the specification, when you drag a window to snap it, the
preview area (referred to as "Indicator") should fade out over 67 ms,
fast out, linear in:
https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#window-drop

Currently, it fades out over 250 ms, fast out, slow in.

BEFORE:
https://photos.app.goo.gl/MQa3rZ4jKX4hZLba7

AFTER:
https://photos.app.goo.gl/iLFHyvqxFZsfreEC6

Test: manual
Bug: 934977
Change-Id: I27d3e4d758097f2a87207880b2bc5ca9622dad7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504037
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638300}

infra cl: https://chrome-internal-review.googlesource.com/c/infradata/config/+/914125

Bug: 936908
Change-Id: I15d82cdf4ca0edb78a7258b6477deaaa0941c6f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496656
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638299}

Changelog: https://github.com/googlechrome/lighthouse/compare/v4.0.0...v4.1.0

Change-Id: Ief76c7c2d0fb4b44e9332b91c2a6bb99f46a9d2e
Bug: 772558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506382
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638298}