GitLab

Currently when an user changes the system accent color on Mac, that
color is going to be used as the focus ring.

This CL changes the used focus ring color by taking just the RGB values
from the accent color. A custom alpha value of 128 is used in order to
avoid having a color too light which affects accessibility.

Bug: 1051391
Change-Id: I8416739ca42ef8deeeca5faf932d6dd9e0fed26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057865Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#742364}

Per discussion in crrev.com/c/2055362, it's generally not safe to use
gRPC outside Chrome Remote Desktop, especially in Chrome. This CL adds
a note to the BUILD.gn file to encourage people to discuss this with
Chrome security team before they decide to use gRPC.

Change-Id: I9218059a977d5aea785cd70621f7ab2c428ecc0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062920
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742363}

This is in preparation for porting these tests to Polymer 3.

Bug: 1026426
Change-Id: I16aa1e85c882431b99a4bbd95393b62a216542a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056576Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742362}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01663f71bc87..f0fc1c09255f


Created with:
  gclient setdep -r src-internal@f0fc1c09255f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1050094,chromium:1052560
Tbr: jbudorick@google.com
Change-Id: Idc3d191bd21ce90be82f0085d9a0531bcf56c115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062762Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742361}

Removed the use of NativeTheme::GetInstanceForNativeUI() from
CastDialogSinkButton.
Fixed the dialog issue icon such that it's color now tracks the
current NativeTheme of it's widget.

Bug: None
Change-Id: Idfa416ad449b6038804087e4dd518ebdb52724bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044631
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742360}

This adds the reverse of SetEnabledTextColors(). It also makes
ResetColorsFromNativeTheme private instead of protected as it was
currently misused and no other call sites.

Adds a simple test for SetEnabledTextColors().

Bug: None
Change-Id: I0b4a15733e4913c809dd5d91cd0c5821370f824d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057625
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742359}

Changes the width of the search box to expand the containing search
wrapper to 288px.

The value used in the CSS calc property 60px is the sum of 48px for the
search button plus 12px margin to the right of the search input field
cancel button.

Note, the width of the search button margins may be reduced in a future
CL subject to visual evaluation.

Bug: 992823
Change-Id: I372df330a5bb446c3430dcd85c0582bd3a3d9b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060401
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742358}

This allows us to remove the color conversion render pass, and use
a lower-bit depth format.

Bug: 1037954
Change-Id: I6810b1105d47c3690d371f92700182ef4f13e7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060664
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742357}

ScrollableShelfView::GetTargetScreenBoundsOfItemIcon assumes that shelf
is horizontally aligned. This CL generalizes this function for side-
aligned shelf.

Bug: 1053705
Change-Id: I56c6a9a6a6bc7e102cb9c479574f1ca44eb0947e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063410Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742356}

GN-gen is spitting out a warning on simple chrome builds with:
  The variable "needs_gomacc_path_arg" was set as a build argument
  but never appeared in a declare_args() block in any buildfile.

This fixes that.

Bug: 1011928
Change-Id: I75038e0e004889672e2cc24f7cedb76465cb55ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063252
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742355}

Most of them failed because of the recent form rendering changes.

Change-Id: I27d3c0628215488eb1c8a1c6fc2aa4c47f21a040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063409Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742354}

Change-Id: I76cf803cdf5ac839c8d6145a837e7f2c021a7573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048363
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742353}

Updated HoverButton code such that it will responsively update its
own and its children's layouts. This is in contrast to its original
behaviour in which layout was set based on the preferred sizes of
it's children at construction time.

This helps towards having HoverButtons with icons that update to
match the color of the Widget's current theme provider. Such
changes could incur changes in the icon's preferred size and
could result in incorrect behavior in the old code.

Also cleaned up unnecessary and unused code and fixed broken logic.

Bug: None
Change-Id: I502c32ea673d8f680f38a45ce2940e155872dd40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045145
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742352}

Chrome on ChromeOS uses triple buffering by default, keeping up to 2
buffers in flight while one is displayed.

This CL adds a flag in chrome://flags that limits to 1 the number of
pending frames, effectively reducing compositing to double-buffering.

This can be useful for experimenting on devices where we want to
minimize latency at the cost of more dropped frames.

Bug: 1010457
Change-Id: I0cddb4c1831d5b909ee3c0193d42f3903e10d03a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059709
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742351}

Bug: 1048832
Change-Id: I7f3f398413b6339e35760fc8efec97b9e19b7601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037845
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742350}

As per https://chromium-review.googlesource.com/c/chromium/src/+/2044632/2/content/public/renderer/render_view.h#33

TBR=creis@chromium.org

Bug: 419087
Change-Id: I525cba9080c2fe9eabf3ff14f5c30efcc2564281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062915Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742349}

Change-Id: I374fd452155ff8e9db96908f40ca98030fb12c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062921Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#742348}

* Remove using:: statements
* Implement ButtonSeparatorView atop views::Separator.  This changes from a 1 px
  line to a 1 DIP line; that complies with the current (MD Refresh) spec.

Bug: none
Change-Id: I7acedbb31bb9cd3fc5342449258efafe471ac976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048911
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742347}

Sets the height of the search box wrapper to 40px and ensures the
contained buttons and input field are vertically centered.

Bug: 992823
Change-Id: I1bcd5e38e1268e1a382ff28304c447e2988fed6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060400
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742346}

Bug: 1024586
Change-Id: Ia0661b281b84f9fcda8aa3a4936a4d4b780d00c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062923
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742345}

Bug: b/149422033
Change-Id: I56af3e77eeec9496027e231424efab8f530c03f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063033Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Alex Leung <alexleung@google.com>
Cr-Commit-Position: refs/heads/master@{#742344}

This is behind a DisplayOwner param of the OmniboxDocumentProvider
feature.

Change-Id: Id66289c0b011838ceee8b129c1d2881f5466effe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929774
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742343}

Change-Id: I63883c00ba35e246f408f18456e5f1afcbc80ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062788
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742342}

This change is part of the post-launch cleanup of ZPS, Rich Entities
and Favicons bundle.

Bug: 1051551
Change-Id: I1e4799caea79d98a258ab891fd513fc4e659b37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049833Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742341}

This is a mechanical change to remove implicit conversions of
ScopedBstr to BSTR.

BUG=1034666

Change-Id: I4a143eb0babc4ed0be9e761ebd29531baf2916a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063528Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742340}

Add ProfileCardUtil.java.

Bug: 1051149
Change-Id: Ib27295d2b01c59f09a10b306f9f28cf6f4a34811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062931
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742339}

When an ExecutionContext is abruptly/unexpectedly destroyed (e.g.
shutting down of document or iframe), an AudioContext can also
go away. This type of shutdown can be problematic because the render
thread still might be touching resources in the AudioContext allocated
by the main thread.

This CL introduces a self-referencing pointer to the AudioContext,
and it is cleared after the underlying render thread is stopped. In
that way, the destruction of AudioContext can be done safely.

Test: Locally confirmed the repro case doesn't crash (UAP) after 1hr.
Bug: 1043446
Change-Id: I2e40b7d58ca9d647eed8a5971fc69dc87ee3d1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049912Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742338}

Non-foreground tabs were being reattached in the reverse order, but this
is unnecessary since the default add behavior adds the tabs to the end.

Bug: 1053388
Change-Id: Id768184cf3d02b679568eb3d0f72a262dacc522d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062686Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742337}

Forward a stop session request from CastSessionClientImpl to
CastMessageHandler.

Bug: 1040184
Change-Id: I74e16506bd7674ad21809982c0d7e7c7150936a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055560Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742336}

Register it in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: I4fc46ea16906ff673aff28b403ac3cd026fbb480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037325
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742335}

A couple referrer-related histograms are expiring soon:
- Net.URLRequest.ReferrerPolicyForRequest logs the referrer policies of
outgoing requests
- Net.URLRequest.ReferrerHasInformativePath logs whether a referrer
contains more information than just its origin (this is used for
evaluating the usefulness of referrer policies that cap referrers to
requests' initiating origins)

This CL extends their lifetimes because these metrics will remain useful
for ongoing experimentation and post-rollout success tracking.

R=csharrison

Fixed: 1053277
Change-Id: I38e3f2cbf8b959a06aaf37795f7e9b9b75f98d7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062293Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742334}

events_referenceSpace_Reset_inline was always timing out because the
reset event was never sent. It turns out that this is because the
frame_data that was being used to process inline sessions was always
nullptr, rather than using the frame data associated with a particular
inline session. This change modifies the requesting_sessions_ map to
store the frame data rather than just the pose, and to process the frame
data for a particular session with that session.

Fixed: 1015195
Change-Id: I3a5d1b619869b57c270304f46bd19b43685869bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062897
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742333}

5a8c22864134 Add document for base94_encoder
07812f5bd615 android: fix the gyp build
faed21a28625 linux: Log register sizes on mismatch

Change-Id: I532f7090eb07f640917a37e929573bd4c8d45ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062936
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742332}

|signinCompletion| has to be set by the owner of the SigninCoordinator
to track when the the sign-in is done, when the coordinator can be
released.
Adding DCHECK(self.signinCompletion) in -[SigninCoordinator start], to
enforce it.

Once the completion block is called, the property is set to nil.
Adding DCHECK(!self.signinCompletion) in -[SigninCoordinator stop], to
make sure the callback is called before stopping the coordinator.

Bug: 971989
Change-Id: I0bfcc2579a8824bc6e4b8345221542bcf5819359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053129
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742331}

This CL adds an integration test for Maps Go WebAPK's first run
experience.

Bug: 689142
Change-Id: I3c86841b269d94c0a7c08704a9cb681ec9e4e03e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025917
Commit-Queue: Henry Jian <hzjian@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742330}

The final response URL is calculated from the redirect chain, URLs
fetched by the service worker and the initial request URL.

The logic is mostly based on what
blink::ResourceResponse::ResponseUrl() does.

Bug: 986188, 1048332
Change-Id: I74dab2b68bbc7463114df25444658dcd0794fe77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036265
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742329}

Change-Id: Ib349e61075844d95458ed3b2d0fd313a888cd674
Bug: 1048862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056489Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742328}

Move MockHatsService to stand-alone files so it can be re-used in
other tests (it is expected to also be used in testing
Hats-related WebUI message handler.)

Bug: 1045348
Change-Id: If7f55fbeddb999c7dbfe184fe15be75785ceabb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044219
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742327}

RenderFrames could be reused for same-origin navigations. This causes
the hints from previous navigations to be used in next navigation
until the new hints fetch finishes and updates the hints. This CL clears
the hints.

Unfortunately this causes race conditions between the image fetch and
the hints update, which causes images to not redirected to compressed
versions. So the image fetches are delayed a bit to circumvent this.

Bug: 1051283
Change-Id: Ie9e5351e68c0081ab9dbfe23faed2c3c5e8e4d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056207
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742326}

TBR=govind@chromium.org

Change-Id: I7acc0ab00daa28f53f2c2f1e0eda99d6356f43bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063249Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742325}