GitLab

Before we have the chance to fully implement the function, we need
a quick fix for (E)AC3.

No ATV we know of that supports (E)AC3 decoder, so it relies on the
audio sink device.

BUG=Internal b/36896359

Review-Url: https://codereview.chromium.org/2845173002
Cr-Commit-Position: refs/heads/master@{#467784}

This CL:
* Fixes the subpage arrow for bluetooth and focus it correctly.
* Provides focus logic for internet-page -> internet-subpage ->
  internet-detail-page.
* Fixes keyboard navigation to details page from cr-network-list-item

BUG=714350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2841873004
Cr-Commit-Position: refs/heads/master@{#467783}

Reland of name kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #1 id:1 of https://codereview.chromium.org/2851453003/ )

Reason for revert:
Reland the original patch as timvolodine and I believe it's not related to the compile failure early today.

Original issue's description:
> Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #2 id:20001 of https://codereview.chromium.org/2843913003/ )
>
> Reason for revert:
> broke clang-clankium-tot-builder crbug.com/716075
>
> (FullscreenWebContentsActivityTest not updated)
>
> Original issue's description:
> > Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag.
> >
> > The flag should only be set by tests and will allow all autoplay related
> > restrictions such as autoplay policy and background playback to be
> > disabled.
> >
> > BUG=714676
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Review-Url: https://codereview.chromium.org/2843913003
> > Cr-Commit-Position: refs/heads/master@{#467692}
> > Committed: https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6
>
> TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=714676
>
> Review-Url: https://codereview.chromium.org/2851453003
> Cr-Commit-Position: refs/heads/master@{#467715}
> Committed: https://chromium.googlesource.com/chromium/src/+/54e35df000303d1a3b5214db2232aa2fb5c12e3a

TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org,timvolodine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=714676

Review-Url: https://codereview.chromium.org/2845973005
Cr-Commit-Position: refs/heads/master@{#467782}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2845973003
Cr-Commit-Position: refs/heads/master@{#467781}

Mouse drag gestures on android are delivered using a stream of
ACTION_MOVE events. If the view does not consume the ACTION_DOWN event
that starts the gesture, it will not receive the following move events.

Consume this event in the EventForwarder to ensure the ContentView gets
the complete gesture.

BUG=714845

Review-Url: https://codereview.chromium.org/2842823002
Cr-Commit-Position: refs/heads/master@{#467780}

This CL adds PRESUBMIT script to chrome/android/webapk/shell_apk so
that any time code in chrome/android/webapk/shell_apk/ changes,
chrome/android/webapk/shell_apk/shell_apk_version.gni must be updated
accordingly. See comments in presubmit.py for detailed rules.

BUG=708053

Review-Url: https://codereview.chromium.org/2830343002
Cr-Commit-Position: refs/heads/master@{#467779}

Mark as failing on Linux Intel HD 530:
WebglConformance_deqp_functional_gles3_texturefiltering_3d_formats_0[4589].

BUG=715881
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849443002
Cr-Commit-Position: refs/heads/master@{#467778}

BUG=715376

Review-Url: https://codereview.chromium.org/2843873002
Cr-Commit-Position: refs/heads/master@{#467777}

Also removes some extraneous interface_registry.h #includes.

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2844063003
Cr-Commit-Position: refs/heads/master@{#467776}

BUG=715644

Review-Url: https://codereview.chromium.org/2852533002
Cr-Commit-Position: refs/heads/master@{#467775}

TBR=thakis
BUG=709341
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2816173002
Cr-Commit-Position: refs/heads/master@{#467774}

Fixes a bug causing suggestions to be added to the bottom sheet's Home
tab every time it's opened.

BUG=689962

Review-Url: https://codereview.chromium.org/2848663002
Cr-Commit-Position: refs/heads/master@{#467773}

We are suspecting that some error reports don't get sent properly
even when the success callback runs. For that reason, we'll check
the response code and classify the upload as failure if the response
code isn't as expected.

BUG=682933

Review-Url: https://codereview.chromium.org/2648713002
Cr-Commit-Position: refs/heads/master@{#467772}

NOTRY=true
TBR=reed@google.com

BUG=skia:6535

Review-Url: https://codereview.chromium.org/2850503003
Cr-Commit-Position: refs/heads/master@{#467771}

In order to make transitions between bottom sheet contents look good,
a background color was set on the toolbar container. This causes an
issue in the tab switcher which needs the toolbar to be transparent.
This change conditionally sets the background color of the toolbar
container while the content transition animation is running.

BUG=702717

Review-Url: https://codereview.chromium.org/2846883003
Cr-Commit-Position: refs/heads/master@{#467770}

Revert of Ensure that builders that use goma strip absolute paths by default. (patchset #1 id:1 of https://codereview.chromium.org/2837863005/ )

Reason for revert:
Reverting in case this is related to the goma errors in https://crbug.com/716089

Original issue's description:
> Ensure that builders that use goma strip absolute paths by default.
>
> This CL tweaks the MB configs so that any builder that is using goma
> also sets strip_absolute_paths_from_debug_symbols_by_default=true.
> This helps ensure that we get the best goma cache hit rate possible.
> We don't just make the default equal to use_goma=true because doing
> so may make it harder for devs to debug binaries, and we want devs
> to be able to both debug binaries and use goma by default; the
> tradeoff is that their builds are slightly slower.
>
> R=thakis@chromium.org, jochen@chromium.org
> BUG=603286, 712790
>
> Review-Url: https://codereview.chromium.org/2837863005
> Cr-Commit-Position: refs/heads/master@{#467574}
> Committed: https://chromium.googlesource.com/chromium/src/+/050dbe550d14e99ad4e83093d4f4e79642b9edc3

TBR=jochen@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603286, 712790

Review-Url: https://codereview.chromium.org/2843403004
Cr-Commit-Position: refs/heads/master@{#467769}

This change adds logic inside the OverlayPanelEventFilter to make
sure that at least one down event is being passed to the internal
gesture detector before a stream starts.

BUG=715183

Review-Url: https://codereview.chromium.org/2843263003
Cr-Commit-Position: refs/heads/master@{#467768}

These tests are failing consistently on the Site Isolation FYI bots.
Disabling them while they are investigated and fixed.

BUG=710098,716085

Review-Url: https://codereview.chromium.org/2845093004
Cr-Commit-Position: refs/heads/master@{#467767}

Add a dialog that can be triggered via LocaleManager that allows a user
to choose their default search engine from a randomized list.

DefaultSearchEnginePromoDialog:
* Add a basic dialog that forces a user to select a default search engine.  This
  dialog only shows up for the "existing user" case and (currently) randomizes
  the search engines available as defined in the TemplateUrlService.

* Add the ability to show the DefaultSearchEnginePromoDialog from the
  LocaleManager.  It currently never fires because the logic hasn't landed, but
  it is triggered from ChromeTabbedActivity and SearchActivity.

Things to do:
- Still trying to figure out how to test this.

Screenshots:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM

BUG=714223,712836,712833

Review-Url: https://codereview.chromium.org/2838833002
Cr-Commit-Position: refs/heads/master@{#467766}

A Sheriff disabled these tests when they were found to be flaky.
I've fixed two problems, an uninitialized pointer which might have
been causing a crash (previous changelist), and in this changelist
a missing call to PumpLoop() causing the test to fail when
race conditions happened.

BUG=712941

Review-Url: https://codereview.chromium.org/2837873006
Cr-Commit-Position: refs/heads/master@{#467765}

4 possible dispositions are 4 combinations of Ctrl and Shift, combined with mouse click (or Enter on a link), as per this: https://support.google.com/chromebook/answer/183101?hl=en

Bug=712331

Review-Url: https://codereview.chromium.org/2842413002
Cr-Commit-Position: refs/heads/master@{#467764}

The 3.17.0 import seems to have stuck, so I think rollback is pretty
unlikely at this point.

BUG=701518
TBR=pwnall@chromium.org

Review-Url: https://codereview.chromium.org/2846743003
Cr-Commit-Position: refs/heads/master@{#467763}

TBR=jochen
for mechanical changes to chrome/browser/extensions/api/omnibox/* and chrome/browser/android/omnibox/*

BUG=697624

Review-Url: https://codereview.chromium.org/2738003002
Cr-Commit-Position: refs/heads/master@{#467762}

base::hash_map is deprecated in favor of std::unordered_map (which it is a
typedef of).

The changes to tracing required updating of callers in third_party/WebKit.

Some uses were replaced with more appropriate variants: std::map,
base::flat_map, and base::small_map.

A std::hash implementation of base::FilePath is added.

BUG=576864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2830093003
Cr-Commit-Position: refs/heads/master@{#467761}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2849613002
Cr-Commit-Position: refs/heads/master@{#467760}

Per UX.

Bug=712331

Review-Url: https://codereview.chromium.org/2847583003
Cr-Commit-Position: refs/heads/master@{#467759}

For all screens:
- Banner content div fit to text content with max-width 722px.
  This makes the banner fit text better and gets rid of excessive
  left/right padding when text is short;
- Remove font-size override and use inherited 14px from body;

For login screen (where banner is only used for migration message):
- Reduce 4px of banner-pod space (16px between banner bottom and
  the selected user pod with this CL);
- Add 4px left/right padding (24px instead of 20px with the CL);

BUG=715706

Review-Url: https://codereview.chromium.org/2849583002
Cr-Commit-Position: refs/heads/master@{#467758}

BUG=716076

Review-Url: https://codereview.chromium.org/2846053002
Cr-Commit-Position: refs/heads/master@{#467757}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2846743002
Cr-Commit-Position: refs/heads/master@{#467756}

BUG=715086

Review-Url: https://codereview.chromium.org/2847813003
Cr-Commit-Position: refs/heads/master@{#467755}

If hardware overlay processing is skipped for a frame, there's no
way to be sure of the state of the previous frame. Reset
|previous_frame_underlay_rect_| for the next frame.

BUG=Internal b/37644269
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2844483004
Cr-Commit-Position: refs/heads/master@{#467754}

ProcessStatsStub is an interface to receive process resource usage information
from a ProcessStats.

ProcessResourceUsage is a structure to store the resource usage of one process.
AggregatedProcessResourceUsage is a structure to store the resource usgaes of
several processes.

ProcessStatsAgent is an interface to retrieve resource usage of one process.
CurrentProcessStatsAgent is a ProcessStatsAgent implementation to retrieve
resource usage from current process.
ForwardProcessStatsAgent receives resource usage from a third-party and forwards
the latest usage as a ProcessStatsAgent.

ProcessStatsSender is a class to regularly report resource usages from various
ProcessStatsAgent implementations to a ProcessStatsStub. It merges several
non-empty ProcessResourceUsage into one AggregatedProcessResourceUsage.
This is typical useful on Windows: we need to calculate the resource usages from
both network process and desktop process.

R=sergeyu@chromium.org, jamiewalch@chromium.org
BUG=650926

Review-Url: https://codereview.chromium.org/2775983003
Cr-Commit-Position: refs/heads/master@{#467753}

Removed navigation drawer from the download home. The drawer was replaced
by a spinner. Space display moved in-page as a header in the download
history adapter.

BUG=712912

Review-Url: https://codereview.chromium.org/2834453007
Cr-Commit-Position: refs/heads/master@{#467752}

Logic in chrome/app, content/app, and content/public/app is
primarily  concerned with basic process initialization and
lifecycle.

This adds some appropriate OWNERS to cover the ongoing effort to
refactor that stuff into services/service_manager.

BUG=654986
R=jam@chromium.org

Change-Id: Idd4ca1ae43e2e14110a82f3cd0e6d5dc04e13b7c
Reviewed-on: https://chromium-review.googlesource.com/488103Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467751}

ConnectorImpl is bound to a thread lazily on first use.
The recent addition of FilterInterfaces did not account for this.
This fixes that.

BUG=716046
R=ben@chromium.org

Change-Id: I4804a4a10167c858ffb51f37825b9f1a5a2b3ff6
Reviewed-on: https://chromium-review.googlesource.com/489021Reviewed-by: Ben Goodger <ben@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467750}

Also updates 2D quad properties to conform to spec.

BUG=643483

Review-Url: https://codereview.chromium.org/2832843004
Cr-Commit-Position: refs/heads/master@{#467749}

This CL adds a test to verify if-heavy is added on fast networks, but a
LoFi response is not received. It also adds a test to verify that slow2G
users will receieve a LoFi image for those requests.

BUG=708276

Review-Url: https://codereview.chromium.org/2842573004
Cr-Commit-Position: refs/heads/master@{#467748}

Was previously crashing because the AutofillPaymentInstrument delegate
was not being reset properly on back navigation. Now it is.

BUG=715093
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2844293002
Cr-Commit-Position: refs/heads/master@{#467747}

   web_contents_android and ARC.
2. Implement sending voice interaction structure from
   cros to ARC.

BUG=b/35643583
BUG=704684
TEST=
  browser_tests --gtest_filter=\
     ArcVoiceInteractionArcHomeServiceTest.*
TEST=manually verified ax element position in clank
TEST=verified voice interaction structure sent to ARC

Review-Url: https://codereview.chromium.org/2808383004
Cr-Commit-Position: refs/heads/master@{#467746}

Also change all occurrences of SPDY_EXPORT into SPDY_EXPORT_PRIVATE.

This is to be used in shared code (net/spdy/core).  Note that
SPDY_EXPORT is not used at all, just like QUIC_EXPORT (defined in
net/quic/platform) is not used either.

Review-Url: https://codereview.chromium.org/2839373002
Cr-Commit-Position: refs/heads/master@{#467745}