GitLab

This will allow us to roll the change out gradually using
Finch.

BUG=385213

Review URL: https://codereview.chromium.org/362553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283476 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (https://codereview.chromium.org/367153005/)

Reason for revert:
this broke unit_tests" on "Linux ASan LSan Tests (2):
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4967.

Original issue's description:
> Sync: Refactoring of DEVICE_INFO syncable type - Part 1
> 
> This change introduces a new class LocalDeviceInfoProvider that is responsible
> for providing the local device specific DeviceInfo/cache_guid. It initializes
> the data asynchronously and allows consumers to get notified when the data 
> becomes available. 
> 
> LocalDeviceInfoProvider will allow to remove these responsibilities from 
> SyncedDeviceTracker / ProfileSyncService and loose coupling between
> ProfileSyncService and a number of SyncableService and DataTypeController 
> derived classes.
> 
> LocalDeviceInfoProvider is hosted on the frontend thread. Since it needs
> cache_guid to initialize DeviceInfo, which is currently available only on the
> backend, I updated SyncBackendHostCore and SyncBackendHostImpl to pass
> cache_guid to the frontend via OnBackendInitialized.
> 
> For the time being SyncedDeviceTracker remains unchanged
> and continues to initialize the local device info too. The entire class will be
> removed in the Part 2 of the change which will move SyncedDeviceTracker
> functionality to a new SyncableService.
> 
> LocalDeviceInfoProvider also replaces SessionsSyncManager::SyncInternalApiDelegate
> which was previously used to decouple SessionsSyncManager from the specifics of
> of the local device info implementation. 
> SessionsSyncManager is changed to consume LocalDeviceInfoProvider instead of 
> SessionsSyncManager::SyncInternalApiDelegate.
> SessionDataTypeController now also consumes LocalDeviceInfoProvider to make sure
> that SESSIONS type model doesn't start before local device info becomes available.
> A very similar approach will be used in the upcoming second part of the change
> for DEVICE_INFO DataTypeController and SyncableType.
> 
> The change includes new unit tests for LocalDeviceInfoProvider and
> SessionDataTypeController.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283461

TBR=zea@chromium.org,rlarocque@chromium.org,sky@chromium.org,maniscalco@chromium.org,stanisc@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/401433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283475 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283472 0039d316-1c4b-4281-b951-d872f2087c98

> NaCl: Update revision in DEPS, r13456 -> r13484
> 
> This pulls in the following Native Client changes:
> 
> r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
> r13458: (noelallen) Update and add GN files to build sel_ldr.
> r13459: (jvoung) Remove env cleanser references to obsolete env vars.
> r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
> r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
> r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
> r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
> r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
> r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
> r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
> r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
> r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
> r13470: (dschuff) Update revision for PNaCl r13392->r13466
> r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
> r13472: (dschuff) Build PNaCl with mingw again
> r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
> r13474: (dschuff) Update revision for PNaCl r13466->r13472
> r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
> r13476: (sky) Changes scan_sources not to output on bogus directory
> r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
> r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13481: (hidehiko) Align at 16 bytes for stack for created thread.
> r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> R=jvoung@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283271
> 
> Review URL: https://codereview.chromium.org/390553002

TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/396343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283471 0039d316-1c4b-4281-b951-d872f2087c98

Similar to ChromeOS, non-X11 Linux builds (such as Ozone) do not provide the
filename to URL conversion.

BUG=none

Review URL: https://codereview.chromium.org/394983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283468 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to https://codereview.chromium.org/370813003/ as per request.

BUG=391338
TEST=kInstallDate is still set on startup when it wasn't previously set (and no backup is present in registry)

Review URL: https://codereview.chromium.org/396753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283467 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes a bug introduced with my earlier patch where in we were converting the insets to
a rect incorrectly for converting it to pixels.

This caused border artifacts for some app windows.

BUG=393930
R=sky

Review URL: https://codereview.chromium.org/394013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283466 0039d316-1c4b-4281-b951-d872f2087c98

use_glib=0 can work on some embedded setup that doesn't use glib.

Review URL: https://codereview.chromium.org/387623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283465 0039d316-1c4b-4281-b951-d872f2087c98

for testing.

Merge internal CL: 71210916

R=rtenneti@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/393143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283464 0039d316-1c4b-4281-b951-d872f2087c98

The sample isn't part of mojo implementation, so it
should be outside of mojo:: namespace.

TEST=none
BUG=330467
R=darin@chromium.org, ben@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/393093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283463 0039d316-1c4b-4281-b951-d872f2087c98

* Update to use a single regex with named groups
* Add flags attr to the TIR __init__ function
* Remove references to 'logical name' (use 'label' instead)
* Use @property for attributes
BUG=

Review URL: https://codereview.chromium.org/390143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283462 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces a new class LocalDeviceInfoProvider that is responsible
for providing the local device specific DeviceInfo/cache_guid. It initializes
the data asynchronously and allows consumers to get notified when the data 
becomes available. 

LocalDeviceInfoProvider will allow to remove these responsibilities from 
SyncedDeviceTracker / ProfileSyncService and loose coupling between
ProfileSyncService and a number of SyncableService and DataTypeController 
derived classes.

LocalDeviceInfoProvider is hosted on the frontend thread. Since it needs
cache_guid to initialize DeviceInfo, which is currently available only on the
backend, I updated SyncBackendHostCore and SyncBackendHostImpl to pass
cache_guid to the frontend via OnBackendInitialized.

For the time being SyncedDeviceTracker remains unchanged
and continues to initialize the local device info too. The entire class will be
removed in the Part 2 of the change which will move SyncedDeviceTracker
functionality to a new SyncableService.

LocalDeviceInfoProvider also replaces SessionsSyncManager::SyncInternalApiDelegate
which was previously used to decouple SessionsSyncManager from the specifics of
of the local device info implementation. 
SessionsSyncManager is changed to consume LocalDeviceInfoProvider instead of 
SessionsSyncManager::SyncInternalApiDelegate.
SessionDataTypeController now also consumes LocalDeviceInfoProvider to make sure
that SESSIONS type model doesn't start before local device info becomes available.
A very similar approach will be used in the upcoming second part of the change
for DEVICE_INFO DataTypeController and SyncableType.

The change includes new unit tests for LocalDeviceInfoProvider and
SessionDataTypeController.

Review URL: https://codereview.chromium.org/367153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283461 0039d316-1c4b-4281-b951-d872f2087c98

chrome.input API allows modifying text as an IME, but the warning only says "Read anything you type". It should say "Read and change anything you type".

BUG=388535
R=jww

Review URL: https://codereview.chromium.org/396653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283460 0039d316-1c4b-4281-b951-d872f2087c98

Mojo: get .so from PRODUCT_DIR for packaged apps. This changed when we made them be LOADABLE_MODULEs

BUG=None

Review URL: https://codereview.chromium.org/395993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283458 0039d316-1c4b-4281-b951-d872f2087c98

ART does check covariance of types passed via JNI anyway, causing the VM to
crash if they doesn't. We'd better check this in Java Bridge and throw a
JavaScript exception, as LiveConnect spec suggests.

BUG=392489

Review URL: https://codereview.chromium.org/393733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283457 0039d316-1c4b-4281-b951-d872f2087c98

-----------------Reland Description------------------
Core animation was turned on in M35. The fullscreen window was not layer
backed, but should have been. This original CL exposed this bug.

-----------------Original Description------------------
In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
views (like the tab strip and the profile icon) are placed on top of the title
bar and require special treatment. All other views are added as subviews of
'chromeContentView' in TabWindowController. This allows tab dragging and
fullscreen logic to easily move the views that don't need special treatment.

This CL also removes the instances where a VersionIndependentWindow's
contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
gets passed around as a subview. This allows VersionIndependentWindow to remove
another of its internal hacks.

Original CL link: https://codereview.chromium.org/379293003/
BUG=392239

Review URL: https://codereview.chromium.org/393933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283456 0039d316-1c4b-4281-b951-d872f2087c98

Write would return synchronously but continue to retain the buffer.

BUG=380340,381147

Review URL: https://codereview.chromium.org/396003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/396743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/394683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283452 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283451 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/f459c85457c6f470af3fe096fef2524d5443401a..3944a1d2374d2de8622b0192aa080dba6fb92c76

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/397713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283450 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283449 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
r13458: (noelallen) Update and add GN files to build sel_ldr.
r13459: (jvoung) Remove env cleanser references to obsolete env vars.
r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
r13470: (dschuff) Update revision for PNaCl r13392->r13466
r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
r13472: (dschuff) Build PNaCl with mingw again
r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
r13474: (dschuff) Update revision for PNaCl r13466->r13472
r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
r13476: (sky) Changes scan_sources not to output on bogus directory
r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13481: (hidehiko) Align at 16 bytes for stack for created thread.
r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"

BUG=none
TEST=browser_tests and nacl_integration
R=jvoung@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283271

Review URL: https://codereview.chromium.org/390553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283448 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tmpdiep@chromium.org
BUG=394426

Review URL: https://codereview.chromium.org/396353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283447 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the width in views mode; it doesn't fix it in GTK+
theme. Actually fixing that there is hard.

BUG=393124

Review URL: https://codereview.chromium.org/387313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283446 0039d316-1c4b-4281-b951-d872f2087c98

recent nonces.  This reduces the amount of time that nonces with future
timestamps are tracked, which allows accepting more nonces from clients
with clocks that agree with the strike register's clock.

Not flag protected.

Merge internal change: 69497947

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/389393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283445 0039d316-1c4b-4281-b951-d872f2087c98

TBR=wangxianzhu@chromium.org
BUG=394338

Review URL: https://codereview.chromium.org/395263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283444 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer needed as of r282376.

BUG=370634

Review URL: https://codereview.chromium.org/395943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283443 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/382213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283442 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/396733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283441 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/396783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283439 0039d316-1c4b-4281-b951-d872f2087c98

Since there is only one button, clicking the notification will perform
the same action as the button per PM/designer decision.

BUG=393680
R=atwilson@chromium.org
TEST=manual

Review URL: https://codereview.chromium.org/395463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283438 0039d316-1c4b-4281-b951-d872f2087c98

SessionManager is responsible for performing Chrome OS-specific steps to re-launch user session (after crash/stub or in tests) or pre-session UI such as out-of-box or login.

ChromeSessionManager is chrome/browser implementation of SessionManager.

SessionManager is initialized with specific delegate that is reponsible for initial behavior. These delegates are introduced, see ChromeSessionManager::CreateSessionManager():

* LoginOobeSessionManagerDelegate - launches either out-of-box or login UI,
actual branching still happens in ShowLoginWizard()

* RestoreAfterCrashSessionManagerDelegate - responsible for re-launching Chrome into existing user session,
happens after browser process crash or in "stub user" session.

* StubLoginSessionManagerDelegate - starts "stub user" session, when executed on non-CrOS machine w/o parameters or in tests. Extends RestoreAfterCrashSessionManagerDelegate.

* KioskAutoLauncherSessionManagerDelegate - automatically starts kiosk app session.

Code move in ChromeBrowserMainPartsChromeos:
* OptionallyRunChromeOSLoginManager() -> ChromeSessionManager::CreateSessionManager()
* RunAutoLaunchKioskApp() -> KioskAutoLauncherSessionManagerDelegate
* Session restore code in PostProfileInit() -> RestoreAfterCrashSessionManagerDelegate
* Blocks in OptionallyRunChromeOSLoginManager -> to delegates.

BUG=387610

Review URL: https://codereview.chromium.org/363613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283437 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/398553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283436 0039d316-1c4b-4281-b951-d872f2087c98

all_value_names_that_have_been_seen.

This makes CsvPageMeasurementResults more self contained and allow
special casing of TraceValue (to be introduced) in
CsvPageMeasurementResults directly rather than in PageMeasurementResults.

This should be inline with the direction we are taking towards
OutputFormatter.

BUG=392901

Review URL: https://codereview.chromium.org/381303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283435 0039d316-1c4b-4281-b951-d872f2087c98

Added flag to check if IME state is updated
This will prevent resetting of mFocusPreOSKViewportRect
on onTouchEvent.

So, if cancelRequestToScrollFocusedEditableNodeIntoView()
is triggerred from onTouchEvent()<ACTION_MOVE> and it
happens before onSizeChanged is triggerred, then the
input field will not be scrolled to view.

BUG=393948

Review URL: https://codereview.chromium.org/392943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283434 0039d316-1c4b-4281-b951-d872f2087c98

The CL makes policy fetching for first time login blocking for all users, except the ones that are known to be non-enterprise users.

This CL has the same contest as https://codereview.chromium.org/330843002/ with a code rebase

TBR=joaodasilva@chromium.org

BUG=334584

Review URL: https://codereview.chromium.org/390763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393346
R=yoshiki@chromium.org
TEST=Manually tested with external USB keyboard
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>

Review URL: https://codereview.chromium.org/386043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283431 0039d316-1c4b-4281-b951-d872f2087c98

As the cost of creating download controller instance is not
too heavy its better to switch to eager initialization which
creates a ready to use instance and ensures thread safety

This method has a number of advantages:
* The instance is not constructed until the class is used.
* There is no need to synchronize the getInstance() method,
  meaning all threads will see the same instance and no (expensive)
  locking is required.
* The final keyword means that the instance cannot be redefined,
  ensuring that one (and only one) instance ever exists.
(source: http://en.wikipedia.org/wiki/Singleton_pattern#Eager_initialization)

BUG=None.

Review URL: https://codereview.chromium.org/387333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283430 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283429 0039d316-1c4b-4281-b951-d872f2087c98