- 04 Oct, 2019 1 commit
-
-
Ian Prest authored
When UIA was enabled, Narrator was timing out because it calls TextRange::GetAttributeValue a lot when trying to navigate between paragraphs. This function was iterating using AXRange, which is relatively expensive. However, since we're just collecting text attribute values, we don't actually need to iterate over all the text positions... we just need to iterate the anchor positions. This change also introduces a test-case for GetAttributeValue. Bug: 1011057 Change-Id: I624e5fccefe88918ad289c0185a501ef290bde48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838373 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702644}
-
- 03 Oct, 2019 39 commits
-
-
Aidan Beggs authored
of GetReputationStatusWithEngagedSites to make more sense. This CL removes an extraneous comment about skipping top domains. It doesn't make sense to pass DomainInfo to GetReputationStatusWithEngagedSites, when this method can easily calculate that information, and its caller, GetReputationStatus, never uses this information outside of passing it on. This CL also includes fixes a few transitively included header files. Change-Id: I528d1f22aaee2b46d8758fec2dfa0e7185f3b419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838535Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Aidan Beggs <beggs@google.com> Cr-Commit-Position: refs/heads/master@{#702643}
-
Charles Zhao authored
Some of the tab discarder code are not used any more. (1) We stop recording total_tab_count and mru_index in the ForegroundedOrClosed event because we think it makes more sense to capture these in the TabMetrics event which we are already doing. Related changes include: (1.1) Deprecating MRUIndex and TotalTabCount in the ukm event ForegroundedOrClosed. (1.2) Removing mru_index and total_tab_count from ForegroundedOrClosedMetrics (1.3) Stopping observing WillCloseAllTabs and CloseAllTabsStopped (1.4) Removing TabActivityWatcher::all_closing_tabs_ (2) LogOldestNTabFeatures() is also removed because it is unused. Bug: 1007136 Change-Id: I25a7b9dbd471804d4680db2e95e80646ca1acb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817871Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#702642}
-
Steven Bennetts authored
This will significantly reduce the amount of includes required when building ash_unittests and chrome. Bug: 996418 Change-Id: Ic9988b1d144f0c422b63d68aafcee20f7860e41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836277 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702641}
-
Lukasz Anforowicz authored
There was quite a bit of repetition in ChromeContentBrowserClient::CreateThrottlesForNavigation. This CL helps avoid this, by changing: std::unique_ptr<content::NavigationThrottle> foo_throttle = FooThrottle::MaybeCreateThrottleFor(handle); if (foo_throttle) throttles.push_back(std::move(foo_throttle)); to: MaybeAddThrottle(&throttles, FooThrottle::MaybeCreateThrottleFor(handle)); Bug: 1003957 Change-Id: I6b9d110f101e246b4f8e70b242f8d20798b3aadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838911 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702640}
-
Tommy Steimel authored
This CL makes the dismiss X focusable. This fixes an issue where a user could not dismiss with the keyboard. Bug: 1011062 Change-Id: Id35723360abd4619096f1e3a57ec0c3412af32fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838295Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702639}
-
Robert Liao authored
This is better served with a FillLayout and Bounds Change View Observer. BUG=1005568 TEST=browser_tests AppWindowBrowserTest.* Change-Id: I7c93be420241fc95c67479ae14a6c8a49d075890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827943 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#702638}
-
minch authored
Bug: 1002733 Change-Id: Ia01ca067072f2383b76571afb1ca4f864b60c8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836851 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702637}
-
K Moon authored
The non-layout portions of LoadPageInfo() have moved to LoadPageSizes(), which manages page loading/unloading and computing page sizes. The page sizes are then passed on to the layout code remaining in LoadPageInfo(), which finishes initializing each page's layout rectangle. A future change will take advantage of this split to compute multiple layouts from the same page size information. No test changes, as this is an internal refactoring affecting private methods of PDFiumEngine only, with no publicly testable surface. Bug: 885110 Change-Id: Ie146d17032dc2e482a0ea0ce27b0bab79deeddfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838527 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702636}
-
minch authored
This is an initial cl for back gesture affordance. Many other issues will be solved in following up cls. e.g, fling event support; make affordance can be moved on y-axis movement; affordance should not under frame area, etc. Recorded video: https://drive.google.com/file/d/1p7T-RiHU8nhaKmyAgrqA_bqITkCDBi7p/view?usp=sharing Bug: 1002733 Change-Id: I89c02372babf2d562e56717c7966df2e8e5405f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834826 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702635}
-
Sergey Ulanov authored
Fixes for the following issues in StreamProcessorHelper 1. Inputs packets were released prematurely when resetting the stream. 2. Output packets from previous streams were not ignored. 3. Reset() wasn't resetting the stream. Bug: 1011117 Change-Id: I907590d92a92052bb3ed9518dd17b0eaa668403e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838169Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702634}
-
Christian Biesinger authored
Use decode('utf-8') to turn bytes into a string. This works in Python 2 and 3. Tested by running this script under Python 2 and 3. Bug: 941669 Change-Id: I0cc4e58031f67867f56d37e47e54ef3dd7a49416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838258 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702633}
-
Matt Mueller authored
Bug: 1008994 Change-Id: I2d47ea71df0bca8d68b40f14e85637f85ffee714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838921Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#702632}
-
Yue Zhang authored
This CL exposes methods in TabGroupUtils to use SharedPreferences for tab group naming and adds unit tests. Bug: 1001738 Change-Id: I0d550e82cafe70b1ca7db9534bbc57c597b7d8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837714Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702631}
-
Peter Boström authored
Replaces zero-width GetPreferredSize(). Bug: chromium:992972 Change-Id: I2029887e6e88c5ed76d4163925640ebc449bf404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838996 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702630}
-
Greg Kerr authored
This adds the no-log directive to the iokit property restrictions, and allows two harmless properties to be read as well. Bug: 1008423 Change-Id: I4707befc1f566d109dd4cb5e1e9a116c148edbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835688Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702629}
-
Connie Wan authored
To avoid weird interactions, stop OpenURLFromTab from creating a new group if the source tab is pinned. Bug: 992508 Change-Id: I144cb5c276e386d2a63da96f3b4992e6b1400a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832158 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#702628}
-
Changwan Ryu authored
It is not clear why this only fails on L/M, but BiMap#remove(Object) is derived from Map#remove(Object) and should only accept key as parameter. Bug: 1010552 Change-Id: I00bf337ac1eb88f4868558e8a795f0d131c42657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838158Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702627}
-
Will Cassella authored
These session behave identically to the previous sample ("Magic Window") with the exception that you cannot enter VR, and there are multiple sessions instead of a single one. Change-Id: Ic26649a5576cba3643ff903fc0c12fccbfe2afd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835267Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#702626}
-
Connie Wan authored
Additionally, slightly refactor DetermineNewSelectedIndex() so that it feels less upside-down: handle the "closing inactive tab" case first. Judging by the tests and the way this is called in TabStripModel::DetachWebContentsImpl(), this is the intended order of behavior. I wasn't able to manually reproduce a case where a grouped tab has an opener. I believe this is actually a different bug in groups: when a tab is opened by an opener, it doesn't get grouped. I'll log this separately (it's already in the Remaining Work doc for Tab Groups). For now, I kept the group logic after the opener logic, so that in most cases it will continue to behave as before. From my experimentation, this works as expected when closing multiple tabs at once, including if they're non-consecutive or in different groups. The behavior just falls back to closing one tab at a time, so it will respect the group of the rightmost tab, which is the last to become active (see TabStripModel::DetachWebContentsImpl()). Bug: 992512 Change-Id: I347fc52c0b0a2b5aca84a3ad2e4a6264bf8b11ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834641 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#702625}
-
Min Qin authored
Use content URI will show the download in files app once it completes. Since the target file path is given, there is no need to generate content URIs. BUG=1010451 Change-Id: Icb61e403a25e837400893d114737155d64f35b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838698Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702624}
-
Kyle Horimoto authored
Before this CL, there were several related issues related to connecting icons; sometimes, icons would appear smaller than they should, and other times, icons would grow and/or shrink as they animated. The issue was that network_icon.cc kept four caches for connecting icons: light bars, dark bars, light arcs, and dark arcs. Each time an icon was requested, we'd look to see if one existed in the cache and return it if it existed; otherwise, we'd lazily create a new one. The problem here was that different areas of the UI request different icon sizes (e.g., Quick Settings requires a larger icon than the system tray), but the caches described above were agnostic to size. This meant that if a small icon was requested first, it would fill up the cache for that icon type; then, if a larger icon size was requested later, the same small one would be returned. This made the user-visible bug change depending on what UIs were used in what order, making this bug difficult to reproduce consistently. This CL updates this code to include a cache for each icon size as well as light vs. dark and bars vs. arcs. Bug: 961843 Change-Id: I468542f29eec4e694a6bbfaa8623ebfe78700a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836454 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#702623}
-
John Chen authored
Restore support of file download with headless Chrome on Mac. The feature was previously disabled due to test failures. The cause of the failures has been identified as https://crbug.com/1011000, which only affects Chrome build with unusual combination of build flags (including commit queue, but not normal releases). Bug: chromedriver:2991 Change-Id: I8960f379ba0b536714bad47f72be59841da2ab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838951 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#702622}
-
Chris Blume authored
CompositorFrameMetadata's destructor is empty. It has no special logic. However, because it has a body defined, it is not trivial to destruct. Making a destructor trivial has surpriging benefits. And it is easy to do in this case, since the destructor's body is empty. This CL makes CompositorFrameMetadata's destructor = default. R=ericrk@chromium.org Change-Id: Ia80fc9fe60161f94a452b14f1e6ceb647fb96994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838032Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#702621}
-
Tommy Li authored
Tiny CL that just makes the highlight circular. Bug: 1205, 929477 Change-Id: I92fbd6bc6fd89c087d7cf7755a69cd7f6633b0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838676Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#702620}
-
Dana Fried authored
Text fields used to display cookie data were eating gesture events. This creates a local subclass of Textfield that correctly forwards gesture events to the containing ScrollView to ensure that the cookie data will scroll correctly. Bug: 1008806 Change-Id: I08490549392a03f5ed745077f5dc483d548cd82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838143 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702619}
-
Rob Schonberger authored
3 Utility classes being added: DistilledDevInfo: a distilled smaller version of EventDeviceInfo with the relevant fields for Neural Palm Rejection. Sample: a single Sample based on an InProgressTouch Stroke: A group of samples in multi-touch. We also add thorough unit tests for all 3 classes. Bug: 1009290 Change-Id: Idd7e3f9f6a09dda2bd0d619c7b576fc3d86461be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832951 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702618}
-
Manas Verma authored
Bug: 949269 Change-Id: Ie3365d3b25b7c488c46541eb2119afb05352b3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833043Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#702617}
-
Andrew Grieve authored
Bug: 982762 Change-Id: I9a1e30f452d48489c5a512905ab9ae79842415b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837082 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702616}
-
Fred Mello authored
Make sure that public methods are optimized for APKs. Related to: https://crrev.com/c/1813520 Bug: 1010777, 1005802 Change-Id: I62fdac9b4acd12f5e09de01dc975cbdb5f116b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838141Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#702615}
-
Theresa Wellington authored
- ArrowBubbleDrawable - ImageTextBubble - PulseDrawable - PulseInterpolator - RoundedIconGenerator - TextBubble - ViewHighlighter - ViewHighlighterTest - ViewHighlighterTestUtils BUG=951455 Change-Id: I2dd5b9310e39964df51cf9448194decdc6942ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833792Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#702614}
-
Sven Zheng authored
Bug: 1010568 Change-Id: I4b132eb3609c0fd4df1bf2148856f00774fbac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838161Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702613}
-
Lan Wei authored
Right now, we are dispatch touch events one touch point by one touch point to Devtool input protocol, but Devtool does not group them together as one touch event. Therefore, when we send touch events to Devtool we need to group all the touch points into one touch event and then send to Devtool. Bug: 999982 Change-Id: I11a85625ede0651b920d732a4e1006292f8be0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838138Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#702612}
-
Nate Fischer authored
No change to logic, this just changes explicit calls to the std::unique_ptr constructor to instead use make_unique() or implicit conversion from nullptr. This is to conform with a chromium presubmit check. This makes MetricSample's constructor public for compatibility with make_unique(), and documents the existing static methods are still the preferred way to instantiate the class. This also fixes some indentation problems found by 'git-cl format'. Bug: 1010369 Test: git cl presubmit --upload Change-Id: I734a48629c435a8c31fe15b8a8d3e44352dcae08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834656 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702611}
-
Sebastien Marchand authored
Change-Id: I8cfd7c201e847596d54b750aa24bb7606b2d8498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836019Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#702610}
-
Sammie Quon authored
This cl enables it in a way so that it will be easy to revert this if needed. A follow up will clean up the file a bit once this has been enabled for a while. Test: ash_unittests Bug: 978112 Change-Id: Ie648f965106e6c021c77f039af0112364006e75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833046 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#702609}
-
Ramya Nagarajan authored
This reverts commit 987ed6b5. Reason for revert: Suspect that this breaks android compile. Details at crbug.com/1011149 Original change's description: > Android: Move UkmUtilsForTest.java. > > Moved to a subdirectory of the build target using it. The old location > was confusing because it's in the same directory as non test code. > > Bug: 1010218 > Change-Id: I1de7cd4ec72c7967506ebd8451fcf2b9378a9fe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838522 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702581} TBR=agrieve@chromium.org,estevenson@chromium.org Change-Id: I1302fe15525dec5a281fb69afdd98aa2387d9646 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838973Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702608}
-
Xianzhu Wang authored
Some baselines for mac-mac10.13 were mistakenly manually put under platform/mac-mac10.13 directory after some automatic rebaseline-cl failures. They are moved to platform/mac. The original baselines under platform/mac are moved to platform/mac-mac10.10 and platform/mac-mac10.11 if the baselines under platform/mac-mac10.12 and platform/mac-mac10.13 were the same (which become the new mac baseline). Remove the stale mac-mac10.13 directory. Bug: 1010946 Change-Id: I050cae84bb3d535f9fd5869fedd8fb7778d7b473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837096Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702607}
-
Jazz Xu authored
This CL changes button row layout tree so that play/pause button is always centered regardless the visibility of previous/next track button. Bug: 1010645 Change-Id: Iba274ccd820346885768fa7243ff523313df3632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834899 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702606}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/563be8e7..43e91961 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff0d56d9ca7b68a5e372e207739e2d014184145a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838595Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702605}
-