- 28 Aug, 2020 19 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I18d2a4c4f03409c962452b329cf600d1c3dd07fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802462}
-
Xida Chen authored
These 3 enums are all private, so relatively easy to convert. Bug: 720553 Change-Id: Ide43578b526677b8da9317decd550a12f40d3f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377557Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802461}
-
Xida Chen authored
Bug: 720553 Change-Id: Iebab3e91d11ec674a95928acd9e08ad1dcfba60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378449Reviewed-by:
-
David Maunder authored
Bug: 1122629 Change-Id: Ifa83a9f981551037d16c73907665f2b2faa1323b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380253 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#802459}
-
Yulun Wu authored
Bug: 1110757 Change-Id: I415313e4f1b9279ac4df68243a6b65f12055c092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378801Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802458}
-
Ionel Popescu authored
This CL adds support for the eye dropper on Mac by using NSColorSampler. This approach avoids the security dialog asking for more permissions. Bug: 992297 Change-Id: Ia70d6c4daf3ec678e558ca528b63bfe960363f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378773Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802457}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc61e5a98324..ed2e4739280f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6f29813265daf52c2f6aeccc963aa5ffc7998267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380342Reviewed-by:
-
Mike Dougherty authored
This tab helper was used to analyze potential improvements for detecting users in bad captive portal states. However, it is now no longer being used. Removing it will clean up captive portal and application code to enable easier changes to captive portal code in the future if needed. This CL is referenced from a new README file so that it can more easily be discovered in the event that this functionality is found to be useful in the future. Bug: 1072565 Change-Id: I0aea60632587780150a0d378438a082824d184fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372901Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#802455}
-
Nikita Podguzov authored
This is a workaround for fixing cross references to PrintJob from chrome.printing API. Bug: 1122616 Change-Id: I13185b71bb53a625336aa405f7c41a66f7ce15a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379721 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802454}
-
Esmael El-Moslimany authored
Bug: 1112992 Change-Id: I7f6969c640e71cee455d64373d95f5d14ea48474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366090 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#802453}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ee58da9d6f49..716e281185b5 2020-08-27 herb@google.com use a dense index internally in SkScalerCache 2020-08-27 egdaniel@google.com Make sure we set vk input attachment for case when doing copy. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I62828aacc200568f07b66938cf51029d00ae854f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380874Reviewed-by:
-
tby authored
We want all file results to be returned by the launcher search provider, so let's stop the omnibox provider from doubling up. Cases to handle: - docs.google.com/... urls - drive files - drive.google.com/... urls - drive folders and misc - file://... urls - local files opened in chrome Bug: 1053637 Change-Id: Ia71174969f14f3d34638c611376d6460dee61105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377326 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#802451}
-
Peng Huang authored
Bug: 1108406 Change-Id: Iaca79e3b6c1d66e421711c46f75a1cb614b7f961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378745Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802450}
-
Mohamed Heikal authored
Downstream material design targets are named slightly differently than upstream material design. Remove the final "_material" from the regex in order to also match downstream package names. TBR=just bringing weblayer exclusions in line with chrome's Bug: 1110346 Change-Id: If4588d674db9ef466fb95e4bf2022eed380908b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380087 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#802449}
-
Peter Kotwicz authored
This CL refactors the |webapk_java| resources so that their names do not conflict with other resources in |chrome_public_test_apk| The CL: 1) Makes the resources target that |webapk_java| depends on no longer import app_icon.png This is useful because |chrome_public_test_apk| depends on |webapk_java| and the WebAPK app_icon.png resource conflicts with app_icon.png imported by |chrome_public_apk_resources|. 2) Adds the 'webapk_' prefix to the following resources" - color_black_38 - color_black_54 - color_black_87 - text_size_large - text_size_medium_dense BUG=1093825 Change-Id: Ib8b648dce6ef5008957552df269fe0bc386a94f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371403 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802448}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ed2e4739280f..33a6332a9232 2020-08-27 treehugger-gerrit@google.com Merge "perfetto: add GPU total memory usage datasource in ui control" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3405d4ae2492bdffd3a9476f4dd480c98e82c522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380831Reviewed-by:
-
Anastasia Helfinstein authored
This change allows Switch Access users to navigate the login screen and enter their password by fixing two bugs. 1. On the login screen, there were two copies of Switch Access running. 2. Pending childrenChanged events were being fired on the DesktopNode after it was no longer focused. AX-Relnotes: n/a. Bug: 1121260 Change-Id: Ia4ef3791fbf5480003ded0b1de70dd4df1f5b9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378891Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#802446}
-
Nathan Zabriskie authored
Currently ImageDataBuffer ctor uses PaintImage::GetSkImage which will be deprecated as we move to enable OOPR for Canvas2D. This CL updates the ctor to be OOPR/non OOPR agnostic by using new calls to PaintImage::GetSwSkImage and PaintImage::readPixels which will work in both modes. Bug: 1018894 Change-Id: Iaf5a9af5b4384fd040a75c3db3cc6ffe8a68d736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366036 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#802445}
-
Xianzhu Wang authored
This CL (temporarily) explicitly enable SignedExchanged* for web tests. Two tests under external/wpt/signed-exchange/subresource are rebaselined. virtual/sxg-subresource is removed. This is to sepearte the change of web test expectations from crrev.com/c/2375886 which will enable the feature for web tests by adjusting the application order of blink feature status and chromium feature status. Bug: 1121839 Change-Id: I240be44a74a72604dcecc4aad34c0ca70a4e76e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378738Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802444}
-
- 27 Aug, 2020 21 commits
-
-
Sam Maier authored
This is unused, and now that we have an expectations file this should still be easy enough to audit. Change-Id: Ic48e76ed4e1b90e351c27a350cf82d3f6b0fea6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380576 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Gavin Williams authored
On Chrome OS, the new Save to Drive destination opens the file picker and saves PDFs directly to the local file system like the existing Save as PDF destination. So in most areas of Print Preview, Save to Drive needs to be treated the same as Save to PDF. The two places the destinations diverge are: - Icon display - Setting printToGoogleDrive on the print ticket Bug: 1112416 Change-Id: I3debedc4298408a4de0e2286e0227a47ccb3d2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358691 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802442}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc61e5a98324..ed2e4739280f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9bac7a6557e7c0e64708a17687473bcc97c6d9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380584Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a CHECK_LE(pos, size()) in BasicStringPiece::substr. This attempts to model standard library behavior, since std::basic_string_view::substr throws an out_of_range exception in this case. Reference: https://wg21.link/string.view.ops#itemdecl:2 TBR=dcheng Bug: 1049498 Change-Id: Ie5c946b8cd1b2cb9d7022bfcd5fa2a89372ec31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372445 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802440}
-
Sahel Sharify authored
Bug: 1121021 Change-Id: If656f90953fcc45f53741974dc44fda5314e465c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376455 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802439}
-
Trevor Perrier authored
This CL adds just the feature flag for the Clank language decouple. Three more CLs will add the rest of the feature. The feature flag DETAILED_LANGUAGE_SETTINGS is added to be used for both the initial language decuple and new Android language settings. Bug: 1068667 Change-Id: I9e999f44e6f431bb1f13d16f170d626f8819db45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360591Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#802438}
-
Ken Rockot authored
This reverts commit 5555c98b. Reason for revert: Breaks the build https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-dbg Culprit v8 CL has also been identified, revert here: https://crrev.com/c/2380613 Original change's description: > Update V8 to version 8.7.26. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/1f2195b4..2a00f38a > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I70ddc2d6f35c8ad166a434367ac411099dcf3aa8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378694 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#802063} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibc4d3da3f7d73eff6af4ea1de700e640eb09f443 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380675Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#802437}
-
Matthew Denton authored
BrokerClient::Readlink returns -ENAMETOOLONG if the buffer is too small for the pathname, but this is inconsistent with POSIX which fills up the buffer with part of the pathname, and only returns -ENAMETOOLONG if the actual pathname is longer than PATH_MAX or an individual pathname component is longer than NAME_MAX. Change-Id: I282f2ead6814bbd799e286a6e80ed5991ceeb54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379470 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802436}
-
Anastasia Helfinstein authored
This is a reland of 76c5ef2b Original change's description: > [Switch Access] Move code out from behind flag > > AX-Relnotes: Launch Switch Access on Chrome OS. > Bug: 1016200,1121357 > Change-Id: I464abbeaeb50c8c40adbac4ce51d7d9f038430fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373368 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801947} Bug: 1016200 Bug: 1121357 Change-Id: Ic1b96aa268768a30ea8b5ace11c0925f62494a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380415 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#802435}
-
Malay Keshav authored
SolidColorQuads use a single color for the entire area, thus the same color can be precomputed. This avoids transforming the color for each fragment in the shader pipeline. Bug: 1072895 Test: All viz, cc, and compositor pixel tests pass Change-Id: I27a4d88ff480ab351a105e1fc3e53393beb26903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357852 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#802434}
-
Greg Guterman authored
Bug: 1122771 Change-Id: Icd0922c3dc77aaa175dd81cc753033490e2b71cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380815 Auto-Submit: Gregory Guterman <guterman@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#802433}
-
Azeem Arshad authored
This CL updates network icon in OS Settings so that they don't show cellular technology badge when the network is not connected. This makes it consistent with Quick Settings menu. Bug: 1122137 Change-Id: Iae972215c456ff884f26761174a5d80b1568864f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380580Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#802432}
-
Thomas Lukaszewicz authored
This CL updates the tab controls container in the tab strip to remain fixed while the Tab Search bubble is open. Keeping the tab controls container fixed is necessary to ensure that the bubble does not slide around on the screen with the anchoring button as tabs are removed from the Tab Search UI. This CL also performs some cleanup and removes unnecessary build flags. Bug: 1099917 Change-Id: I28d395f4804175d3ab868d2ea4ae9e3607170571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377550Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#802431}
-
Anastasia Helfinstein authored
As part of sharing more code between the extensions, move the methods manipulating rectangles from select_to_speak into the common rect_util class. This is a pure refactor with no behavioral change. AX-Relnotes: n/a. Bug: None Change-Id: Ic1b47def1b0bc3306799476d3ea722961429eebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376665 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#802430}
-
Avi Drissman authored
The Mac malloc interceptor relies on internals of macOS. Update those internals and links to the 10.15 versions. This relands 994f22b5 with a fix for profiling_client.cc which correctly only includes a Mac file header on the Mac. Bug: none Change-Id: I8132dc1ffeeb0c6b65edb80cc729bcb4836f2121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377983Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#802429}
-
Daniel Cheng authored
This helper is intended to replace |Post()| while also supporting an optional reply callback, à la |base::PostTaskWithReply()|. Q: Why have SequenceBound at all? A: Performing blocking / slow work on a different task runner is a common pattern for improving responsiveness of foreground task runners. SequenceBound aims to make it easy to implement this pattern by making it natural for code running on different sequences to be partitioned on a class boundary. Q: Isn't this just promises? A: No. Promises allow arbitrary composition of asynchronous tasks. This helper is much less flexible: - It only allows one call to be proxied to the managed |T|, and optionally, one reply to be proxied back to the owner sequence. - It does not allow delayed attach of the 'then' callback. - It has no notion of rejection. Q: Why not simply add a |PostTaskWithReply()| method? A: Template parameter packs don't work well in a function parameter list if they are not at the end of the parameter list: sb.PostTaskWithReply(FROM_HERE, &Helper::Method, arg1, arg2, std::move(reply)); will not work unless the template parameters are explicitly specified. Inverting the argument order works: sb.PostTaskWithReply(FROM_HERE, &Helper::Method, std::move(reply), arg1, arg2); but results in code where the arguments are in reverse order. Q: Why replace |Post()| which worked perfectly fine? A: Replacing |Post()| allow base::Location to automatically set as a default argument. This is a minor quality-of-life improvement from: sb.Post(FROM_HERE, &Helper::Method); to: sb.AsyncCall(&Helper::Method); In the future, it's likely the various |PostTask()| APIs will also be refactored to not require specifying FROM_HERE, so this keeps a more consistent API surface in the long-term. Q: Why not use |base::BindOnce()|? A: SequenceBound() does not expose the raw managed pointer value to ensure its internal sequence-safety invariants are not violated. This makes it impossible to use |base::BindOnce()| if the caller wants to bind any arguments. Change-Id: Ib7c48e216c9f99cc84be10af205b205aafde6556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242723 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#802428}
-
James Cook authored
CrOSComponentManager::Unload() calls into code in MetadataTable that assumes that system salt is available. This isn't always true when chrome restarts to apply non-owner flags. Unfortunately the MetadataTable API is synchronous and non-trivial to convert to async. Work around the crash by ensuring system salt is available before attempting to unload the lacros component. Filed crbug.com/1122753 to track refactoring MetadataTable so it doesn't depend on data that isn't guaranteed to be available. in about:flags, restart and let Lacros download/install. Then explicitly set flag to "Disabled" and sign out (not restart). Sign in again. No crash. Test: With non-owner account (secondary user), enable LacrosSupport Bug: 1122674 Change-Id: Idf25ef8955315e92c6f823a0da8f8b65fd0a40c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380320Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#802427}
-
Jinsuk Kim authored
This CL adds new histogram EphemeralTab.CtrPeek that indicates that user interacted with the peeked preview tab to open it beyone peeking state, in contrast to EphemeralTab.Ctr that indicates the preview tab got fully opened. Bug: 1025081 Change-Id: I7555ed9b21cc33d7348b4fd60052b49111fbc596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377029Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#802426}
-
Yuly Novikov authored
Flaky on D3D11 Intel WebGL2. TBR=bsheedy Bug: 1122744 Change-Id: Idb03c637582150acc120e2f13818a0914bb58a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380495Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#802425}
-
Weiliang Chen authored
In viz, the display compositor owns the context provider, and as the display compositor is getting destroyed, the context provider should be destroyed at the same time. Objects created by the GLRendererCopier has been the only ones keeping the context provider alive longer than the display compositor. This change will fail copy requests when the display compositor is getting destroyed. Bug: 1096487 Change-Id: I3cedd70dff42ed7ef9f946ec4b34017d3560df7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253159 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802424}
-
Dan Sanders authored
Change-Id: I922b80ac8b9b67b0500c69ba764d6e4ef4ae266d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380149 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#802423}
-
