- 18 Sep, 2020 40 commits
-
-
Alexandre Courbot authored
Fix a few warnings reported by clang-tidy. BUG=None TEST=Chrome builds. Change-Id: Id3b7249365d8a9c68fcb59e676c35036a219c21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413944 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808279}
-
Omar Morsi authored
Following up on CL: https://crrev.com/c/2190216: Support disabling Chrome OS native VPNs by policy; this CL adds tests that address the internet page changes which were mainly showing a policy indicator beside the button used for adding a new VPN when VPN is disabled by policy. Bug: 1098653 Change-Id: I54c24d74511f528f1e6dd4dc64af81fceec9bdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414239Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#808278}
-
Patrick Brosset authored
The implementation Page.screencastFrameAck method is supposedly here to throttle the frame rate when doing a screencast over CDP. It's supposed to be used like this: on('Page.screencastFrame', frame => { Page.screencastFrameAck({sessionId: frame.sessionId}); }); Page.startScreencast(); But in reality, calling screencastFrameAck or not does not make any difference. The frames are still sent by the backend at the same rate, without waiting. This change fixes the video_consumer code path in PageHandler so it does wait for Page.screencastFrameAck to be called after it has reached the maximum number of inflight frames. Bug: 1126915 Change-Id: I8bc1bc37e48689262b250376879fb9ae726a6700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404113 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808277}
-
Leo Lai authored
Removed the owner password from the EULA screen so the secret doesn't expose to attackers that can physically access the devices; also it makes more clean and secure implementation of owner password feature at chrome os side. BUG=chromium:1109629 TEST=browser_tests, with "--gtest_filter=EulaTest*" TEST=check that the System Security Settings is still available, and the look doesn't change. TEST=check that the System Security Settings doesn't show the owner password anymore. Change-Id: I9ee41263f0e73d6a80afe448c57cc2a2148bd816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409661Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#808276}
-
Anders Hartvoll Ruud authored
This reverts commit 33345bc7. Reason for revert: The death test introduced here doesn't work on several bots, for example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868834693840167792/+/steps/accessibility_unittests_on__none__GPU_on_Mac_on_Mac-10.10/0/stdout Original change's description: > Simplify parsing code in ax_enum_util > > Replace the hand-written code to parse each enum from ax_enums with a > templatized function that builds a map from string to attribute value > on-demand. > > This saves a little bit of manual effort each time someone updates an enum. > > Note that these parsing functions are only used by the automation API. > > Bug: None > Change-Id: I4be5e192041cf0686175a20e68782184295a1f9c > AX-Relnotes: N/A > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404164 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808190} TBR=dmazzoni@chromium.org,dtseng@chromium.org,chrishall@chromium.org Change-Id: I61d62255a981ff119933d6110bd39819dcb7b6d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416357Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#808275}
-
Koji Ishii authored
Add inputs/outputs table for each inline layout phase. TBR=yosin@chromium.org NOTRY=True Bug: 982194 Change-Id: I8a90b87b00dab13f9c06de693d8c808a971eb8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417677Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808274}
-
Tomasz Moniuszko authored
Bug: 546640 Change-Id: Id2685a95d05e621012bb0e9aab6b129e88e57cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391144Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#808273}
-
Naoki Fukino authored
Fling (kinetic) scroll event is notified using pointer.axis_stop event in wayland terms, but the event is not supported in wl_pointer v4. This CL upgrade the version from v4 to v5 to handle the events. Doc: go/lacros-fling Bug: 1105310 Change-Id: I0c1ad3391ba772d2f9e4cacfd60d7db1905958c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404224Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808272}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600387025-1a927353a66c94deef84219e25e017cd673d3d66.profdata to chrome-mac-master-1600408803-f0e40d48b8629d1086dbcdc0a0535ae545c69485.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Icfc0fa9e621fed5fb907271f1ba1e1b03ed52b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808271}
-
Boris Sazonov authored
Changes order of calls in SigninManager - now it triggers an update to the account list before setting the primary account. This way, the list of accounts is available by the time the primary account is set. Bug: 1095128, 1121479 Change-Id: Idc596f99e6899624284b9cc86bdf01320f16b954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416520Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b0c99c387b38..8cf89f57dc90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126301 Tbr: yutak@google.com Change-Id: If2c11686fc5fb960c5941f0a128caa18f29efdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417961Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808269}
-
Johann authored
Converting MIDIDispatcher also allows us to use the HeapMojo wrappers to manage the mojo connections. BUG=chromium:1049056 Change-Id: I1870796a2c99036537f09be71206eeafe59dda11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417468Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#808268}
-
Alex Rudenko authored
The method ResourceStyleSheetText was using stylesheet's href attribute to look up resources stored in the resource_container_. It only worked when the href attribute and the FinalURL() were the same because FinalURL() is used to store resources in the resource_container_. This CL changes ResourceStyleSheetText to use FinalURL() when looking up resources. FinalURL() is the actual URL where stylesheet was loaded from (e.g., after redirects). Fixed: 1128360 Change-Id: Ib2dff7d2c86af582a857493a73f3f9fe27307e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414213Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#808267}
-
Sven Zheng authored
TEST: Locally tested on Nexus 5 device. Bug: 1117345 Change-Id: Ia1690ea4800ab1230aebd60addc92ea4a81af9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417254 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808266}
-
Takashi Sakamoto authored
The initial value: the return value of IsWindows8Point1OrGreater() is not trivial. So this requires thread-safe static-local initializer (i.e. _Init_thread_head) on Windows platform. If using _Init_thread_header on the allocatoin path, causes crash while windows crt startup when using PartitionAlloc as malloc. Bug: 1126432 Change-Id: I922f8211603c499c9e5d7cba8de90f8ce752c29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409655Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1d3589d0a8c9bd4c1851e3386179f9b443db4243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417966Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600387025-8e83821116dd5b4024f7e67a897d35744d6cd04c.profdata to chrome-linux-master-1600408803-cf78b7068fa61ec1aacbec5ee17841a8e2bbd57a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I02ef44edfd7eb4a52701e980e8ea98cb7337a042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417077Reviewed-by:
-
Yutaka Hirano authored
On network::QuicTransport it is difficult to satisfy the requirement of ArmingPolicy::AUTOMATIC written in SimpleWatcher: // NOTE: It is important when using AUTOMATIC policy that your // ReadyCallback always attempt to change the state of the handle (e.g. // read available messages on a message pipe.) Otherwise this will // result in a potentially large number of avoidable redundant tasks. Use ArmingPolicy::MANUAL instead. Bug: 1129597 Change-Id: Ic7170458687b3086eb212cce987e6ce676ee4ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416154 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#808262}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/795fa782ca1a..ec598d5b00eb 2020-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0a8a3ea25b36 to 8d4331eeb5ea (13 revisions) 2020-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 70a60d85 to 33c87dad (467 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: angle_deqp_egl_tests --gtest_filter=dEQP.EGL/functional_query_context_get_current_display_rgba8888_window* --use-angle=vulkanTest: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest*/*Test: Test: angle_perftests --gtest_filter=GenerateMipmapBenchmark.Run/vulkan_webglTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/*Test: Test: dEQP-GLES3.functional.fbo.blit.default_framebuffer.*_linear_* Change-Id: I8e7ba3d468efc128ed63b639b3015e5cfc5bbcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417956Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ac3765e663cd..d6498a41ab4e 2020-09-18 hao.x.li@intel.com Query API: Timestamp Query on Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If9a7928acf17257ea83f6c668b796ed4d69e2f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417958Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd0862c6..e6a7fb53 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1283d81408c7c7698c8e516be7e84eb64cbe2ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417854Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808259}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02cb3385f611..3a2a14855653 2020-09-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c768fd8eab63b2dc04ff0cca95c7e6ea30e4075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417957Reviewed-by:
-
Omid Tourzan authored
It will be used to add/change 3 parts of the Files.app UI by SinglePartitionFormat flag: - Directory tree/Gear context menu for Format and Partition device - Format/Partition dialog warning text - Format/Partition dialog confirm button Along with new feature strings, it changes existing format dialog strings (warning text and confirm button). They will be used with the same flag. Bug: 491043 Change-Id: I35ad96e64605e50c4367338898d7e63e1e76ada0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379338Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808257}
-
Clovis PJ authored
Bug: 1113721 Change-Id: I79132bdf3ea1f276994932e8e6a882c60d8ea946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364618Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clovis PJ <clovispj@google.com> Cr-Commit-Position: refs/heads/master@{#808256}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4183.84-1598870250-benchmark-87.0.4247.0-r1 to 87-4247.0-1600077656-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8ba69e6b509437b6dfdb8c6ff9670989295e8cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417965Reviewed-by:
-
Muyao Xu authored
Bug: b/155648481, 1128722 Change-Id: I63c1c64e6ac6e1e5dd74dc33853805c8d57d3893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412973 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#808254}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I4b1c212368b3b5844d0c49b403a2594dc04b5250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418011Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#808253}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4183.84-1598867895-benchmark-87.0.4247.0-r1 to 87-4247.0-1600080536-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I715ce3210cc2097554fc0d291579495bc2398858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417964Reviewed-by:
-
Nektarios Paisios authored
Changes AXPosition::MaxTextOffset so that it fails gracefully when given a non-supported object type The NGOffsetMapping class in Layout NG does not support calculating text offsets in elements of type other than atomic inline level, out-of-flow and text. This patch enforces an even stricter version of this condition in AXPosition::MaxTextOffset, namely that the layout object should be only of type text. This avoids a bad type cast which was causing a security bug in Blink. A followup patch will thoroughly test the remaining object types, namely atomic inline level and out-of-flow, before possibly adding them back. As a second improvement to the resiliency of the code base, this patch updates AXPosition::IsValid. Previously, AXPosition::IsValid() would DCHECK if called at the wrong document lifecycle stage, i.e. when the document is not active. Also, it would DCHECK when the document attached to the AXPosition has a dirty layout tree. The reason for this behavior is that in both of the above cases the user of the AXPosition is clearly doing something wrong, because AXPosition objects should not be created and used at the wrong document lifecycle or when the document layout is not clean. This patch makes IsValid to also return false in the above cases. AX-Relnotes: n/a. TBR=dmazzoni@chromium.org Bug: 1124661 Change-Id: Ic1ab3654ce9c37051bd001802bb81d569792e678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414251Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#808251}
-
Rob Buis authored
This CL makes unknown elements in the MathML namespace have display: math (instead of display: inline). This makes the HTML sanitizer (relying on the layout object's display in several places) behave differently i.e. it does not filter out these elements and their attributes anymore. However, this is ok because these elements are not treated as HTML/SVG. The clipboard test is changed to check that nothing is style/executed. Bug: 6606 Change-Id: I15b1df448c2bdee46c4a36c48a4cfb27d7828ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397949 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#808250}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32de9efebce4..68c424fe4240 2020-09-18 syoussefi@chromium.org Vulkan: Workaround oldSwapchin bug on Android 2020-09-18 jmadill@chromium.org Guard against data race with MemoryProgramCache. 2020-09-18 syoussefi@chromium.org Vulkan: Add perf warning for mid-RP clear 2020-09-18 syoussefi@chromium.org Vulkan: Free up 5 bits in RenderPassDesc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I4d1f510964888b1b4f9e9990326c19e91649a069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417954Reviewed-by:
-
My Nguyen authored
Strings updated according to: http://go/cros-lang-settings-ux-writing Figma: http://go/cros-lang-settings-figma Spell check view: http://screen/6MFsoL4rUAf8Zg7 Customise spell check view: http://screen/AzuM66T9pEtnBWH Bug: 1113439 Change-Id: I617403ef016c0d3dc7e2b10564522d0c6304f263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417428 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808248}
-
Yoshifumi Inoue authored
This patch changes |NGConstraintSpace::ToString()| to use |BfcOffset()| to avoid using invalid union field |bfc_offset_|. Change-Id: Ic79ae585622135c6d1b28dc75597fe0a404d1143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417784 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Maggie Cai authored
activity. Currently when sign in with GlobalProtect on the web, the code try to launch with the activity that stored in the app info. However this causes a bug when try to sign in with GlobalProtect, most likely because the intent filter is not registered under the default activity. Remove the default activity assignment to fix this issue. BUG=1126183 Bug: b/164976626 Change-Id: Ie0a75801d0739a0a2638573bff0a36045c25bd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416433 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#808246}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4183.74-1598869788-benchmark-87.0.4247.0-r1 to 87-4247.0-1600076215-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1b93e5cc731c5772a39a17dcb4710f8b4027121f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417963Reviewed-by:
-
Christopher Cameron authored
The capture process knows nothing about whether or not hardware acceleration is enabled, and cannot therefore be told not to send GpuMemoryBuffers when there is no GpuMemoryBuffer support. Add a path whereby a media::VideoFrame can be created to wrap an IOSurface-backed gfx::GpuMemoryBufferHandle. This will be used when the capture process gives Blink a GpuMemoryBuffer handle, but there no longer exists hardware acceleration support (because of being disabled statically or dynamically). Bug: 1125879 Change-Id: Id87ca3d832e68a3501ed12540d3d265f23cd0362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415575 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#808244}
-
Eric Willigers authored
Tests in https://chromium-review.googlesource.com/c/chromium/src/+/2405034 failed CSS-COLLIDING-TEST-NAME, which would block export. TBR=andruud@chromium.org Bug: 2405034 Change-Id: I515449b1c52d7c1ee974472e77c2265569a9ddb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417785Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#808243}
-
Alan Cutter authored
Previously if an offline_manifest was specified for a default web app the install flow would immediately use it. This CL adds an only_use_offline_manifest config parameter that says whether to attempt a network install first or not. This allows default web apps to prefer networked install to acquire an up to date manifest and only use the offline_manifest if the user runs into network issues. Bug: 1119710 Change-Id: I9ecee5e105e22388a070247762bf450745098acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413607Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808242}
-
Alex Rudenko authored
This CL removes InspectTool::Dispose method that was never implemented by any of the tools. Change-Id: I5c8c3dea03a0b98f6915f31120f66ab8760c3428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417891Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#808241}
-
Kent Tamura authored
This CL makes SliderPosition() in layout_slider_track.cc a method of blink::HTMLInputElement. This change will help to share the code between the legacy layout and LayoutNG. This CL has no behavior changes. Bug: 1040826 Change-Id: I65bb04e8808820a812a4fabb82a7bf24c5f66341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417780 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
