GitLab

cc and viz pixel tests each have constants for which renderer type to
use. Combine them and move them into the viz namespace.

Both test suites also add some GN defines to determine which renderer
backends are available for this configuration. Combine them and convert
to buildflags.

Bug: 1047820
Change-Id: I3226f75feb5e34c205a30b989c545a3aaeb6f283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390941Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804365}

Diagnosis for crbug.com/1123083:
It crashed when UIsManager tried to access CPRImpl#mClient which is
null after CPRImpl has closed. Since CPRImpl is not supposed to be
used after closed, UIsManager should not use PaymentUIsObserver
(implemented by CPRImpl) after CPRImpl is closed. However, the original
didn't allow CPRImpl to inform UIsManager of CPRImpl's closing, nor
should it because UIsManager is responsible for PaymentUIsObserver not
CPRImpl.

Change:
UIsManager no longer accesses CPRImpl directly. Instead, PRImpl is
used as middle man to handle it. The reason is that since CPRImpl,
PRImpl, UIsManager are structured in layers (low to high), CPRImpl
and UIsManager should not be aware of each other.

Acronyms:
CPRImpl = ComponentPaymentRequestImpl
UIsManager = PaymentUIsManager

Bug: 1123083

Change-Id: Iaafd1827691031c55f30731f1ac7f6bec8ddbe9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392757Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804364}

This is in preparation for launch. Metrics report:
https://docs.google.com/document/d/1QmvnzeFeFOHx4Bk0MwQCJ261sYSqgrrFFUQUQB4ecUI/edit

Bug: 964049
Change-Id: I5c97ca2dd4c5f00a9340c64261e33fd8213d6b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391644Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804363}

This policy controls the ability of cross-site images to trigger auth
prompts when a page is loaded. The policy applies only to images, and
applies to all HTTP authentication types (Basic/Digest/NTLM/Negotiate).
This CL updates the policy description for accuracy.

Bug: 1124044
Change-Id: I82f53e5ca644d39506f94e91a2a0442a5682069a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390857Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#804362}

This CL moves some abort-related PageLoad metrics to be recorded on
ReportAbortMetrics() instead of RecordPageLoadMetrics() because the latter is
called the first time the page becomes hidden, or never if it starts hidden.
Since we use these metrics as filters for our abort metric and our definition
does not exclude pages that start hidden (it only excludes pages that are never
foregrounded), we move these metrics to ReportAbortMetrics() so that we can
reliably use them. The metrics moved are:

* Navigation.PageTransition
* Navigation.PageEndReason2
* Experimental.Navigation.UserInitiated

Bug: 1123972
Change-Id: I7bef04f7d44644b6966595518118633027625562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390460
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804361}

This test is already flaky and now also times out. Importer tries to add
the timeout as a separate line instead of combining it with the existing
line, which causes a lint error.

TBR=smcgruer

Change-Id: I0046597b917746e5ec8e7110025f1507adf74582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391205Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804360}

These tests were disabled for flakiness. They passed 3000
iterations on the bots without flaking. One test fails
consistently on the LaCrOS bot and is disabled for that
build configuration.

Bug: 69215, 108493
Change-Id: Ie93c5949520c39c7b1ec8439f442722795535fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376463
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804359}

We've decided to abandon system modality on non-ChromeOS platforms, so
always use window modality for this dialog instead. Some minor cleanups
of DownloadInProgressDialogView are included in this change.

Bug: 1121132
Change-Id: Ia1e5efaa63a38a0f97608253ee688b08b8a86a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377989Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804358}

Bug: 1123704
Change-Id: Ifb025407075376c7046c79e361bdc4c690db905d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386843Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804357}

We try to unregister NetworkCallback in cases where one was never
registered due to an earlier failure. This fixes that.

Fixed: 1121933
Change-Id: If0a3a9db5d64197e8bad11df8bc53d8433692d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392742
Commit-Queue: Ken Rockot <rockot@google.com>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804356}

Validation: Test passed locally
Bug: 1102144
Change-Id: Iee4dcf7dc58d103b3ef26e7c86950293645ccad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392406Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Xiang Ji <jxiang@google.com>
Cr-Commit-Position: refs/heads/master@{#804355}

Bug: 1099917
Change-Id: Ie496c68ea5fbcc05eb803da4a74fcd3f2eaadd88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392764Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804354}

Fixed: 1123803
Change-Id: Ibf8a56c667ca469d0e4679c7be9e88f682446848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389343
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804353}

There's a weird split of responsibility between RenderWidgetHostImpl
and RenderWidgetHostViewBase, both of which are used for all platforms.
This merges some responsibility up to RenderWidgetHostImpl for the
OnRenderFrameMetadataChangedAfterActivation() event.

R=avi@chromium.org

Change-Id: I2349391493b1bb1e71393c5a7bb34e931d650527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392620
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804352}

Skew tests are being added for the following versions:
1, 85.0.4183.81

TBR=estaab@chromium.org

Bug: 1041619
Change-Id: I5a9d7b39a0ac540fe0389cb788d6b81ed860c768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392981Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#804351}

Adds deep links to the Printing Page and the CUPS Printers subpage. Adds
a new test for the Printing Page.

Bug: 1084154
Change-Id: I2695fb9817a29ec7bcbd9c42b141cff0bad7dd4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391603Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#804350}

This method is just for tests, and they can find the value by using
a RenderFrameSubmissionObserver.

R=avi@chromium.org

Change-Id: Id73446e782953f8c4e94dad0c91cd37acd16b434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390855
Commit-Queue: danakj <danakj@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804349}

https://imgur.com/a/8EY34XX

Bug: 1123227
Change-Id: Idf4d10b8b4a9652df8fb8876ad7b0d497e289347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390996
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804348}

The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568
that properties like 'text-align' that don't apply to ::marker, should
not be able to affect the ::marker via inheritance when set to an
ancestor.

Therefore, this patch sets 'text-align: start !important' in UA origin.
The specific value is not much important, since inside markers are
inline boxes unaffected by 'text-align', and outside markers are usually
sized with shrink-to-fit. It only matters in case of outside markers
whose text contains newline characters, or in quirks mode when the
marker is forced to occupy the whole line.

Additionally, since 'text-align' has been implemented as a longhand
rather than a shorthand of 'text-align-all' and 'text-align-last', this
patch also sets 'text-align-last: start !important'.

Bug: 1031667

TEST=external/wpt/css/css-pseudo/marker-text-align.html
TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js

Change-Id: Ibe8d72d4675c5d1e3b0ceedf3acc615e1514fe7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391242Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#804347}

Bug: b/167434069
Change-Id: I57d5caef848498563e7932114cd880204b73c975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391736Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804346}

Bug: 1093066
Change-Id: I2cfb8124ee962c57c253771e10538e993337f85c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354829Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804345}

This CL adds an array of |Attachment| in MetadataMessageData so that the
back end can send the pp::VarArray of attachment information with the
rest of the metadata to the front end, and then stores it.

Bug: 177188
Change-Id: I676c8ecf86321eb0cbd2d95f328d76ed5eec0e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335032
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804344}

Uses the decision logic documented in the bug to decide which type of
probe to do, if it is needed.

The HTTP probe functionality is left intact, with an experiment flag to
force its use instead of a TLS probe.

Bug: 1115731
Change-Id: Ia93436cf3e0ef94d7ca9b2e5131a24c965f0b2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376566Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804343}

This feature will show the printer status icons on the Print Preview
destination dialog page.

go/printer-availability-destination-dialog-design-doc

Bug: 1123754
Change-Id: Iae8c761193397ec18d4e7c3b177fd39a6b31013d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388268
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804342}

https://webrtc.googlesource.com/src.git/+log/ea8f739bce40..c94650d88fd7

2020-09-03 mbonadei@webrtc.org Remove AudioProcessing::SetExtraOptions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I0e28defc353717c8b800a2ce757064dcd85ff8ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392663Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804341}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009030800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/zwRP_oB_FFojw9A51kcgFuTt7F2XMAF7nY9G1H61DPsC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/165878563
Tbr: media-app@grotations.appspotmail.com
Change-Id: Ia1f3b48e556f1a6059b8586cd48620236661d96f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392674Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804340}

This moves the query for 3D API blocking policy back to the IO
thread with the document URL provided by the renderer again. The
IO thread is used to reduce sync IPC hangs in renderers using
WebGL, and the origin is trusted from the renderer (a) to avoid
racy coordination between IO and UI thread and (b) because this
is not a security-sensitive decision.

Fixed: 1119941
Change-Id: Ica47eb137c1e28a7e754b753f2356266e8b9d659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380345
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804339}

Change-Id: I84c31c97a340011c42642810425c3e9676e27eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995877Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#804338}

This reverts commit 1af1bc07.

Reason for revert: Blocking the Chrome on Chromeos uprev.

https://bugs.chromium.org/p/chromium/issues/detail?id=1123901#c6

Original change's description:
> arcvm: Start arcvm-adbd on starting ARCVM
> 
> This CL depends on the following CLs:
> https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2380431
> https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2378806
> https://chrome-internal-review.googlesource.com/c/chromeos/overlays/project-cheets-private/+/3238221
> 
> BUG=b:166314117
> TEST=arc.Boot.vm still passes, arcvm-adbd runs
> 
> Change-Id: I385a807d84a98b4a97dcc66daf6bef5881eef2bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380733
> Commit-Queue: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803035}

TBR=yusukes@chromium.org,hidehiko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:166314117
Change-Id: I30644f24fbe139330a54e88aefc1b73c0340340e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392625Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804337}

The basename suffix '_test_helpers' (with an 's' at the end) gets
special treatment by audit_non_blink_usage.py: like other test code,
it's exempt from the audit. This came up when trying to use
the css_test_helpers namespace in a new animation_test_helper.h/cc
util, which was frowned upon by audit_non_blink_usage.py.

This CL also wraps the functions in a animation_test_helpers namespace.
This is just something I recommend, and not strictly required. (It
makes it less risky and more acceptable to add new helpers with
"common" names, like CreateAnimation).

Change-Id: I627fa6987c5dfad9b7c1d1452de10b07ee9b8ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391221Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804336}

https://android.googlesource.com/platform/external/perfetto.git/+log/5383c636752f..f39c62ab1284

2020-09-03 fmayer@google.com Merge "Check if target process has exited first."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ie1bbf442efcee24948b266e82ae38a88fc0757a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392719Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804335}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/600d59e343a0..fa82803f46aa

2020-09-03 madigens@gmail.com * ChangeLog: Add entry for last commit.
2020-09-03 dalboris@gmail.com Export version info (#58935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I11ce70217ed73add9f3600415a200da959f13f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804334}

When the touch-selection context menu is re-shown after moving one of
the selection handles, it goes through RenderWidgetHostViewAndroid which
always sends the request to the mainframe renderer, which is incorrect
when the selection is inside an OOPIF.

This CL fixes it by having TouchSelectionControllerClientManagerAndroid
route the request to the manager's currently active client. If the
selection is in an OOPIF, then TouchSelectionControllerClientChildFrame
will handle it.

We still need to develop tests for touch handle movements & context
menus, both for OOPIFs and main frames.

Bug: 977215
Change-Id: I3649af49839778fea4462b35b1b11349e00edcc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382227
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804333}

Fixed version with integration test to guard against the bug that
required the revert.


Original message:

Use IncognitoTabModelObserver to break IncognitoTabModel->.incognito

Two new classes IncognitoNotificationPresenceController and
IncognitoProfileDestroyer now bind the TabModelSelector to the
.incognito package, controlling respectively the incognito notification
and the incognito Profile destruction.

Since TabModelSelectorBase creates the TabModels only after native load,
it acts as a relay for the events. It is changed to recognize that there
are two TabModels, one normal and one incognito, so it can observe the
incognito one.

Splitting IncognitoTabModel into interface and impl keeps tests from
having to depend on IncognitoTabModelImpl.

Bug: 1109013
Change-Id: I04421e2f58e7ab498fbab31657175ee5e2c310b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378733Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804332}

If the <munder>, <mover> or <munderover> elements have a computed
math-style property equal to compact and their base is an embellished
operator with the movablelimits property, then their layout algorithms
are respectively the same as the ones described for <msub>, <msup> and
<msubsup>. In this CL we delegate to the scripts algorithm which is
changed to be able to handle script types over, under and underover.

This CL does not handle embellished operators as defined [2] but just
the first case, i.e. <mo> elements but not the two other cases, to
simplify this CL.

To handle dynamic changes to the movablelimits attribute on <mo>
UpdateFromElement is implemented on LayoutNGMathMLBlockFlow.

To handle dynamic changes to attributes (like displaystyle) on math
elements UpdateFromElement is implemented on LayoutNGMathMLBlock.

[1] https://mathml-refresh.github.io/mathml-core/#children-of-munder-mover-munderover
[2] https://mathml-refresh.github.io/mathml-core/#embellished-operators

Bug: 6606
Change-Id: Ib4af58ed88b7d41944f4d4676bba812c3b7a3a2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383023Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#804331}

Rerecord the tests on Mac OS.
Upload the rendering_desktop_e0cf9b9bd8.wprgo to chrome-partner-telemetry.
Unzip the wprgo file to make sure the expected URL
"http://kenrussell.github.io/webgl-animometer/Animometer/tests/3d/webgl-indexed-instanced.html?webgl_version=2\u0026use_attributes=1\u0026use_multi_draw=1\u0026num_geometries=120000"
appears.

This should fix the request failure issue on current perf bots.

Bug: 890539
Change-Id: I4f409d4304cc910c81f4275780d3578c195349ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391595Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#804330}

https://imgur.com/a/OxpFoac

Change-Id: I07d79f0b682cf8da7ca1416a7882d34b560ee767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390963Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804329}

print_class_dependencies.py is used to audit deps, and normally we look
at outbound deps and inbound deps at different points and in different
situations.

Change-Id: Ie331b7502ff09827a3ddf08a6c2cc3b8d7183b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391593
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804328}

This CL adds extra logging to NavigateToURLInSameBrowsingInstance that
was blamed for the first failed test assertion in the log stored in
https://crbug.com/859487#c3.

This CL doesn't contain any actual fix for the flakiness, but reenables
the test anyway, because
1) the test passed 50 times when run locally
2) hopefully the extra logging will help diagnose the flakiness if the
   test starts flaking again on the bots

Fixed: 859487
Change-Id: I90caf66b0ffbbd341a5c8cd00a5605d509aa31d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390998
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804327}

This is a reland of 0ad6a0b8

This CL fixes the _partial_java rule, which was failing due to
android resource issues in the original CL.

Original change's description:
> Replace AndroidX Preference[Dialog]FragmentCompat with the version from master
>
> This CL replaces the PreferenceFragmentCompat and
> PreferenceDialogFragmentCompat classes in the AndroidX preference
> library with the version from master, which has a change needed for
> WebLayer. The preference library maintainers say they won't create a new
> release just for this fix, so to get it we'll have to pull it in
> ourselves.
>
> Bug: 1092986
> Change-Id: I0e1c936f6372cb541cabfa29c2aea0d0ee7225fb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253029
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802334}

Bug: 1092986
Change-Id: I3330d3d5f9f9c1732cc853a8a3ab5fb59595a4a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382617
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804326}