- 01 Aug, 2019 40 commits
-
-
Taylor Bergquist authored
This requires notifying layout_helper_ when a tab is being destroyed, and TabStripLayoutHelper to step carefully around closing tabs in a few places, but saves more complexity by not duplicating state between TabStrip and TabStripLayoutHelper. Bug: 958173 Change-Id: Iaeafc2391ecac0397947ccc34ddaecf853feb787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725271 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#683380}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e33a7e91b89..5833269d4277 Created with: gclient setdep -r src-internal@5833269d4277 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ia7bb304416e85f3286e941b00efa999309fe0850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731781Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683379}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46c53596. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I9d473295c249178d077aad3e0d789a13249a1fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683378}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Bug: 968369 Change-Id: If7ea7b08af65702c7c972f2e10bd1fa290587306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705890 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#683377}
-
Daniel Clark authored
An <input type='tel'> should have LocalizedControlType of "telephone" per https://w3c.github.io/html-aam/#el-input-tel Currently its LocalizedControlType is "edit". This change updates it to "telephone" by adding an entry to BrowserAccessibility::GetLocalizedStringForRoleDescription(). Bug: 988138 Change-Id: I880df88fe45208e2a0bb296a1541599228ff73cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721033Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#683376}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/3101bd58464a..d289a55e46ff git log 3101bd58464a..d289a55e46ff --date=short --no-merges --format='%ad %ae %s' 2019-08-01 zoddicus@users.noreply.github.com Only use -fPIC on compilers that support it (#772) Created with: gclient setdep -r src/third_party/shaderc/src@d289a55e46ff The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I699f58472bb7349d308620a8a84d7eb33f83b65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683375}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69c9ca09..b0db4f56 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia96f03cf868819ab97413e8b5337f2ddc784fcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731709Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683374}
-
Yuly Novikov authored
Since Linux FYI Release (NVIDIA) now runs the same OS and driver. Move gpu_skia_renderer_vulkan_telemetry_tests and gpu_blink_web_tests_vulkan testing to "Linux FYI SkiaRenderer Vulkan (NVIDIA)", where they belong. TBR=kbr Bug: 978103, 908932 Change-Id: Ibc48e7925c71de048e08b411cba9b6e131ed32cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730600Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683373}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80e7bd03d473..c711a8649301 git log 80e7bd03d473..c711a8649301 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 michaelludwig@google.com Combine erode and dilate implementations Created with: gclient setdep -r src/third_party/skia@c711a8649301 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: Iff533e7316d9d671bf93e249c376e8c6419aeebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730587Reviewed-by:
-
Hiroshige Hayashizaki authored
To enable to reference `sourceContextList` when checking results. Bug: 906850 Change-Id: I6d27ac081cef1f2cfa3d387a2a448833aa424694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725258 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683371}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5dd6b1e0a5ef..d014b3d5541d git log 5dd6b1e0a5ef..d014b3d5541d --date=short --no-merges --format='%ad %ae %s' 2019-08-01 eashanbhatt@google.com cros_chrome_sdk: Delete --require-exact-version 2019-08-01 bmgordon@chromium.org cros lint: Remove deprecated shflags arg Created with: gclient setdep -r src/third_party/chromite@d014b3d5541d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Idd91a34376401a3af5e4639e5a696b82b52a8362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730584Reviewed-by:
-
Nate Fischer authored
No change to behavior, because the legacy net path is no longer supported. This trims out usage of URLRequestContext/URLRequestContextGetter in the Safe Browsing component. This is only used in the legacy net path, so it's safe to remove entirely. This updates chrome/ and AW/ to no longer pass values for URLRequestContextGetter. Bug: 989709 Test: autoninja monochrome_apk (both chrome & webview compile) Test: Manual - start up chrome for desktop, verify SB on http://testsafebrowsing.appspot.com Test: Manual - start up webview demo app, verify SB works Change-Id: I84a39cdee3b0703ebf401f565a73ef590d82ef74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730252Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683369}
-
Maksim Ivanov authored
Introduce an intermediate layer between the PinDialogManager and the RequestPinView, so that the Chrome OS PIN dialogs manager class is abstracted away from the Pin Dialog UI implementation. This change allows adding in follow-up CLs the support of different PIN Dialog UI implementations - for the Chrome OS Login/Lock screens. Bug: 964069 Change-Id: Ia7130ce76fb007b61daa51e513d62bfa4e6ba590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710556 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#683368}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6d82d95f2dd0..077eb792907f git log 6d82d95f2dd0..077eb792907f --date=short --no-merges --format='%ad %ae %s' 2019-08-01 tsepez@chromium.org Break dependence of cjs_document.cpp on fpdfapi/font. 2019-08-01 tsepez@chromium.org Rename CPDF_Font::GetBaseFont() to GetBaseFontName(). 2019-08-01 tsepez@chromium.org Break dependence of fpdfapi/page on fxcrt/fdrm. Created with: gclient setdep -r src/third_party/pdfium@077eb792907f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ic8b4dbc8889530f92c6d475967a2248c327931a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730583Reviewed-by:
-
Wez authored
Temporarily filter some tests which fail due to broken getsockname() semantics on connect()ed UDP sockets. Bug: 989223 Change-Id: I5ddd5783d33ce84999cced12f273d3680f56fae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730653 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683366}
-
Shakti Sahu authored
Bug: 989821 Change-Id: Iaf03ae1d1dbf8fb7a97dba470e4001b3af7f3906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730511 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683365}
-
Nina Satragno authored
Add the `AddCredential` command to ChromeDriver. A draft of the proposed addition to the specification is available at https://github.com/w3c/webauthn/pull/1256 This is one in a series of patches intended to create a Testing API for WebAuthn, for use in Web Platform Tests and by external webauthn tests. For an overview of overall design, please see https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing Bug: 922572 Change-Id: Id9b9fb75ab6682126d5d1275b12785640b7f0053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729963 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683364}
-
jonross authored
This adds skia_renderer_isolated_scripts to chromium_linux_rel_isolated_scripts. This will add the tests to Linux Tests on CI, and linux-rel on CQ. TEST=skia_renderer_swiftshader_blink_web_tests vulkan_swiftshader_blink_web_tests Bug: 984120 Change-Id: I3c92d414a0c0aba97e93fc2ad299fd5fee8ecb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731015Reviewed-by:Aaron Gable <agable@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#683363}
-
Vladislav Karnaukhov authored
This CL fixes a typo in the hardcoded path for OEM third-party libraries. Bug: internal b/138659261 Change-Id: Ia3d6aeab4e9bc116ac21aeedf47672d14d89acff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731545Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#683362}
-
Tsuyoshi Horo authored
Bug: 989868,924416 Change-Id: I7b19d9e9332df1472e0511a9a410d4e3331e9f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730832Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683361}
-
Anna Malova authored
To support multiple profiles we need to ensure the 1:1 relationship between counterparts. Native object creates its Java counterpart. Move AwTracingController from AwBrowsingContext to AwInit because TracingController should be per-app and not per-profile. Bug: 963875 Change-Id: I7e6523bbd83b460a94bed65022b3064c554088e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708930Reviewed-by:
-
Kevin Babbitt authored
MaxTextOffset was computing the total text string for a given node in UTF-16 just to obtain its length. Taking the length of std::string is a constant-time operation, so eliminating this effort reduces the scale factor from number of characters to number of nodes. On a simple test page this led to a 24% speedup in MaxTextOffset which is used by a variety of TextPattern methods. Bug: 970297 Change-Id: Ie40e8032b72a45510a2a9ee6bc0e4c4cf5564627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730094 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#683359}
-
Ken Rockot authored
This CL introduces a new content.mojom.ChildProcessHost interface to complement content.mojom.ChildProcess. Together these interfaces now support generic requests to bind interface receivers between the browser and any child process. In preparation for the removal of the "chrome" and "chrome_renderer" services and ultimately the removal of the Service Manager, this migrates spellcheck mojom interfaces off of aforementioned services and over to the new, more direct Content APIs for binding interface receivers. Bug: 977637 Change-Id: I277753b83b9c83715bac5595854edbae075ab2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730730Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#683358}
-
Kevin McNee authored
The comment mentions the need to update |last_committed_entry_index_|, but this is not done. It looks like this was introduced here https://codereview.chromium.org/7078002 where the update needed to happen for the replacement case, but now this code is not reached when replacing due to https://codereview.chromium.org/1245433002 Bug: None Change-Id: Ia3386cb8893702b79295213b82ec2d671a17d792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729798Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#683357}
-
Emircan Uysaler authored
Bug: 989759 Change-Id: If39223de6950027ca1183aa0c2a6d4bde786daa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730776Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683356}
-
Hiroshige Hayashizaki authored
Currently, policy deliveries (and thus <meta>, HTTP headers) in top-level Documents are processed by `handleDelivery()` methods, which accept only one policy delivery. This CL - Merges `handleDelivery()` methods into a single `handle_delivery()`, - Introduce `util.PolicyDelivery` to represent policy deliveries as explicitly typed objects, and - Extends `handle_delivery()` to accept multiple policy deliveries. Bug: 906850 Change-Id: Iadbef1240c4855967e40f81cb3417389cff5c9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723229 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/868f5fa02353..593b1a6ca228 git log 868f5fa02353..593b1a6ca228 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 dongja@google.com Vulkan: Fix array handling in default uniforms 2019-08-01 jmadill@chromium.org Capture/Replay: Refactor entry points. 2019-08-01 syoussefi@chromium.org Disable atomic counter buffer tests on AMD/Windows/GL Created with: gclient setdep -r src/third_party/angle@593b1a6ca228 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Id0a8c5753d327f22457657d6584cfc8f5e04221f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730582Reviewed-by:
-
Robert Sesek authored
Using mach_msg_send() will wait until the message is delivered. If the receiver is on the same thread as the sender, then the kernel message queue can fill up and block the sender indefinitely. Switch to using mach_msg() with a 0-second timeout and return the error in that scenario instead. Bug: 950323 Change-Id: Ia9491034cca45239417f8954f80b1bfb1817e1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731478Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683353}
-
Adam Langley authored
The implementation of CECPQ2b in BoringSSL is too slow on other CPUs to even want to experiment with. Since Finch doesn't have CPU restrictions, limit it in code. Bug: 930812 Change-Id: I991a03a5edd617ce4ab8f46963d175fcc4224d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731539 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#683352}
-
Eugene But authored
GREYConfiguration API has changed for EG2, so this CL uses different methods depending on compiler defines. Also added a separate EG2 target for ScopedSynchronizationDisabler. Bug: 987646 Change-Id: I4005a8c12a149492642aeaa61bf6c7c5eabb7a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726370 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#683351}
-
Avery Musbach authored
I claim that Issue 988524 is fully addressed just by changing the ARGB color. The desks bar appears only in overview mode, wherein the whole wallpaper is blurred. As the goal in the first place is to be consistent with the shelf, the desks bar shall add no additional blur. The issue mentions using kTransparentWithBlur, but that would be inappropriate. Test: manual Bug: 988524 Change-Id: I3d432b73bd4e35809db304f95001a7de17ef7f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730768Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#683350}
-
Sam Sebree authored
[SyntheticModules] Address follow-up comments from "Implements ValueWrapperSyntheticModuleScript::Create" CL The following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1694604 Contains a few comments left by nhiroki@chromium.org which didn't make it into the CL until after it was merged. This is a follow-up CL designed to address these comments. The comments are: third_party/blink/renderer/core/script/value_wrapper_synthetic_module_script.cc: Line 22: "Non-member variables shouldn't have trailing `_`, so this should be `options`." Line 55: "According to the spec, the base URL and fetch options are null, while in this CL they are set to non-null things. Is this intentional?" Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=967018 Change-Id: Ie579d0f0d0429e32304b5f01e2e9454ee4cad044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727519Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#683349}
-
Oleh Prypin authored
Currently it's provided transitively/accidentally. Without it, there's an error: Undefined symbols for architecture x86_64: "_objc_msgSend", referenced from: message_center::MessagePopupView::GetOpacity() const in message_popup_view_mac.o Change-Id: Ic890ab72be9f1523045e518556abeda8be73a75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730415Reviewed-by:Evan Stade <estade@chromium.org> Reviewed-by:
-
Nico Weber authored
We had a global define NO_TCMALLOC, and then build/build_config.h set a define USE_TCMALLOC if that wasn't set. Instead, use the buildflag system. Also remove most allocator gn args from build/config/allocator.gni to base/allocator/allocator.gni (the rest to move in a follow-up). Also use a single, consistent mechanism for disabling allocator args for nacl. No behavior change. Bug: 961767 Change-Id: Id2776cee1c77c00f401b73c414bb5e8d924ce4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731613 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Cathy Li authored
Bug: 977621 Change-Id: I78bfea20233d63b97dd48fd7cb6377476940ea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698984 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#683346}
-
Lei Zhang authored
Move the code that handles PDF document permissions to pdfium_permissions.cc. Change-Id: I01704423d089d24f6bdbfbee3b8c981977f19a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726904 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#683345}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. TBR'ed as suggested due to dsinclair and kpaulhamus OOO NOPRESUBMIT=true TBR: dinclair@chromium.org, kpaulhamus@chromium.org Bug: 977050 Change-Id: Ic8201d1a43f19cf12ea2433a09a967cb5195d43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700915Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683344}
-
Kurt Horimoto authored
This is the non-modal version of the UI currently supported by AppLauncherCoordinator. Bug: 976919 Change-Id: I881293aca913870202264097ea1088cbb782cdb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727397 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683343}
-
Virender Singh authored
This CL removes PDFiumPage::GetLinks method because there are no callers of this function. Bug: 990050 Change-Id: I627dffcde764bec440f2733db162bd3d443072ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731789Reviewed-by:
-
Callum May authored
Bug: 982234 Change-Id: Ia272a637bd65289092b7ff271b415f750159fd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696192 Commit-Queue: Callum May <camay@microsoft.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#683341}
-
