GitLab

BUG=141700


Review URL: https://chromiumcodereview.appspot.com/10836185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151194 0039d316-1c4b-4281-b951-d872f2087c98

Apparently it's possible to have the context WeakPtr not be cleared yet but have
the underlying proxy already be gone.

BUG=141880


Review URL: https://chromiumcodereview.appspot.com/10830265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151193 0039d316-1c4b-4281-b951-d872f2087c98

to remove static_cast<> in the callers.

BUG=139130
TEST=try bots

Review URL: https://chromiumcodereview.appspot.com/10855002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for constrained windows to ShellWindowController which is used by platform apps.

BUG=140593
TEST=Verified that constrained windows on tab windows still work. Ran the media gallery test app and verified that opening constrained windows inside a shell window worked.


Review URL: https://chromiumcodereview.appspot.com/10823176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151191 0039d316-1c4b-4281-b951-d872f2087c98

Regression came from change to leave panel in title-only mode
when draw attention is cleared, but mouse is over the panel title. (r137530)

BUG=None
TEST=Updated StopDrawingAttentionWhileMinimized and DragMinimizedPanelWhileDrawingAttention


Review URL: https://chromiumcodereview.appspot.com/10828220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=cmp

Review URL: https://chromiumcodereview.appspot.com/10837213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151188 0039d316-1c4b-4281-b951-d872f2087c98

This is the Cocoa version of the following two CLs:
https://chromiumcodereview.appspot.com/10696042
https://chromiumcodereview.appspot.com/10824054

Currently the extension install dialog shows permission warnings inside a multiline text field.

OAuth issues are different in that they are a list of issues, each of which can be expadned to show more details.

To support this I replaced the multiline text field with an NSOutlineView.

Screenshots:
  - OAuth issues + Warnings: http://i.imgur.com/Hbag3.png
  - Inline install + Warnings: http://i.imgur.com/gpLI9.png
  - Inline + No Warnings (outline view hidden): http://i.imgur.com/se9tH.png
  - Bundle install + Warnings: http://i.imgur.com/5H3Rm.png

XIB changes: Replaced warning and subtitle text field with outline view. Updated relevant outlets.

BUG=30206
TEST=
  1. Test OAuth issues. Run chrome with --demand-user-scope-approval. Drag/drop oauth2.crx from estade. Verify that warnings and oauth issues are displayed. Verify that expanding a oauth issue grows the dialog.
  2. Test Inline install + Warning. Navigate to https://www.google.com/chrome/intl/en/p/google-plus.html and click install. Verify that warnings are displayed.
  3. Test Inline Install + No Warnings. Navigate to http://chrome.angrybirds.com/ and click install. Verify that the outline view is hidden and that the dialog is correctly resized.
  4. Test Bundle Install. Run chrome with  --apps-gallery-url="http://www.corp.google.com/" Navigate to http://www.corp.google.com/~jstritar/bundle.html. Verify that warnings are shown.

Review URL: https://chromiumcodereview.appspot.com/10829170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151187 0039d316-1c4b-4281-b951-d872f2087c98

FindReplyACK could never have any effect, because queued_find_reply_message_
can only ever be NULL.

BUG=83097


Review URL: https://chromiumcodereview.appspot.com/10836195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=compiles.

Review URL: https://chromiumcodereview.appspot.com/10829290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151185 0039d316-1c4b-4281-b951-d872f2087c98

Found with:
$ git grep --files-without-match --name-only "namespace views" -- ui/views/{*.cc,*.h}

TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151184 0039d316-1c4b-4281-b951-d872f2087c98

This was caused by a refactor to use the JSC (crrev.com/148166). I apologize for being so careless
and thank you mihaip for catching the problem so quickly.

BUG=140792

Review URL: https://chromiumcodereview.appspot.com/10829273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151183 0039d316-1c4b-4281-b951-d872f2087c98

This flag is not feature complete on mac and linux, it's premature to enable field trials.

BUG=133602,140866


Review URL: https://chromiumcodereview.appspot.com/10824271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151182 0039d316-1c4b-4281-b951-d872f2087c98

The original patch introduced a crash (GetCompositor() can return NULL), but
reverting the whole thing is not possible without a lot of other reverts, and
the proper fix is fairly involve (likely not reasonable to patch to the branch).

This only reverts the problematic part, and a follow up will do a proper fix.

BUG=141756


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151153

Review URL: https://chromiumcodereview.appspot.com/10828262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151181 0039d316-1c4b-4281-b951-d872f2087c98

Also added comment about how to use TokenService from tests.

BUG=141123
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10834262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151179 0039d316-1c4b-4281-b951-d872f2087c98

We were failing to associate the mobile bookmarks folder at sync startup time.
This could result in various seemingly-random bookmark unrecoverable errors.
We now associate the bookmark folder if it's there, and condition triggering
an association error on whether we expected it to be there (which we only do
on ANDROID platforms).

BUG=121587
TEST=Sign in to sync with a clean profile, but synced mobile bookmarks existing
in the mobile bookmarks folder on the server. Bookmarks should appear on the
desktop client.


Review URL: https://chromiumcodereview.appspot.com/10828268

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141389
TEST=Run with --force-device-scale-factor=2, go to a page with standard scroll bars and observe that they are crisp.

Review URL: https://chromiumcodereview.appspot.com/10837205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151177 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10832236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151176 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10825304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151175 0039d316-1c4b-4281-b951-d872f2087c98

- Reduce col padding for invalid transition to 15px and use a 50px for first
  column;
- Fix a problem that invalid transition gets reset when touch scroll is more
  than 100%;

BUG=none.
TEST=Verify icon moves less when attempting touch scroll to an invalid page.  Also invalid move is not abruptly reset in the middle while dragging the touch.

R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10832255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151174 0039d316-1c4b-4281-b951-d872f2087c98

I believe the crash (see bug link) is caused because we remove the delegate
connection, but we never stop observing the WebContents. I haven't reproduced
the crash, but I think this should fix the root cause. I've put in a bandaid as
well, which might be redundant, but good for safety. Will remove it once I can
confirm the fix works.

BUG=141875
R=sky@chromium.org
TEST=This type of crash (see bug) should go away.

Review URL: https://chromiumcodereview.appspot.com/10829284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151173 0039d316-1c4b-4281-b951-d872f2087c98

Connects a command-line switch to the exclusions WebRuntimeFeature methods added for https://bugs.webkit.org/show_bug.cgi?id=91420
Contributed by betravis@adobe.com


Review URL: https://chromiumcodereview.appspot.com/10832183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151172 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for a NaCl-side change to make the debug stub
use the Windows debug exception handler process instead of Vectored
Exception Handling.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2948
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10836197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151171 0039d316-1c4b-4281-b951-d872f2087c98

Sync credential caching is a Win 8 feature that allows Metro and Desktop
to share sync credentials under some circumstances. The feature is
slated to ship with M23, and was disabled for the M22 branch point.
Now that M22 has been branched off, it is time to re-enable the feature.

This patch turns on the feature by default, and provides users with the
"--disable-sync-credential-caching" flag if the feature must be disabled.

BUG=139712
TEST=Sign in on Win 8 and make sure that "Sync Credentials" is written to the default profile directory

Review URL: https://chromiumcodereview.appspot.com/10855063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151169 0039d316-1c4b-4281-b951-d872f2087c98

This takes over for part of http://codereview.chromium.org/10455004/.


Review URL: https://chromiumcodereview.appspot.com/10825308

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151168 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ivankr@chromium.org
BUG=141559

Review URL: https://chromiumcodereview.appspot.com/10836200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151167 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151166 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak@chromium.org

BUG=


Review URL: https://chromiumcodereview.appspot.com/10834277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151164 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151163 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10836193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151162 0039d316-1c4b-4281-b951-d872f2087c98

1. Reset the background of the tooltip frame view or it paints behind the
BubbleBorder2 and makes it look blurry.
2. LauncherTooltip bubbles should not consume mouse hovers.
3. BubbleBorder2::GetBorderThickness should return the actual thickness.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10828266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151161 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=Compile ChromeOS without enable_hidpi GYP_DEFINE.

R=flackr
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10829281

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151160 0039d316-1c4b-4281-b951-d872f2087c98

The original patch introduced a crash (GetCompositor() can return NULL), but
reverting the whole thing is not possible without a lot of other reverts, and
the proper fix is fairly involve (likely not reasonable to patch to the branch).

This only reverts the problematic part, and a follow up will do a proper fix.

BUG=141756


Review URL: https://chromiumcodereview.appspot.com/10828262

TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136394
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10827272

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151158 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141559

Review URL: https://chromiumcodereview.appspot.com/10854071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151157 0039d316-1c4b-4281-b951-d872f2087c98

Add the following UMA stats:
- Launcher_ClickOnAppListButton
  Count clicks on launcher's app list button.
- Launcher_ClickOnApp
  Count clicks on apps in launcher bar (including Chrome).
- AppList_ClickOnApp
  Count clicks on apps in app list bubble.
- AppList_Search
  Count search + open result in app list.
- AppList_ClickOnAppFromSearch
  Count clicks on apps in app list search results.

BUG=137358
TEST=Verify the added UMA stats work as expected.

R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151156 0039d316-1c4b-4281-b951-d872f2087c98

This function was added to support WebView.copyBackForwardList(). It
basically copies much of the content of the view's NavigationController
into the appropriate Java data structures.

BUG=138478


Review URL: https://chromiumcodereview.appspot.com/10836155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151155 0039d316-1c4b-4281-b951-d872f2087c98

Fixed Issue 141873. Crash when BrowserActionButton get disabled or hidden.

BUG=141873
TEST=Try to disable or hide extension buttons, should not crash.

Review URL: https://chromiumcodereview.appspot.com/10834275

TBR=yefim@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151154 0039d316-1c4b-4281-b951-d872f2087c98

The original patch introduced a crash (GetCompositor() can return NULL), but
reverting the whole thing is not possible without a lot of other reverts, and
the proper fix is fairly involve (likely not reasonable to patch to the branch).

This only reverts the problematic part, and a follow up will do a proper fix.

BUG=141756


Review URL: https://chromiumcodereview.appspot.com/10828262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151153 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151152 0039d316-1c4b-4281-b951-d872f2087c98