- 22 Jan, 2021 40 commits
-
-
Xiaocheng Hu authored
Currently, counter style updates is a phase in UpdateActiveStyles. This patch moves it out as a standalone phase of UpdateStyleAndLayoutTree, so that we update counter styles only when needed. This patch also adds MarkCounterStylesNeedUpdate() to indicate whether counter style updates are needed. Note: After refactoring, the framework of counter style updates looks almost identical to font updates. This is intentional. We will try to unify them in the future. Bug: 687225 Change-Id: If07de2878ae5faa6800644a967029a569bef566a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#846203}
-
Robert Liao authored
BUG=1168231 Change-Id: I9f46b03f3c03a50382778c8d8ae404be8714ab31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644316 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#846202}
-
Peng Huang authored
To support ANGLE, we need to create ANGLE context and surfaces from the native EGL context and surfaces with the EGL_ANGLE_external_context_and_surface extension. And ANGLE will save and restore during make current or release the current context with eglMakeCurrent() call. To do that, ScopedAppGLStateRestore will not create gl::GLContext, save and restore GL state anymore. It only queries stencil state with native GL binding instead of the ANGLE GL binding, since ANGLE will not return the GL state from the native GL. And SkiaRenderer may need the stencil state later. The ANGLE EGL context will be created in OutputSurfaceProviderWebView, and make current in HardwareRendererViz. Bug: 1157501 Change-Id: Ieca9c85855df5ab529846fe2882d7451f50f51bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612925 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#846201}
-
dpapad authored
Since it is only used in one place, there is no reason for this (deprecated) UI component to be in shared WebUI code. As a result of this CL bubble_button.js/css is no longer part of the build in non-CrOS, and in CrOS is inlined within arc_suport/main.html as a result of the |flattenhtml| usage on that file. Bug: None Change-Id: I9838bc4a9a6b71370fbc212d1e189311045b0813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643091 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#846200}
-
Robert Ogden authored
This CL moves the dumper to be a test target. This CL also refactors the FrameContentAsPlainText function into a separate header so that it can be relied on by both testing and prod code. The prod code is moved into a new machine usage only class which will be the focus of many upcoming changes to add missing support and logic that caused the method to be deprecated in the first place. See the second bug for more context and details for that effort. Bug: 585164, 1163244 Change-Id: I02fd5c204c71e9ffc82de5267d592ad316d0cbc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610941 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#846199}
-
Evan Shrubsole authored
When hardware acceleration was disabled, the WebRtcVideoTrackSource can receive NV12 frames in software. This patch adds support for the NV12 frames in WebRtcVideoFrameAdapter so that the WebRtcVideoTrackSource can pass those frames safely. with hardware acceleration off and confirmed that it worked. I also confirmed that the NV12 frames in software are used as expected from WebRTC, as they would be if they were from a GMB. Test: https://webrtc.github.io/samples/src/content/peerconnection/pc1/ Bug: 1168948 Change-Id: I5b78ec01fe6ef1c4a4a047bb3fda908ad6813e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645084 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#846198}
-
Michael Bai authored
This will help test team to verify if the feature is enabled or not. Bug: 1169367 Change-Id: I1d731b00c30080a9f3d37ddce36ab642140990c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643705Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#846197}
-
Aaron Leventhal authored
The role changes internally, but the object was not reserialized. Bug: 1167459 Change-Id: I2fcb36a359481e88211397bcc0ddba8a448b2754 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644859Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846196}
-
Majid Valipour authored
Almost always a renderer is either using the request or response side of the federated auth service. Having two mojo interfaces for each one is cleaner, more flexible, and more efficient as it also avoids wasting resource by keeping unused state around. Test: manually using existing demo `./chrome --enable-features=WebID https://webid-demo.glitch.me` Bug: 1141125 Change-Id: I2a41cd57022775ef5348e74991650dd5be90fa3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636946Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#846195}
-
Peng Huang authored
This CL adds support for EGL_ANGLE_external_context_and_surface. With this extension, it wraps a native EGL context to an ANGLE EGL context, so we can use ANGLE on a native EGL context. And call ANGLE eglMakeCurrent() with this ANGLE context, will not change the native EGL current context. And if this external ANGLE context is created with EGL_EXTERNAL_CONTEXT_SAVE_STATE_ANGLE. ANGLE will save GL state of the native GL when this ANGLE context is made current. And ANGLE will restore the saved GL state of the native context, when this ANGLE context is released with eglMakeCurrent(EGL_NO_SURFACE, EGL_NO_CONTEXT). Bug: 1157501 Change-Id: If7bb23dda18f09866fe33d185ef0f21a78a6ba1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638194 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#846194}
-
Dirk Pranke authored
This reverts commit 17801e45. Reason for revert: Fixes to the internal scripts that broke have landed. Original change's description: > Revert "Reland "Force Python 3 to be used in build."" > > This reverts commit 6ea5c38d. > > Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview > > Original change's description: > > Reland "Force Python 3 to be used in build." > > > > This reverts commit b6172196. > > > > Reason for revert: We rolled GN to a new version with a fix for > > the win dev issues, so hopefully is good to go now. > > > > Original change's description: > > > Revert "Force Python 3 to be used in build." > > > > > > This reverts commit bb97ab9b. > > > > > > Reason for revert: Various breakages. > > > > > > Original change's description: > > > > Force Python 3 to be used in build. > > > > > > > > This CL makes Python 3 be the default script executable used by Ninja > > > > to run action() and action_foreach()'s during the build. > > > > > > > > This does *not* mean that everything works with Python3; many targets > > > > may still use Python 2 via the python2_action() and > > > > python2_action_foreach() targets or via custom logic. > > > > > > > > However, it does mean that it should prevent regressions from > > > > creeping in. > > > > > > > > This CL should not be taken to imply that we can start to write > > > > Python3-specific code that can run during the build; we should > > > > still be trying to ensure that everything is compatible with Python2. > > > > > > > > Also, this CL does not enable the use of vpython in actions; we should > > > > still avoid that because vpython is slower than direct Python > > > > invocations. > > > > > > > > Bug: 1112471 > > > > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Cr-Commit-Position: refs/heads/master@{#836234} > > > > > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1112471 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576 > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Cr-Commit-Position: refs/heads/master@{#836284} > > > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1112471 > > Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#844885} > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1112471 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844986} TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1112471 Change-Id: Icbefaa2cb23b1bf9e54bbd674cb5ab564dae3785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643157Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#846193}
-
Lijin Shen authored
When AsyncInitializationActivity is destroyed, modalDialogManagerSupplier offers a null object, which cause the mediator a NPE. Bug: 1169413, 1163300 Change-Id: I858ffc2aab2fcedabb792087780072808789f76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644064Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#846192}
-
Michael Ludwig authored
Bug: 1169366 Change-Id: I98a1d5270cdff58884958e837ab001e56d6eee90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643029Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#846191}
-
Dave Tapuska authored
ChromeExtensionsRendererClient::CreateBrowserPluginDelegate is not called. This method has the only ctors for ExtensionGuestViewContainer and MimeHandlerViewContainer classes, so those classes can be deleted. GuestViewMsg_GuestAttached and ExtensionsGuestViewHostMsg_ResizeGuest are IPC messages that are only sent/received by those classes so those messages can also be removed. BUG=533069 Change-Id: Ie904cfdd01db9980a4286be6a79e94e2eb83374f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635797 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#846190}
-
Michael Lippautz authored
Backings require re-implementing of traits. Split the files off instead of relying on the macro to split the implementation of each trait. Bug: 1056170 Change-Id: I43a005119986ec51c05a34f76dca25614a6f1196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642340 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846189}
-
Andres Pico authored
The NativeThemeGtk instance is able to detect high contrast changes in the system by reading the GTK theme name. NativeThemeAura is not capable of doing this however, and is never aware of the true state of high contrast in the system. With this change, NativeThemeGtk will update NativeThemeAura when high contrast changes. Bug: 1157686 Change-Id: I6f0407dd639a1d61d1d7f99fccd2122cb0fdc669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586068 Commit-Queue: Andres Pico <anpico@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#846188}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/21b394fcfab2..170343fcf165 2021-01-22 vapier@chromium.org cros_update: convert to python3 only 2021-01-21 yueherngl@google.com octopus: add firmware-octopus-11297.196.B branch builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0d730b3b9c9333068985f57e384ed86722674342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846187}
-
Abigail Klein authored
This reverts commit 9a823ced. Reason for revert: Need to make another modification to the string. Original change's description: > [Live Caption] Update Live Caption subtitle string based on UX feedback. > > Bug: 1055150, 1167349 > Change-Id: I4c321cdfa6e00c3a8002cbea02e89fc2689e3ecd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633375 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Abigail Klein <abigailbklein@google.com> > Cr-Commit-Position: refs/heads/master@{#844972} TBR=avi@chromium.org,abigailbklein@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1055150 Bug: 1167349 Change-Id: If426b45462ab0b25bbe9cd68e51c42d22cda2358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643491Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#846186}
-
Allen Bauer authored
For a nested class use BEGIN_NESTED_METADATA(outer_class, class_name, parent_class_name) The use of the other macros remain the same. Bug: 1166802 Change-Id: I125dce952969d529e0277559ab739ef89bae9afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631607Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#846185}
-
Roman Aleksandrov authored
Create separate CSS module which will hold specific vars to change style of oobe elements. Bug: 1151292 Change-Id: Ic9afa104672325d2330fcf08550f0b5b0d251623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580884 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#846184}
-
Richard Knoll authored
A macOS notification is identified with the tuple {notificationId, profileId, incognito} and we have to pass these down to the XPC service to close the correct notification. The same applies to the notification id used in the UNNotification API where we need to include the incognito flag in the id. Also updates some method names to be more consistent. Bug: None Change-Id: Ie45cb74eab182e0b495560110d8e6e32367c4bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642275Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846183}
-
David Bertoni authored
This reverts commit bbc76b3b. Reason for revert: This flakiness was caused by crrev.com/b53ca149, which was reverted in crrev.com/7cf9ce83. Original change's description: > Disable ExtensionServiceTest.ExternalInstallClickToRemove on Win > > It is flaky > > Change-Id: I0a1f011768ddef79c16bd0945231fe3b96dd7146 > BUG: 1168464 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640037 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846046} TBR=rdevlin.cronin@chromium.org,cfroussios@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,cfroussios@google.com Change-Id: Id3941aa4683d0fd7f54b734faa0d60f472a344b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644379Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#846182}
-
Michele Mancina authored
Bug: b/175311081 Change-Id: Ibfce2d6df8033426fe54afee3ca511bcca13e948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642373 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846181}
-
Takuto Ikuta authored
The flag is nop now. Bug: 1142713 Change-Id: Iff9287d2d317fce85c06ba43cfaabf2fc66efbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643000 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#846180}
-
Dan Clark authored
We've decided to remove V8's behavior of filtering the import assertions to only those expected by the embedder. The interop guarantees provided by doing the filtering in V8 are probably not worth the added complexity. Going forward, hosts will no longer need to provide a list of supported assertions, and they will be expected to ignore unknown assertions received from V8. The Blink code is already written such that unexpected assertions are ignored, so the only thing that needs to be done on this side is to remove the DCHECK that expects at most one assertion. Once the V8-side changes are made to remove the filtering, Blink can then stop setting v8::Isolate::CreateParams::supported_import_assertions. Change-Id: I40578c40ff4c97cd64b6bb0840b72163e9c5a2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643059Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846179}
-
Charlie Hu authored
As PRESUBMIT check on code generation is added in previous CL( https://chromium-review.googlesource.com/c/chromium/src/+/2633734), we can now remove the feature for test in document policy features. Change-Id: I51e104cc9d77ad0339bcdd8c6c09dbb88af5e705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636942Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#846178}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/372791761157..cc6961b9ac5e 2021-01-22 johnstiles@google.com Add checkpointing functionality to SkSL Lexer. 2021-01-22 egdaniel@google.com Remove preferring cached memory for vulkan cpu write, gpu read memory. 2021-01-22 ethannicholas@google.com SkSL vars now track their declaration instead of their initial value 2021-01-22 brianosman@google.com SkSL: Remove ByteCode interpreter, generator, etc. 2021-01-22 bsalomon@google.com Revert "Revert "Reland "asyncRescaleAndRead supports unpremul results on GPU""" 2021-01-22 johnstiles@google.com Factor out modifier-token parsing into helper function. 2021-01-22 reed@google.com More hiding of legacy drawImage calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: If1a364c60712e3328fd0c3b1b50ba711419a8c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846177}
-
Richard Knoll authored
Starting Activities from BroadcastReceivers is no longer supported. Bug: 1169595 Change-Id: I820d888a6adc37b73d0315df9a9b3a598e771d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643509 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#846176}
-
Wei Lee authored
The information printed by CAMERA_LOG is visible in feedback report. Therefore, migrating some VLOG to CAMERA_LOG in VCD should be helpful for debug camera issues. Bug: b/172344305 Test: Build successfully Change-Id: I6398e8a47714417b50fe8225a3fbc443eb860223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641689 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846175}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbab010f..bef4c393 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I12e3f36f131b3b2acebc2a11b56180c5e24c60f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644921Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846174}
-
Ben Pastene authored
Devil's bundletool.py expects a java binary on PATH. That's OK today since all the bots have a system installation of java. But when rolling the bots' images forward past the point where install-build-deps-android no longer installs a jre/jdk, that assumption is broken, leading to failing tests. So this CL causes most/all of chrome's android tests to run with the hermetic java SDK under third_party on PATH. This should cause tests that invoke the `java` binary at runtime (like chrome_modern_public_bundle_fake_modules_smoke_test) to use the hermetic java toolchain rather than a system installation of java. Bug: 1169403 Change-Id: I133d6613347704bc505431e04ac1f0e6bfef6a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643983Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#846173}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611304267-88ef864b2fcc457a2d5ceb59f34a94c5685188fd.profdata to chrome-win32-master-1611316382-261a271ac3191d9a6f726d2f754b45ee0d0f178e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I945cb5eacc7d4771e0dd872cd19935befa3a8385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846172}
-
Curt Clemens authored
The data usage setting was showing the current value and a description. Now it shows the name of the setting and the current value to match the way other settings are shown. E.g. instead of Mobile data May incur mobile data charges show Data Usage Mobile data https://screenshot.googleplex.com/AaDrHHDc7hMZnTs.png In the data usage dialog, change the confirm button from "Update" to "Done". Fixed: 1168289, 1168287 Change-Id: I7bec6416909a4f4e3b95a76026e242eccf430e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643568Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#846171}
-
Michael van Ouwerkerk authored
Bug: 1169122 Change-Id: If401cb17cf9b5443f9892eca45eb45d39ea46f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642147Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#846170}
-
Luke Zielinski authored
A WPT import ran into trouble on Mac11 and wasn't able to get results for that platform. It thus added duplicate expectations for all other platforms for these tests, and on a subsequent import also added a Mac11 expectation. So each test had 7 distinct and identical expectations, one for each platform. These can be collapsed into a platform-agnostic expectation which will cover all platforms anyway. Change-Id: Ib9810f4d42ac6420290170ac306045862253990e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644562Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846169}
-
Curt Clemens authored
If the body of a success notification is clicked, then the primary action should be taken instead of doing nothing. Fixed: 1168293 Change-Id: I494bcf53ec1bb1cd615a30e417c95e01877c9431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643856Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#846168}
-
Jesse McKenna authored
This change adds a metric to measure how often a navigation occurs where the target URL matches a RenderProcessHost that was destroyed in the past few seconds. The new metric, "SiteIsolation.ReusePendingOrCommittedSite. TimeSinceReusableProcessDestroyed", emits on every navigation. It records the time (in ms) since a RenderProcessHost with a matching process lock was destroyed, up to 7 seconds. If no matching host was destroyed within the past 7 seconds, it records a sentinel value of 10 seconds. Knowing the most common times since reusable processes were destroyed will inform a broader experiment to potentially delay subframe process shutdown by a few seconds to reduce process churn. Including the sentinel value adds information around how frequently reusable processes are destroyed, i.e., how much opportunity for process reuse exists. Test plan (see "Metrics" section for details on this metric): https://docs.google.com/document/d/11XruVZzYLSkt4se6IV2O4jFOkKs-QbkRB5NMf4mH_hE Bug: 894253 Change-Id: Ic15089d1e3b086480942b6afe32525b3c6461895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575945Reviewed-by:
Oliver Li <olivierli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#846167}
-
Scott Violet authored
SessionService(FilePath) constructor was only used in one place, and can easily be converted to use the Profile* constructor. This converts to the Profile* constructor and cleans up conditional code. BUG=none TEST=none Change-Id: I3f486ee48db97b8e825df31a66bf276737b76c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644070Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#846166}
-
Adam Ettenberger authored
This CL addresses a Blink Accessibility invalidation gap, when a node's aria-hidden state changes, its blink accessibility subtree must also be invalidated so that the accessibility ignored and invisible states are serialized to the browser process. This is important because we rely on these states being accurate in the browser process, and we need need to receive the state changes through AXEventGenerator in order to send appropriate platform accessibility events, such as structure change events (add/remove child, hide/show, or 'children-changed'). Adding AXObjectCacheImpl::HandleAriaHiddenChangedWithCleanLayout which handles this invalidation, and immediately handles ChildrenChangedWithCleanLayout on the parent of the modified node, and increments |modification_count_| to invalidate AXObject cached values. e.g. AccessibilityIsIgnored(), and IsInertOrAriaHidden(). I needed to also modify BrowserAccessibilityWin::CanFireEvents to allow events to process for the corner case outlined in Bug:1159660. Because the node becoming ignored was the only child, the parent became a leaf node, and the node removed would return false for CanFireEvents because now it "IsChildOfLeaf()". I added a condition to check if the ignored state changed this frame, and if so, allow events to process. BrowserAccessibilityManagerWin filters platform events appropriately for nodes that are ignored. Bug: 1159660 Change-Id: I82e2368c09d4855fdb834600aed7ac61d1883c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612365 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846165}
-
Eugene But authored
Made zhaoyangli and stkhapugin the owners of EG infra. Made zhaoyangli and olivierrobin the owners of test infra. Bug: None Change-Id: Ieedec52a5798353ed3bcf622302fb1ea279b2113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643262 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846164}
-